From patchwork Mon Feb 19 06:27:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13562211 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F424C48260 for ; Mon, 19 Feb 2024 06:27:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFF348D000E; Mon, 19 Feb 2024 01:27:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A87AE8D0008; Mon, 19 Feb 2024 01:27:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 903628D000E; Mon, 19 Feb 2024 01:27:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 75C388D0008 for ; Mon, 19 Feb 2024 01:27:51 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 466B880215 for ; Mon, 19 Feb 2024 06:27:51 +0000 (UTC) X-FDA: 81807572742.06.26C7301 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id CF0AF140005 for ; Mon, 19 Feb 2024 06:27:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=iRcbIgMy; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708324069; a=rsa-sha256; cv=none; b=2Mi04c8KLIA4WdiiRSbwK/Hh75Oww+n1NbC6wM8/VPkolHSi9Go0yRBQP6SAN61Ay60RJC +jsG9CQx5ccr1bAhHnBO0qWXkhIFjwkk5mAQFboXcSqk3spG5JmooKD3UqKVBR8UpWDziR qNWvfkWpPeEdKZdNRGKzblPoNdOy0oY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=iRcbIgMy; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708324069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3YY6BZIZmUaROG7bkAzG3HaXF5m4f+ODCrHAQtZlXeU=; b=00lfQy1Next+hmmaOyWnDHJxmFrJTe1F6Y+CHNyFyqYDm3t02w+NsgX6A0GPmm1UMdY9d1 MMu5+kUTU2/KvgblAHh8Wv8V2eELEBxSFQzyDdtsuZ5fYue04o7dCoEZIos/JzAMHeF334 6RvGN/WKDwqjxiieioFH7PDjown4pZo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=3YY6BZIZmUaROG7bkAzG3HaXF5m4f+ODCrHAQtZlXeU=; b=iRcbIgMysd7NXSEW4lQTxPVtTE HmczKWoxUJ9Ldr3AsfZ/GAM/QOrFpLOefjvtEAKezelNC0HEqOGeMz+JOuOPZaE1tdpCgm64jAYNI y3EZD2omyyyXZG6qujajC74kjD55zr3wr59ZD5FZCh1FJGaSHiyGgPl1c48cY3df04lIvc4iUPPyp h3KHwzam2e83of93/Sld1zUVeOWE2mdflOBg7kiq1Qj50iWEoz+ZnczJIiLM3KVf64LmuPmOrhAx0 6ddQUNymeDoaEDs+bW9x0GA3bB9ZKr1e655jG8UsncTGJ2UPwG4GP0ix2ndLPKifOZZE3ERvFLOdz PVCYq56w==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbx7z-00000009FCK-0n3c; Mon, 19 Feb 2024 06:27:47 +0000 From: Christoph Hellwig To: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton Cc: Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 09/22] xfs: shmem_file_setup can't return NULL Date: Mon, 19 Feb 2024 07:27:17 +0100 Message-Id: <20240219062730.3031391-10-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240219062730.3031391-1-hch@lst.de> References: <20240219062730.3031391-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CF0AF140005 X-Stat-Signature: drpwfba1b6yjrjmzpanhnhsthxmuwio5 X-HE-Tag: 1708324069-121950 X-HE-Meta: U2FsdGVkX18O8ycbjT8nLF+eyVMNZAfr2LveqNeviLYpnOcO4awqQB8XHXcVbBOEKz899rjH1iPJWo+7vpsnLl1zXLvmYkEhgFcNSDLocRGA9bUYqozLRPetFqg3SS51vUYNICFNbYfYQfEtEfB8SK2GS0LBOiV1R4lioKynQ0O4WsBL8HKfXq6KAjNkT0woQ1GSuZDiQcTRwuvopJZtT02xTVsFZnP1T1r5w6bLD0Z5Npb5VrZF5P06l2BJaREo2DfmIg3ZXITucq8A4CTEaYQsyTLPVSmCuDEVkoA500Ea2+uZ3GbOiPMMC4R+xrMAw+Ns4Ue/cYvYb6ieG1E3s33jQU7LCVuUsxSB7NtkRdybyc8NisjY4jTIxMRRAr8U63r7iWuum/2CBGkzcjxt3hYS8kMGSojkIFTDNqsA+Uh0yu+pBLBbus9JNylas2pm80qgwgw9SeF78+Ld7cnN3u2ZBImK2OUsj2Op4dV+n+QDey5F4StFhUhNReXjuHgIGEtuZJc6yql0AhktGNs+Xmpqs3gD+wjUbpwuC6LPPfo4quDtW+EEiE5u0rpqTeBTaaK7El4oV4DL3Qyw76hedRkBbcJvCoebJx/rbexEuj1XhEYocR7OP1rqDXQYH30yWz59a23Z7CjEmMmNc1Zn3/TorEKulSdmpRaWbfJvvkb02pU7pcIPakQrRMzaBh3/orbhCl/7hHV0/A0y2AMCFM458lp6349k/eg4Q/qSm5WZuuVUBh5fukX/bg+xdI6ys645M67goR69K4aKComMKfj73pkkFHnCtNEdMd+Hd0ulDv/JJR8krAOU9PGXib0e4A0h6LJqR4jNTIwAX48Bhsc3oYnkpq89scZREok1aF0vCYTc8smV58symIbTXe5CfJrrIkpKGg+zqHeR8FNGkRpsp6cJAlATDmP1ak1zHxlwu1Lt91NHz8USCgoY0562rivrRkcVTDu0nch7X9G gilRcu7s b5n3hGpxt/SERTIN497bybMW+zG3gi538cnPOz8fYesJZu+kUWXC8ZQAXvuu+SXY8tS/05wwBf3lk/mAr0csfYhyitZCT00KnsHUZJWGQCzy2afqTLCaaoDVAz02Uzs2fVyQcnr3XqHTUAdQIhtgLKIhnxrVhHTImwLVNVy6y9l1a5H2tG8gufzfOCkfpGGak4NiPDCMM5mOKkM+KcXF1wJT7vg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: shmem_file_setup always returns a struct file pointer or an ERR_PTR, so remove the code to check for a NULL return. Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong --- fs/xfs/scrub/xfile.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c index 1cf4b239bdbbd7..e649558351bc5a 100644 --- a/fs/xfs/scrub/xfile.c +++ b/fs/xfs/scrub/xfile.c @@ -62,15 +62,13 @@ xfile_create( { struct inode *inode; struct xfile *xf; - int error = -ENOMEM; + int error; xf = kmalloc(sizeof(struct xfile), XCHK_GFP_FLAGS); if (!xf) return -ENOMEM; xf->file = shmem_file_setup(description, isize, VM_NORESERVE); - if (!xf->file) - goto out_xfile; if (IS_ERR(xf->file)) { error = PTR_ERR(xf->file); goto out_xfile;