From patchwork Mon Feb 19 06:27:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13562205 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6DE0C48260 for ; Mon, 19 Feb 2024 06:27:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 336518D0001; Mon, 19 Feb 2024 01:27:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E6538D0008; Mon, 19 Feb 2024 01:27:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160258D0001; Mon, 19 Feb 2024 01:27:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E7E828D0008 for ; Mon, 19 Feb 2024 01:27:37 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C11AD160209 for ; Mon, 19 Feb 2024 06:27:37 +0000 (UTC) X-FDA: 81807572154.05.8023F66 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id D2DD4C0005 for ; Mon, 19 Feb 2024 06:27:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xUYvP8bm; spf=none (imf22.hostedemail.com: domain of BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708324055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m8bNau9njavlNFAZK08RacrmSpqtfTJnRVvJoaaL3Z8=; b=Kdn2rQS1XHLIIhxM2KsUjLLiRnVQ9dpIBIt3xOSu6X8+VFrQ0sdnaxKVfE1vg3tu8DEca/ fazvj90kkj7suGU9hJ/81qtXsx3gzlSdB7Yq0eLCtWHSYUjQHy10AMkS4bDzrmH8z7Gv40 XTdkKdrooWFpahHkdBuhZ8s3ugi1wtU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708324055; a=rsa-sha256; cv=none; b=pnaRFRUPH4mxvH6Q6EFRDyTwRwwQPtif3RykN38etTcWp5YvD1RIjEr6J/XT92LyC6o2a+ Wtef0EKcWZW1kxKxl9bM0exfB0XDOgcqKDmEFagLcvPFfr6RbYX0bP9j4pQY4xYL+ROZ+D xRljsh6peF/p+1pjqTusp3kHoKA4qU4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=xUYvP8bm; spf=none (imf22.hostedemail.com: domain of BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+994827af29a55d2021e7+7484+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=m8bNau9njavlNFAZK08RacrmSpqtfTJnRVvJoaaL3Z8=; b=xUYvP8bmy68OOaUGaiZ2KblmiK Q6infFV0+/plG4Pe9Q8zhlzEhPB323U+1SH228ltswSLMJzahDZdFotcxBQ4ym6dwwzEJNam+gqwy zXfe5poLm5sH4xqTHQTKZVBv4SGz1vof7MZXE8TNwvm0t8O5fFb2ht8JwUQm1W17+Ig8taf62QK4C L3NyW0Cjp+qxKNJGT+ehURX4TvSxLgAFGmxdfRwJyIMdDReWN0GwbRIVt+bqCFsXalyTNDMT/qoiW vuyQHh5P0dr/PE6oJzAFNqHJl5cT5ayNbEXTiiBpZEOKEWEw/WdTiLmExogVgLgX3s0wMEvYh2237 TJqD93dA==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbx7k-00000009F6h-0Pst; Mon, 19 Feb 2024 06:27:32 +0000 From: Christoph Hellwig To: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton Cc: Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: [PATCH 03/22] shmem: set a_ops earlier in shmem_symlink Date: Mon, 19 Feb 2024 07:27:11 +0100 Message-Id: <20240219062730.3031391-4-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240219062730.3031391-1-hch@lst.de> References: <20240219062730.3031391-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: D2DD4C0005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: m9fhrwjoz78pgahkt53gdhophng95kwc X-HE-Tag: 1708324055-330045 X-HE-Meta: U2FsdGVkX1+mqODDnXV83m6L6urGYAUEQtP6kT+BqMVYobKrYkvPj6imIFESEktWCwc9ocut25ArBuH78RA15cMr3A2yFy5URlWgI5E6t7prByLneXgLEW2xoqZcem2vQXihZ+Esjxy072PIP8I6rObdlPs5zv3nPGuTLUnqgAaQoNZLQFzB5oFRKwpAzjWbzPrRJ5gdOztZN/RrjG1BL7Ptfluv5QTD6IAWfq/axxVSUoxQH9xBmi134Jys3USE57SdZot1k9K+1OToMUjMOdD6uAsA2Xg3D+5sE5YzZ78+i20y/Iihqg6qUf8iGEFEzTHfsnkaZLSFhsnfsVRIJ6/AFZfPBU/HldGRNC8uXIQfTTAVRh7Hgld0Z3osFw02FVpmsSWEzF8+parEtS/xxI3x3J5zooaqID2rrzRXX98bQhKQdu2M1mIC3BkxnjAESl2r/Sf3yOrd5ISaPOkBI2a9vanonmsjmXS5YxnCx93DkGKBzLPH70bMrqO/tirfp/Z8D9Y2IAdDxLy8bumJcWJbpV8zqVoDDF8eQFrNqvkvSC+y6qmfyS4hBo1Yj+atcJLo2xbG5np+CSa8wOjvprFsCqZD2WGv8Y5S834ywzzsP2SNDHio0Dk2GXnNJn57MgzYq6cgB5BUEkc49iC2JvjMdivr6lqfuFjEORpn+Yq/pSLV7UZVf5aInhd/c/2t/DK5TCLS46ljxj/ttWFE3bRuF4PmngsXZYG/aLEZALNb7ilydRgTs4xHkgnBiLL4yY+rxrTyCSoE2zlc78I0H0uuv6qDQtCwPcx23AbUXqSFKK3s2YwfU/DCr0yYZIQXrA0QgpZwUOXR3Fa/0AsUhbO2hUgJPiym9gtXfDmUWXpg/jPyoVvkFRUf8SwfFwylFXLIiMxYrVt4R+SBhby3zNSN8u8rp5wenjqoGYkI7uEK0I4ScYJ38StphZB6VhQ6UImIezPgXGR/j+HA+Gs p68uu1hf SGwhlGp3YAtdwlYa0JUB3e4Dn+CRvE6c4kKIBcDIUnP4PrC/7X7OGYlS8iqdArtOnLHXuuQ/2feXw6DWAsWvfQKLIhZ+/f5EbnC/NlZmhWOvEYvzXyLfboulESzUax8b5pqie3YK91ZziGAR5U6G9dvQuZqybKwqJ0LO/IpC0IwgRCqxWn8/8cG/d7uG0cN7xzpNE4XhtiteFcDmKEbuWo6GewTCNU3pTR8B2oR7cvhsnnTklBtqcbRIyl1xhcxjy/mgzfH+I3PRqZGTjZ7FC7wGGDnBk1tVLAgFYN/qmkJKHBwL0PIDRJiMRfPh2OVqkrlryBH2J5MzcSHN+4jW7XAHNFQl2UbkBV1+91w2wppYy/EMbwhs+GAJcfaU4/hdRi0tAm3ZlAcPpCYjOIZ7wHCILgzAloZxayNF82NPZduWL+wlwNf5wJvbgkHGQH9o26QEU1C/LRjfIfBmi/9yBXZv6cvfJAaW6iXLJwZrK67a3+Wuk2iN7VJ9P9Nuq0XxIgpH6JvUKVkG3Ykk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Set the a_ops in shmem_symlink before reading a folio from the mapping to prepare for asserting that shmem_get_folio is only called on shmem mappings. Signed-off-by: Christoph Hellwig Reviewed-by: Matthew Wilcox (Oracle) --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index f607b0cab7e4e2..1900916aa84d13 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3506,10 +3506,10 @@ static int shmem_symlink(struct mnt_idmap *idmap, struct inode *dir, inode->i_op = &shmem_short_symlink_operations; } else { inode_nohighmem(inode); + inode->i_mapping->a_ops = &shmem_aops; error = shmem_get_folio(inode, 0, &folio, SGP_WRITE); if (error) goto out_remove_offset; - inode->i_mapping->a_ops = &shmem_aops; inode->i_op = &shmem_symlink_inode_operations; memcpy(folio_address(folio), symname, len); folio_mark_uptodate(folio);