From patchwork Tue Feb 20 06:53:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13563471 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FFBEC48BC4 for ; Tue, 20 Feb 2024 06:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 006AC6B0082; Tue, 20 Feb 2024 01:53:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF9BF6B0087; Tue, 20 Feb 2024 01:53:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D99096B008C; Tue, 20 Feb 2024 01:53:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ABD466B0082 for ; Tue, 20 Feb 2024 01:53:18 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7F8EDA059B for ; Tue, 20 Feb 2024 06:53:18 +0000 (UTC) X-FDA: 81811265676.19.CBBD706 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf06.hostedemail.com (Postfix) with ESMTP id 9073F180005 for ; Tue, 20 Feb 2024 06:53:16 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf06.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708411996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rSrN0VU08UnJ1XHlLciRWceHdRFe+MkVOKHbF6z/wOI=; b=6vAM7Wk+CedHU0ZCHMU3U3qGnVnUDNjUkLJ9x+tPP17YpxNRHljHFeLkAhaZRyS7/OlNOP 4duhz7KZ3/Rkv3OtFuFI+xVY/MZOFTSnTI+HOoqFSwfZ5oHz/Jrai33otudrTxFkDN2HaO tte3RxJgFs6VjLIgEdyxN283uWvtRgg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf06.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708411996; a=rsa-sha256; cv=none; b=bAREf/l5uXGa7uGzHQouVFoYk/lh7/dQeUVLt25q2vP9u0fy0LnzBdjR0pu3246Eu8BpWU 7aji4Ek7lnywKWQBQPcySjcI269cGV4xaM0ZPsouhblrBPnfz90BipUkvEMJGNft5AbHn7 I8h6P7GHx/F3x+bhFKr2DuTFcBLiv84= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 20 Feb 2024 06:53:00 +0000 Subject: [PATCH 1/3] mm/zsmalloc: remove set_zspage_mapping() MIME-Version: 1.0 Message-Id: <20240220-b4-zsmalloc-cleanup-v1-1-5c5ee4ccdd87@bytedance.com> References: <20240220-b4-zsmalloc-cleanup-v1-0-5c5ee4ccdd87@bytedance.com> In-Reply-To: <20240220-b4-zsmalloc-cleanup-v1-0-5c5ee4ccdd87@bytedance.com> To: nphamcs@gmail.com, Andrew Morton , Sergey Senozhatsky , hannes@cmpxchg.org, yosryahmed@google.com, Minchan Kim Cc: Chengming Zhou , linux-kernel@vger.kernel.org, linux-mm@kvack.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1708411986; l=2317; i=zhouchengming@bytedance.com; s=20231204; h=from:subject:message-id; bh=cqkPrPVAWUs+Ao8dP81X35doam5/5XwHmrqtbfkzja8=; b=b6RxioH3nI4BzApNzDWLkeJUM2KNNI2jIWfPF0wnvNdHFanI0ZxZ8jRdFwHgIq3V0GN2CzKie q3prV92J9KxB5aPLZFDeZyXd2Qc3kEs2h5qb8Cu+K3t4Kjat+DJ1Zyp X-Developer-Key: i=zhouchengming@bytedance.com; a=ed25519; pk=xFTmRtMG3vELGJBUiml7OYNdM393WOMv0iWWeQEVVdA= X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9073F180005 X-Stat-Signature: 1jjqip88hxxahcxbtug57squphco16e4 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam-User: X-Rspam: Yes X-HE-Tag: 1708411996-834268 X-HE-Meta: U2FsdGVkX1+ezPyknZYjUK9mvn5rfIho9XQJKZivJasn53XT6/EHtROMkIPxwPq5fIYly7If777mo3DxVwh8n0pk690WEy3jZ/tHkZ7CtPycT8yysAhbN3+MQ8n2PoRTeNm1EFZfU3AIVvpst4YjIJSm8v+Sru6bicNoSuL03Nqh3rqV0VR2oOJLbME1yJV58hLG0Xc/ggtoQboUPSPnOJaOiMf3DOj1O1KLgCFhrEtRBWf+HJVUv+5qb0vkmJAzYwhAgXcgQOsWngiFD3pnEZ+k5Aks9YXffz0veb5qhq4TbQSF+18VMv66ZIhJXy5hbAPlc3jNi107Y1qvDi83rqlbUOV5xWrXYSeORFs2fq7RFxC8GGNeKWjwocrSBNae+nfdiouQ7DtZVJrTygfXS79LTiQJEuszR89SZuq53L2boMuu7rTNYRFPloDr2baa83nAgt6FdQvhfdqzZuZjKnGMJ+DVa053pGniCmsHtXXMzlpmwaj6lOFh1BhvH8PJO/8V9D/fm1J0C7ezdaKP3RcS5lE/yt77FF3trkcLTKaDVZHZLwOctcumguPBGBQSCoqLhZZ3C0C3BBkUuUuM15527lqqBCUA4f/q6b3C8tfGaO+Fimz9+AVGX42G87txI9rjWc5veKe+C77BW4uL5p73XNPYZKHSJoCY+0GPIVfkgBK+ndV8BoxgbrNfzI6YsyfdZgf+sjuTJe+blrDCiHaAgD0VwURFoNzpWqQkRe9mh99iDKyP0Q1IdCyItbqSiSu5W7Zaln3B6Ys4I/s4hPgbI4AcXT7gqLIJ7Nix8HXZ7ARe2NRToEpHRfyKpKmESepF6vca22W+QZSDiy0yQSTYLJW6i4sKS3X1B9b8kalmLGp0VTZpF29+EldD+p6fm4BQVQgXSkg0wPM31AtT6WmQeqb4lnlhbSRspjWjBVLRJV3h56OZcQEMTOwFBq4JY2MvdRz8c7BukoxYLqu vq9n4Gfm Nw2Tm2vSreuJAorxBYIg1Y5IcMFJE+am2M5piJPVbSP26oKFun8eXh22FWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We only need to update zspage->fullness when insert_zspage(), since zspage->class is never changed after allocated. Signed-off-by: Chengming Zhou --- mm/zsmalloc.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index a48f4651d143..a6653915bf17 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -486,14 +486,6 @@ static struct size_class *zspage_class(struct zs_pool *pool, return pool->size_class[zspage->class]; } -static void set_zspage_mapping(struct zspage *zspage, - unsigned int class_idx, - int fullness) -{ - zspage->class = class_idx; - zspage->fullness = fullness; -} - /* * zsmalloc divides the pool into various size classes where each * class maintains a list of zspages where each zspage is divided @@ -688,6 +680,7 @@ static void insert_zspage(struct size_class *class, { class_stat_inc(class, fullness, 1); list_add(&zspage->list, &class->fullness_list[fullness]); + zspage->fullness = fullness; } /* @@ -725,7 +718,6 @@ static int fix_fullness_group(struct size_class *class, struct zspage *zspage) remove_zspage(class, zspage, currfg); insert_zspage(class, zspage, newfg); - set_zspage_mapping(zspage, class_idx, newfg); out: return newfg; } @@ -1005,6 +997,7 @@ static struct zspage *alloc_zspage(struct zs_pool *pool, create_page_chain(class, zspage, pages); init_zspage(class, zspage); zspage->pool = pool; + zspage->class = class->index; return zspage; } @@ -1397,7 +1390,6 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size, gfp_t gfp) obj = obj_malloc(pool, zspage, handle); newfg = get_fullness_group(class, zspage); insert_zspage(class, zspage, newfg); - set_zspage_mapping(zspage, class->index, newfg); record_obj(handle, obj); atomic_long_add(class->pages_per_zspage, &pool->pages_allocated); class_stat_inc(class, ZS_OBJS_ALLOCATED, class->objs_per_zspage); @@ -1655,7 +1647,6 @@ static int putback_zspage(struct size_class *class, struct zspage *zspage) fullness = get_fullness_group(class, zspage); insert_zspage(class, zspage, fullness); - set_zspage_mapping(zspage, class->index, fullness); return fullness; }