From patchwork Fri Feb 23 18:27:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 13569861 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67E2C5478C for ; Fri, 23 Feb 2024 18:27:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0319B6B0078; Fri, 23 Feb 2024 13:27:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFCBF6B0075; Fri, 23 Feb 2024 13:27:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9CEF6B007D; Fri, 23 Feb 2024 13:27:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C69956B0075 for ; Fri, 23 Feb 2024 13:27:43 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7452E1C0F69 for ; Fri, 23 Feb 2024 18:27:43 +0000 (UTC) X-FDA: 81823902006.20.2B0ADC1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 1A5FA40003 for ; Fri, 23 Feb 2024 18:27:40 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qd8LsPfV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="nMZra/aK"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qd8LsPfV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="nMZra/aK"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708712861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7brqYZxmuxrRKSYQEeacefCe+ctYuF6xWTXM5McbA8I=; b=hvA1yNTUhc1RBvMHvI5JqhYlfrsCwEiwPo/P/dJpXF5R0KUCoJatdh329uZFVuIXMnYxsr /eXPWp6F1zNHz7Y+f58FFW6GdaTjGtR5w1M513L6EDDhMbRG5ToM644PVEHF1UCKLQbB/H FR2cjcH4lOSOxNv08h+I7nVXHi/sgjQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qd8LsPfV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="nMZra/aK"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qd8LsPfV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="nMZra/aK"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708712861; a=rsa-sha256; cv=none; b=ZzaYPtMb9XGdUvT6h6hmD8yKeM0wiTTvH4pjNDPX987QjZ0AhIUKUPncaJYQihakblpu2+ 2FILxapq7JUMe0Yp4PwoLHwLbcordVZWTXV6vBqBYAiAxJm5yRPsjxsCzi7x+RxXemCQwN zfOyApuyryf0pqZGfxDdiq5IhnzyP8s= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 28A201FC2A; Fri, 23 Feb 2024 18:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7brqYZxmuxrRKSYQEeacefCe+ctYuF6xWTXM5McbA8I=; b=Qd8LsPfVNYRjMhedMtLQ9mEmCVsypU2uQh2vZjA/HgXPPaDR8h6Ob8cd8kWmdHVkIEyWc5 tZICMKAYYO83n5ZTXm+kGImHl31S91luqmF99uGMQrY23pYLrC8FYIbz+5qVyYmtbNCrKw Ow1WIWaUaW6G1ZKB3a3lruEOoFTS/EA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7brqYZxmuxrRKSYQEeacefCe+ctYuF6xWTXM5McbA8I=; b=nMZra/aKnnlj9lkcc3nn6p3CDtjcpzXA6pWZ7RKjeB9Du6opgh5HJm8+D3P0y4LF8SXZOz FXDZgr9xc/wiCJCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7brqYZxmuxrRKSYQEeacefCe+ctYuF6xWTXM5McbA8I=; b=Qd8LsPfVNYRjMhedMtLQ9mEmCVsypU2uQh2vZjA/HgXPPaDR8h6Ob8cd8kWmdHVkIEyWc5 tZICMKAYYO83n5ZTXm+kGImHl31S91luqmF99uGMQrY23pYLrC8FYIbz+5qVyYmtbNCrKw Ow1WIWaUaW6G1ZKB3a3lruEOoFTS/EA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708712859; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7brqYZxmuxrRKSYQEeacefCe+ctYuF6xWTXM5McbA8I=; b=nMZra/aKnnlj9lkcc3nn6p3CDtjcpzXA6pWZ7RKjeB9Du6opgh5HJm8+D3P0y4LF8SXZOz FXDZgr9xc/wiCJCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 008AE13AC1; Fri, 23 Feb 2024 18:27:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gJluO5rj2GUaTQAAD6G6ig (envelope-from ); Fri, 23 Feb 2024 18:27:38 +0000 From: Vlastimil Babka Date: Fri, 23 Feb 2024 19:27:17 +0100 Subject: [PATCH v2 1/3] mm, slab: deprecate SLAB_MEM_SPREAD flag MIME-Version: 1.0 Message-Id: <20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz> References: <20240223-slab-cleanup-flags-v2-0-02f1753e8303@suse.cz> In-Reply-To: <20240223-slab-cleanup-flags-v2-0-02f1753e8303@suse.cz> To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Cc: Zheng Yejian , Xiongwei Song , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Vlastimil Babka , Steven Rostedt X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1937; i=vbabka@suse.cz; h=from:subject:message-id; bh=xj2FbXNZUF1ZX1Yi4h91pRFSVKXZaW8ItJyLfGmRRuU=; b=owEBbQGS/pANAwAIAbvgsHXSRYiaAcsmYgBl2OOSfAZ6NhpOQjvkRl542eUJ71NZdn+YC7Mu6 stXO0E2hXKJATMEAAEIAB0WIQR7u8hBFZkjSJZITfG74LB10kWImgUCZdjjkgAKCRC74LB10kWI mib0CACG+JmJHKxWWP/7G2u05sgQbj5Lct25lOvrv1QuCza7ZVTLPiTE2iE+BTE0PtH2dbdAYA5 sl5xS/B71qhL1xjxpXhlT48vuelChx7oiMjOTPC1tbcKaU3HM68z420oR4LMO374DAlIaO5zlXu 3UBG5MbidRfJxcqpQ8bWT8BUApwBuLjP1/psufGw7UGhM8uOii58OmE81DqIaPf9+9L0upk6xw9 TNwRePi/w3rAJw42PoL6BkGJktvFbYpMLsDlfcPtjayFWVLix+Fwxkw09xUv4ZmAHSNjBDIMLjm HUnykdE/UgcYH0yBCAYi+6kvrVWPQw9wvQU/PWokxe3J3Ive X-Developer-Key: i=vbabka@suse.cz; a=openpgp; fpr=A940D434992C2E8E99103D50224FA7E7CC82A664 X-Rspamd-Queue-Id: 1A5FA40003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: na7somo3uwd1qnjw1d77oscxj8gaq8kj X-HE-Tag: 1708712860-480305 X-HE-Meta: U2FsdGVkX1/CBxkESL3jpoDTLMtkG7HQRSlaJgDsvWf9Iy+MfsFfzLBGBQC890OKfqfjR0NshB3wJ6C/nfIf8MganwfidkfYzLMn6jW9RXyU9REjM/GFIw+ow8epL+Djf8IFyBP0dbRkNHYa7V1vTjpEJwY618w77dPJMkiP1kp/HUHpAZeUEBxUXdCtHpvzGqGDmyYAmQFhpKdaWJFbh71gdD3Zhk64+5abshF3wjDLMBN1g8EUBr589yK79JV+vIJlAcVVi/vCWL2dXxnj9rwC8H1K/X6anQD8grTwqL83Y9UxiqmFJY5mIM1/8dI8cXbGYoQGQ8Bs6funcjktt4Q9Dnl/JzEGiqldMC49qCJEJWKczIpMdtZ1P6JpnswLOagjR3LAWHZWOZpheDCWeRuL8z9CpRzpJ7ZQxcGX+ZrIKnpD/LXzWji/nlDZFy7CIbZXrdRnHQszBDlL9kleXcdNoGsso+B4x/GUSivt3knTR1e9+wHCwOZj68S7duphAFmqiT+0ZNveeYiUam7tNeJb8rZ3m9HKReDIWrsIsurj4CMShyS9VROSh/GRjS8xt6+4K0saUvUD9EppV/qQjs9ZgixD2UPIFPgYMTpzgCOORpoQc4w83eEXBZhsCf+IUNGfBJQBGIWRogqpLfrY9a5fDn3GRt9pqh+vN9uX6pfvTzuH5IRxWv8j+sZCoQEj8xqw9xDEgD+/t+6tfm3o2KIduj3pMMSDvWNFu0KDTFdxW7mvc8yc6C7oU+SE0ak1Zo5dGha1in9CrL0ketVYWplO23za8djQ0TiF9nxnJhJ9R0JkW6VUWhKQIheIubU2oDISgq2PN0uUcyw7ijFChvofHaGHX84LKLhHKe9Rjw5nE9uYls0cr4kVk7KTgGmIZzc9Zb2QXIFzxFCc/Em8tLohz8/5yfUHfhKdsj9OQ/aIjTT2Qejl0e54YLeAAaoH4jPAlkNq5ylRjVDfT4k nMunwUKZ 2L7p8UCtV7Jo59oshs8d26I+qh96lwXLJT4dj8dJirOLU6F5i2/LqMBw6ux/LHZODrjhQqDV1SV5cNfQckO+HLh9QFYjRSV0rl7kuiVHA8zlvzL+5b1jDWh2epj+jBWTSMnEtk2vW/+J49FbE7NR/frtdVeNOVzLSFc14Gluh097v6xn3BfTz1yu0EObZh4Rnpr1XYSQBk18q0ArpXS/XeIp+aBMo8akktdKj5JWidoRcPlSYW2Yu7Q+enVkJz4Qk4kbbgnoNao4XDGBZzZx+SZYudUE2dHiD2bsO3P7CTGzg4Pe8vjbGfXiESx5+VtaQbWl6/6ExHsMK2NFLxvJ5mFaIr4odpKPrUjyJOMzdHhfL2gp6rjRGc+xLWCW3wZQCdLWQBjn0ws+fDBcbKIy8x/ignJPjocZ4qaOaosJEZ6m15iqftJ9ktC82Dn9HZbLnoUBSeLhiYFMM+yCwGwncV9hoiYuIUunOG0BeY/50RicBsBljE0tJRwJBdvwMJS/OjUMUPSvMeq+oNpQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed. SLUB instead relies on the page allocator's NUMA policies. Change the flag's value to 0 to free up the value it had, and mark it for full removal once all users are gone. Reported-by: Steven Rostedt Closes: https://lore.kernel.org/all/20240131172027.10f64405@gandalf.local.home/ Reviewed-and-tested-by: Xiongwei Song Reviewed-by: Chengming Zhou Reviewed-by: Roman Gushchin Signed-off-by: Vlastimil Babka Acked-by: David Rientjes --- include/linux/slab.h | 5 +++-- mm/slab.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index b5f5ee8308d0..b1675ff6b904 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -96,8 +96,6 @@ */ /* Defer freeing slabs to RCU */ #define SLAB_TYPESAFE_BY_RCU ((slab_flags_t __force)0x00080000U) -/* Spread some memory over cpuset */ -#define SLAB_MEM_SPREAD ((slab_flags_t __force)0x00100000U) /* Trace allocations and frees */ #define SLAB_TRACE ((slab_flags_t __force)0x00200000U) @@ -164,6 +162,9 @@ #endif #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ +/* Obsolete unused flag, to be removed */ +#define SLAB_MEM_SPREAD ((slab_flags_t __force)0U) + /* * ZERO_SIZE_PTR will be returned for zero sized kmalloc requests. * diff --git a/mm/slab.h b/mm/slab.h index 54deeb0428c6..f4534eefb35d 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -469,7 +469,6 @@ static inline bool is_kmalloc_cache(struct kmem_cache *s) SLAB_STORE_USER | \ SLAB_TRACE | \ SLAB_CONSISTENCY_CHECKS | \ - SLAB_MEM_SPREAD | \ SLAB_NOLEAKTRACE | \ SLAB_RECLAIM_ACCOUNT | \ SLAB_TEMPORARY | \