From patchwork Fri Feb 23 14:37:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13569147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6DFC54E41 for ; Fri, 23 Feb 2024 14:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A08416B0075; Fri, 23 Feb 2024 09:37:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DF206B0078; Fri, 23 Feb 2024 09:37:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 881226B007B; Fri, 23 Feb 2024 09:37:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7A33B6B0075 for ; Fri, 23 Feb 2024 09:37:44 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5AFD91410F8 for ; Fri, 23 Feb 2024 14:37:44 +0000 (UTC) X-FDA: 81823322448.04.0B67BF5 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf09.hostedemail.com (Postfix) with ESMTP id 413B1140013 for ; Fri, 23 Feb 2024 14:37:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708699062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+th/Td19wsW0vrhRbKsf1M2KQWDRombwPDo6kwExpPs=; b=fr8S35lgpcKDcNRZ8J36cxuCpbPSVNuNQpfvSqzs/ID2hcgiu49HX5D0zqcSIX8pqOGEXC xpt/a8C2JPZEfA6Cnw9oFNoLApF4TowznUKy/UD6Y6WUShWNMIG4YGth8IgbUslVK7rNrz 1wMZ4kjKaCYLLJ/6kB5pE2ifQnQ0O70= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708699062; a=rsa-sha256; cv=none; b=HRU5W+XVfrJx6xC4NClbKl8f8d+IbmuAJMsMXaTA0NoowxJ9TZUMe7ZqAqlavnbQoZfZEJ d75DeBxrIRYMVqDP5LBUVWTlyFH2jFJno8QzwGWIyXMdKrEx/6tnQstpR6VuNCHeEnUYHD 45etAy/o4tJH3rkgwAlPWjKEzX8TeII= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ThCF44XpBz6K8d2; Fri, 23 Feb 2024 22:34:00 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id B5B62140D26; Fri, 23 Feb 2024 22:37:39 +0800 (CST) Received: from SecurePC30232.china.huawei.com (10.122.247.234) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 23 Feb 2024 14:37:38 +0000 From: To: , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [RFC PATCH v7 02/12] cxl/mbox: Add GET_FEATURE mailbox command Date: Fri, 23 Feb 2024 22:37:13 +0800 Message-ID: <20240223143723.1574-3-shiju.jose@huawei.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20240223143723.1574-1-shiju.jose@huawei.com> References: <20240223143723.1574-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.122.247.234] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To lhrpeml500006.china.huawei.com (7.191.161.198) X-Rspamd-Queue-Id: 413B1140013 X-Rspam-User: X-Stat-Signature: 7zunorgn64a8hx11418e4tds6af3iqim X-Rspamd-Server: rspam03 X-HE-Tag: 1708699061-699245 X-HE-Meta: U2FsdGVkX1/9C1BvkNcBUXCVMR5NSxpBtmmpUdo+Ej4NUdHkcPk5DRMif6dh9gLd988AfzTXmPOiS9WzH7EFOMxvcXZikUtvTCfJZKJ0SfZrz5vxY/RyH1nWsn4eCpQkbFM9Y4f4b2ficzZsfOwVclCVxGlFNd1W/ajdqJNLpvzFZyylIzxAaog6De3UM0DX3yK3U9vp7Z3TfXghwYC4hyu1fKa0JLJ3ZLAMZU24x7aOer1xfRT0ti1oxw0UkorSTWECo125JcWchyQm9MywlkjFi0GKfhuhcNRmjXHT9YrnfARDcSTjYZrYb2c759VIWurE3wxqVpRCherRwOh9Esm/Wp1u9X4dCt0heS/PAeYmOxSj/FsIorntK8MBKgrV8i7arc9xRVuJhfCdSnhCrxjRMdZcseYRp1tbOm9RzOv5O3WluWNhpKkrFEWF4UYPOKMbuxkDdPYpYMiBPI1ob0f1p2ERIWs6rstSbhzaj6f47TpUvqJ+gFvzTbqdSKHHONCk1uwHWqilMHeo0wDMnEP6KsNa91Zj504/+khG/2Xu9wz+RJH7wV4UOCbme7Ahizz8C/IMRas68fvzOV1Hbhg9W/5ihgfEXa/iHGkZZyLQRdbGJvTiMm+FTWxUwj+xpQO5ZXJD7+0IPUamBhGBqQteN0trAriPrcL87tobMqIjVeD9ag3vkFsMzpR922ltLN2QI5/HO/Mv52xdSqVabRcsvnq0OzgJ6jvJkQNihD/h8jnArAx0XSObu/smVNZYxqerhHutmm1ydUat9v58vJmxHnJBf6UpSzzxTAj2cLQpEhuIMtYETTKtqqFThfg2x3FWrHjYRZu5SRq8kzue/yjAEoLVbMUmZGraWTjkKojRDkwSRQGIBJgsHeTE44hOalv/JJEcJtTaCdi2Hlewp4vhG5sGRQOZrJ+VsPesSy9oi6jc7+HoaSp2hCmYpNhMm1wwCwDf3YupFHkmgPO s03J/JIo UBBbZ9xSoaSn2WwiMkM763X2MiIihuADDqzYlK0t9X/DScSMR478u7L8XFDRlaKedFvt39Zk1npHwOn4wJBBFfKg4L1mfuHcO11vNZYpOwz7aZ69fBvRefK1sfH+dLSo3V90Aunlb44KiUwSRDfTUrcsSwfYIqUSXOvLaHX4f9v3sRSH5IRqhzeTJt5u0hIKQqKEM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for GET_FEATURE mailbox command. CXL spec 3.1 section 8.2.9.6 describes optional device specific features. The settings of a feature can be retrieved using Get Feature command. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 49 +++++++++++++++++++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 25 +++++++++++++++++++++ 2 files changed, 74 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 79cc7fd433aa..c078e62ea194 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1317,6 +1317,55 @@ int cxl_get_supported_features(struct cxl_memdev_state *mds, } EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); +size_t cxl_get_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, void *feat_out, + size_t feat_out_size, + size_t feat_out_min_size, + enum cxl_get_feat_selection selection) +{ + struct cxl_dev_state *cxlds = &mds->cxlds; + struct cxl_mbox_get_feat_in pi; + struct cxl_mbox_cmd mbox_cmd; + size_t data_rcvd_size = 0; + size_t data_to_rd_size; + int rc; + + if (feat_out_size < feat_out_min_size) { + dev_err(cxlds->dev, + "%s: feature out buffer size(%lu) is not big enough\n", + __func__, feat_out_size); + return 0; + } + + pi.uuid = feat_uuid; + pi.selection = selection; + do { + if ((feat_out_min_size - data_rcvd_size) <= mds->payload_size) + data_to_rd_size = feat_out_min_size - data_rcvd_size; + else + data_to_rd_size = mds->payload_size; + + pi.offset = cpu_to_le16(data_rcvd_size); + pi.count = cpu_to_le16(data_to_rd_size); + + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_GET_FEATURE, + .size_in = sizeof(pi), + .payload_in = &pi, + .size_out = data_to_rd_size, + .payload_out = feat_out + data_rcvd_size, + .min_out = data_to_rd_size, + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0 || mbox_cmd.size_out == 0) + return 0; + data_rcvd_size += mbox_cmd.size_out; + } while (data_rcvd_size < feat_out_min_size); + + return data_rcvd_size; +} +EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index dd66523cd96a..bcfefff062a6 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -530,6 +530,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, CXL_MBOX_OP_GET_LOG = 0x0401, CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, + CXL_MBOX_OP_GET_FEATURE = 0x0501, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -753,6 +754,25 @@ struct cxl_mbox_get_supp_feats_out { struct cxl_mbox_supp_feat_entry feat_entries[]; } __packed; +/* Get Feature CXL 3.1 Spec 8.2.9.6.2 */ +/* + * Get Feature input payload + * CXL rev 3.1 section 8.2.9.6.2 Table 8-99 + */ +enum cxl_get_feat_selection { + CXL_GET_FEAT_SEL_CURRENT_VALUE, + CXL_GET_FEAT_SEL_DEFAULT_VALUE, + CXL_GET_FEAT_SEL_SAVED_VALUE, + CXL_GET_FEAT_SEL_MAX +}; + +struct cxl_mbox_get_feat_in { + uuid_t uuid; + __le16 offset; + __le16 count; + u8 selection; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -887,6 +907,11 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds); int cxl_get_supported_features(struct cxl_memdev_state *mds, u32 count, u16 start_index, struct cxl_mbox_get_supp_feats_out *feats_out); +size_t cxl_get_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, void *feat_out, + size_t feat_out_size, + size_t feat_out_min_size, + enum cxl_get_feat_selection selection); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr);