| Message ID | 20240306123217.29774-3-osalvador@suse.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | page_owner: Fixup and cleanup | expand |
On 3/6/24 13:32, Oscar Salvador wrote: > stackdepot only saves stack_records which size is greather than 0, > so we cannot possibly have empty stack_records. > Drop the check. > > Signed-off-by: Oscar Salvador <osalvador@suse.de> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>--- > mm/page_owner.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 7163a1c44ccf..e7139952ffd9 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -865,8 +865,7 @@ static int stack_print(struct seq_file *m, void *v) > entries = stack_record->entries; > stack_count = refcount_read(&stack_record->count) - 1; > > - if (!nr_entries || nr_entries < 0 || stack_count < 1 || > - stack_count < page_owner_stack_threshold) > + if (stack_count < 1 || stack_count < page_owner_stack_threshold) > return 0; > > for (i = 0; i < nr_entries; i++)
diff --git a/mm/page_owner.c b/mm/page_owner.c index 7163a1c44ccf..e7139952ffd9 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -865,8 +865,7 @@ static int stack_print(struct seq_file *m, void *v) entries = stack_record->entries; stack_count = refcount_read(&stack_record->count) - 1; - if (!nr_entries || nr_entries < 0 || stack_count < 1 || - stack_count < page_owner_stack_threshold) + if (stack_count < 1 || stack_count < page_owner_stack_threshold) return 0; for (i = 0; i < nr_entries; i++)
stackdepot only saves stack_records which size is greather than 0, so we cannot possibly have empty stack_records. Drop the check. Signed-off-by: Oscar Salvador <osalvador@suse.de> --- mm/page_owner.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)