From patchwork Wed Mar 6 18:24:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13584425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C04C54E41 for ; Wed, 6 Mar 2024 18:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24BDB6B00A2; Wed, 6 Mar 2024 13:25:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D59F6B00A3; Wed, 6 Mar 2024 13:25:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1D1B6B00A4; Wed, 6 Mar 2024 13:25:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D9DAA6B00A2 for ; Wed, 6 Mar 2024 13:25:19 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B95341A0176 for ; Wed, 6 Mar 2024 18:25:19 +0000 (UTC) X-FDA: 81867441558.19.0AAF6D6 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf22.hostedemail.com (Postfix) with ESMTP id 06246C001B for ; Wed, 6 Mar 2024 18:25:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oOB+CKpg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of 3DLXoZQYKCE89B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3DLXoZQYKCE89B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709749518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bHZwja06se4PI5NvmXw6g0w6FqOSRgAaf+Zh29a7Axs=; b=l8vXhiTNgzUxmVyGZB1DaL2sR3A9OAduGovdUgcIMEXME5Uy/KVqSZlX0ShFpTZfHONsJH Bm48jsrfx4FRORWlAEIUEovnbwHU+5Y71wpYaqnEsnECqlZ4NGfthOM2b2rWMbhV2GVc2x aIZKcD8iIOu4oaPlXD40EIRH97tKG4A= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oOB+CKpg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of 3DLXoZQYKCE89B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3DLXoZQYKCE89B8v4sx55x2v.t532z4BE-331Crt1.58x@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709749518; a=rsa-sha256; cv=none; b=ZCP3hGx3NzeMNeouYTLigG44+szttr4BiXHBN9Y/Ia38msYrjMOZhDDNp0iukU5sph4XN0 aJcoQwdyVU4lbv9YVXxzjHDyqPevrhiaMNUz+pSbFktGxRTg5sF2UneOvDFgtKScsHgt4q XeoxtwXVM/CGbndv7rggpH3D4a7YLqo= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc647f65573so12656258276.2 for ; Wed, 06 Mar 2024 10:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709749517; x=1710354317; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=bHZwja06se4PI5NvmXw6g0w6FqOSRgAaf+Zh29a7Axs=; b=oOB+CKpgL6QEJTstBWHNtCsNNENAERdxRn9E5dqhU6zuyLXXUWPpJZu9PyfqgaC/RV ZdV1pE3nyXOEssc03ZoKnBTAWFdLGkB3/0RW4jfDOeYxM38pcl0GoTmjrg5iGcdYHdhv zcApsFokU3yr6H3wdX1mZOSP1XRvkk+Zr5Kwt75TDdNgOCA40olBuheeUCHV+h8YaaU/ 30ZwS5TqGNy9SJhO0iLYhJjF0gz2encNdbOHAVn0BmYRLZCR8krM6IIHLKHBxa+qG0Za /JrcunloGn7LahxRVHaz1RRZmVlyIXUAA4uIKyz2xQLQ5NSFiC/uKQLcBVqOa+xP2dpM V5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709749517; x=1710354317; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bHZwja06se4PI5NvmXw6g0w6FqOSRgAaf+Zh29a7Axs=; b=AZXh0VLe+yZDqa4IgCjuUWCNKDbbTH3W+T+vJvPTUfM86Wg/h6XzcODv3iNVkXQrwk pwA5ut3NyTa/ThcxRHwox7q8ZomH28LUgwi0LoAcFhuTLvdu2KHznBnEJx6ma5INT3QN zoyq29mbI1SjlkAabVsKZQXoqnl13tWE0/yEAmHxs+wY9c7xzzxA985FXkd9C6lolltK gm5/DpqzU+roozSTmEMpVutNooSLo6Byvj9Vnj0SeK9G+V9m4Sc99jNKm4pIyYx5D7HO XQrG+sCkhz3+dHbjVitZTXRgg99SZibC8aTcWswEzwHblFWBbTYEK9DKJtOopuh+Orhz dgHA== X-Forwarded-Encrypted: i=1; AJvYcCXKwcGXNSzAwmVRnkADZbSTUJMh2c2AYqHVVOeOnqM5JO4vgK9Qkj4H1JdfDkgzYVOMr7wBSP8lmminRO7blkirKRA= X-Gm-Message-State: AOJu0YwRha0LjkaMsVsRzl5e8/OmqSSxkDaHxI8zKf4fkZdWvu4sIDPP e4miNNKckj1IWlQS+FOQBEUFTlal9bHt4WqgFwtZeBB5oo17TQcAn3maOP4gPLQ7CNjeD7udXi1 B6w== X-Google-Smtp-Source: AGHT+IEY0dq37W/YL8K/UAYJglAS6s8iwOM7lJC17R20EwJUoGE14Vwyo3M1UA8Agcy0JGlj8awomXhRYvE= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:85f0:e3db:db05:85e2]) (user=surenb job=sendgmr) by 2002:a05:6902:18c9:b0:dcd:5e5d:458b with SMTP id ck9-20020a05690218c900b00dcd5e5d458bmr4001383ybb.3.1709749516858; Wed, 06 Mar 2024 10:25:16 -0800 (PST) Date: Wed, 6 Mar 2024 10:24:13 -0800 In-Reply-To: <20240306182440.2003814-1-surenb@google.com> Mime-Version: 1.0 References: <20240306182440.2003814-1-surenb@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240306182440.2003814-16-surenb@google.com> Subject: [PATCH v5 15/37] lib: introduce early boot parameter to avoid page_ext memory overhead From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, surenb@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 06246C001B X-Stat-Signature: 9czf3c46h5g3badw8f46s3cjswnftpwg X-Rspam-User: X-HE-Tag: 1709749517-980484 X-HE-Meta: U2FsdGVkX1+t+Lq1/60dz5dbJAyxFYF8fzk2WEIngZDhi/q50cVGA07wViNqGwc+Y4z/YRlRJlGr0X26/q8EBpEBIH7YB718Ftf02fLGvQb3bTKzZICa0SYOFg8mizcUB8ea7iuYaVwKcDvds0poyUbtUqemVN3bqzJYJ4P/RcBNWfbDBbomGrRjaRC2/v6LeCM3mx9LeaZt4otRmu1s0JseoepB0u0SB+XQ5DAnYTiAmcYRKYxkycOcTHp2szx+HjQrlM+mq2IM9AXF0KYTa0EonmPxv95t2/WSiBeX4WhW/nqB6XdScffCHf8++pb43lDqkNHFPUuMY3zalBT0UFzyHxLnvUpkE8to3DjrpmPLBSQDgoyyE8Go7amhwA6Xv9Ft/Y1NcXLwbbA2swz28BFc1yKHGziFM1OiYPmlXfabSlDDrYbluJA1K4YYn6RXE5OikKbBTqeGEUHEqbTiO8CmXWLVX7cj8++mE8mqiVLqJMDwJ3qvtsJUKtqIZBpaZCt0coE+T8oPxWGT/FQkLcVIEIQL6bZnHbp1JcGv+wh9wiE79xlLtb6eXj9JOiZZ63agHQMmG+QmjsOzPG39g8AIulUq3gOjL4elYA8ang+eBt8YySW5U9+LzdcbjrJPh/gG7Zmsd79hEL0NwJ+fa0QZGT8P0eNY+K0V857anmkefjI8IWq//CtXerLoCk4E8YH53UzO4sxsEbPO605buXT/bfUh58feOzwaKLAjQYIIUcBCaWWXidFlyqovMKmoPHp5tr4CatBYSsabcM+F7iDfdDhjKd9SL3TKofqIHL7SPNF+q2NqQMEImYyFBvqCDlmYf2U4cwKk3SjivEYNK21WnJ4qNmT8A16ZTUovej0plhBxb3sLI5/IeZmaf3yVRiryPrJv2QNvjj8x2SBZgibCnip3FrP86kIM9cntrPaXuiOyHf0R6wqBvgfwc2I7pS+NxFncouh6Yw42huZ UOt+b+1D vxgytwZBpldqupx6PtTzG/SYcDyJ8jXedPjmTWWN1IF1tYlDVgdhXl9ps02GEwmKsYEbdi7o8npgRkkbZKJBF27TSpGDmFqdrQxVzq8AHBTQUmaSnwgQwh0h7L5ZYL1lI6tuOLCX0K0pIX9jq2e4pkEKhNLmBIJ16yILKnhYK6Ju9qapeUGQgzu45bTf/ESyRCjWjOn7z2ubL0igQ1/5gwuaGeXI8+/bs91edVATg41Hk2d6skveYW0OluadTPJlNPG2wFL9gxlM539tFYhtOsUJNE2tlM3BWSAxVQk8dz0mwZVC3JeuQhSYT54wj+28iwF/RXNg6A8CdoUWiT0SQbGAZPuxt2HN6hAjpCtfO4/hXk4fG2rPcrnQE/Z7Sr07S2zysk00L2smmq1DRzs4YK2s4C3BG2b4Rm7sV9J+TNzDPV4kiqgjfCQNl+9GcYMvvLqhd2BLap6bbjyucddIgvHGZfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The highest memory overhead from memory allocation profiling comes from page_ext objects. This overhead exists even if the feature is disabled but compiled-in. To avoid it, introduce an early boot parameter that prevents page_ext object creation. The new boot parameter is a tri-state with possible values of 0|1|never. When it is set to "never" the memory allocation profiling support is disabled, and overhead is minimized (currently no page_ext objects are allocated, in the future more overhead might be eliminated). As a result we also lose ability to enable memory allocation profiling at runtime (because there is no space to store alloctag references). Runtime sysctrl becomes read-only if the early boot parameter was set to "never". Note that the default value of this boot parameter depends on the CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT configuration. When CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=n the boot parameter is set to "never", therefore eliminating any overhead. CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=y results in boot parameter being set to 1 (enabled). This allows distributions to avoid any overhead by setting CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=n config and with no changes to the kernel command line. We reuse sysctl.vm.mem_profiling boot parameter name in order to avoid introducing yet another control. This change turns it into a tri-state early boot parameter. Signed-off-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka --- lib/alloc_tag.c | 41 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index cb5adec4b2e2..617c2fbb6673 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -116,9 +116,46 @@ static bool alloc_tag_module_unload(struct codetag_type *cttype, return module_unused; } +#ifdef CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT +static bool mem_profiling_support __meminitdata = true; +#else +static bool mem_profiling_support __meminitdata; +#endif + +static int __init setup_early_mem_profiling(char *str) +{ + bool enable; + + if (!str || !str[0]) + return -EINVAL; + + if (!strncmp(str, "never", 5)) { + enable = false; + mem_profiling_support = false; + } else { + int res; + + res = kstrtobool(str, &enable); + if (res) + return res; + + mem_profiling_support = true; + } + + if (enable != static_key_enabled(&mem_alloc_profiling_key)) { + if (enable) + static_branch_enable(&mem_alloc_profiling_key); + else + static_branch_disable(&mem_alloc_profiling_key); + } + + return 0; +} +early_param("sysctl.vm.mem_profiling", setup_early_mem_profiling); + static __init bool need_page_alloc_tagging(void) { - return true; + return mem_profiling_support; } static __init void init_page_alloc_tagging(void) @@ -158,6 +195,8 @@ static int __init alloc_tag_init(void) if (IS_ERR_OR_NULL(alloc_tag_cttype)) return PTR_ERR(alloc_tag_cttype); + if (!mem_profiling_support) + memory_allocation_profiling_sysctls[0].mode = 0444; register_sysctl_init("vm", memory_allocation_profiling_sysctls); procfs_init();