From patchwork Wed Mar 6 18:24:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13584442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF6AC5475B for ; Wed, 6 Mar 2024 18:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E34D06B00C0; Wed, 6 Mar 2024 13:25:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBC1D6B00C1; Wed, 6 Mar 2024 13:25:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE7096B00C2; Wed, 6 Mar 2024 13:25:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AAE136B00C0 for ; Wed, 6 Mar 2024 13:25:56 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8CE42A065B for ; Wed, 6 Mar 2024 18:25:56 +0000 (UTC) X-FDA: 81867443112.07.07AE75E Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf18.hostedemail.com (Postfix) with ESMTP id DB3E01C001F for ; Wed, 6 Mar 2024 18:25:54 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HJ0mz2Yd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3MbXoZQYKCHQkmjWfTYggYdW.Ugedafmp-eecnSUc.gjY@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3MbXoZQYKCHQkmjWfTYggYdW.Ugedafmp-eecnSUc.gjY@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709749554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+wmfS4WzHQ3O9sWr06d7OoGjn7qYNg0oNg7s1VmP4AA=; b=Pj4Id//vrxGX0jDjjgTDyLMikhN3z/Ex6jdY0+eo+9x+xhSILNa8JRGBMuVkzltXTv/LKv PTtnpoudfIgg761aCepWyELjmGNXpdJg0Y4usFPufg9YVDqbNu+6+72JeRNeQbGA64VFmH A3tIc7cC2Xhf1Wj9FT4p/s8BS2WxxF8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HJ0mz2Yd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of 3MbXoZQYKCHQkmjWfTYggYdW.Ugedafmp-eecnSUc.gjY@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3MbXoZQYKCHQkmjWfTYggYdW.Ugedafmp-eecnSUc.gjY@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709749554; a=rsa-sha256; cv=none; b=3jBL/CK1B+IBEY23V++/WIjrmka8TGcMHHA2IAfe38PxMoAa3PRgQdjVc4UoM1GgoRqlP2 +MxPUaPj73Tv0gpwXnijuHViND3dUqV5nyx8Fr6yP2n2c4rpXwobMAv8Cb32lGQqrXlB/h gwyLAnbLbtgcnd7o7DyCMHsqkwFzsEQ= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc3645a6790so4024489276.0 for ; Wed, 06 Mar 2024 10:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709749554; x=1710354354; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+wmfS4WzHQ3O9sWr06d7OoGjn7qYNg0oNg7s1VmP4AA=; b=HJ0mz2YdYOqaZ9Emxogc+EHgpSA/i3Vz+0gzeGSqk4gbOoY3Ec4JeyK/A19keUicbm KK1oY1wiPMovojCGdSFNYK5LEbnu2DeONwDT+FSTMx0bv6DywY91W/krSvTneB6hYu8T 6VHJFErbVnDSXfykggGhaeURpxMt38dWr4z2DatvEO91OQ8IaVBF/F6a3d+WG+JtEacm t5sh7Z12Qb9fhLgflmAVMy//vIpoazr9PY8Sm52a0CpWBIdBAcwIpOS8+Ln0ZXruvuFK 8qOH0IM9feODs4MmOjpINF8OWlryDx2tvCX0BzQF8iUN+xgWGGpj0ft3G3JP5R4Wl2Oo B0bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709749554; x=1710354354; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+wmfS4WzHQ3O9sWr06d7OoGjn7qYNg0oNg7s1VmP4AA=; b=VwCbyBveBz/lR83kt9/MI89cd1WgJI/rVoqTVUwn0ycKmKqPwzHpyFbbC/bQDp1YRW jLrXFgIQ2759fvKPtGKEV3tmYoNiy9mzOsmjnW8hISusViQjwqUdvElGKutt5DT7bg9V pt+5+GYvn3FBDwObkcK43TeZLnVc4mj+sZjsk6m3JKXidHRNUGmht//IZtCBANrFDAyk A0nqfQsHUntpWUitQPR83JerCaDW51U7kQ6s+QCPt5u7kwN1OTq7jNq+10eydBK8qbnV rIVMKD3zNIevPbsEX/1rPU2kcgc2Apj8RGkEUYSAa58ZAT9TYj2HCwmCNBC+lI/FJENI kQJg== X-Forwarded-Encrypted: i=1; AJvYcCVYqfQMYO1RzbO+i00ApGef3PUNXOkdhhl86AjASuCap7+ORgMdz4Nj2tT020sNi0XauPHljRyexADhEPZ1aOrA0SY= X-Gm-Message-State: AOJu0Ywjtn8lmsXCGOdAlIYRia6Fgi/hDeBT+gOSu/40czD4SuHfgEVD iAMv84Pk9x+cUuSJGRy5IOdguKT1Ieh3ROGM5w/xrcNVaR+0dZWXcT7qYI2Lf4IdKhCn+69WIaV pPg== X-Google-Smtp-Source: AGHT+IF6YEyRmq18pPuKKpt59wbNGO1QMY+fEEbCCtJ5tUZChXHjWclQVIOgZ7rujqj4/I2Mqr5y06vHSeM= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:85f0:e3db:db05:85e2]) (user=surenb job=sendgmr) by 2002:a05:6902:150d:b0:dc6:fa35:b42 with SMTP id q13-20020a056902150d00b00dc6fa350b42mr4231906ybu.2.1709749553765; Wed, 06 Mar 2024 10:25:53 -0800 (PST) Date: Wed, 6 Mar 2024 10:24:30 -0800 In-Reply-To: <20240306182440.2003814-1-surenb@google.com> Mime-Version: 1.0 References: <20240306182440.2003814-1-surenb@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240306182440.2003814-33-surenb@google.com> Subject: [PATCH v5 32/37] lib: add memory allocations report in show_mem() From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, surenb@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org X-Rspamd-Queue-Id: DB3E01C001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zkg5fppgu5fecgc8tn8iru63hidssq6y X-HE-Tag: 1709749554-754731 X-HE-Meta: U2FsdGVkX19M+gvpn95aCY+xLIF5ZO+wLPGXcUj6jiDL5po3eeZwZrTIlop9IdEf+xvm3VlPvvjFy8GwPfgM1tP+yoIunQUbA004jrJaM3NhpOJmqJiInEioRe9+MnVEGG5eHtVFVTbV5DHeC8P/SiVJREk6C1lyiQBcVKAQ46P/4HgH8OoQ0PgG4Pm+jDA01vz+SzpomrknJCTz1ozpeCEEAgH3Ge1gJhe0u9RK66AUvVzA0KaLuS4ybk/MRjin9c/ldtf1MsHqk6axoKDIf1bXnemN7RV2YEvQS+PbzUJCPGaGDs64XeUwf/+JT27Tl47FS2gLQiFBtZZRfUtktgfVD0KLlTCYWb5jK3i1q/fcXR+BrlisvemPUTho1OM5mxCXO0sMd66/+UFwGAZZzAAz5SQZZllgHhhJ6bTp9nWqubFglmyavCNEH+kWUsasL+IuRjuWaznxLV/7CjWZSfAA5/l83frIN4SGfGbHFSILAfR1bq9qlmpqVKa9PHjjfF7+7IlSfVMgvtn8g+JfYa+vUg3KMatmbngZfNSFeuxFd68Gy3tScggpL2dP69LPkOnBfgWOuO2aUzonpGe2qs1hvOfjvqtvIPn4s6yyFJ27bOiTwuPL22qLvbhuf5EzpY263b1SNQ6XuAORw5uyuvRk45oPfYPAc8U6qHW7W9rb3/abg0Pz9PYIF5JG54TQtrmzCxjjsZYZZs7OmVQgmJu0M83g1k+wZp7TeZFiyC7mKorFvhhLpwqh669/tXKiWEFz01MPgyOd6ZA8LdD0+WsClT81DsGsnqXl0SKOLeaGLbkcX4PbNkNbq3MU4Pj0IO9B7BXUzLnSrWZ31itkavHpKmU0JcuK/EDFbODk32WhcXxHT3e22Mw+L69k4irwwqlAyL1yhKL+hKOqUcVGENfLkgHnIEhrHCJMaDTrKZwdEZawSR0JMbBbZoDlnRFgVn2hxnT194rRN4nP8nE RzEQyj6R AIdckOm/Efld3dkrmfcWfGY1S/wljExeA1yRHv2o0iunNFk/gF0p/VfqmUZ9LpU7NkG8y0SdjDIlc+tUtM6jsL182Jq9SnAkWIg970V4DAFcpZiPYmSwxDcDflCKts24H7Un+h5qsDCCt1mMaTns0voqnfTMQhI2ABPxyO6KrRfOhJoiv5EZ0WIhv6m5t3u8OC6kcLpFBDALbOqtXUDQoMzxb2KnCeKCbuB/TU+gsx6DHnatJYHIPAVqvuk2sNV1ikJ2jgLNQir6H58Szbbx1AggSv1nv77M5qgzdRUG+b6tSyOD6/yqAbU2rjVyBnXhF5zIcf5mDULY+/Aq3D0uU7GcQEleVFL78zDuFGy8NxXHXNMD08onuaFAAC5Xu+/80/hTYWqYQOlYzmijh7P/YwxnKIn03/v7VTuC+MgXGGDWEyAQAhW8oErYaxc7p3juFmBx/VqAUdibps58eTYwYszvGug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Include allocations in show_mem reports. Signed-off-by: Kent Overstreet Signed-off-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka --- include/linux/alloc_tag.h | 7 +++++++ include/linux/codetag.h | 1 + lib/alloc_tag.c | 38 ++++++++++++++++++++++++++++++++++++++ lib/codetag.c | 5 +++++ mm/show_mem.c | 26 ++++++++++++++++++++++++++ 5 files changed, 77 insertions(+) diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h index cf69e037f645..aefe3c81a1e3 100644 --- a/include/linux/alloc_tag.h +++ b/include/linux/alloc_tag.h @@ -30,6 +30,13 @@ struct alloc_tag { #ifdef CONFIG_MEM_ALLOC_PROFILING +struct codetag_bytes { + struct codetag *ct; + s64 bytes; +}; + +size_t alloc_tag_top_users(struct codetag_bytes *tags, size_t count, bool can_sleep); + static inline struct alloc_tag *ct_to_alloc_tag(struct codetag *ct) { return container_of(ct, struct alloc_tag, ct); diff --git a/include/linux/codetag.h b/include/linux/codetag.h index bfd0ba5c4185..c2a579ccd455 100644 --- a/include/linux/codetag.h +++ b/include/linux/codetag.h @@ -61,6 +61,7 @@ struct codetag_iterator { } void codetag_lock_module_list(struct codetag_type *cttype, bool lock); +bool codetag_trylock_module_list(struct codetag_type *cttype); struct codetag_iterator codetag_get_ct_iter(struct codetag_type *cttype); struct codetag *codetag_next_ct(struct codetag_iterator *iter); diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index 617c2fbb6673..e24830c44783 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -86,6 +86,44 @@ static const struct seq_operations allocinfo_seq_op = { .show = allocinfo_show, }; +size_t alloc_tag_top_users(struct codetag_bytes *tags, size_t count, bool can_sleep) +{ + struct codetag_iterator iter; + struct codetag *ct; + struct codetag_bytes n; + unsigned int i, nr = 0; + + if (can_sleep) + codetag_lock_module_list(alloc_tag_cttype, true); + else if (!codetag_trylock_module_list(alloc_tag_cttype)) + return 0; + + iter = codetag_get_ct_iter(alloc_tag_cttype); + while ((ct = codetag_next_ct(&iter))) { + struct alloc_tag_counters counter = alloc_tag_read(ct_to_alloc_tag(ct)); + + n.ct = ct; + n.bytes = counter.bytes; + + for (i = 0; i < nr; i++) + if (n.bytes > tags[i].bytes) + break; + + if (i < count) { + nr -= nr == count; + memmove(&tags[i + 1], + &tags[i], + sizeof(tags[0]) * (nr - i)); + nr++; + tags[i] = n; + } + } + + codetag_lock_module_list(alloc_tag_cttype, false); + + return nr; +} + static void __init procfs_init(void) { proc_create_seq("allocinfo", 0444, NULL, &allocinfo_seq_op); diff --git a/lib/codetag.c b/lib/codetag.c index 408062f722ce..5ace625f2328 100644 --- a/lib/codetag.c +++ b/lib/codetag.c @@ -36,6 +36,11 @@ void codetag_lock_module_list(struct codetag_type *cttype, bool lock) up_read(&cttype->mod_lock); } +bool codetag_trylock_module_list(struct codetag_type *cttype) +{ + return down_read_trylock(&cttype->mod_lock) != 0; +} + struct codetag_iterator codetag_get_ct_iter(struct codetag_type *cttype) { struct codetag_iterator iter = { diff --git a/mm/show_mem.c b/mm/show_mem.c index 8dcfafbd283c..bdb439551eef 100644 --- a/mm/show_mem.c +++ b/mm/show_mem.c @@ -423,4 +423,30 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx) #ifdef CONFIG_MEMORY_FAILURE printk("%lu pages hwpoisoned\n", atomic_long_read(&num_poisoned_pages)); #endif +#ifdef CONFIG_MEM_ALLOC_PROFILING + { + struct codetag_bytes tags[10]; + size_t i, nr; + + nr = alloc_tag_top_users(tags, ARRAY_SIZE(tags), false); + if (nr) { + pr_notice("Memory allocations:\n"); + for (i = 0; i < nr; i++) { + struct codetag *ct = tags[i].ct; + struct alloc_tag *tag = ct_to_alloc_tag(ct); + struct alloc_tag_counters counter = alloc_tag_read(tag); + + /* Same as alloc_tag_to_text() but w/o intermediate buffer */ + if (ct->modname) + pr_notice("%12lli %8llu %s:%u [%s] func:%s\n", + counter.bytes, counter.calls, ct->filename, + ct->lineno, ct->modname, ct->function); + else + pr_notice("%12lli %8llu %s:%u func:%s\n", + counter.bytes, counter.calls, ct->filename, + ct->lineno, ct->function); + } + } + } +#endif }