From patchwork Wed Mar 6 18:24:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13584445 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2925C5475B for ; Wed, 6 Mar 2024 18:26:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18B8A6B00C6; Wed, 6 Mar 2024 13:26:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13A836B00C8; Wed, 6 Mar 2024 13:26:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA6966B00C7; Wed, 6 Mar 2024 13:26:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D76DA6B00C5 for ; Wed, 6 Mar 2024 13:26:02 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AB313A0661 for ; Wed, 6 Mar 2024 18:26:02 +0000 (UTC) X-FDA: 81867443364.06.46F13C7 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf19.hostedemail.com (Postfix) with ESMTP id D78461A0021 for ; Wed, 6 Mar 2024 18:26:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=odrBIkVb; spf=pass (imf19.hostedemail.com: domain of 3N7XoZQYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3N7XoZQYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709749560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j6JoLMysN5flVa9c5yM3pdaz8HR3taJXen1pd2wjpNc=; b=Hb/meiCVxQ/8blLB7QuIDbXuttAbwrVPo5DNkQFY7EtpVKU2eKmSnpC0oTRWahIHw90j14 CGmZp677Nuc4PQrUNq2TlNzcca/XIixKdNRPsXiJcuOQVyZQ/eehi6wQpiE9BoZkW2jmZb Vt2Qn+n7AZElJn9Idd46WdPOCuRmG74= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709749560; a=rsa-sha256; cv=none; b=W6kXalqItvg84ogHFXloEW2KIwpZscpj9HHw63M2f2urKJohZo/MR9kx/NuDOy6EnwyYqd FZbKZ3nE93WzCS/e7vOUpbDh/VPVxfSGJKLoYu/AcmwahDvRVwZDG631pzGXrGs4A+I2xd 2iFeetumCqqJZ9c3OwSoSW8pAM9c/no= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=odrBIkVb; spf=pass (imf19.hostedemail.com: domain of 3N7XoZQYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3N7XoZQYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-60802b0afd2so844927b3.1 for ; Wed, 06 Mar 2024 10:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709749560; x=1710354360; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=j6JoLMysN5flVa9c5yM3pdaz8HR3taJXen1pd2wjpNc=; b=odrBIkVbHG2CUAdfektW16tuyF98w/bxYYTkgvkHfsyAeFndbSl9gMjgrHtXuWDjiu CzjbHSJY5uzTtuDOD2Rww8MSOiQHCBPppWiD+vCvJr+QZlp2yBahakhfqO10/KaU3IuS swJqqZSDJm/TByQaAF7XFJxdPgQIfrfgnVTSe6jdZ0w5epoeWrsbG9Dc3ZbaCM4qEIH8 n4vgD4Uqctoagn+UscPnBfKEyeuLBLKWQNdekSa9VlK0J4+JNhU6lv5m4xFex+ZoYagq spK1/Yx0srPMzG2HQtuovVgkJlQhrKUHw8cEH13NgEm4U62woJfCdvBG8Gba7r1Wg9Hz caOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709749560; x=1710354360; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j6JoLMysN5flVa9c5yM3pdaz8HR3taJXen1pd2wjpNc=; b=lNbMX+MekBIGeteOe2Ap9fCsORNvV4J+X1at26V/GG2UCMX5ch30djyr3uoxPzy1Yg VbhDhYU/s6IAbSPBx8DrLBSSuPflCDnX0Rw9+m9KqTmKQaci3d7YnQSRh4S/JTi5wWyk +CwOs16HwarnqtUSfXjwvIr9NtvSklqvufdHn2EeqmKJlUwZfwUtk/7WRNj7rexebq+V jRjrUvpRgpV/fLzEXKD+09bGAQJ9FWC9pu587Ddp/LjphbPYGRqz3bj4jdcKxcgZaX7W cmWXpKncJWxId1iIltfc4dl9qtAIO9dM5Etadr0TkJimiURpkWG2Pg5MX3+b9dEd4kkK B65A== X-Forwarded-Encrypted: i=1; AJvYcCVK0DVJue15b54Np0dhg7s/lp62TyTPP0N480G9DHFyGm+vFR77NvDVCu3ra/yIvuU1XpZyn0vcsjGPxtp0tvf0y3g= X-Gm-Message-State: AOJu0Yzsu1qJDT9TVZgke9xMwIgXnvu2EBD5FP5xp1vfE3xHf5qwXHZ/ pI0EWERlB6RSZyeIkmyscshWzGHwLtAdw5ouwxd0OahhLzPEHCP6wb5XM6dWJg3XXFdcvBVQv3O GMA== X-Google-Smtp-Source: AGHT+IFJf4+3zsOtaYj4w4sYtLT+urJK6k/XCbV3fma9m2tOepAucRt++i9xMDbmvInEP4W6X3kckDvXGNU= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:85f0:e3db:db05:85e2]) (user=surenb job=sendgmr) by 2002:a81:ae60:0:b0:609:3c49:d77a with SMTP id g32-20020a81ae60000000b006093c49d77amr1209593ywk.5.1709749559768; Wed, 06 Mar 2024 10:25:59 -0800 (PST) Date: Wed, 6 Mar 2024 10:24:33 -0800 In-Reply-To: <20240306182440.2003814-1-surenb@google.com> Mime-Version: 1.0 References: <20240306182440.2003814-1-surenb@google.com> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog Message-ID: <20240306182440.2003814-36-surenb@google.com> Subject: [PATCH v5 35/37] codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, surenb@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org X-Rspamd-Queue-Id: D78461A0021 X-Rspam-User: X-Stat-Signature: to1418ohd1uhisfxnuj6npypf7daqn4g X-Rspamd-Server: rspam03 X-HE-Tag: 1709749560-878486 X-HE-Meta: U2FsdGVkX1+pXMALYEMN5gZnY8sj1nXkEartCuyQtP44egnnglkJLk2MQ9bhjQW70StenEwRjFts7GBp9ZCkI1n7mZ1E+9B3A13sWXSbw7BOc/8BCYfZVnsEWIt/sLDnbNYyVS11d//CPeQpAslagEc4/9rdmp9OzHa+tqXKgr2uwpHgiDTAinV2+sQUTP9te4PiiRn77ccW/TIJZp+pimos+QFE9oiqwSVaZXB9FoLvtyJ+OVjL7/79rL3icg1+76fSMIEcUNVtLJb5CjpIdWqop8R5WATHmOwDcYABNZVegIxpCY8CmsK8KpalGngC/Rtex4ZHlVOiaS335ke0zFIZjoVq7lG8QILYAXVQdgGVkvQY2gTCUZL440pDnOhGgW9HRxMPZ8AT39+02RHdUgYpsP8u5oItaDJ4HJXXgCTDI27feXi+gonpCJbML6djCDyI0kS10uGUdoaX58j9S197Cy4b5lwG2LBL0FfByj9+RVRZY6VUcMReaJwYGiqexPUM9EfFhNNVhc63sbEPwtOPK6Y4mRsqePr39++0wpA4M45xIuAycgSiRtDbg+Chf3qt4QCBohZeXs1k8dJ2QebJSSIqBcQiaoBGmgo9stF3u6h5FoMugWEFVwrJ75nCfWAOSlLpDVTF+x2IqtrXG2x+jONa8XK+I7HacmRTTIQmTL/LGDznyUfQB/QeVh2eWWjmUkczaHNNAIHFBQhENYZO9Dc8s5gtDt3eEJE5Ww7eXCiaDcD8yRDDCvgLKyzM2MdGtLpl/peBikQD4PkWJaRSvY8W0J7P02QSDNTECuGwGLW+gr0AS1UN/kZS9C5KKg3pFZfeQ0xNtnCBkOl3ScDC7fNFvJikE2yGv0weRaBz5SJb2hL7WCKoexYmYlcMQwA9/9CJQEOibTTY0YhjpvQACNnnH/QjoYU0RUxOPFb5BexYsoAgZYAZmmPCVNOEyekxCviK4MFVgXNGa0l NKrOKVHq pz4DdJ83agHRtHjCMfPYm2Cl9lJkL9VdaeVG8cQvQJbbRYp3IBYo9FRttv8ls0O6xNYTAmUs56bXfa+LSzRVGtHanI8R17SbFdHqQgihlDarfCQAquewjedlr4p2rTObwIaMAtue9y88/xCMLe/FtpXAdBJ/AyIoXOpdULJ4wPy8Q+DLsTBzbBLL5L5H7mBSlk73AW/TlhvYR19PtfrZWbO0l4u28HaX0FKWcKqfx6dE3LYJnbniIgShJ4rIBktbuKfiepWjvWc5OgHvAM/niirGdWQvSmZ/ZTcuG5nempn03oG3wN8QAWMEKfi5a7O92vgKIVouSCyJqbGhCu2I4np/kjjI4//D1TLUuU4j/bgULgL93qWNIDgtTg2ZbeIbf/tc8e6TXrtWaVggSvX9wMoQnM1rA6d19x+BB/ACynE5caAAgR1wv+hiJ72WzgxpsQUPh8UR4sN6PisjD7ivebF00lFUmhPKMtdQJnhin0Rtv1PSnL7KirairYV6NWVKrwO1t+WPkin4LfoW7VZDF//++YxpKkEiMetC3yXETH6ovr+QYlW+xpCU7Ahtz7UGb1hK5PZ2MnyRQPOa83OPqPapFIApF6TbKrNr9/41jzVt18EE8P+Kff8A/00fVSPuRNQ09HMHAG3o9U1PO+4/M92ubQTwGGd00CBedzuwE9wwmyxGLkLDeckqbczXp8CHrQyhrArPZGRM2ukl5Quc7q3fjiyOADCB+WL13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If slabobj_ext vector allocation for a slab object fails and later on it succeeds for another object in the same slab, the slabobj_ext for the original object will be NULL and will be flagged in case when CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled. Mark failed slabobj_ext vector allocations using a new objext_flags flag stored in the lower bits of slab->obj_exts. When new allocation succeeds it marks all tag references in the same slabobj_ext vector as empty to avoid warnings implemented by CONFIG_MEM_ALLOC_PROFILING_DEBUG checks. Signed-off-by: Suren Baghdasaryan --- include/linux/memcontrol.h | 4 +++- mm/slub.c | 46 ++++++++++++++++++++++++++++++++------ 2 files changed, 42 insertions(+), 8 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 33cdb995751e..3dfb69f97c67 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -366,8 +366,10 @@ enum page_memcg_data_flags { #endif /* CONFIG_MEMCG */ enum objext_flags { + /* slabobj_ext vector failed to allocate */ + OBJEXTS_ALLOC_FAIL = __FIRST_OBJEXT_FLAG, /* the next bit after the last actual flag */ - __NR_OBJEXTS_FLAGS = __FIRST_OBJEXT_FLAG, + __NR_OBJEXTS_FLAGS = (__FIRST_OBJEXT_FLAG << 1), }; #define OBJEXTS_FLAGS_MASK (__NR_OBJEXTS_FLAGS - 1) diff --git a/mm/slub.c b/mm/slub.c index 4a396e1315ae..d85fbf9019fa 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1901,9 +1901,33 @@ static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) } } +static inline void mark_failed_objexts_alloc(struct slab *slab) +{ + slab->obj_exts = OBJEXTS_ALLOC_FAIL; +} + +static inline void handle_failed_objexts_alloc(unsigned long obj_exts, + struct slabobj_ext *vec, unsigned int objects) +{ + /* + * If vector previously failed to allocate then we have live + * objects with no tag reference. Mark all references in this + * vector as empty to avoid warnings later on. + */ + if (obj_exts & OBJEXTS_ALLOC_FAIL) { + unsigned int i; + + for (i = 0; i < objects; i++) + set_codetag_empty(&vec[i].ref); + } +} + #else /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) {} +static inline void mark_failed_objexts_alloc(struct slab *slab) {} +static inline void handle_failed_objexts_alloc(unsigned long obj_exts, + struct slabobj_ext *vec, unsigned int objects) {} #endif /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ @@ -1919,29 +1943,37 @@ static int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, gfp_t gfp, bool new_slab) { unsigned int objects = objs_per_slab(s, slab); - unsigned long obj_exts; - void *vec; + unsigned long new_exts; + unsigned long old_exts; + struct slabobj_ext *vec; gfp &= ~OBJCGS_CLEAR_MASK; /* Prevent recursive extension vector allocation */ gfp |= __GFP_NO_OBJ_EXT; vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, slab_nid(slab)); - if (!vec) + if (!vec) { + /* Mark vectors which failed to allocate */ + if (new_slab) + mark_failed_objexts_alloc(slab); + return -ENOMEM; + } - obj_exts = (unsigned long)vec; + new_exts = (unsigned long)vec; #ifdef CONFIG_MEMCG - obj_exts |= MEMCG_DATA_OBJEXTS; + new_exts |= MEMCG_DATA_OBJEXTS; #endif + old_exts = slab->obj_exts; + handle_failed_objexts_alloc(old_exts, vec, objects); if (new_slab) { /* * If the slab is brand new and nobody can yet access its * obj_exts, no synchronization is required and obj_exts can * be simply assigned. */ - slab->obj_exts = obj_exts; - } else if (cmpxchg(&slab->obj_exts, 0, obj_exts)) { + slab->obj_exts = new_exts; + } else if (cmpxchg(&slab->obj_exts, old_exts, new_exts) != old_exts) { /* * If the slab is already in use, somebody can allocate and * assign slabobj_exts in parallel. In this case the existing