From patchwork Mon Mar 11 15:00:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13588931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891C8C54E58 for ; Mon, 11 Mar 2024 15:01:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7F566B00AC; Mon, 11 Mar 2024 11:01:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2ADD6B00AD; Mon, 11 Mar 2024 11:01:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCBB06B00AE; Mon, 11 Mar 2024 11:01:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AB0466B00AC for ; Mon, 11 Mar 2024 11:01:26 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 457C2120E4D for ; Mon, 11 Mar 2024 15:01:26 +0000 (UTC) X-FDA: 81885071772.23.D21BCAC Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id B2A4A40036 for ; Mon, 11 Mar 2024 15:01:22 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710169282; a=rsa-sha256; cv=none; b=iH4mzT/gDpFcka8SQbf9J04s2qI+8BQZa0l42/hnk7pMoguEs4b3CA1EZVO61wEPiztmlV 52DwqZFrXndcu9eW45rk9TSnearkqumcwwhYGepUdO6zIVIBiAgDs+ntd0hOwNWxPO2J3L p1lGkjkPw6HiD3Lm225FaKZ7kcgmz+c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710169282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hTYYDb/sq70D+WjhRYsih11v6WpSGH7mt+chjXPp+AI=; b=mf0If9ZNWikfyQ9M8hRy6cTC+JxMVo/udE9dRC8htWTFf7Pxkc0iM5cxYk/mxLPlLKOoiG rAbzPQgOM42jd0asB8HJVpSoTWDcbwAPfmyea5H4FFgGx0Jy2YJPdcASK+vlhwVttKRN5b 7PkYSfU0yo8B+GgqCfJS3Gymj42LXzI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B4CFEFEC; Mon, 11 Mar 2024 08:01:58 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CCDCB3F64C; Mon, 11 Mar 2024 08:01:19 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , David Hildenbrand , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li Cc: Ryan Roberts , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/6] mm: vmscan: Avoid split during shrink_folio_list() Date: Mon, 11 Mar 2024 15:00:57 +0000 Message-Id: <20240311150058.1122862-6-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240311150058.1122862-1-ryan.roberts@arm.com> References: <20240311150058.1122862-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B2A4A40036 X-Stat-Signature: xy88s9tz6q8tn91kk7454gei8tb1jwax X-HE-Tag: 1710169282-477617 X-HE-Meta: U2FsdGVkX1/In8/HkygQWpJYO46cjmLEOrqO8OJG7GsEAtja4vf81pPHG88rX+Qkwtvo1Khc9fsNVZ362/k+LyfdSKtrdgM36ti5Rytt4HKZnGWNXFsuvBl31bB7A+4ZKIrzpwhk9XTSO/slhy/ewslUuXpmji/zu3M/0//dSUhrsRGkjJQ0TsMO+hCAy9ITCeDy23425OdIFRdWsWV8IcdBqJj/A7IGYX4vDJhawADI1CIh9qyMDn2KL6qSMET3CHyBzp51aw0q1accQ+5+1UPMxD5z3iGaxt85W8iTXpRx+YlRuuyMAzBxbGY/l00jJJmv1y21oxR2hAMZC3suXd8mzjUvMd5iaPTG0EOejEpeXeBJC8wPavMwfcMAGfrd8qqfhNAh5zI1IyL7Pmz6sPnrJqSla/t99aM0dbAs/Q2nBjiBYz6ZVr/eJQqWOFSMs974Gy2uEi2bWc85KzwMTBFaJz/rbe9dNmN9bWcP6CxD303rU+gPZA9rHl7C28u0OfK+EDcX/1y9wN9EEGEz3t/RCwIe3iyGOBDPMX+lUA/yKm196+/U4GVzIYPvHy7OuL/QTkmy5H1jYaZCsqG6LtWdekMDEgplSDgEEEBSoyQdXek1ErrKPuN0JEwf39p1TqLX2/XseuQWUWQtfpUBxsy4akfoJ/zZNHOWYF/eTVd7x2JY2HF4IcbdJSghV8ufQHIOIQ7XSqGjmkMUYnfUEpDA+f1VtDB6zzOToct0DJJk7Mov30HpQutyWJ2mtVZaAGHRFX39almjmg7MVH4SursDW2sQ7V+mkxdXS17lGYKu84HCpWRHcFOVIKjNEze3tP0j3qiBQJRiYFOmW2GcxzqH33x3mZ9qheSUDRRDlgutET5huV/WdGfzoNir8naOYprHUy42OdYEFrm4eB330weJkimJZOMnYALanKNtmGLzav4jk8syKOJprZcFZM5hgfK6pwWKSUryO50/FYN ECq6VcvK 7ISUQU0Dhgon/I9FyGO+zUyRKSQjzflHIEuWCamL9gN5OlLqYZtzbgoMtEIxUfa6kp876/HDYpZklJ4e+2kSNRq6nLUZBNCQWvpQZkGPlz8I/HLhgncMuQEyeczDaYA+axKRlSbwZkpW7pGOO/HE1BVd8p6pVPLayf/BMQpdplkcVAvxChwCxIB6NcL6yt5eblFbJRvW/w0na3FI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that swap supports storing all mTHP sizes, avoid splitting large folios before swap-out. This benefits performance of the swap-out path by eliding split_folio_to_list(), which is expensive, and also sets us up for swapping in large folios in a future series. If the folio is partially mapped, we continue to split it since we want to avoid the extra IO overhead and storage of writing out pages uneccessarily. Signed-off-by: Ryan Roberts Reviewed-by: Barry Song Reviewed-by: David Hildenbrand --- mm/vmscan.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index cf7d4cf47f1a..0ebec99e04c6 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1222,11 +1222,12 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, if (!can_split_folio(folio, NULL)) goto activate_locked; /* - * Split folios without a PMD map right - * away. Chances are some or all of the - * tail pages can be freed without IO. + * Split partially mapped folios map + * right away. Chances are some or all + * of the tail pages can be freed + * without IO. */ - if (!folio_entire_mapcount(folio) && + if (!list_empty(&folio->_deferred_list) && split_folio_to_list(folio, folio_list)) goto activate_locked;