From patchwork Tue Mar 26 06:11:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13603609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D33BC54E58 for ; Tue, 26 Mar 2024 06:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCBAF6B0092; Tue, 26 Mar 2024 02:12:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBA776B0095; Tue, 26 Mar 2024 02:12:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A58426B0096; Tue, 26 Mar 2024 02:12:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8FECA6B0092 for ; Tue, 26 Mar 2024 02:12:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2EFE74091B for ; Tue, 26 Mar 2024 06:12:04 +0000 (UTC) X-FDA: 81938169768.06.8F3F5E4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 56237140010 for ; Tue, 26 Mar 2024 06:12:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZVwbHbon; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711433522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=26pF07psouxIQGL4z587QBIfGHVQZVYNO+cDKaqMYbM=; b=BH4L7+Lvh1pLPQrnbpclw0nSta9+lL7XM2+oUUEjyw51GCapJJQM4HWrxlTXFZqxMekQfV hcZ8/zKbZaMBFSie+SvxW6d5QF3H/G8Jfd5ASnCtppwWwcqKb2zOP0LvthsFknAo4AGjfn iDczoMtvW60c1sBkTg01TdS84vdS7wc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZVwbHbon; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711433522; a=rsa-sha256; cv=none; b=JAka51FZajsYIhyxWhve8Z5eZsKoHhOQrRZyrvvhGQPF8hmtccZQZnXc+FVcvxJKtF5Am0 iBb7SIllB2IEVyN5QW/mBqTQrLyN/qYvDg7buONiITjmYABJKPWFvrzQSC2KSSbvL1wpnR UAo+gYtMueczUpDbOIzZjbNJcF9cOpA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711433521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=26pF07psouxIQGL4z587QBIfGHVQZVYNO+cDKaqMYbM=; b=ZVwbHbonWcJHPu7vpmD6J0Wvou9NmS5hz4Wx7OYD4E8W9ErkUdPl3Y//ckGaJ8plroQIpG FPkI6DFlOqvJ1OKefwBBjITMihS8M2mJD6XnhZVK4ltQ7BRegIaQcPXdt3Ro7eGcnqQrCA ChjGc77YsSFyHCPD/7FKEPWpWZn/0Bg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458--n3bVuZBMXeJhzzcqYgiEg-1; Tue, 26 Mar 2024 02:11:57 -0400 X-MC-Unique: -n3bVuZBMXeJhzzcqYgiEg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E671A800262; Tue, 26 Mar 2024 06:11:56 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (unknown [10.72.116.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3C9710E4F; Tue, 26 Mar 2024 06:11:54 +0000 (UTC) From: Baoquan He To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, rppt@kernel.org, mgorman@suse.de, Baoquan He Subject: [PATCH 5/7] mm/mm_init.c: remove the outdated code comment above deferred_grow_zone() Date: Tue, 26 Mar 2024 14:11:31 +0800 Message-ID: <20240326061134.1055295-6-bhe@redhat.com> In-Reply-To: <20240326061134.1055295-1-bhe@redhat.com> References: <20240326061134.1055295-1-bhe@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-type: text/plain X-Rspamd-Queue-Id: 56237140010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: a66w3k1yztd31gikcksd6o51d834c8z3 X-HE-Tag: 1711433522-649584 X-HE-Meta: U2FsdGVkX1/yNAbauXTc2+b1FGxJJEWXJ5fW9TVV5izHfn3fOZsPOhT4Ot78JQiYfg7za9W6UUE8Q4Vy7azR0X3+9Rd+yDKKyyibsiF25hv8XRICmcBPkbhPHakJy0agXJg4wd9S8VsweBSb4tppNmYDi8Ad4sxC5JJurPldIHtsK1QCArgxnP0p82JcDaQ6zWLkIzfgL7gOy1WhW5B0o+WpINJJgZEy7GkDpPZoNU3UcaFK3flJF+ls9DSSXgDcniWvjG3ebM0XHyKZBg1RmK8vRJ0c6qhv4BsotxevXVoS/p7FVz0SHm42kDC0LhRo3+y0RwhnXPaMomw9DYnPWD/RH5+Vh/FFc1FCxX7P4mWyT9qsIbguN5lfFcJ2DxxleR5Z826VWbvrD+MH44Eiz2R43w8Knc1+rw3tsXi8tKbKX5PP2Ki7/Tkbmwi6Yvpjy4Vf4OPTrBimmPQYq54L1vgWNNnc54bSqOZD0TG3immG1FMg1FmeLwu0pFswkem2Bs8lcfsY+/9SqUFe7wzNQGA/blfuHyvjNTFbzul2K3jpQ09z2vwIWq9PiY/pWcGmVEub6qGM3edYBmGNkfiFGfb/8Flr1HM6fgfL/dFQh5nL25q8XI3GiLwwdw88h1w+iDujxbnooDXT9WZFJ1Usjrv1uDjiYt1SAJqwpWpCRpxMxbVkkczHpB63cPM2x5znelf7fX0Y+wz9e3LLyGozta2nUZWZfBD8a/fC4s06L0w48RHzb2LqAni8mGJ+JL6JAWVolIq0Oxsc4zz+YQPuejpDVAjCfWmdW3WmJ5AV3HRcr7xlHe8IqNQ9sY4leNePHt8p/bOZusr8f4ygA4TkUCX+ZHyynUv4ti43Omrul4GrHENO7vMpB76nJmBgMdcQFwH5RAKPhYwOk+tYmOxSfPZ8uNXC+JQfiRoLo6mqmtp6s6YsfItf+q2GYXrrZzugZtrmgIfstKZ/I8k3uRb x+08GmG7 smIBr0J7YOPAR9ULANvGYaN1/1VZZf7Ud1rVeAYKwiOPTt+Uq4h6D7fi65G8LF9tH2DuZ47GBmSHfhu/ojFNGZ9ElbFXzTFpGtvhiJWA6RN6T0o4OVU7SzEHhQWosSss/MrfFlwBhhBXelo4sDuM6it0CBl0ftQdMRs3kYgJluBd+HfWlf7p7om5gAzle6iKJbEGhV7XkmW2XlIbaDntHS0V7lQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The noinline attribute has been taken off in commit 9420f89db2dd ("mm: move most of core MM initialization to mm/mm_init.c"). So remove the unneeded code comment above deferred_grow_zone(). And also remove the unneeded bracket in deferred_init_pages(). Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport (IBM) --- mm/mm_init.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index cbdb49cdd2ce..cc24e7958c0c 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2006,7 +2006,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone, __init_single_page(page, pfn, zid, nid); nr_pages++; } - return (nr_pages); + return nr_pages; } /* @@ -2208,10 +2208,6 @@ static int __init deferred_init_memmap(void *data) * Return true when zone was grown, otherwise return false. We return true even * when we grow less than requested, to let the caller decide if there are * enough pages to satisfy the allocation. - * - * Note: We use noinline because this function is needed only during boot, and - * it is called from a __ref function _deferred_grow_zone. This way we are - * making sure that it is not inlined into permanent text section. */ bool __init deferred_grow_zone(struct zone *zone, unsigned int order) {