From patchwork Wed Mar 27 13:05:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13606612 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD01CC54E67 for ; Wed, 27 Mar 2024 13:06:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E28F6B0089; Wed, 27 Mar 2024 09:06:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3932D6B008A; Wed, 27 Mar 2024 09:06:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25AEA6B0092; Wed, 27 Mar 2024 09:06:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0825B6B0089 for ; Wed, 27 Mar 2024 09:06:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 582561C02AA for ; Wed, 27 Mar 2024 13:06:09 +0000 (UTC) X-FDA: 81942842058.18.3D7CE74 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 264FFC001C for ; Wed, 27 Mar 2024 13:06:06 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VvTLv1yh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711544767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gSD1jJkroCyXm61fF+oNruRo3coWmssTF4skwAil3Lw=; b=BAY2jLiX+KLck+MJxM0uMDLMTeJU1OMooPcgRR2sYm3yEarKWNNEEzDJCWhVowVlq6dVgf BVYJECSRXQaib+eKlm+zpodAIqVpkleqZYVz3bNLzxYAvUPmUTtxPKItM6e3sXOCH92OPn LdC2kYeHtDwkATBitX59fBe1zn7POjQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VvTLv1yh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711544767; a=rsa-sha256; cv=none; b=HHtualTVSTIb9zErhJvaiwLY9LqTtJM1uscXAtRKaRkkylg8dI4asC8AbVbwhvTNnsZZmz CRcrZRfuP/Dn3VOq0F1VoblcgGBnTjvNjUPNF6fldDsmWYmMaEaBWRxt6dndKT/ZCDhAPB BQgRoP40XQ2MX32z0+zW8/QlbDiqETA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711544766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gSD1jJkroCyXm61fF+oNruRo3coWmssTF4skwAil3Lw=; b=VvTLv1yh7dmp2mLc09x+Jnt/bGSBu6ajNsroUd66opLw6ZFNRT2oft9QObmuCs3WlnmLzR hBnBr8WNAT+0h1y7KEVW+269yKkmDKDOEfIHluYezihBNSQJ6eSJ6bQ4FNOv1zKCWgjgQ4 Par+Mw6jIhXvAn2TwemHj37elrn025o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-n4vWnbRDMPWu0T-sgcsqLg-1; Wed, 27 Mar 2024 09:06:00 -0400 X-MC-Unique: n4vWnbRDMPWu0T-sgcsqLg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 82920800265; Wed, 27 Mar 2024 13:05:59 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.193.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 203CF1C060D0; Wed, 27 Mar 2024 13:05:55 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Andrew Morton , Mike Rapoport , Jason Gunthorpe , John Hubbard , Peter Xu , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org Subject: [PATCH RFC 3/3] mm: use "GUP-fast" instead "fast GUP" in remaining comments Date: Wed, 27 Mar 2024 14:05:38 +0100 Message-ID: <20240327130538.680256-4-david@redhat.com> In-Reply-To: <20240327130538.680256-1-david@redhat.com> References: <20240327130538.680256-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Rspamd-Queue-Id: 264FFC001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ymufxq1otqfres4uyau9ot5faeyy8x67 X-HE-Tag: 1711544766-330495 X-HE-Meta: U2FsdGVkX1+4JJXXNVDzfx4i1cN4jkosik+wh36j7SpON3Y6h06Eq/fuP3VudrPNtsKQh3WA3v4M1XMwKLSpjeiWYPRQbt+NqpnLbPoiXHXUeWtpoMGPaUoeAR5eI9wcSevJ9nEfkT3h4yjo+Be+H2zWwbo37FZ6Hm8C8ZsKED/0zrAXjkwCjqVaLEaWwNa72id1yo3S1jA39nuojAKUe/wxKh3yB2wSjXBYkkWRQadq8YFvh3EI1bi0y76JY8WHrSHOqsJo3sL0JG+ox6i9prGyu1LK9jkUyVK49X7+rv2977yJYf6RTjaLgtcwIbDpcmJE09iHuRA8vI1u3IHKT4eKrPMxV108nkQ6nqWu15MTS+mNMmAF1ylYwR8T4WdRAOXKkVOFckbc5oe/1pTf5S9xevb3i9MB0U5YqYeiFe0vKQz4UNdHJ119GLbccpupbmci0ukG2sTgppICSugQjDfRs8flQpqcjWXQ0KnwphrgtZN/c4pOYRhM86re+9iclrAAm8HLv/UfvTS/oPkcDrEN9tvdq44M7Z04t9pCytHwh/LONL8ELcbMIxkPa8ov0Tn+JchMudVHQmkSOXq/oG9XuET0eYhmz4aN/b9qygIvZl6bON4k1vRaOmKYysTsGZEIG+3eLfRujyc24b/ezlm835ScUnwcFkdhh29hS31uoDkCXjba6BwVCe8g3Lh0JSH6WEx3VualVrHtkaFAJv78wxjJk073viRk3HlQBdRRngVHRzx5cw00rklCfBdgL9B9Vn+//+CKsMjwTgFvEmKavk/SDE57BkBxChenVGHDVzcAzxwuhbsAxs0cFBZ9d0pN0PD7D9VF8ces5xAoAjexYC0q/NPVoslgB5jshjgHRD77p7uv0tbIezWQqug/mUUva/EP73fVmbsyhPB4KthoT2kUHdqn1Ul9Op8CNbxQt4qBqG2+2vCw250S1rkEWSa6p9MojImIKkgoWI4 WQxc8mXh 3GjwKn2VrC8lN5wbeda1qRv5yXqWHkY+deexMbpqz8o+6JB0H6AIes9FYbM5JFtAMJWK3zZFNfbwHbV3YtlyBZ/7MbH1o1wdDp0Cl1UmSoPj6LR42KtdRaQud+MSy6aRFzKiG9cW7J3HNCaAaujZW1ZJE+sCB7ttFC/JBHO8Y9EXCZO/BZrz03kOGWEoT5iIfY2Uujt1CaGX+f8EShrtPn+r2Ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's fixup the remaining comments to consistently call that thing "GUP-fast". With this change, we consistently call it "GUP-fast". Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) --- mm/filemap.c | 2 +- mm/khugepaged.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 387b394754fa..c668e11cd6ef 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1810,7 +1810,7 @@ EXPORT_SYMBOL(page_cache_prev_miss); * C. Return the page to the page allocator * * This means that any page may have its reference count temporarily - * increased by a speculative page cache (or fast GUP) lookup as it can + * increased by a speculative page cache (or GUP-fast) lookup as it can * be allocated by another user before the RCU grace period expires. * Because the refcount temporarily acquired here may end up being the * last refcount on the page, any page allocation must be freeable by diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 38830174608f..6972fa05132e 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1169,7 +1169,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, * huge and small TLB entries for the same virtual address to * avoid the risk of CPU bugs in that area. * - * Parallel fast GUP is fine since fast GUP will back off when + * Parallel GUP-fast is fine since GUP-fast will back off when * it detects PMD is changed. */ _pmd = pmdp_collapse_flush(vma, address, pmd);