From patchwork Thu Apr 4 16:36:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13618060 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83EE6CD1292 for ; Thu, 4 Apr 2024 16:37:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17E446B00A2; Thu, 4 Apr 2024 12:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12EBA6B00A3; Thu, 4 Apr 2024 12:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEBCD6B00A4; Thu, 4 Apr 2024 12:37:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C9DCF6B00A2 for ; Thu, 4 Apr 2024 12:37:32 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9D2781402B0 for ; Thu, 4 Apr 2024 16:37:32 +0000 (UTC) X-FDA: 81972405144.02.3CE4D74 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id A8E6BA001B for ; Thu, 4 Apr 2024 16:37:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UGhd8cqG; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712248650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wn9vbDVG4YtRegf5ZBlenhUihh95CLw8Qi8j4juWPxs=; b=TE73UelwLFNroF6qKM5V8GkTj1PxXfh5u+YjJkdICXcoLUgcEmIZnSP5jMldYJQsQ/ndsp zJhwFOqYlB8iClF9+5tW4kfJuBh4AcuGLs+q2nRhlBlJY3N7L1MtStHSjuIAIWu1ocbjnW J72bxQgW/jh1qkI7mTtzyhEyz0JRmrw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UGhd8cqG; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712248650; a=rsa-sha256; cv=none; b=pMcctYyQITRdI6CIP0XNmbd3ZMot66AOVWnDfVhIyKRehsgd15p7KYw+QNV7o4VPjdn5iG xt/iqWw/KPRslRcvIntsmIB9/W002RZNxakUZ15uTaw2HBhwh5gPnxwjbDfI9ZNYrWQvWS swzxR+uL0Sy4OXK80Q1e9JUuzdgG818= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712248650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wn9vbDVG4YtRegf5ZBlenhUihh95CLw8Qi8j4juWPxs=; b=UGhd8cqGvYkjl+9cUHy/iDcIRMaf9+ly1C8qU8LH9Z05MUWB+HI92Frzks38xFjmQvT01j O3KIjnr9w8qV6G7Pae9ieGtlc1SWoBspPXxH+9Xx87h/LzYh5mu61wlCWZ/NrHuX6tH9au 9kDitPKIGgWdTZxNBA/MIqD/fEoUJFE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-546-ZB9ewTULNjmhHBCUXGQC7Q-1; Thu, 04 Apr 2024 12:37:26 -0400 X-MC-Unique: ZB9ewTULNjmhHBCUXGQC7Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D4C688D01A; Thu, 4 Apr 2024 16:37:25 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.192.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1ADD23C54; Thu, 4 Apr 2024 16:37:21 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, David Hildenbrand , Matthew Wilcox , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Janosch Frank , Claudio Imbrenda , Gerald Schaefer , Thomas Huth Subject: [PATCH v1 4/5] s390/uv: update PG_arch_1 comment Date: Thu, 4 Apr 2024 18:36:41 +0200 Message-ID: <20240404163642.1125529-5-david@redhat.com> In-Reply-To: <20240404163642.1125529-1-david@redhat.com> References: <20240404163642.1125529-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Rspamd-Queue-Id: A8E6BA001B X-Rspam-User: X-Stat-Signature: eyodwu4kpgabyxywdgm4tbk43cgq7h6w X-Rspamd-Server: rspam01 X-HE-Tag: 1712248650-646653 X-HE-Meta: U2FsdGVkX19v6Nzw6m7dn6VjSyrKsbweV1eZT29Po6eYR+VQ9A6A1T51hJMjrTJQ7lWqGJU8bvQZ3Qj1DruGRu1J2mbPVT6BNDZImJbzTltGyUMR1lnccrfhKE1wUxNC4tXepYXLDOOeCaTNLWbT9tmm/t7fNH9I5LtIR304wOI3n7BbNEgZmD7pt7MPR33BqmHnMmSf+QN0MT1akrOt5eZvR+4lG2X2DBw2H99hkcHE51eP6LrhJjbaHHfyLEQZYIOOVluh5WhbSho75cZdx1eD17uWVT5/pXat8Jdw5ltjoBKsRljoovN8tG+rwl9Ru4yW1e8e/ojG4DXgt0KYr/ITgVZ63XoGxtd4lusSkTZeBVooFzHyPy8cG9SS6XwgOVi+GhexLmBsHN33feDVjMQ7lnD6cmSoOcopvvCCXBNgaE2fqmOuAyzlC82rzdjKxoRpEhCiOz6SIVD7PfX1c3Oo1kQV0VRPW+Gz8cfdAMkJ0/ZwfrDlvuPZ+oEjqjYtgPFIfw4yOcLp+7VW6ucBXof0K0GCaReyMWaGe+jR7uA9uqQ0/IdXO7WdckgW1gwS2koTt5zOBX6U/dz2jiqoKG+kzQjPzU7yvB/hdNzfaRnoD/GVTG6c0c0e+akIT1cwYL/MY9tCCQCZpJSUNTU/fqapAJxw89Lkx0H9ZxXYU5OmJHABpQjlBV6XY+XkI7CUr0SdcUWRaJPl7BpiFuEPf17I3lrLTf6TeNQ1JnXkgGJhLIxe3mwTqjOCRyoeRyfRGYlOksxVOokYa2TI+OzenxKUfG4j6bHAL5uETYJbHFIZGJXUxtpx3SxmSbLPh2bqLdpqsffo84p3mgeSGJ7xVTymxVJTWnGGd6w+EemQuaZLTqAigPsw5WxixjSSEp+KKonTGemnlhqBzaL8DLdqXIjbWvHX4xbfK1KZovLsYFGc6Jq9UABP8gtluI6ejyJ7fF1PMVuVryWJvXHwhrJ 2Eka2FUM BeskNs7BZoSo4jJeF2WoIYq8IccOFPu9IwRRmSCM1Ae5xWD5PvvP9QtH6hcX2oYJEpTUK7UPcRoAJPpydNNYLdlxMlDOaOgw5/6+28pMPoMDbxwn+LudxPdnQ+t9U6IMtg8/EE2QZHqnQ/mFX4w1+9Od9xSdDoIoTFzQ5F4o/upDR9sGlO2c4ul67kQnNyhxSZHz/c3+9BUcBG+NCYb4JsLCtGCHsGgTroLLH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We removed the usage of PG_arch_1 for page tables in commit a51324c430db ("s390/cmma: rework no-dat handling"). Let's update the comment in UV to reflect that. Signed-off-by: David Hildenbrand Reviewed-by: Claudio Imbrenda --- arch/s390/kernel/uv.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c index 9c0113b26735..76fc61333fae 100644 --- a/arch/s390/kernel/uv.c +++ b/arch/s390/kernel/uv.c @@ -471,13 +471,12 @@ int arch_make_page_accessible(struct page *page) return 0; /* - * PG_arch_1 is used in 3 places: - * 1. for kernel page tables during early boot - * 2. for storage keys of huge pages and KVM - * 3. As an indication that this small folio might be secure. This can + * PG_arch_1 is used in 2 places: + * 1. for storage keys of hugetlb folios and KVM + * 2. As an indication that this small folio might be secure. This can * overindicate, e.g. we set the bit before calling * convert_to_secure. - * As secure pages are never huge, all 3 variants can co-exists. + * As secure pages are never large folios, both variants can co-exists. */ if (!test_bit(PG_arch_1, &folio->flags)) return 0;