From patchwork Tue Apr 9 21:02:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 13623253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B719C67861 for ; Tue, 9 Apr 2024 21:11:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 174DA6B0082; Tue, 9 Apr 2024 17:11:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 125336B0083; Tue, 9 Apr 2024 17:11:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03CCD6B0085; Tue, 9 Apr 2024 17:11:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DFCE16B0082 for ; Tue, 9 Apr 2024 17:11:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 65EE0A0C60 for ; Tue, 9 Apr 2024 21:11:22 +0000 (UTC) X-FDA: 81991239204.04.DBB1A55 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id 68FCB4000A for ; Tue, 9 Apr 2024 21:11:20 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of "SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712697080; a=rsa-sha256; cv=none; b=jzu5OW/1vq8GMPMrNy3auvRyAW2Sc5O1zk+EHGsI4FVV+Y3GA4bRHJryZg5iEjngEnHTym /crYQFL28RNes/Wf/fdf87521+eMehujKxk2aoBaVeI7vAHiTeruRCcmYo7jYzQCSBrhBo KtQa0qnU1bTrU7KoE+ZqqSy0+GJOfOw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of "SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=qg+T=LO=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712697080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references; bh=sLcpGc76wNT4fHaDjTFl8tf9Gen4NZ7+dEBshn2Gw9E=; b=DXozBl93eZ0M0CdEe/AyTHHS7EYAGIWp0DCpDURHLgRmHhL1Qkz86P8l7Pk+ycILKXnpvI lENllVslKABS4h+BhC1dioGIrXk92D9F1112ZmtKN7Rbrexr7ckf/UV2s/P7b/Sn6PwREm 3YM/5ePJkLe7K/5GCYqbfu81ZzXX/mU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id BEE11CE23E9; Tue, 9 Apr 2024 21:11:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB506C43399; Tue, 9 Apr 2024 21:11:15 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1ruImt-00000000d2d-1ZXv; Tue, 09 Apr 2024 17:13:51 -0400 Message-ID: <20240409211351.234897475@goodmis.org> User-Agent: quilt/0.67 Date: Tue, 09 Apr 2024 17:02:56 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon Subject: [POC][RFC][PATCH 2/2] pstore/ramoops: Add ramoops.mem_name= command line option References: <20240409210254.660888920@goodmis.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 68FCB4000A X-Stat-Signature: 81w3uar57c3wche3777fg67euifsm13a X-HE-Tag: 1712697080-703035 X-HE-Meta: U2FsdGVkX196BEcBSsbSfuQXYLVFORgfpOQNJMgd8Gyo0IgytbHpATloO30jmcwBTbnt95tULYfs98+Eh5Abpg899aeAE9QZk6lV6/P0fDpWXrNsOOi8ZJn0By3TYUWd9xSCTc6BT9BRYrvKT7FOSSeuUmaLCdwJh13BcT/qbYq79yiYCuyjJy+tEiQ+QOZ3Bx/26j+DnCPOisPRqgEDK6zDAS0zNalZ4gFJZTbQI9JzkLOC5CW/3Pm+iyq22muKmcL/D4TyEuGWrFCraX/O70U+3yjQ+1z+bhrXZhyocyDCJBxs6v3ldrUixrwKqFxGzHb0aN5Mg8Tyws9w/XuXJkDxT3m/LA9fMNjRNWhUqSkweFEnwp2ZSyre5GGbUaWqEtAVXn3ILvHoNdYOMAQmjaoFlZ71pIp2yKnAhlVnCsORYaIhJvcVJFlD5j8nsz6rKz3lS81Sg4g92pYpYSTqerVYBZe8yNTbPHOB1+9u2vqax7s4g4lqzWRO/lEGmnqnCQB0Lry8IB1uMGTbUY7UapXRw/WrIfbyvgm85pt7u3s7PQWt5ElW580GU8xEo+fEOq979Cjdpvf1l68/ydbS3wuZMvHF8qZKElqePxhh/kSeGtdRovF1zS8fsz1TM9XlFWC061etC+N6Ob7HkTMJ7oX1QQ0fbAjNoPTfjQuPV9cFx0fvV8cvT3rtLd96w1fI656U3Ya9PXoDBWvdknxNhtyIK+sXn4FvDypdhnbUH5241ldTq/VFiA+9NCcc9+dBetbixY/q5Z0hYWY9SzznLOmICmEuDcIT8vKE2mewEtUaYRQqRdqFT/YMo00AGvxcWN+TUNkVz8qtEW6U1o6kcnmnHo1tPO51uCUNnYaot7f4ogEXOPtBa8IvsenYBHL8r6HlvgrJ3jCL8Uc3yibqAIphclMQPWUn/EO4H60+52fqumOYajR1yu6rCO3awbP2HSCOgQulXbsHZt0fjMF zoGpRDEC GpJ/pXv+CmOa1PLrbaVBYlGFSdBkzwRmaSYuFuT8ZUACJIjh3CFHtNzpo+WxkRff0DT8xdepMh3Vu6n70oz4/f9SngNYlsXoDOOhyFUMGfrVlf0Imxah/5WFmZAkXicApLkLIyhd9tcy+31dM9S1ATN3gkoW5xYeW0vyJlOkwtJQpGClJJUC6ui1LcM0chbZkA4m3zfwgTJVZyCox5j/B9giTN+z6uTswRJunkyfUje7p7Aj+JcT/57eOUZ2D4IdpB4jPj3q2+GxuikuxX2HU767q3Q90IjBueickfEPDelC4BrplQWyvuWNUnOMVCArPTaEGU78rjOI+vW0rc/adNjlcoTwLBw63VkO+NyY4tgbUBYk2sOWw81Co8IvORYA8RnIFUUShYhgXSbQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Steven Rostedt (Google)" Add a method to find a region specified by memmap=nn*align:name for ramoops. Adding a kernel command line parameter: memmap=12M*4096:oops ramoops.mem_name=oops Will use the size and location defined by the memmap parameter where it finds the memory and labels it "oops". The "oops" in the ramoops option is used to search for it. This allows for arbitrary RAM to be used for ramoops if it is known that the memory is not cleared on kernel crashes or soft reboots. Signed-off-by: Steven Rostedt (Google) --- fs/pstore/ram.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index b1a455f42e93..c200388399fb 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -50,6 +50,11 @@ module_param_hw(mem_address, ullong, other, 0400); MODULE_PARM_DESC(mem_address, "start of reserved RAM used to store oops/panic logs"); +static char *mem_name; +module_param_named(mem_name, mem_name, charp, 0400); +MODULE_PARM_DESC(mem_name, + "name of kernel param that holds addr (builtin only)"); + static ulong mem_size; module_param(mem_size, ulong, 0400); MODULE_PARM_DESC(mem_size, @@ -914,6 +919,19 @@ static void __init ramoops_register_dummy(void) { struct ramoops_platform_data pdata; +#ifndef MODULE + /* Only allowed when builtin */ + if (mem_name) { + u64 start; + u64 size; + + if (memmap_named(mem_name, &start, &size)) { + mem_address = start; + mem_size = size; + } + } +#endif + /* * Prepare a dummy platform data structure to carry the module * parameters. If mem_size isn't set, then there are no module