From patchwork Tue Apr 23 19:22:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13640578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628F1C4345F for ; Tue, 23 Apr 2024 19:22:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8B0E6B0171; Tue, 23 Apr 2024 15:22:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C45EB6B0175; Tue, 23 Apr 2024 15:22:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADB476B0174; Tue, 23 Apr 2024 15:22:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 91DAB6B0171 for ; Tue, 23 Apr 2024 15:22:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 56D1A1C0BAA for ; Tue, 23 Apr 2024 19:22:27 +0000 (UTC) X-FDA: 82041767934.15.77AA219 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id 59E8440015 for ; Tue, 23 Apr 2024 19:22:25 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=p+WQ0DGV; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf11.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713900145; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QH8+VVHeKCvyXF+XfpPQcB3hgAUVEIgYamedVnOHyoQ=; b=h+13VdsvtJmv0wNjangM44xfxIrDHiQB7UIDdAGU+CIwUv6C9Jos5HrrOQiSCyfKRgClHH id/wvT6JgTpXrVLS8yCGzY8z3kNLlTx1UaBqjfDbSt9jIgl/eEIN63NSWYbhqjtsjhXcV9 iBVc5dG4Zkt7k3JZf4JN2ZkzAf2pB+g= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=p+WQ0DGV; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf11.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713900145; a=rsa-sha256; cv=none; b=fX4OoAa5n+y8fdJNamAG3iHxdVWUm+sk8hxYHZdi9mqgOxNI1YpYHNfV9/sZIrwt9/MU/a 663h3vru0pknNU6+WrS5HwJZY+7hUpTpW+e2Yv9R37rzfhNaRDT4zJpybCZiFyWGuKNOS7 zm5mP1rvShbmop6SNFCTgK/n0jH8Y08= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=QH8+VVHeKCvyXF+XfpPQcB3hgAUVEIgYamedVnOHyoQ=; b=p+WQ0DGVtlrOAjESqjZUK58O8k nisgxZqza7lnpwKkHu/cm5nXgHvuDPDUh+ETV2yigLg30aS1kNAP/2njfMQUTDyClS/xUJ4u0PfnI AtDL6m9exbragWOT0L9tZ5cJd/CSP9tu9X9S85K9dDMYFwkAlfkZry2fx3pvV/xnqMjBgMSRECaGo arQv8U4+baya92uW5jw1z9dDgR47wh3gSS3UWBpOgWsX3gtqQpqbvQfqKiC3V3NWlPdDvcDvYVqmi V1C1vE6m5kmnyO5PKjON0tvVNztPaXjYUo6ZyOq3lBuo1iM9DQGHi3/spFwK2piLYT76AzMlnqzkI 8BjjovSw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLig-00000001GKt-3E51; Tue, 23 Apr 2024 19:22:22 +0000 From: Luis Chamberlain To: akpm@linux-foundation.org, willy@infradead.org, Liam.Howlett@oracle.com Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, djwong@kernel.org, david@fromorbit.com, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, mcgrof@kernel.org Subject: [PATCH v2 2/2] lib/test_xarray.c: fix error assumptions on check_xa_multi_store_adv_add() Date: Tue, 23 Apr 2024 12:22:21 -0700 Message-ID: <20240423192221.301095-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240423192221.301095-1-mcgrof@kernel.org> References: <20240423192221.301095-1-mcgrof@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 59E8440015 X-Stat-Signature: o6bhqwojui8jdq31h3rn6g1s1cz48oga X-HE-Tag: 1713900145-342953 X-HE-Meta: U2FsdGVkX1+umOJq8Vw3nmbpFFLU3u1Fi03xb1lSO84fp7KvH4I4wYToEQ9oSbkQFaJiiVsUulzzogd2vnyeuaAUG3/6UFIVjrtJcD5Vu7+9vvUnAPqwKumIPuKC3c6ma4UpaFlFvQcGkk+SuhnIvJDfBdGNIC3UpPrNkVIOMT0igIcz0pXi85jcrWWBbR+jM5ZVElDflgQu1F0lLWLszFhWAHz0W/KbVzI0zJAMHg1AeIy/pffHsu4+Jh74OMmtC6uN83UREPL3kA2SVckdgVlhJ/aJEB8CB3fzvwf4XfglbNLRxnfPQDeoI9qaNTGxh/rAiEw9/DKmr4/fmwYzLM61wFNJAvE8A+RGvLoaatGbxj10MtJi4VmdVsEB+qApQRAsoJ+G+X9fP/VEQ7ULjXzsUtnWsMji2DUgkdMEb4G+N8GO+v6tXGMLP4EA0QnOHhYF1MGks3ZaYbZqO4iwQ4FtRoMvmYQgwbnvNTajDWUce6FVjklSFZmTNZdCa+yNmOeAF8snMp+hoa74zlFnUprJVfAanWUyvT7GKLYvkoRzmT4Ekoz4uJuQI4c+ckMMJLgvnIP0c5aQ9ixvHRT7JD9WOBEtfv85aa/ESmoRdudzgRNj1p8DqVvkJklVWcVMGHtNPhOv/e9hsx2thKBRRz5zOJMkhyltbYU5bh3QJ/7vJ28gUWVYJcPW1niFG4LkSeLbaEaJQzJjYNJgasTfLg8bcygLkhrRVqveS9JDjGSK9JxPtBXv73iB6CEmUMMJeOhF+fp/RDpITz8IzrtTw4eNNvxsEFo3ldiogkhxlfc+5SL9cas8oG/KSYQh4OAx6JO0b7t0rZdvagSru8Fp/2DHCnwvV8kI8hlEvlxHP5MYmeuilKa1Fplg04L8yTAjSe5TTBkiTvHdGGtLLse0skqmT3xS424tCUAojjbCRoXSwmJtnf0OS1OU8u06O1W03awZkR04FsmI79iuv9u lXovga9V cPO/GI3TsVIE7irDDwyWY5gc1PEtNUXAy3msBJ59qKu0dQd/wrGrZu42mUunYJ5nuMwkQstSbC34d6u920Ai5eVdPhO6PrSNwVB/v4XZ2AIVWRd3sYrkomgPVhoFclBOy8NnLwRqoqN22tIvtH+m8Ri5RUkJahyYkA9Ya X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: While testing lib/test_xarray in userspace I've noticed we can fail with: make -C tools/testing/radix-tree ./tools/testing/radix-tree/xarray BUG at check_xa_multi_store_adv_add:749 xarray: 0x55905fb21a00x head 0x55905fa1d8e0x flags 0 marks 0 0 0 0: 0x55905fa1d8e0x xarray: ../../../lib/test_xarray.c:749: check_xa_multi_store_adv_add: Assertion `0' failed. Aborted We get a failure with a BUG_ON(), and that is because we actually can fail due to -ENOMEM, the check in xas_nomem() will fix this for us so it makes no sense to expect no failure inside the loop. So modify the check and since this is also useful for instructional purposes clarify the situation. The check for XA_BUG_ON(xa, xa_load(xa, index) != p) is already done at the end of the loop so just remove the bogus on inside the loop. With this we now pass the test in both kernel and userspace: In userspace: ./tools/testing/radix-tree/xarray XArray: 149092856 of 149092856 tests passed In kernel space: XArray: 148257077 of 148257077 tests passed Fixes: a60cc288a1a2 ("test_xarray: add tests for advanced multi-index use") Signed-off-by: Luis Chamberlain --- lib/test_xarray.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/test_xarray.c b/lib/test_xarray.c index ebe2af2e072d..5ab35190aae3 100644 --- a/lib/test_xarray.c +++ b/lib/test_xarray.c @@ -744,15 +744,20 @@ static noinline void check_xa_multi_store_adv_add(struct xarray *xa, do { xas_lock_irq(&xas); - xas_store(&xas, p); - XA_BUG_ON(xa, xas_error(&xas)); - XA_BUG_ON(xa, xa_load(xa, index) != p); - xas_unlock_irq(&xas); + /* + * In our selftest case the only failure we can expect is for + * there not to be enough memory as we're not mimicking the + * entire page cache, so verify that's the only error we can run + * into here. The xas_nomem() which follows will ensure to fix + * that condition for us so to chug on on the loop. + */ + XA_BUG_ON(xa, xas_error(&xas) && xas_error(&xas) != -ENOMEM); } while (xas_nomem(&xas, GFP_KERNEL)); XA_BUG_ON(xa, xas_error(&xas)); + XA_BUG_ON(xa, xa_load(xa, index) != p); } /* mimics page_cache_delete() */