From patchwork Mon Apr 29 12:16:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Rapoport X-Patchwork-Id: 13646868 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C19C4345F for ; Mon, 29 Apr 2024 12:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D46836B00AA; Mon, 29 Apr 2024 08:27:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF6716B00AB; Mon, 29 Apr 2024 08:27:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBE486B00AC; Mon, 29 Apr 2024 08:27:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 78F1A6B00AA for ; Mon, 29 Apr 2024 08:27:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 44DDF161ABB for ; Mon, 29 Apr 2024 12:16:54 +0000 (UTC) X-FDA: 82062468348.27.7507A6F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 904151C0030 for ; Mon, 29 Apr 2024 12:16:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rrtaQ6ZR; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714393012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xy/onuXdQ30KVEaYuNUZWEt3SxlLWflAgQY6tAjVj70=; b=JxCeBBDpkIVZfzBby7VJJOfkYRLECqN9GMGa/u2m41FtcjqQXbj6ZkwwSPua74/RVsh1CP f0sOraz6OfWQs5GvzejyxgD6h3FaqS/cOpoTLjjGT4cN0PDOcwvDrwHNLSzDWDuhYVKbCp yeL84Opw5wITtKpTs+20HEiwJMbkClg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rrtaQ6ZR; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714393012; a=rsa-sha256; cv=none; b=tM3RSbMhGZZpCP1fi3I7yXC4TRV2rZDVa7invNlAeUVqLvTqJaBA2s4NYRx1Dc4dm04VWI lES9hE5/w7t6yXDHc7VyG1LekH0Nz+9VM35nKPKWFslmcXk6ByeBXpyZjw769Lwh1yKgKE YrBoZBMFdJ+NY/GU4Yy8KEK8rSJZ3Sk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CC6F860C8E; Mon, 29 Apr 2024 12:16:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCD6AC116B1; Mon, 29 Apr 2024 12:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714393011; bh=M6QQiy27Yx7cZTOC0617KB9Ln6pKKwikPWIcgenY/bM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rrtaQ6ZRauqLf/QhMFAemIwxty5h8uPgHqNHcQHMySQ0MVzSPRXhHPa70sYRHy560 R3ypGaNGmpK25kfwoaLY75bO6SL3PrS5QdWsCTpF3c0uNb2RjHmIMtQehjComNV4PA 7rTOG9sf9Y4cRg2FKyjlc2ZMSHW9W888iUWXrOzZF7gBQ3O6SNysHzMRswOtXovsDJ CSL1YJvy+o21e6T+s2OL2KTljE4I5btQP46OkO1QxwfyupslVupTFPTNAfbQDRv3R/ ArsqZQxMTG8N9Bok5TZcctWTKYXAa/ipZzVziPkgCkS09miRTrC6AopDRPXdDfwsbN pkCNlBgseaK3Q== From: Mike Rapoport To: linux-kernel@vger.kernel.org Cc: Alexandre Ghiti , Andrew Morton , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Mike Rapoport , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Rick Edgecombe , Russell King , Sam Ravnborg , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: [PATCH v7 01/16] arm64: module: remove unneeded call to kasan_alloc_module_shadow() Date: Mon, 29 Apr 2024 15:16:05 +0300 Message-ID: <20240429121620.1186447-2-rppt@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240429121620.1186447-1-rppt@kernel.org> References: <20240429121620.1186447-1-rppt@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 904151C0030 X-Stat-Signature: nm4kosxugjep3op9r7kks4m7ueszf95b X-Rspam-User: X-HE-Tag: 1714393012-768999 X-HE-Meta: U2FsdGVkX19xThV7PBm10vl1E/GUd1b7GNZG1vzGhM3p2LXbEILHKmNZoERcKCm5E7T19OLI0qTEsUMmMiLNq0PuQgDuyeCc2nAr07kz5XuKJ4Tpnv/tPk/kb9tSFJgalbVzOfBHlgNH78AZT4BYr8RKwmcEztpY5vEK6vJU4CFrNYqunfW/qiC/NJTYTzyZbpmopiraEjalm/h0doNvUBhBEp/DnYRunFedh4Ef3CQOnIoQlBFwSEM2hVHNs9zThEJM2FkQMa5PPfI9ulbacr8lEifzCMhJPVJi6OHzEj8ILX7MqHpvKtveQc2uftamEJKfnx8lCoWWQnzNjLHWRpOxwT+rS8gF3sGtitpGwtZXCD9F1rAMSoqqiBn9I4ZWKPpXT43hJImhNgDDpEN7zOhAmCaGnWEDk2IDT2NLYWAbYF+iBWC9+F1uRwvRbauopYOq++uwRbFefUgddhRW7OauxlhdRj6ePcsYIdU1ziseIFFKMM8BNxiAo1zjMSf6S4++L41lvsLUwmwosjz/h7ywjQ/AvXgsj3UMD3m0+kPQtJ60R0ewras9HO65Ux/RsptWfMGrrBnbbZp2wmXTDSvrHWqvy56dRkZZxp8rp53CC9BE/XvbjgsC+MElgiaR1ynrz6Fhx0Jppc2MgOIHLkCUnwHhu1IpmwgQgnNV3v1R2r21GD7n/y6NzOzqlBe0W6jYLjSTXS6sDgH1cG9TuyYuVZiqtqF7vfyOxh72VUgYcy726+rHGNYj9bKTDxx3hPhGOid6eEezxCs0OJEQ3GfDncYqpYznmByGTDJrNFz6MM9c2FPsq34Xf80OjCGtFBQQmWrbtO4cQKrSxIO7F/Pyqt4vUKbSHneOkaMyr+/K3Ip4LbachErsYSYeOr1ZoS1Sxm7v4qCPlWNPG6frSxQ9E9jA3YAHBu7BD4vdWT8EQcEJLYLrZM0RSTI0IBjtJAKg0j84EGRNXjEuXdy t0cxD5jC ZJJr8GkRmn8chzBq88mjpEkLvhvmS6qUjMVr3GIm01E/m3Hy4oPGBX5BIBB2jl5FOsK0MPPh6oWpLLcMxwr0FDVDvTNo0dV+1JpNcA/Un144+hd/G7+j483x5ssPYCMlImkyWMvSH/2jEmwHItLLMflDpaACbj45b7Rn/vjTP+bevjOWlbSdieekK/88Unam4IRRdEyrHPS+90I+Y9UX15Wm9oJWepr/iA0q9QpKU1z0Gr7mRTVSqFjzRyc33kAnLmgDXskI0h7j5ZaCrh3ksiLbzOuozfh8KBX2CCTfHMUabuwcanqdgs11Xf50y0K1iWUP+Rwa7hjQFypvvxOceLY+HBli+XXI9nuvm9cpYsXE06U1b8CB1cWoIEJ/2K6i7bs6+rRWQp3T8wXgYhHHZemMAa2xT7AgC1alkJMBfYYuMje9cEPy3Ermw6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Mike Rapoport (IBM)" Since commit f6f37d9320a1 ("arm64: select KASAN_VMALLOC for SW/HW_TAGS modes") KASAN_VMALLOC is always enabled when KASAN is on. This means that allocations in module_alloc() will be tracked by KASAN protection for vmalloc() and that kasan_alloc_module_shadow() will be always an empty inline and there is no point in calling it. Drop meaningless call to kasan_alloc_module_shadow() from module_alloc(). Signed-off-by: Mike Rapoport (IBM) --- arch/arm64/kernel/module.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c index 47e0be610bb6..e92da4da1b2a 100644 --- a/arch/arm64/kernel/module.c +++ b/arch/arm64/kernel/module.c @@ -141,11 +141,6 @@ void *module_alloc(unsigned long size) __func__); } - if (p && (kasan_alloc_module_shadow(p, size, GFP_KERNEL) < 0)) { - vfree(p); - return NULL; - } - /* Memory is intended to be executable, reset the pointer tag. */ return kasan_reset_tag(p); }