From patchwork Fri May 10 06:26:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jane Chu X-Patchwork-Id: 13660906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD93C25B10 for ; Fri, 10 May 2024 06:26:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44E466B0093; Fri, 10 May 2024 02:26:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FCAC6B0095; Fri, 10 May 2024 02:26:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22C506B0096; Fri, 10 May 2024 02:26:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EA83A6B0093 for ; Fri, 10 May 2024 02:26:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 731C812058E for ; Fri, 10 May 2024 06:26:32 +0000 (UTC) X-FDA: 82101502224.25.87DB990 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf26.hostedemail.com (Postfix) with ESMTP id 8A948140007 for ; Fri, 10 May 2024 06:26:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=g+GG0Ikx; spf=pass (imf26.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715322390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tFRwwH8vMdoczPoQRYMz5N41Zt2owkILdQOhrik+iU8=; b=NVwwxcBIo9PAIZM72HPELsy0lGHk9QEsUAff6gTzIYNR33hMdaRNG7oOl9HF00C7VeFGrT Nq2K5sLiyqeIVKucr+xMY4YzgpVrD9yjbYqWsZJ1rG9Ied65WkKJD8q0OiRj49UGPJvJ0K 3shXWNBKV/r3/jMq67bTIhaKQW7UzD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715322390; a=rsa-sha256; cv=none; b=EtRw/MZwMqM9FmsyAJSp68iR1OctnPUP4lehPzTCCeIk3yU6cxz2uIFa02wLfb8uXPojTq zZe2bumYLNeWSW7U38tUwqrthYXvTvxpIZtg6YSM+hWejOCtEMymlGQNytyjTnVL69VriN V3+JWcr9E92Uui5Ynz0i/8taSHsZCNY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=g+GG0Ikx; spf=pass (imf26.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=quarantine) header.from=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44A6MlnA021258; Fri, 10 May 2024 06:26:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2023-11-20; bh=tFRwwH8vMdoczPoQRYMz5N41Zt2owkILdQOhrik+iU8=; b=g+GG0IkxeBwWGSyuHfsSdSx+LFncqCu5jZOcbVaDHmkL9ozkB8xCjsgtm+GrDkXmTUj5 MXoy9msQbB+PCutyZxq+HAKT2pUU8SvxyEZ2h8S8G7Zgpmx8DuozzcRn3wU88odGNPMW 64+S4Ksxo0HtObmuilQyCk1Bd9sTw/qfkE5mtg1aJGpyp2oOSkUjnFa5aXIRYK5lfYTI vAky1uOu1pEQjAxLxo/Of1rF5SrdrkCi2qS+I3DhHhWoODouj/cHvEGyv5JIMn/0SxtB 9EzEdDUEkS747E2AHQEmFIXqS5giacQ4OQ2QB0t2qfddTjokh/pxF1dkkb3+namnHna6 sA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3y1e8sr05v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 May 2024 06:26:26 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 44A5vUjP020104; Fri, 10 May 2024 06:26:24 GMT Received: from brm-x62-16.us.oracle.com (brm-x62-16.us.oracle.com [10.80.150.37]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3xysfpghcd-6; Fri, 10 May 2024 06:26:24 +0000 From: Jane Chu To: linmiaohe@huawei.com, nao.horiguchi@gmail.com, akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/5] mm/memory-failure: send SIGBUS in the event of thp split fail Date: Fri, 10 May 2024 00:26:02 -0600 Message-Id: <20240510062602.901510-6-jane.chu@oracle.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240510062602.901510-1-jane.chu@oracle.com> References: <20240510062602.901510-1-jane.chu@oracle.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-10_04,2024-05-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 mlxscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405100044 X-Proofpoint-ORIG-GUID: Bbu3oqFBFYt86uLCdWySG1px70G6up9M X-Proofpoint-GUID: Bbu3oqFBFYt86uLCdWySG1px70G6up9M X-Rspam-User: X-Stat-Signature: jisgd6bfnxfx5qffjmm5zhjherksqnyf X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8A948140007 X-HE-Tag: 1715322390-534075 X-HE-Meta: U2FsdGVkX1/1g8TfyUtm8OJ6KvB9X3cABSChPRzE9SSBfctaJYn6fo1r1MOEufGRimKv4Qwk7GWmeiWTrLs9OdQh7yWGWUMj0S51mHGHBOE5LBOc5nEW3vSc6UXPyBJIR7jQb/c5sxOjVQYuonyDpFsPzuIZJXuvgYooOxaCV5LB+oLl1cAzd/CoL949GziecnRVzNjzhrZPKGtnc2zzCJGXZE2Tpr4/H2wAKU7op8biQqMnQYvgH1/vZ6PviwUjn0ojXxvVWoATnXravRInr7Tl05RLmqZic3PcVnqoURJYyp4ugMTe2sA8Xxds611pLLNfPFyM51rvMZ/WQxB+mrM4Fk0IZhVFoDnSRalc8iqrG//1zy4DB4KugboS6e29hBnEu2q4jWVc/vlEJoBjPn1khboW1c0YGkMqyQ/0sCty5stUoU9P0X+0gdbzIcKr8LAzt5eYn+OQZOqNGqHpWR/5LuHFt73HnDMN1eyg3/pNu+7yy2fZyBO70ziokKsAI9QP5mpbWsOBTeWsGgVxco/e9tPpGcrYHsPFtDYxrMRvn1ubaO1P1A00JX7rKnbD7V6TmX70EqgelyN9gaB3ukbHXf/PQ6l+bquv49HFXOOpyoJCM4y68UoPbotyBlQYsF8W1YOON4FG2pzx67KPfjTXQXEChBEax+5VOjA8WBY1lSnDueOAN/OGpx3tt3drMct8IzUgQPtF94M91/wi3k2SvKGEHYgJiWCpajBB9V8EvVj1rxM/r/OT3axPboPP/ZIYFQJ2CC1ZPEeK8OXWAETcz2g4xUyUAGIx4lYG6dLzUaE3xuNlhYTJQYp5vEbh8eGfgmLvklj+qV5z1jzmRRTmfviWnx1KXHcT5zHLFI7t5YfUErExqk6EWm0YPG31nkrdMgsgP7Q2Wx8oom5oBECavSMoeLP/br02sbeLLcG5AkbPfwOOkfHIh8CwwHc2AqPk99ZkvYkt2ofHzNe KkJV8dAl G6Lj5TayZh1WnZtJ3Ht2//BOvIJ8lIdotN5jewFGgl1oTH+pyEqRzYWwwI5YYjQSD3xREjywfm2Cd2sVjEQUEnBKr4s8vbJ8cB/MVfcy+Ixg9u30ogn0/2aZFcbrYCBFtr84p2w77mr8uqOwgaRkuvvQmwWjeLjJFEmFMvNN01wzFOaxKoi2zj/xO8CwOix3YDHUgv/5RgO27/gvl04T6u2soPn0RYmSEKkOEwmlJ59CJdrknSgkUd4OSS4nGODTrC9k9MqpROuDxW+SIedahjvhtZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When handle hwpoison in a RDMA longterm pinned thp page, try_to_split_thp_page() will fail. And at this point, there is little else the kernel could do except sending a SIGBUS to the user process, thus give it a chance to recover. Signed-off-by: Jane Chu --- mm/memory-failure.c | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 2fa884d8b5a3..15bb1c0c42e8 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1697,7 +1697,7 @@ static int identify_page_state(unsigned long pfn, struct page *p, return page_action(ps, p, pfn); } -static int try_to_split_thp_page(struct page *page) +static int try_to_split_thp_page(struct page *page, bool release) { int ret; @@ -1705,7 +1705,7 @@ static int try_to_split_thp_page(struct page *page) ret = split_huge_page(page); unlock_page(page); - if (unlikely(ret)) + if (ret && release) put_page(page); return ret; @@ -2177,6 +2177,24 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, return rc; } +/* + * The calling condition is as such: thp split failed, page might have + * been RDMA pinned, not much can be done for recovery. + * But a SIGBUS should be delivered with vaddr provided so that the user + * application has a chance to recover. Also, application processes' + * election for MCE early killed will be honored. + */ +static int kill_procs_now(struct page *p, unsigned long pfn, int flags, + struct folio *folio) +{ + LIST_HEAD(tokill); + + collect_procs(folio, p, &tokill, flags & MF_ACTION_REQUIRED); + kill_procs(&tokill, true, pfn, flags); + + return -EHWPOISON; +} + /** * memory_failure - Handle memory failure of a page. * @pfn: Page Number of the corrupted page @@ -2313,8 +2331,11 @@ int memory_failure(unsigned long pfn, int flags) * page is a valid handlable page. */ folio_set_has_hwpoisoned(folio); - if (try_to_split_thp_page(p) < 0) { - res = action_result(pfn, MF_MSG_UNSPLIT_THP, MF_IGNORED); + if (try_to_split_thp_page(p, false) < 0) { + pr_err("%#lx: thp split failed\n", pfn); + res = kill_procs_now(p, pfn, flags, folio); + put_page(p); + res = action_result(pfn, MF_MSG_UNSPLIT_THP, MF_FAILED); goto unlock_mutex; } VM_BUG_ON_PAGE(!page_count(p), p); @@ -2688,7 +2709,7 @@ static int soft_offline_in_use_page(struct page *page) }; if (!huge && folio_test_large(folio)) { - if (try_to_split_thp_page(page)) { + if (try_to_split_thp_page(page, true)) { pr_info("soft offline: %#lx: thp split failed\n", pfn); return -EBUSY; }