From patchwork Sun May 12 17:54:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13662809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C802CC25B4F for ; Sun, 12 May 2024 17:55:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C87ED6B0114; Sun, 12 May 2024 13:55:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC05E6B0193; Sun, 12 May 2024 13:55:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8C466B01A0; Sun, 12 May 2024 13:55:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7443C6B0114 for ; Sun, 12 May 2024 13:55:00 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E21011A0B79 for ; Sun, 12 May 2024 17:54:59 +0000 (UTC) X-FDA: 82110494718.19.9ED7CEC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 505FF14000A for ; Sun, 12 May 2024 17:54:58 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cc70FMlK; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715536498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VJpsqidB+sPCTOeJSLqcSxbS/rS/jby608SgB8npLVQ=; b=Ql3bHzC+GzeN23Pk7diLIzpLvCMeVY41xEaSyN/Vb1AQWhWHLJKAcf7k0xMJeGwR3D68Mu DG0TqJ7Lj1jWq97tiXUxqMwfEjzspQlZULw68WnNKY5aozCbHj9aasED1HQ/OF9mOs6tIj Jphp9ehdlEZbikITLDysGwV2ERNrMkU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715536498; a=rsa-sha256; cv=none; b=5oZ0TJAguvZIDjLvcEyoe5X/CbXckjVmbX+pqumTKLoOHRW6OoHcsbQlZkhB9gOzIcsfTD 3UemUYOOlF5ydVrwAEjB/OvW1tEqX9+Xc0FY4EYfw5tGysbwNvuFicQjnjmbC6tXS+EnGN mSXorPRzbN95CotpMvSZjFktxeqR0/4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cc70FMlK; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8F86560B8D; Sun, 12 May 2024 17:54:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC9FFC4AF07; Sun, 12 May 2024 17:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715536497; bh=pJ6vzvCtZUPWSFq3LZUFfl+zSubCIvDIafn053zECpU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cc70FMlKxLi1JuD51HmpqEsx8453y79uRyuCpKWF1nFmbmpT3wquNTxEgmigdAGeP vOBagAGtYXvLeuZDb7OAbeB7Bg/rsRmffuka3NZMTyvrPgBuKUCuH6zS64yc8uIegg eo9hlLQMmqvopMR8rbRj2YnhWwtjtZotQ5AgJi26Y5BHdKGHt7b7iqvcnrIV+0XH5h 5Ay0c7jBCrdo0JwwpVwLuqqcqJQx6Ur+54tZHTranalXvTOFgw1NHZQYObYyribLXj HySwsRHduSQvTrYwk/d08i69oLkf8HWJkllCj9u+M2yPaM6ABrwmmwrU9Wo0GCzIZN 3zOv8UL9vgZ0w== From: SeongJae Park To: Cc: Honggyu Kim , SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeongtak Ji Subject: [RFC PATCH v4 4/5] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion Date: Sun, 12 May 2024 10:54:46 -0700 Message-Id: <20240512175447.75943-5-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240512175447.75943-1-sj@kernel.org> References: <20240512175447.75943-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 505FF14000A X-Rspam-User: X-Stat-Signature: 945mmnt7ofh98s4fk39yi48kbybsn36r X-HE-Tag: 1715536498-431231 X-HE-Meta: U2FsdGVkX18ryZO55GuIiSqPnhT4G4jK+7vJTdD13/GGw/7bYgqUBZ7HF3aNqYh2DAJx3V4iDe3U5RlaUMMcEkEyzZHwmSt3yCZYGZMmMAn6b6VYBDw9KniIz75M9c38xfCjIqzMazGGAZj6KckRfUkA2AFr+pALW1kROXtaDzIbE03eoL/qFQ3jMqfUE/tqdPjIToDgjJuNA+Wp5vg2LQyqwPEW09KTuFzoO7RYI6VOYGPiaVosgw4BQ24tEV2dA4RL71S3GZ4tBcwyAWfpDkt5DO9X9abreWE4Laq9vqVOBLYn0m1ADmTvdoBqjWPeCThDh9wuj+sIDWqAhXsZECYTry0K62gHcCKj+VLJ9mpB7TRbXcxp4ckWjIBVqMKt6VsSZ7CHc68SVLAm0jlM3MDbEtqBCsU0n7WgWA7FJDnzPp/nketA2w7JGy9XTunuPOZG2Dnpk7HXPU24p8AK2BksQjar5ym42ZPWoNujqwFoNOniwjXGvQsj3oANsDLUbdgSTnobRQThUlXjVb7YJs8NwylaDBsyyc49SS7z0dcZQXsParulxLsyDGjgPH/BrSdJgkJq2/T2ansdPmTYw75GcvAaWKThGvAOn36J5n5RlM6j/erR+08eFLMN+EGXE2Svq5CjljhmROE7xxg3jcEElOZpo6s4z9M6Wu1YhOoGCJegwGJ+FwIZ+79IhBOTsxNdb2OtVxeU3Oshu5ViPWTWiMoUSFhsY0xhs0QJ4vV/Y0mz5yqllCYwoiV6ibOvua+bbYIQ7x/Nmjd86dlhHjq3jPSH7jYPNKJtGJ1wYCbauwp9b/Ios6/i0nHL39DM3sKD7jovw/oH4WscxvEdMcjPNLB3HlD9q35VFO5P6KZxYdg8HhzMsfsUdn25ZFR8gzb9n6kQ+V2qS4bOZoBiW7j7IwceTZ7dD8NkLZCj6F/U5vmec2of8+niroJ0DijOwezWy3SGoFVRQjcShSF /CWLnzdn AprRzid09/wu4iR64Vq4Yud7iMq7VhSkI/D/wJzfDZX/FQLNUFnbZIhH9hQZu+CXVjt+0TH2V9ng5eHuCsoPp5T/ld7DztYJK5wCMHce3TlyS4/wcKCMWnBFgXSdy4e1DT4oqPtflOYLeuYGmMqG2j3XQRBupiwr9V/IH3mKdp5qR0URk4NsSY0RH/1xlE/u1n0K719+AhiZSJnKR/fYrJIYpzbF1lCrBBajMSjvMzKUddjJKsM/jAxMsc74kbtrBj2O3xok5syMkIMiKoiR9yste3OxoTm0VaGCZDGF7yoidh55oaKegQgPjjLvxjcp0iWv84kJMR6hbRbqL7wEft3FQjfFmHgZCM5Qs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Honggyu Kim This patch introduces DAMOS_MIGRATE_COLD action, which is similar to DAMOS_PAGEOUT, but migrate folios to the given 'target_nid' in the sysfs instead of swapping them out. The 'target_nid' sysfs knob informs the migration target node ID. Here is one of the example usage of this 'migrate_cold' action. $ cd /sys/kernel/mm/damon/admin/kdamonds/ $ cat contexts//schemes//action migrate_cold $ echo 2 > contexts//schemes//target_nid $ echo commit > state $ numactl -p 0 ./hot_cold 500M 600M & $ numastat -c -p hot_cold Per-node process memory usage (in MBs) PID Node 0 Node 1 Node 2 Total -------------- ------ ------ ------ ----- 701 (hot_cold) 501 0 601 1101 Since there are some common routines with pageout, many functions have similar logics between pageout and migrate cold. damon_pa_migrate_folio_list() is a minimized version of shrink_folio_list(). Signed-off-by: Honggyu Kim Signed-off-by: Hyeongtak Ji Signed-off-by: SeongJae Park --- include/linux/damon.h | 2 + mm/damon/paddr.c | 154 +++++++++++++++++++++++++++++++++++++++ mm/damon/sysfs-schemes.c | 1 + 3 files changed, 157 insertions(+) diff --git a/include/linux/damon.h b/include/linux/damon.h index 21d6b69a015c..56714b6eb0d7 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -105,6 +105,7 @@ struct damon_target { * @DAMOS_NOHUGEPAGE: Call ``madvise()`` for the region with MADV_NOHUGEPAGE. * @DAMOS_LRU_PRIO: Prioritize the region on its LRU lists. * @DAMOS_LRU_DEPRIO: Deprioritize the region on its LRU lists. + * @DAMOS_MIGRATE_COLD: Migrate the regions prioritizing colder regions. * @DAMOS_STAT: Do nothing but count the stat. * @NR_DAMOS_ACTIONS: Total number of DAMOS actions * @@ -122,6 +123,7 @@ enum damos_action { DAMOS_NOHUGEPAGE, DAMOS_LRU_PRIO, DAMOS_LRU_DEPRIO, + DAMOS_MIGRATE_COLD, DAMOS_STAT, /* Do nothing but only record the stat */ NR_DAMOS_ACTIONS, }; diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 18797c1b419b..a468792d9162 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -12,6 +12,9 @@ #include #include #include +#include +#include +#include #include "../internal.h" #include "ops-common.h" @@ -325,6 +328,153 @@ static unsigned long damon_pa_deactivate_pages(struct damon_region *r, return damon_pa_mark_accessed_or_deactivate(r, s, false); } +static unsigned int __damon_pa_migrate_folio_list( + struct list_head *migrate_folios, struct pglist_data *pgdat, + int target_nid) +{ + unsigned int nr_succeeded; + nodemask_t allowed_mask = NODE_MASK_NONE; + struct migration_target_control mtc = { + /* + * Allocate from 'node', or fail quickly and quietly. + * When this happens, 'page' will likely just be discarded + * instead of migrated. + */ + .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | + __GFP_NOWARN | __GFP_NOMEMALLOC | GFP_NOWAIT, + .nid = target_nid, + .nmask = &allowed_mask + }; + + if (pgdat->node_id == target_nid || target_nid == NUMA_NO_NODE) + return 0; + + if (list_empty(migrate_folios)) + return 0; + + /* Migration ignores all cpuset and mempolicy settings */ + migrate_pages(migrate_folios, alloc_demote_folio, NULL, + (unsigned long)&mtc, MIGRATE_ASYNC, MR_DAMON, + &nr_succeeded); + + return nr_succeeded; +} + +static unsigned int damon_pa_migrate_folio_list(struct list_head *folio_list, + struct pglist_data *pgdat, + int target_nid) +{ + unsigned int nr_migrated = 0; + struct folio *folio; + LIST_HEAD(ret_folios); + LIST_HEAD(migrate_folios); + + while (!list_empty(folio_list)) { + struct folio *folio; + + cond_resched(); + + folio = lru_to_folio(folio_list); + list_del(&folio->lru); + + if (!folio_trylock(folio)) + goto keep; + + /* Relocate its contents to another node. */ + list_add(&folio->lru, &migrate_folios); + folio_unlock(folio); + continue; +keep: + list_add(&folio->lru, &ret_folios); + } + /* 'folio_list' is always empty here */ + + /* Migrate folios selected for migration */ + nr_migrated += __damon_pa_migrate_folio_list( + &migrate_folios, pgdat, target_nid); + /* + * Folios that could not be migrated are still in @migrate_folios. Add + * those back on @folio_list + */ + if (!list_empty(&migrate_folios)) + list_splice_init(&migrate_folios, folio_list); + + try_to_unmap_flush(); + + list_splice(&ret_folios, folio_list); + + while (!list_empty(folio_list)) { + folio = lru_to_folio(folio_list); + list_del(&folio->lru); + folio_putback_lru(folio); + } + + return nr_migrated; +} + +static unsigned long damon_pa_migrate_pages(struct list_head *folio_list, + int target_nid) +{ + int nid; + unsigned long nr_migrated = 0; + LIST_HEAD(node_folio_list); + unsigned int noreclaim_flag; + + if (list_empty(folio_list)) + return nr_migrated; + + noreclaim_flag = memalloc_noreclaim_save(); + + nid = folio_nid(lru_to_folio(folio_list)); + do { + struct folio *folio = lru_to_folio(folio_list); + + if (nid == folio_nid(folio)) { + list_move(&folio->lru, &node_folio_list); + continue; + } + + nr_migrated += damon_pa_migrate_folio_list(&node_folio_list, + NODE_DATA(nid), + target_nid); + nid = folio_nid(lru_to_folio(folio_list)); + } while (!list_empty(folio_list)); + + nr_migrated += damon_pa_migrate_folio_list(&node_folio_list, + NODE_DATA(nid), + target_nid); + + memalloc_noreclaim_restore(noreclaim_flag); + + return nr_migrated; +} + +static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s) +{ + unsigned long addr, applied; + LIST_HEAD(folio_list); + + for (addr = r->ar.start; addr < r->ar.end; addr += PAGE_SIZE) { + struct folio *folio = damon_get_folio(PHYS_PFN(addr)); + + if (!folio) + continue; + + if (damos_pa_filter_out(s, folio)) + goto put_folio; + + if (!folio_isolate_lru(folio)) + goto put_folio; + list_add(&folio->lru, &folio_list); +put_folio: + folio_put(folio); + } + applied = damon_pa_migrate_pages(&folio_list, s->target_nid); + cond_resched(); + return applied * PAGE_SIZE; +} + + static unsigned long damon_pa_apply_scheme(struct damon_ctx *ctx, struct damon_target *t, struct damon_region *r, struct damos *scheme) @@ -336,6 +486,8 @@ static unsigned long damon_pa_apply_scheme(struct damon_ctx *ctx, return damon_pa_mark_accessed(r, scheme); case DAMOS_LRU_DEPRIO: return damon_pa_deactivate_pages(r, scheme); + case DAMOS_MIGRATE_COLD: + return damon_pa_migrate(r, scheme); case DAMOS_STAT: break; default: @@ -356,6 +508,8 @@ static int damon_pa_scheme_score(struct damon_ctx *context, return damon_hot_score(context, r, scheme); case DAMOS_LRU_DEPRIO: return damon_cold_score(context, r, scheme); + case DAMOS_MIGRATE_COLD: + return damon_cold_score(context, r, scheme); default: break; } diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 0632d28b67f8..880015d5b5ea 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1458,6 +1458,7 @@ static const char * const damon_sysfs_damos_action_strs[] = { "nohugepage", "lru_prio", "lru_deprio", + "migrate_cold", "stat", };