From patchwork Wed May 15 13:09:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13665235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D05C25B79 for ; Wed, 15 May 2024 13:13:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40B646B03C5; Wed, 15 May 2024 09:13:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31BF96B03C6; Wed, 15 May 2024 09:13:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 195476B03C7; Wed, 15 May 2024 09:13:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EE89D6B03C5 for ; Wed, 15 May 2024 09:13:05 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6FE6612039B for ; Wed, 15 May 2024 13:13:05 +0000 (UTC) X-FDA: 82120670730.19.D457BDA Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf09.hostedemail.com (Postfix) with ESMTP id D55C914002E for ; Wed, 15 May 2024 13:13:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715778783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8i+u9721UZkLAugPLModC3HmJ0FuIQrU/oQpFtA9ETo=; b=RpMpUteGZqiOpHeakOGQPghwrr5FNf7+x3Jsd4nfsuEfN3ILs6qj9chIEFdNqKGsKLRArL grnojTrY26n74joAV3ALUTolZGvAdLR4hXFI4a7PaZYY4fPsCkO6eEu9CKwmKVH10TgFsF QryoQsFljTFMbC/ilDvb0LhX17iu9Tk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715778783; a=rsa-sha256; cv=none; b=JsE3MfJY46BvxQAkKa9hOU5zpEkrpO0ii5LM2f6VmILJQizPRtHmnLxgvWLTgCoj8HH7Kw i0zqIcJkHrJDrX+5iBtMkv+yTzxT/zfNMqXYgQKmau1zcLHo/6KlewnpQTJfif4DVjkPdi RCmEqSPEsBuHrpEpr2QZgYWtyHWUE+U= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VfYT61n99zVm4m; Wed, 15 May 2024 21:08:58 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id B89D9180080; Wed, 15 May 2024 21:12:59 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 21:12:59 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Eric Dumazet , David Howells , Marc Dionne , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , , , , , Subject: [RFC v4 07/13] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Date: Wed, 15 May 2024 21:09:26 +0800 Message-ID: <20240515130932.18842-8-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20240515130932.18842-1-linyunsheng@huawei.com> References: <20240515130932.18842-1-linyunsheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500005.china.huawei.com (7.185.36.74) X-Stat-Signature: i197g59ikhoray5xhcw9q7aum3jnta8n X-Rspamd-Queue-Id: D55C914002E X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1715778782-176243 X-HE-Meta: U2FsdGVkX1+SEVx2taK8YXAK8EcJ3RPJWdLoFdNLjCHm1Q3mIX67CVX99izJIcjtkCocoRaBlUhlDY7Vl88OFhyM4B5NOTOSg71vUzaCcV8uAKmsTO8ORTRQuMp0t+6JcqRz33bb9jLBh9eV5JUX8JRLqW6XF3WmeSp5rIcuEUSQotFGh577NbBUB+FNbAqmisA59sepJEuZ9z3dladi4xk4+1P6BzXOZaBr2C7qB3dwSW57rpgI6CNrAE7V6Gtj4vEVbOXsR8EemSLyAUvlsxtibrRo/bDp+Eqjv1xRCvzmT0iU41ZBjkCvgJ7cZZKS43LYdt1UtomnLqn5mqtJt1YPcjD9hfw4aKsNGycNEgVYmykmo4GOGE6+2X7NHIX22RKWM+3xpqUtAmDI4mCuqYLSg+P8yqZ9azjOWODgSizNrCNXP7kOtkXqSK6L8ddwVVYkZlLqbVKlvnuLf8wIAm0Jg2Vm+uqFOPubuUugvkwehwSJt81EuQtXYjFIQ+yjJq6V048aULmlfnTmC9/+9QSU8elCCPnkP8zkR9WSObt5/FWg46XS8r4OgaVAm+n2Fl1tfkzDt5aLa9KHC5sUn55abPlKwMJDe6+Rg2LtsbqkGm6XrFf0/TibpfKTI0pKPMkArHU+kkBY8GsknVP6/lSH8lTREqHZ7Hwi3FVw7nZdbYO13oh7WnqpfHQGYWUtiClKOaZTE3yfdPcKvk6H4ci3FRBhnB/ehEJ2g1w76zCKKGKeFTD1SEFOli2Agm1ytWZh+zjeAizvOoy4GcBw4VBfqqyaAx/kkEPTd3dkOJZq2RDvP32l0Xhe0w8M39T8WjK47ydw/EdPeLk7cMGcoZzN505HY20Q68jRU3DGXCD2XjOFudahBbIgw24AMnHd7b5G0TGoFdD4DCz0rKJk1mGmhRSMEKCVd+FcBq/1EiSZmc5o/KFzzqQPVdWF+5hyRep/YBKEKaZwtgbIUWX ELGjoI8L gmCG2616pkhfBANSLSLxZDLchadZhUBjj3ji/vWuR5RIHpq00iOhp/kaQXHMvZnjY3QZK1wn9pNHgcWuj9GCx1bntc3FWIjDNp4+gcGGf5nbrfSZskuzIremT0Gk2rDHQxUbqIrLRIa4NUnKqfmV2szfakv+39ooV5Gh+9uSOWbbmvmz0oX3hzC4exPVcnOeRSX6dB3lWzgZb5izqoU5BBB4lD4D1nAp6//8DcaPOtHOT0hihwFzNlOYN8JcDhVyhhKOIHSjfau0maaH4iDNgFnSfYBL2YKCt++jf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use appropriate frag_page API instead of caller accessing 'page_frag_cache' directly. CC: Alexander Duyck Signed-off-by: Yunsheng Lin --- drivers/vhost/net.c | 2 +- include/linux/page_frag_cache.h | 10 ++++++++++ mm/page_frag_test.c | 2 +- net/core/skbuff.c | 6 +++--- net/rxrpc/conn_object.c | 4 +--- net/rxrpc/local_object.c | 4 +--- net/sunrpc/svcsock.c | 6 ++---- 7 files changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 6691fac01e0d..b2737dc0dc50 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -1325,7 +1325,7 @@ static int vhost_net_open(struct inode *inode, struct file *f) vqs[VHOST_NET_VQ_RX]); f->private_data = n; - n->pf_cache.va = NULL; + page_frag_cache_init(&n->pf_cache); return 0; } diff --git a/include/linux/page_frag_cache.h b/include/linux/page_frag_cache.h index a5747cf7a3a1..024ff73a7ea4 100644 --- a/include/linux/page_frag_cache.h +++ b/include/linux/page_frag_cache.h @@ -23,6 +23,16 @@ struct page_frag_cache { bool pfmemalloc; }; +static inline void page_frag_cache_init(struct page_frag_cache *nc) +{ + nc->va = NULL; +} + +static inline bool page_frag_cache_is_pfmemalloc(struct page_frag_cache *nc) +{ + return !!nc->pfmemalloc; +} + void page_frag_cache_drain(struct page_frag_cache *nc); void __page_frag_cache_drain(struct page *page, unsigned int count); void *__page_frag_alloc_va_align(struct page_frag_cache *nc, diff --git a/mm/page_frag_test.c b/mm/page_frag_test.c index bb9f5aa84631..641255136105 100644 --- a/mm/page_frag_test.c +++ b/mm/page_frag_test.c @@ -337,7 +337,7 @@ static int __init page_frag_test_init(void) u64 duration; int ret; - test_frag.va = NULL; + page_frag_cache_init(&test_frag); atomic_set(&nthreads, 2); init_completion(&wait); diff --git a/net/core/skbuff.c b/net/core/skbuff.c index dca4e7445348..caee22db1cc7 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -741,12 +741,12 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev, unsigned int len, if (in_hardirq() || irqs_disabled()) { nc = this_cpu_ptr(&netdev_alloc_cache); data = page_frag_alloc_va(nc, len, gfp_mask); - pfmemalloc = nc->pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(nc); } else { local_bh_disable(); nc = this_cpu_ptr(&napi_alloc_cache.page); data = page_frag_alloc_va(nc, len, gfp_mask); - pfmemalloc = nc->pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(nc); local_bh_enable(); } @@ -834,7 +834,7 @@ struct sk_buff *napi_alloc_skb(struct napi_struct *napi, unsigned int len) len = SKB_HEAD_ALIGN(len); data = page_frag_alloc_va(&nc->page, len, gfp_mask); - pfmemalloc = nc->page.pfmemalloc; + pfmemalloc = page_frag_cache_is_pfmemalloc(&nc->page); } if (unlikely(!data)) diff --git a/net/rxrpc/conn_object.c b/net/rxrpc/conn_object.c index 1539d315afe7..694c4df7a1a3 100644 --- a/net/rxrpc/conn_object.c +++ b/net/rxrpc/conn_object.c @@ -337,9 +337,7 @@ static void rxrpc_clean_up_connection(struct work_struct *work) */ rxrpc_purge_queue(&conn->rx_queue); - if (conn->tx_data_alloc.va) - __page_frag_cache_drain(virt_to_page(conn->tx_data_alloc.va), - conn->tx_data_alloc.pagecnt_bias); + page_frag_cache_drain(&conn->tx_data_alloc); call_rcu(&conn->rcu, rxrpc_rcu_free_connection); } diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c index 504453c688d7..a8cffe47cf01 100644 --- a/net/rxrpc/local_object.c +++ b/net/rxrpc/local_object.c @@ -452,9 +452,7 @@ void rxrpc_destroy_local(struct rxrpc_local *local) #endif rxrpc_purge_queue(&local->rx_queue); rxrpc_purge_client_connections(local); - if (local->tx_alloc.va) - __page_frag_cache_drain(virt_to_page(local->tx_alloc.va), - local->tx_alloc.pagecnt_bias); + page_frag_cache_drain(&local->tx_alloc); } /* diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c index 42d20412c1c3..4b1e87187614 100644 --- a/net/sunrpc/svcsock.c +++ b/net/sunrpc/svcsock.c @@ -1609,7 +1609,6 @@ static void svc_tcp_sock_detach(struct svc_xprt *xprt) static void svc_sock_free(struct svc_xprt *xprt) { struct svc_sock *svsk = container_of(xprt, struct svc_sock, sk_xprt); - struct page_frag_cache *pfc = &svsk->sk_frag_cache; struct socket *sock = svsk->sk_sock; trace_svcsock_free(svsk, sock); @@ -1619,8 +1618,7 @@ static void svc_sock_free(struct svc_xprt *xprt) sockfd_put(sock); else sock_release(sock); - if (pfc->va) - __page_frag_cache_drain(virt_to_head_page(pfc->va), - pfc->pagecnt_bias); + + page_frag_cache_drain(&svsk->sk_frag_cache); kfree(svsk); }