From patchwork Wed May 15 22:10:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 13665575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D27BC25B75 for ; Wed, 15 May 2024 22:11:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 305CA6B00F1; Wed, 15 May 2024 18:11:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B7136B0122; Wed, 15 May 2024 18:11:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 108646B00F1; Wed, 15 May 2024 18:11:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E4E096B00AC for ; Wed, 15 May 2024 18:11:01 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 854A91415EA for ; Wed, 15 May 2024 22:11:01 +0000 (UTC) X-FDA: 82122026322.24.D4623DA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 1A906140012 for ; Wed, 15 May 2024 22:10:58 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TehATqvI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JmR7OA9a; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TehATqvI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JmR7OA9a; dmarc=none; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715811059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=UbNozqNMmhpbat3rHDj+SFwxeoFjIiOhDT9lmvodkQc=; b=Nyd5FrfNBpX7DpXClzXlvK0fhxoDp5wcAyCABfqF4wZXtz63/KzBKhLfyhWmflWmzR0viI 3gbQQiTrO7IrCg+SoPbDSwp8aupYFJ9gCMLJ4vSQJz7flpm5mV2KgjElz8+yLgq0xs2/wT Grvr4cg0L8iobmwxP/gbKxv15bR7uX4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715811059; a=rsa-sha256; cv=none; b=iST6okeA6di5tiityh74cRfS3HlL56w17A6mWe5RC/hpp1m0JyBbXBJvj68MIgZygmtkE7 +Mt6y7dJbE4MfohzKXijnr8VvH9VQIGfL4jcmPPJZxC4BGZBA2yQ/CjLWJxe3ma7T6j5P/ IgwZRwbSL9Q9knWRkhxVCbC0ihtk00s= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TehATqvI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JmR7OA9a; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TehATqvI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JmR7OA9a; dmarc=none; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 325E7340A8; Wed, 15 May 2024 22:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1715811057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UbNozqNMmhpbat3rHDj+SFwxeoFjIiOhDT9lmvodkQc=; b=TehATqvIUOhdiTQGr18reOa1F5vdROLC74YAavgH2GqXV/m5GHjkQdjrCKZrsE5/pzjL7+ z34QD4m3KDhQFhGeG6Zt6w4TZ6oCB7VMtNdtzHXqdV2yCs6Aq1xgYNTbIuVzClX0IY6yrT 7xugv/LTmb/GWBKtu8gSconwCDwx2ws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1715811057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UbNozqNMmhpbat3rHDj+SFwxeoFjIiOhDT9lmvodkQc=; b=JmR7OA9aKzawaSpVkHV2MDCC5VYkbHIFQXBTDH3whnVEPdUDAwjR+Ozxiu0sVDW6+ahxW2 1DZF8Y6my3L/7gCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1715811057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UbNozqNMmhpbat3rHDj+SFwxeoFjIiOhDT9lmvodkQc=; b=TehATqvIUOhdiTQGr18reOa1F5vdROLC74YAavgH2GqXV/m5GHjkQdjrCKZrsE5/pzjL7+ z34QD4m3KDhQFhGeG6Zt6w4TZ6oCB7VMtNdtzHXqdV2yCs6Aq1xgYNTbIuVzClX0IY6yrT 7xugv/LTmb/GWBKtu8gSconwCDwx2ws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1715811057; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UbNozqNMmhpbat3rHDj+SFwxeoFjIiOhDT9lmvodkQc=; b=JmR7OA9aKzawaSpVkHV2MDCC5VYkbHIFQXBTDH3whnVEPdUDAwjR+Ozxiu0sVDW6+ahxW2 1DZF8Y6my3L/7gCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D50F91372E; Wed, 15 May 2024 22:10:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qEexM/AyRWYRFQAAD6G6ig (envelope-from ); Wed, 15 May 2024 22:10:56 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 7F594A08B5; Thu, 16 May 2024 00:10:49 +0200 (CEST) From: Jan Kara To: Christian Brauner Cc: , Hugh Dickins , , Mikulas Patocka , Jan Kara Subject: [PATCH] tmpfs: don't interrupt fallocate with EINTR Date: Thu, 16 May 2024 00:10:44 +0200 Message-Id: <20240515221044.590-1-jack@suse.cz> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2126; i=jack@suse.cz; h=from:subject; bh=nepuCvwX/Y1NrHhBKEWye0lsb804dUMaCn8jkYTf/Fg=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBmRTLb53IJKE3UGywIDzAg6YE2qe3Zgf+FnQxwBGoI uBuyXCKJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZkUy2wAKCRCcnaoHP2RA2ROKCA DfwZwvwPVs+UdJm114a1v6s5fidRjLSRujhkuHfKEi7L9qLsz/fQrm1SVs64WQMtQ9P3sCHmpRRbAQ NCxBS/KDayvQMk9+dcT8TmQlkRFUl+cmYE76zutnqrWGlknEArpeitP1opG6GFByqcEm4iRUE1vx3t XlL25ZIwKyujeQ4BPNf7Ur3EiFZQNPMQtYajjDSoZMXWslPeIll++hqEL7YZOTJrJiImJ2cEhqLCtP E4pb51s/HMHz6OncsJftfBT32pMtvS09L7SnGoFP/L6bZpViWEYjJ1SmOsbwgq+2CaYc0fgm35WhhG eIMlz0qsbjvH4MBtiDfRG/zylhqS2s X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C X-Stat-Signature: 58nhyp34y1jwm7p7omp4n4otbnrtosf7 X-Rspamd-Queue-Id: 1A906140012 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1715811058-475704 X-HE-Meta: U2FsdGVkX1+09nkqtPKWVCNrATAVzNOYzM8kaf3mPGRW54CSRpKulGmXrfSRRB/ZzV1tPTnv+BZLmLkqsK2YJmePkzaAVAO2GVz2QsHj6RAKa/1z8w32cD5G74hMekOnZjL2P4RL8EYm6NPxCod/nncMmVwsiKTSb6pmw5xyCYLH6OenlbRNf0RBUzVbNKoUjfRffT6MjYi6aUlR081geVeBL7pqIxtijWyXxkxoZhIIt71aHVDCvO7iGXFvT9b4JbixtArVQNoFcfDqUaRA9yZdc1JIx0ldgAK8vF6CXjxMB7qCpoUUl5zE70O9STuEDnBuwZMeYlNb6YmO/V+muHiqj8c65VI7q0pktsYI2jQvgOqe0SLw5TajqorFzmxfZK/LGfau31NhZgBSjwsfG5aFAolwCcH6Zr2qn1vRYX34OPA37yn1WkK9qJmI0dkv5ourgTJERIkQBJljbpDcYWxrwehzm23588lHNd2kxvEfWkqrvXwLSXo4x/SWVwUUuWgKQaFoO2DrGZIsdglaEcNg6hS/ixPBIwW3JJ7okPgB3LZhGK/90cH0HC7pNL476OwHzvfq9/RjDtpyCYKjo3/Ya8kXRRvgs+J6JL09TR8FYN9xTF0gyDvGTrHgAEHoIyvC1y2PZqOG4nJXr3xDxrbliyGChrzLYoOoOeL5Mb+z84xFB9cyk7YIZPIFj/EQiOZ24SvOVmT4676ZbLvSsus1EugTYhF26YPqvrvfTeesLtX8TLdAaY7D/9sLCyFf8QFeUvCsFdbT/Xy1hhoq0jsVQNuIbJcWayJROwGGt+DSJ64BYf2k3/GjRPk96AGcdcvhJ6wnUVOnDwsrxupf/bGtSRE1aoKgU6RHiRJkT1Mnjoqz5IqeP17e2SCr6XYITGtdNC2VwSKMPNSo9X8WZ6kTZQg06BJfTdTQMp0HIC7CzmXrB/N+LPp6bmuy1l6H2OurTEqcvt9U6PGIEiU 4Dd0KWFz 2KIFsThtxo70SK3ycxi9xPr2czSewnpFNAuTFDPrGloFrGdizz6iqdCCy8HyfqyuvaI8bp/YnwUYo/+/HwrkEHST94IUryDVosulV+hdZksw0+qCHDWEUhWFM8KdFjWM3Xvk8mtVF/pKDfY+hmRW/jZDuwU9fzEKdihWb1Ic1MsrjKL4wkmCUGnaCr8ixSCb5JQ5KVTP6AxNY8gdyfXR+C/YpZp99smtclj/mXe3eE8Nschs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Mikulas Patocka I have a program that sets up a periodic timer with 10ms interval. When the program attempts to call fallocate(2) on tmpfs, it goes into an infinite loop. fallocate(2) takes longer than 10ms, so it gets interrupted by a signal and it returns EINTR. On EINTR, the fallocate call is restarted, going into the same loop again. Let's change the signal_pending() check in shmem_fallocate() loop to fatal_signal_pending(). This solves the problem of shmem_fallocate() constantly restarting. Since most other filesystem's fallocate methods don't react to signals, it is unlikely userspace really relies on timely delivery of non-fatal signals while fallocate is running. Also the comment before the signal check: /* * Good, the fallocate(2) manpage permits EINTR: we may have * been interrupted because we are using up too much memory. */ indicates that the check was mainly added for OOM situations in which case the process will be sent a fatal signal so this change preserves the behavior in OOM situations. [JK: Update changelog and comment based on upstream discussion] Signed-off-by: Mikulas Patocka Signed-off-by: Jan Kara Reviewed-by: Matthew Wilcox (Oracle) --- mm/shmem.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 1f84a41aeb85..9c148f9723f4 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3167,10 +3167,13 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset, struct folio *folio; /* - * Good, the fallocate(2) manpage permits EINTR: we may have - * been interrupted because we are using up too much memory. + * Check for fatal signal so that we abort early in OOM + * situations. We don't want to abort in case of non-fatal + * signals as large fallocate can take noticeable time and + * e.g. periodic timers may result in fallocate constantly + * restarting. */ - if (signal_pending(current)) + if (fatal_signal_pending(current)) error = -EINTR; else if (shmem_falloc.nr_unswapped > shmem_falloc.nr_falloced) error = -ENOMEM;