From patchwork Mon May 27 16:36:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13675640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1105C25B74 for ; Mon, 27 May 2024 16:36:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 694CC6B0098; Mon, 27 May 2024 12:36:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66B466B0099; Mon, 27 May 2024 12:36:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 532AB6B009A; Mon, 27 May 2024 12:36:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 387EC6B0098 for ; Mon, 27 May 2024 12:36:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E18181A08D5 for ; Mon, 27 May 2024 16:36:27 +0000 (UTC) X-FDA: 82164728814.22.DC4CBFD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 5656120016 for ; Mon, 27 May 2024 16:36:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=DF+0PB+J; spf=none (imf03.hostedemail.com: domain of BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716827786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=27+lP32Q2mw19iey55M36pSytXlr5S4+SrngC3O6v+s=; b=K4sxsngAz565ld/+VOEtIyXChO6FrJpXJtNvQbpYMWQb3YOBm3Mxg1nBXetkpHlJHUQgOH WQ4f0XYWdjTZ93PZbunh4Ignbf61mQRgylNvtaQA6wmGRATqhVhnb2excTI/+ME+E77gfm TMlL6nzONolzSY2VLkBvtmQFxtgg1gc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=DF+0PB+J; spf=none (imf03.hostedemail.com: domain of BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4fba24c4406d7dd25148+7582+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716827786; a=rsa-sha256; cv=none; b=nd9eh2scuxvG/BV1fJBmpVSqGjhqgKU+0RO8Y4PzzpXyvIiXIpVGoazRUIIQf88zOOYpZm 1qjEv4cPRAI3iZTtg7UIc3lKYDedozP2B8ZXqDnfR8mN60WJ0/OCn57Px1+EpLmMO0hW6k BEZ+V0OcXWrx5VQJuS9e6VyLIysNCTs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=27+lP32Q2mw19iey55M36pSytXlr5S4+SrngC3O6v+s=; b=DF+0PB+J1G3GjShibBUkkXKzbg fXBJp4C12z3fLlSUjFb8iSZ12AevUEdRfRjZ65AWcrNk697Svt6DuF5gVqg4QjbjnUClInBMEI1fO TfEbmNaMYRqU/2QXTmXXyJL+AvEdUbrZ+JSijhLQH8oOgsoRdGmy8m7OGPwOckiF+0Z6qGrT1GbQv T/4dxOFKBIJdGP/bWENwVdcqF0qb34xY2V4MCNg0VQwK49HqlXvDjpSaCsAvfsFMLwrrOFg7l6wSd dCI/QdL+yV5U3WF7sB3kYhStTLsR9aFpkkG+H5/jCwMl6/YKu7F1t0WFZn5pMml3EY9duNuMKrv16 rsI69DyQ==; Received: from 2a02-8389-2341-5b80-3177-e4c1-2108-f294.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:3177:e4c1:2108:f294] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBdKh-0000000Ft6T-11pI; Mon, 27 May 2024 16:36:23 +0000 From: Christoph Hellwig To: Trond Myklebust , Anna Schumaker , Matthew Wilcox Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Date: Mon, 27 May 2024 18:36:08 +0200 Message-ID: <20240527163616.1135968-2-hch@lst.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240527163616.1135968-1-hch@lst.de> References: <20240527163616.1135968-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5656120016 X-Stat-Signature: ijtpfborafa4zde91t91ukhtrrzazcxq X-Rspam-User: X-HE-Tag: 1716827786-678201 X-HE-Meta: U2FsdGVkX1/oGjukJu7w8tGUMbkHpgsYv/UV/U76BNlJ2pgAjdzLcEMl+Nf3l2FwjyiJXHJjEpBhxey4JGAYv1pTaM85bbyNQCSJoxeH9wvdintnNZlDLJZWbt86MJpqC5CtU95TK393mRdEXFy0OurRBStsxfVUbjM1izISXLk4rbONyOH3W3U20q97yHyB88rMdSowB394IdVophUx1TMFOOsmrHsQpqX0WCgDbKwbUh9MRB2BaX3UNOmUvT9d0HP+bAwb26lt3p7BJYJEiOWl4k9BcRWjypZUxdUc0c/jBoE650SoHlpPCLlkMqZd4GytkPFAb9bZwuboo4bm5eWGCXNlrACOInDvsh39PejfZ6qqZi1TH9M66rlGo10K6b+6faICt209hChlG0717sy5USz1/OTHyC9dhGNqe8IlNc/FKR0JfYW+mzA/gADlEFCiN52trOQqF/iDzdhMwawTC5TQbsNf4+uOACShRtmx44lywg2rQNPiIF7AwmEjbeQaA+Y7l0QgYm8C+vq9Pu0mNFZPfLGvwfglB+uqftjmpgKnIFpxuqzDaM4QUcEhkUUMMJWtgOH5oci+syuNTmSPYRyI8LNpjveuDqWtNBtUeOiJ1QFfwrSp5PLPO8yEUCa6tij+2Rzjh+ssngmRojjnxb/y2MZKB3Ks0kbGvCFtEuDQvGpcJpmSqumH+WUYMYLXRcX9n6stosmIObK4RpttrznaCRD5qd1Dz95gaX7wbllXpSJyIrm4Pr+8VszUIYbmPcBymzVFx+3qyRhqYT8t9nUwABQxJBtmsbd7hVrvtDVFPJ6kgXd5YlvtFSDfDJUE+wh6muhWDIvcSpMqUxB1P2hytcqNNC+iOyDzG6yPXDWx6yn9WWFpFRSYmjL/YEZ0H5tPM1/I9dEEcIXwY950MRyxOnkbRQe0JBmA92HeS/q2XqTRyQGTvMDga7VcrlRzDKVhLw6zzquO6ab 8oIHNvTq fjCHREwfyCReIhptMeh3UAnIweaalpGim+JYOAQXIZaCRSEo+8QALY90dSvvH0zS3ad5SujkLDgJ0SqX+u6zk0b/4S4YTfeOmUBrfI5dHnluvEK34W+th9IcgycQXbPEt7Y9Yr22k2hmLdTgD1SaSy0LEE5cLyoUJyTdjFZuXAzpuALW5kY9tpTaJOnME1JA0mzZQS4bVzlT8srjhqDdTBmbmZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Matthew Wilcox (Oracle)" Modelled after the loop in iomap_write_iter(), copy larger chunks from userspace if the filesystem has created large folios. Signed-off-by: Matthew Wilcox (Oracle) [hch: use mapping_max_folio_size to keep supporting file systems that do not support large folios] Signed-off-by: Christoph Hellwig Tested-by: Shaun Tancheff --- mm/filemap.c | 40 +++++++++++++++++++++++++--------------- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 382c3d06bfb10c..860728e26ccf32 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3981,21 +3981,24 @@ ssize_t generic_perform_write(struct kiocb *iocb, struct iov_iter *i) loff_t pos = iocb->ki_pos; struct address_space *mapping = file->f_mapping; const struct address_space_operations *a_ops = mapping->a_ops; + size_t chunk = mapping_max_folio_size(mapping); long status = 0; ssize_t written = 0; do { struct page *page; - unsigned long offset; /* Offset into pagecache page */ - unsigned long bytes; /* Bytes to write to page */ + struct folio *folio; + size_t offset; /* Offset into folio */ + size_t bytes; /* Bytes to write to folio */ size_t copied; /* Bytes copied from user */ void *fsdata = NULL; - offset = (pos & (PAGE_SIZE - 1)); - bytes = min_t(unsigned long, PAGE_SIZE - offset, - iov_iter_count(i)); + bytes = iov_iter_count(i); +retry: + offset = pos & (chunk - 1); + bytes = min(chunk - offset, bytes); + balance_dirty_pages_ratelimited(mapping); -again: /* * Bring in the user page that we will copy from _first_. * Otherwise there's a nasty deadlock on copying from the @@ -4017,11 +4020,16 @@ ssize_t generic_perform_write(struct kiocb *iocb, struct iov_iter *i) if (unlikely(status < 0)) break; + folio = page_folio(page); + offset = offset_in_folio(folio, pos); + if (bytes > folio_size(folio) - offset) + bytes = folio_size(folio) - offset; + if (mapping_writably_mapped(mapping)) - flush_dcache_page(page); + flush_dcache_folio(folio); - copied = copy_page_from_iter_atomic(page, offset, bytes, i); - flush_dcache_page(page); + copied = copy_folio_from_iter_atomic(folio, offset, bytes, i); + flush_dcache_folio(folio); status = a_ops->write_end(file, mapping, pos, bytes, copied, page, fsdata); @@ -4039,14 +4047,16 @@ ssize_t generic_perform_write(struct kiocb *iocb, struct iov_iter *i) * halfway through, might be a race with munmap, * might be severe memory pressure. */ - if (copied) + if (chunk > PAGE_SIZE) + chunk /= 2; + if (copied) { bytes = copied; - goto again; + goto retry; + } + } else { + pos += status; + written += status; } - pos += status; - written += status; - - balance_dirty_pages_ratelimited(mapping); } while (iov_iter_count(i)); if (!written)