From patchwork Mon May 27 21:01:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 13675780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5065BC25B74 for ; Mon, 27 May 2024 21:01:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 539E76B0083; Mon, 27 May 2024 17:01:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E9226B0085; Mon, 27 May 2024 17:01:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B0C06B0088; Mon, 27 May 2024 17:01:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E4A16B0083 for ; Mon, 27 May 2024 17:01:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ABA88A27C9 for ; Mon, 27 May 2024 21:01:46 +0000 (UTC) X-FDA: 82165397412.19.F6F6724 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 9737240011 for ; Mon, 27 May 2024 21:01:43 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XsuVjs01; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716843704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=HDLaoQD7cnvad9Y4kohJVJq8Wi/o15RfSw0EInJn85g=; b=Zzjse61j6Mctjx4SQn7cejt4UsjpQSfOi5MVTC4AjYMdkTrQ2mqZ8sKqnQBW64omhJQupJ RkOoZky7uLtfyahlNO9rV8qbSvj0tJ6eZtrmBUGlpnOPzAekiHaY8MhKhyCDW/nAS0I3wm ljCy44Sg+c01BLATaMBHx+kE2xsakKI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XsuVjs01; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716843704; a=rsa-sha256; cv=none; b=U5gAA2PE7pCxf+i6d5NGMPXZ5n4z50hY3UuBrMA5GInqo9+B5SoHoUZRcTpOomTE68qstI Rcnr7W4wzvNZkmwBE8FPqShtV4KywzNYMHYbyp20k+IzZMkwmSHDztcYyqcm677mLVIQHR ZGFat/lvm4ZS9ND2t98i16VYhCm3RWw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=HDLaoQD7cnvad9Y4kohJVJq8Wi/o15RfSw0EInJn85g=; b=XsuVjs01D2A4snvIOF0Tkf2krm Bd4zzZilKsucxO4d0BOVKcbaDAHrIdKrC/JQdKnTEZWBcLQe/jL2CmpPN5agCqjD8lfKIv3ilZs0v 0ZmkrbK8cmhLjJBoRa8kajFepFpRSjfrB5F68CezJOH4HNlVkbUKv0PaeYUOi7B2rA2W3ahfig8U2 0aC3Q35KhX4zT8Zy5RNW67HYbTMe3p8hh1+cYcVjiCHu8mud1r97EcMZCALq8Mp7BkUGpnEmnXEK6 Bw7dE+mGrKkk/Qj7GcnhQpb2qQiFIQyajYIblqZ2/a8+4hT90E46rkoMyQrEzzDf/TYszEv8N1GGy W3n+g2Lg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBhTJ-00000007zjV-12Yd; Mon, 27 May 2024 21:01:33 +0000 From: "Matthew Wilcox (Oracle)" To: akpm@linux-foundation.org, willy@infradead.org, djwong@kernel.org, brauner@kernel.org, david@fromorbit.com, chandan.babu@oracle.com Cc: hare@suse.de, ritesh.list@gmail.com, john.g.garry@oracle.com, ziy@nvidia.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, kernel@pankajraghav.com, mcgrof@kernel.org Subject: [PATCH v5.1] fs: Allow fine-grained control of folio sizes Date: Mon, 27 May 2024 22:01:23 +0100 Message-ID: <20240527210125.1905586-1-willy@infradead.org> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9737240011 X-Stat-Signature: n1qwhj8chq1pspjpsdpirwhribnphk89 X-Rspam-User: X-HE-Tag: 1716843703-537219 X-HE-Meta: U2FsdGVkX1/QbLVKlmH/vZoNxTDFKaYf8V+Sbo4ckWJHIJnUbkOYEKH0HQMv6f0PJbHy5oTN2U3ygd/D2mcR3kds3sUT/l4fF/X2pHSGanK4rjHLg5vUzuCLDSprjuwY+6eVpddYERGSePXOd+tvgH7ftLmTGHIYo5t+v67hgVVKPDe4ND3/fGsXz4lsvjxjMtRj7+4C3dGfJmepwCs3srocfWvZmzT3tgRDemJhSkGl+rRE3mfk2eet3jAoUHekllTh7GaRQmGCM3jPd/cEkwZd+uO4hPEl0ApfTkjTceoiI31dgb7y9uiK6C+2WTOL6q0Tgq51LNpOWXLnVIqq7h6AFVGvKzOCtQZGYB1ajaD/vkyI/hOtStlbIPJScjAZaQDqs742aYem4Iuxe3eolW07q2BBZUzG5pJ7HS0vI+Q34dlCxt9Kw4DtOrJoFavmiQro7DnQxe+J6INA6sFaS02SCD4WzSlh0K1L9ns9JHZ3Crcfz3EnYmjQQ0ScP/+5IcOvgOOFKbBMtyLq+nzp4hpgFxLi8sBnL2+NUzAJ2Mw9nWmVj+BiSG0U8+rS63wN/mvQGefhwP3NX0n0ewRzAMHCECn8lAblUsweLgwfIvEUaqP2Qo0y+O2RlX82wbuDWRgTQpF4IBvXCfR2GL0dR6OKwC9KBeoplRNQm51llng60bmku4oXI4hkpMNBrrQt/OQwSSV3wmBcffGyVqenhoYrUrHGEFNTbfgsA8dJO41Cg6LJ+Jq6/HGPtWfdvyYL/GV9aFsWpGRXjD1esvcJInME84u0ULbJNIEwAEUnNw1e+4S8d/Pui1B6LjDc4QvpTrc1G4s/GxFZTdXivVB0ZQE/0IcKKK4vRpkK846F4sUHRW0cyQZzrdmw94AuRDRH/j9SF7UcuHZaCuM08HAdouMhCJ5ws4OgkQ108FjFFn58+GNwshHKkS1lR8Uzn7/jrMTyy4zjGLW7AP+aU0T T39iZVGh y6AJbHL72l6szFPvOIW4ghqxZKlK/VjNzOBNk2BVVjj1VequLU0BqWO1sOf7hyfrlPZzn1AibbMpwLr3USdNjJiq+NXdFVtkWTIgYN2tJgf0dfcyTPGJQwx9eSr1WOfkL8MFh4XzAPTXWJjFsJKoh3rXoJg5qYB2QqPw8dYC2xv1frHfWaBjZAXUQzuWusGg+P/iKMEiev8CXQQL3/1SzZtMeuKY6mdxMnnlpX7ulLVXfwPI5X2SuwDczkQ8Dl4Koq2mBUYepO8JeB2rD/xwVmkXh3rf7uDNPza3IgCQ5Wu+52RSX4GXGCMy6oozh7zwnAG46i+qAdhgIRt4RcQPpyBe9Bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We need filesystems to be able to communicate acceptable folio sizes to the pagecache for a variety of uses (e.g. large block sizes). Support a range of folio sizes between order-0 and order-31. Signed-off-by: Matthew Wilcox (Oracle) Co-developed-by: Pankaj Raghav Signed-off-by: Pankaj Raghav Reviewed-by: Darrick J. Wong Reviewed-by: Hannes Reinecke --- For this version, I fixed the TODO that the maximum folio size was not being honoured. I made some other changes too like adding const, moving the location of the constants, checking CONFIG_TRANSPARENT_HUGEPAGE, and dropping some of the functions which aren't needed until later patches. (They can be added in the commits that need them). Also rebased against current Linus tree, so MAX_PAGECACHE_ORDER no longer needs to be moved). include/linux/pagemap.h | 81 +++++++++++++++++++++++++++++++++++------ mm/filemap.c | 6 +-- mm/readahead.c | 4 +- 3 files changed, 73 insertions(+), 18 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 1ed9274a0deb..c6aaceed0de6 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -204,13 +204,18 @@ enum mapping_flags { AS_EXITING = 4, /* final truncate in progress */ /* writeback related tags are not used */ AS_NO_WRITEBACK_TAGS = 5, - AS_LARGE_FOLIO_SUPPORT = 6, - AS_RELEASE_ALWAYS, /* Call ->release_folio(), even if no private data */ - AS_STABLE_WRITES, /* must wait for writeback before modifying + AS_RELEASE_ALWAYS = 6, /* Call ->release_folio(), even if no private data */ + AS_STABLE_WRITES = 7, /* must wait for writeback before modifying folio contents */ - AS_UNMOVABLE, /* The mapping cannot be moved, ever */ + AS_UNMOVABLE = 8, /* The mapping cannot be moved, ever */ + AS_FOLIO_ORDER_MIN = 16, + AS_FOLIO_ORDER_MAX = 21, /* Bits 16-25 are used for FOLIO_ORDER */ }; +#define AS_FOLIO_ORDER_MIN_MASK 0x001f0000 +#define AS_FOLIO_ORDER_MAX_MASK 0x03e00000 +#define AS_FOLIO_ORDER_MASK (AS_FOLIO_ORDER_MIN_MASK | AS_FOLIO_ORDER_MAX_MASK) + /** * mapping_set_error - record a writeback error in the address_space * @mapping: the mapping in which an error should be set @@ -359,9 +364,48 @@ static inline void mapping_set_gfp_mask(struct address_space *m, gfp_t mask) #define MAX_PAGECACHE_ORDER 8 #endif +/* + * mapping_set_folio_order_range() - Set the orders supported by a file. + * @mapping: The address space of the file. + * @min: Minimum folio order (between 0-MAX_PAGECACHE_ORDER inclusive). + * @max: Maximum folio order (between @min-MAX_PAGECACHE_ORDER inclusive). + * + * The filesystem should call this function in its inode constructor to + * indicate which base size (min) and maximum size (max) of folio the VFS + * can use to cache the contents of the file. This should only be used + * if the filesystem needs special handling of folio sizes (ie there is + * something the core cannot know). + * Do not tune it based on, eg, i_size. + * + * Context: This should not be called while the inode is active as it + * is non-atomic. + */ +static inline void mapping_set_folio_order_range(struct address_space *mapping, + unsigned int min, unsigned int max) +{ + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) + return; + + if (min > MAX_PAGECACHE_ORDER) + min = MAX_PAGECACHE_ORDER; + if (max > MAX_PAGECACHE_ORDER) + max = MAX_PAGECACHE_ORDER; + if (max < min) + max = min; + + mapping->flags = (mapping->flags & ~AS_FOLIO_ORDER_MASK) | + (min << AS_FOLIO_ORDER_MIN) | (max << AS_FOLIO_ORDER_MAX); +} + +static inline void mapping_set_folio_min_order(struct address_space *mapping, + unsigned int min) +{ + mapping_set_folio_order_range(mapping, min, MAX_PAGECACHE_ORDER); +} + /** * mapping_set_large_folios() - Indicate the file supports large folios. - * @mapping: The file. + * @mapping: The address space of the file. * * The filesystem should call this function in its inode constructor to * indicate that the VFS can use large folios to cache the contents of @@ -372,7 +416,23 @@ static inline void mapping_set_gfp_mask(struct address_space *m, gfp_t mask) */ static inline void mapping_set_large_folios(struct address_space *mapping) { - __set_bit(AS_LARGE_FOLIO_SUPPORT, &mapping->flags); + mapping_set_folio_order_range(mapping, 0, MAX_PAGECACHE_ORDER); +} + +static inline +unsigned int mapping_max_folio_order(const struct address_space *mapping) +{ + if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) + return 0; + return (mapping->flags & AS_FOLIO_ORDER_MAX_MASK) >> AS_FOLIO_ORDER_MAX; +} + +static inline +unsigned int mapping_min_folio_order(const struct address_space *mapping) +{ + if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) + return 0; + return (mapping->flags & AS_FOLIO_ORDER_MIN_MASK) >> AS_FOLIO_ORDER_MIN; } /* @@ -381,16 +441,13 @@ static inline void mapping_set_large_folios(struct address_space *mapping) */ static inline bool mapping_large_folio_support(struct address_space *mapping) { - return IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && - test_bit(AS_LARGE_FOLIO_SUPPORT, &mapping->flags); + return mapping_max_folio_order(mapping) > 0; } /* Return the maximum folio size for this pagecache mapping, in bytes. */ -static inline size_t mapping_max_folio_size(struct address_space *mapping) +static inline size_t mapping_max_folio_size(const struct address_space *mapping) { - if (mapping_large_folio_support(mapping)) - return PAGE_SIZE << MAX_PAGECACHE_ORDER; - return PAGE_SIZE; + return PAGE_SIZE << mapping_max_folio_order(mapping); } static inline int filemap_nr_thps(struct address_space *mapping) diff --git a/mm/filemap.c b/mm/filemap.c index 382c3d06bfb1..0557020f130e 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1933,10 +1933,8 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, if (WARN_ON_ONCE(!(fgp_flags & (FGP_LOCK | FGP_FOR_MMAP)))) fgp_flags |= FGP_LOCK; - if (!mapping_large_folio_support(mapping)) - order = 0; - if (order > MAX_PAGECACHE_ORDER) - order = MAX_PAGECACHE_ORDER; + if (order > mapping_max_folio_order(mapping)) + order = mapping_max_folio_order(mapping); /* If we're not aligned, allocate a smaller folio */ if (index & ((1UL << order) - 1)) order = __ffs(index); diff --git a/mm/readahead.c b/mm/readahead.c index c1b23989d9ca..66058ae02f2e 100644 --- a/mm/readahead.c +++ b/mm/readahead.c @@ -503,9 +503,9 @@ void page_cache_ra_order(struct readahead_control *ractl, limit = min(limit, index + ra->size - 1); - if (new_order < MAX_PAGECACHE_ORDER) { + if (new_order < mapping_max_folio_order(mapping)) { new_order += 2; - new_order = min_t(unsigned int, MAX_PAGECACHE_ORDER, new_order); + new_order = min(mapping_max_folio_order(mapping), new_order); new_order = min_t(unsigned int, new_order, ilog2(ra->size)); }