From patchwork Tue May 28 08:59:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tong Tiangen X-Patchwork-Id: 13676344 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814A8C27C44 for ; Tue, 28 May 2024 08:59:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E1406B0099; Tue, 28 May 2024 04:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46A7D6B009A; Tue, 28 May 2024 04:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BD076B009B; Tue, 28 May 2024 04:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 05D1B6B0099 for ; Tue, 28 May 2024 04:59:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A65F4A03DA for ; Tue, 28 May 2024 08:59:34 +0000 (UTC) X-FDA: 82167206268.25.CE220DE Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id 8E57A40008 for ; Tue, 28 May 2024 08:59:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716886773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1rH7ohauD1o7ullv7l8c2uGds6pBAu7U1sjaJ0/dU4U=; b=2qMrAfqNHNSQh2HIY8JzTL6UxgFtY5IKILHetdjTaDqupEpX6ohVSbQIpm5mbf+K3/jyFz MvHk9oraYhVV17GfVfd0XQy4JM1DY+z1yzfpaLvma37MxXGfcUtZ6jyDnK8m3PTxyfRaJu FtRA1h+Ue87sUmoLoWLnYOpOoXZjMOo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716886773; a=rsa-sha256; cv=none; b=MfX4q92tSYSgpDyuFvTRWnbbj6bWANDeaW8kc7D+3n/P6Rlp1kUEI//5oxKASYzDqtEZP4 JGsE69xp4P1bZSK5ihxOw6HZONtaHG/u2qgPAcTEU64fIG7IYJ4moMb7MfzT8852IVuY3B QPc8Hg5d+5xxd7z0aHN5LIJ3DvC2xmQ= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VpRDF0V3xzlX8L; Tue, 28 May 2024 16:55:09 +0800 (CST) Received: from kwepemm600017.china.huawei.com (unknown [7.193.23.234]) by mail.maildlp.com (Postfix) with ESMTPS id 013A5141EC8; Tue, 28 May 2024 16:59:30 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 28 May 2024 16:59:28 +0800 From: Tong Tiangen To: Mark Rutland , Catalin Marinas , Will Deacon , Andrew Morton , James Morse , Robin Murphy , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Michael Ellerman , Nicholas Piggin , Andrey Ryabinin , Alexander Potapenko , Christophe Leroy , Aneesh Kumar K.V , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" CC: , , , , Tong Tiangen , , Guohanjun Subject: [PATCH v12 6/6] arm64: send SIGBUS to user process for SEA exception Date: Tue, 28 May 2024 16:59:15 +0800 Message-ID: <20240528085915.1955987-7-tongtiangen@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240528085915.1955987-1-tongtiangen@huawei.com> References: <20240528085915.1955987-1-tongtiangen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600017.china.huawei.com (7.193.23.234) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8E57A40008 X-Stat-Signature: 9fn98i7w8x4i3d55n9f6cupsrxup58q5 X-HE-Tag: 1716886772-728741 X-HE-Meta: U2FsdGVkX19s3wYbNUMdzzTyetyFUqeFeUPTaM8WT5Z9jBdeg4PlbuhVcYnUwuKz4gKnLuDgVYym+nIz2Ng4RPcGmwR1MFRoFN3b3e1MFL64rqAnmjAFsWatQyLy9K+z++qW15c0JHwPORwYqw2aSCjMjZthEanEk2c03uk522k1QquYyhTkjCgYw4hCMnoHVMna6V8TBzuf/TYsQ4D7uhydhtgceETW786oXNcdgMwfPjPyJuOsWO5NcazBtzUMDuXB5VVwquM0UIq/XWqWc+CGJawFLm0OR3VVIq98Sj20ztpc1ZEFf2X8Ep1DiHxf0TKjRrOrsIYA3tl4Doziu9I5xJntu+tjao7jOrqRrIuXPmfUKEtSoWoHAWXJtQ/3HZYxKyw90mQ/ZhrDttP5c7hXnFGEtz18yfqsk9/xnot4YuExIbgCAc57N2GI31+w9ygM2JT4XqBSJwF6n6ml79t6MS6qQenh8EbNXRiMz2HdnHiNkelQxSQ31MFa3HTSO89iBiumZIlyXGvMnSudVZwBkXJY0VzwoCJCgL0YmDBv7MR6HRjXdKrv4o3NgifIMA4lgkw4iYXQlTnJTAWvIsvQeE74+iamA0kPXKH4D554a7t2X9mPKbI2lUJ/Xj9WtweUNzI6z+jHIfN+Ywt+KEQ12dIcuARsHIPNk/iFDhi6fMe4nQkp+mCVzHzBUiIVl2s56zh6p1OTyN7pw8QSDl4I265bS8Pgzt6GRs5Jn7nVkZ5vExlCxJmDsS9Pw8apYbvVloLt7nKRPvn2qCrVyZZbcC2TTkM0KM/Wt522ryePw+GDPbeuCJ4DNPT8DoQTmypOefcQKs6M9+kuETQWEJic/T2xXbBuqqpk6jgpiwHvsHi4f7zG385LAjfAX5qOmWdlEi9/yGIHY4nu3y1p6M0VSyILEkfgmcdxGJnV1k1csFkZK7l9wnpvX8csHKCDRz00AkyBNsQ7L4pfOxo 43BFxU75 k1q8q+zh/iX4Ap6GvbajGJLuPl+bB/cYduBq2mIzaaPQKITPI9jBJPUv3FZyWPundsQyToanY937sA8JTIvXhcWrFJ6uUrg1uP2WpAgTHCDcoEKr+ewiBovUMm2uUROALBSkQAVKrWT7eiE5K3nYsNzGyCreSZmq2at20W2OVstyQY3USggaKi6t5XfIG/DbQ/8Zhr1lUxAmNfWKrVrO6O2lLluYxzxX1h6xGrMMOF7L/Zp1nFWmZzvWhRXgNltClJaFGtnJwqksrp2Tpe0586s/n9ydnWvpb3rvLfwjmFd6zNpM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For SEA exception, kernel require take some action to recover from memory error, such as isolate poison page adn kill failure thread, which are done in memory_failure(). During our test, the failure thread cannot be killed due to this issue[1], Here, I temporarily workaround this issue by sending signals to user processes in do_sea(). After [1] is merged, this patch can be rolled back or the SIGBUS will be sent repeated. [1]https://lore.kernel.org/lkml/20240204080144.7977-1-xueshuai@linux.alibaba.com/ Signed-off-by: Tong Tiangen --- arch/arm64/mm/fault.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index 2dc65f99d389..37d7e74d9aee 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -730,9 +730,6 @@ static int do_sea(unsigned long far, unsigned long esr, struct pt_regs *regs) const struct fault_info *inf; unsigned long siaddr; - if (do_apei_claim_sea(regs)) - return 0; - inf = esr_to_fault_info(esr); if (esr & ESR_ELx_FnV) { siaddr = 0; @@ -744,6 +741,17 @@ static int do_sea(unsigned long far, unsigned long esr, struct pt_regs *regs) */ siaddr = untagged_addr(far); } + + if (do_apei_claim_sea(regs)) { + if (current->mm) { + set_thread_esr(0, esr); + arm64_force_sig_fault(inf->sig, inf->code, siaddr, + "Uncorrected memory error on access \ + to poison memory\n"); + } + return 0; + } + arm64_notify_die(inf->name, regs, inf->sig, inf->code, siaddr, esr); return 0;