From patchwork Tue May 28 13:45:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 13676759 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA72EC25B7C for ; Tue, 28 May 2024 13:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BACF96B0098; Tue, 28 May 2024 09:45:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B22D66B0099; Tue, 28 May 2024 09:45:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C3526B009B; Tue, 28 May 2024 09:45:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 62DA66B0098 for ; Tue, 28 May 2024 09:45:26 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1B8D31605E8 for ; Tue, 28 May 2024 13:45:26 +0000 (UTC) X-FDA: 82167926652.30.24EC49E Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf02.hostedemail.com (Postfix) with ESMTP id 2A71380004; Tue, 28 May 2024 13:45:22 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716903924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NRuIUy2fMFhIcDljkycbP3YyA5GHegENarFTanSw40A=; b=WaoT4p2Qk4wZ0IAudblkBvi//0EiWoetz3nSjWYMx9SssWdGeNsELMFFbYnBUTa9gUgn6f c1Bh4TN2xKkFUqcr+qLnB8tDdpRA5IJ+7Rr2ZKao/B2KufbN5bSCIW+hAZPGUJ6LC0kDV/ KlsHbeBGJ9r6F3jIh3DuQEeJSH21Uco= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716903924; a=rsa-sha256; cv=none; b=Em4KgKr1k1tzSo5SuYhLUGI0NV4j9uiLduTNnEIezhx2Me0DyiQRJElVCldDfxxyje29ks 99fNJfnOoqaa7i6758l6nBZ3fJI1ey9iBanDL6FyRW5f5LGUbT6EX9+ZLXBV/pXuc9T2+0 NasE7Rsuh0eJQ1xnr/uO+phst4OP53M= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4VpYZh5b0sz1S8Hg; Tue, 28 May 2024 21:41:32 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id DF25618007F; Tue, 28 May 2024 21:45:18 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 28 May 2024 21:45:18 +0800 From: Kefeng Wang To: , CC: Tony Luck , Miaohe Lin , , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , Zi Yan , Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple , Jane Chu , Oscar Salvador , Kefeng Wang Subject: [PATCH v3 3/5] mm: migrate: support poisoned recover from migrate folio Date: Tue, 28 May 2024 21:45:11 +0800 Message-ID: <20240528134513.2283548-4-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240528134513.2283548-1-wangkefeng.wang@huawei.com> References: <20240528134513.2283548-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Stat-Signature: 9hspnsweyp75xch93oxjw381c9c84sx3 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2A71380004 X-HE-Tag: 1716903922-270402 X-HE-Meta: U2FsdGVkX1/1o9JqL9RIVbEzDvcvb26OoJlhNbzzh5eZNy3IOTLOOgWc3dhPSAvQT6QoxBUz5mMKVTXmWUcessulFtGAcSgqtRI6K0DCyw5PSJCCXlS2IsIlohiB1yFDw9NtF5bkHEvkmtT8yN5kdhbVl3g7yfMx3XfTph4jOLSDYasvPh8DXxnLgEirZ+zuRZ6NdTU2RcDIqsHouSLIPR12J2DLC+MFWL5Px4kosNTeuSpejSKOH1W/h+MU4Pa5H45YNj19HxyIp4NOi1BoiBAek5pPiLkLmEQ1TSD+9QBq9GlinIs5iB44Yt9vjveaPx8YTLBxiJds5XeniVbya2hQ/Mz0Q0J7Vox8YwnGQETdQfQpRRj/zye6Aedlv/AOwR7NtUw/mpl4zRIw8+5pKmNO8VlYcizy2RMP5nD5EnG/VUZepcapfXs3BOa2pFnKGb5MzpLGsl7X0GWJhMXOtHAEvtWL+juACjx+Johg6ScARnueUd6QPADNfl1NstQq3HGMsrhpWtXyvdqNQS27bCK1GU4GfMxijUJYbKdSMlgj1Tsa/3GcBnHdqHCHM964qSgPpgJ/c6BQqSocO3e8uEqA7R0et775eapVxLfJtJbfIBEHruvn8+ZO4B0yJesfuRIOTzrLxCa8Ui1kB4jjqJrvVbHsyhSYlSJDwLJ4/lOSffBfyOJDO7Z9uGvLXGfZrnVrv/uGpGvXamJbKx678JKZIkMMj1hiUS7QMhT5l4DZy4mBgBgdaWVvacYA4DYmGaXO6ji9/YgTULAKi7kMfJY0dojBit1bBRUEi0NkbC2Wek8PHbJti6ThNLE6EtFSleiqJhTNg6N/QGOU3WezUuco5boNfij2Hpzgh4DLENdDdtIkpqRetlad8cMHc9I0GTxIG9MoHxh1QM28Qi1E/CtWAm+ZlK3ef4I8NVpTm4NYfFIcX0xrBk8lMy3tWBb7HPAEOBtA/nRMLqBcWNp U2hdCYcq dmSx61FAeXMLPnG76rnnt/aJr7y8VW4D5oBmkZQ12+4aCljdghkhndjXy5tmwlF7kRPC5Vv1KMalBH/IF6mT5WngUlmnPhb0wjt9zKt61xomk/GpS2CRT8Tx2N7YMM37g+1uyuEDdAqa2HVGHF84WAXrzMoWzPOyXZ36T4vTYPsRQMcb2PQAGgXbOWgHoWbl250Hm2aXbAULogD7T04Cfk+cSUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The folio migration is widely used in kernel, memory compaction, memory hotplug, soft offline page, numa balance, memory demote/promotion, etc, but once access a poisoned source folio when migrating, the kerenl will panic. There is a mechanism in the kernel to recover from uncorrectable memory errors, ARCH_HAS_COPY_MC, which is already used in other core-mm paths, eg, CoW, khugepaged, coredump, ksm copy, see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers. In order to support poisoned folio copy recover from migrate folio, we chose to make folio migration tolerant of memory failures and return error for folio migration, because folio migration is no guarantee of success, this could avoid the similar panic shown below. CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0 pc : copy_page+0x10/0xc0 lr : copy_highpage+0x38/0x50 ... Call trace: copy_page+0x10/0xc0 folio_copy+0x78/0x90 migrate_folio_extra+0x54/0xa0 move_to_new_folio+0xd8/0x1f0 migrate_folio_move+0xb8/0x300 migrate_pages_batch+0x528/0x788 migrate_pages_sync+0x8c/0x258 migrate_pages+0x440/0x528 soft_offline_in_use_page+0x2ec/0x3c0 soft_offline_page+0x238/0x310 soft_offline_page_store+0x6c/0xc0 dev_attr_store+0x20/0x40 sysfs_kf_write+0x4c/0x68 kernfs_fop_write_iter+0x130/0x1c8 new_sync_write+0xa4/0x138 vfs_write+0x238/0x2d8 ksys_write+0x74/0x110 Signed-off-by: Kefeng Wang --- mm/migrate.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index e930376c261a..e8acc6c38574 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -663,16 +663,28 @@ static int __migrate_folio(struct address_space *mapping, struct folio *dst, struct folio *src, void *src_private, enum migrate_mode mode) { - int rc; + int expected_cnt = folio_expected_refs(mapping, src); - rc = folio_migrate_mapping(mapping, dst, src, 0); - if (rc != MIGRATEPAGE_SUCCESS) - return rc; + if (!mapping) { + if (folio_ref_count(src) != expected_cnt) + return -EAGAIN; + } else { + if (!folio_ref_freeze(src, expected_cnt)) + return -EAGAIN; + } + + if (unlikely(folio_mc_copy(dst, src))) { + if (mapping) + folio_ref_unfreeze(src, expected_cnt); + return -EFAULT; + } + + __folio_migrate_mapping(mapping, dst, src, expected_cnt); if (src_private) folio_attach_private(dst, folio_detach_private(src)); - folio_migrate_copy(dst, src); + folio_migrate_flags(dst, src); return MIGRATEPAGE_SUCCESS; }