From patchwork Wed May 29 13:45:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pankaj Raghav (Samsung)" X-Patchwork-Id: 13678911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8559C27C43 for ; Wed, 29 May 2024 13:45:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ABDC6B00AE; Wed, 29 May 2024 09:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 728EA6B00AF; Wed, 29 May 2024 09:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 584FE6B00B0; Wed, 29 May 2024 09:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A1496B00AE for ; Wed, 29 May 2024 09:45:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9E541A1F94 for ; Wed, 29 May 2024 13:45:57 +0000 (UTC) X-FDA: 82171556754.30.DE8FA00 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf16.hostedemail.com (Postfix) with ESMTP id D436B180029 for ; Wed, 29 May 2024 13:45:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=XtmSRYj1; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf16.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716990356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1QtcK2fxbZ+x1HZw3p1m35+0G7d81xL3TX3Jwuj1ZS8=; b=i3CwFkExQInY9IpS4O7QVqDV1eRGGwyvxHY0YLTk5knZMcvOvwhjfsSnfm705/PZBpAzz5 7HikOVnZitNxYIIBEeFOBQL6/8HP9EarHBW9D/9syD8Aao7SFx2grXPWmMZyjg2SZIh4Ak /LiXgUpXWOKi/51fpKIhBB32mSehyu8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=XtmSRYj1; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf16.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716990356; a=rsa-sha256; cv=none; b=cMEidWcxIBArgNGlpyYQusG56vh5iTmRS0C42G53Stc6/O5FrEw8kUExbvy33jojZ0/FPp FNKBKTZMx+husbobV92x8cQPdz/O2ncoHsKxuw6DvDH8akau072vfvQCrdXMgL/RZADPe+ NokxP6idrizEjfX1GRufmeo2uz1V8rc= Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4Vq9dD5WLlz9srg; Wed, 29 May 2024 15:45:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1716990352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1QtcK2fxbZ+x1HZw3p1m35+0G7d81xL3TX3Jwuj1ZS8=; b=XtmSRYj18h9+1ShKisqhJuhbvmFNCkHXkrsU/DwgyRVYGbZx8dom0yMEQL7U9ngd+ACH4q cxANxsQsXNqDYf8t3VO+RKQajOU6g5SL1w1u7KAPSRb/8t+qJDmTlMMY5mgfCtJmjGkyar bdQ9ZZcUFfZKkPiJLjPDGura3CWpql6cfv3N9B0ri29HyUB6pM3I8nI/LJyKIPoAZ3mzUS Mfp5TcBEP7f0p6iI0cliKqVakwYXw15t2f0GrFMq7FtHYWmgIjbsMbjDuueEkNec3nLCXO UdBFXpbh1KzrRFqCrVS6KA2ZvQiIe8nHUUkiYFbT3YhJndAYblsnR1RihCReEA== From: "Pankaj Raghav (Samsung)" To: david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, willy@infradead.org, djwong@kernel.org Cc: linux-kernel@vger.kernel.org, hare@suse.de, john.g.garry@oracle.com, gost.dev@samsung.com, yang@os.amperecomputing.com, p.raghav@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, mcgrof@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Dave Chinner , Pankaj Raghav Subject: [PATCH v6 08/11] xfs: use kvmalloc for xattr buffers Date: Wed, 29 May 2024 15:45:06 +0200 Message-Id: <20240529134509.120826-9-kernel@pankajraghav.com> In-Reply-To: <20240529134509.120826-1-kernel@pankajraghav.com> References: <20240529134509.120826-1-kernel@pankajraghav.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: D436B180029 X-Stat-Signature: trwmmnzabcdgx9gwcryj4qi9buhsn3ma X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716990355-888296 X-HE-Meta: U2FsdGVkX1+EpLT0NH3jr3hu9K0jkd4fm7t/LEJdnocvHP/1JcELXMVSWC6wyDevqyijNV88iwu+pQQEUWjAL43I5OfBk2LQFexr5Eb5x7TI3Iu1TDcHCXtDfrJFnf45EBNDCChc4my3fqOqXuE1++gV5s3SL+em8lH32IUwTHgCb6c21lLXwfF5Z9CNbHcqbAoN9wifS2j6X9gb5ht2kseTVQWvUMnhYVoaLK25zosysafHL9s8SDlJD0QSLtqLeAROQDqcsXqqljoo+573I6peRYXALfOEXMR3k+ajenAE8WoDizlzNR+yAoiZFuNP2UGiIAbO2a1etkHWV4TSXzLj4BMSWXK+TFp3xfpEZdXs+UkIHbNCVSipaCPdLpnMyKlfAwgvHBAzfzr+QbVjgSDUeawt4nr5qtj4LI7YYt8xAIO0GtD4mlpvBRwUr1K6CKIE7MSLPqmOb0eMuYIw5zIf0gECVCQIXq6/iO07y8yYJYYKDH33OO3nHSEbZbRVOQcLhZDNHjFwBwZNlGw9R+RYlxRbceLwgiQmHaA+qTtxlcvfVxslwon7clVAmAqEyigWrwWEWABd+R5dy2AtLEDIs1lEnbJoIz1tU6Y8re/LlZFvVFARijaE0uTlXeBzEK8g6DtmQAhKFpw43e5gEfZycLZ/e/ncupbt2t4+EH8T0kZ6BgQK+xfJKWKJVsap+NHn4Mk+VFxL+htgNXBkOmK1nQXKDn89+6K02F1/nklYdup0yPFRiHkXWE9xZ+ojD0PDcN/weGSwRb7mreQlHsTk9dA7ON3pmXOl7AB9f0bMMdtmqdQAQ4+nH3kPhOirdyNlPdqlOJBA/IIPdQvOBdSPvFlIFlP6nhCOT4qUMzujDxNoUjxGsW++I/wwF25ZUUoUfh723kuushwwAwHxD8kKdLMZ9M/GKWXSnjIkKe/0FCWA8owIVNVLgR7f71GUHBvxZHnPzTveNZzl//o mS/iCB2e Q18APMZajC5na/qQr88zRRCOCYgyRR/s/4RryJz96gLizyy056qwIu7YlmwtBSoF73P5NHCnS9HH7YSKCnHreccA+kPgxr9g07F3usvvOpg39thAHbUrloifH8Wvay5rY3rELUb+Jxx/SMmlvpjOFW2isgaoTquE1ou17hy6gxPsUqGwc5ER5Jj4iXUXvctp7FoU1aN644J2YEup0Ua12tsKrzE5rTiYheV9lS3FJfcleOc0uz/kOBu+9W71ApeAjpM/bOge8jndFh5+LgE/8NjeJR1cjbBaTAaLUdFafTiIkVOcxayZ0IBqV61HJOPHpAeX2COQxBpMVnob5Oo7seRRpx2k+NINPpMFhPdzDyp7hKfM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Dave Chinner Pankaj Raghav reported that when filesystem block size is larger than page size, the xattr code can use kmalloc() for high order allocations. This triggers a useless warning in the allocator as it is a __GFP_NOFAIL allocation here: static inline struct page *rmqueue(struct zone *preferred_zone, struct zone *zone, unsigned int order, gfp_t gfp_flags, unsigned int alloc_flags, int migratetype) { struct page *page; /* * We most definitely don't want callers attempting to * allocate greater than order-1 page units with __GFP_NOFAIL. */ >>>> WARN_ON_ONCE((gfp_flags & __GFP_NOFAIL) && (order > 1)); ... Fix this by changing all these call sites to use kvmalloc(), which will strip the NOFAIL from the kmalloc attempt and if that fails will do a __GFP_NOFAIL vmalloc(). This is not an issue that productions systems will see as filesystems with block size > page size cannot be mounted by the kernel; Pankaj is developing this functionality right now. Reported-by: Pankaj Raghav Fixes: f078d4ea8276 ("xfs: convert kmem_alloc() to kmalloc()") Signed-off-by: Dave Chinner Reviewed-by: Darrick J. Wong Reviewed-by: Pankaj Raghav --- fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c index b9e98950eb3d..09f4cb061a6e 100644 --- a/fs/xfs/libxfs/xfs_attr_leaf.c +++ b/fs/xfs/libxfs/xfs_attr_leaf.c @@ -1138,10 +1138,7 @@ xfs_attr3_leaf_to_shortform( trace_xfs_attr_leaf_to_sf(args); - tmpbuffer = kmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); - if (!tmpbuffer) - return -ENOMEM; - + tmpbuffer = kvmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); memcpy(tmpbuffer, bp->b_addr, args->geo->blksize); leaf = (xfs_attr_leafblock_t *)tmpbuffer; @@ -1205,7 +1202,7 @@ xfs_attr3_leaf_to_shortform( error = 0; out: - kfree(tmpbuffer); + kvfree(tmpbuffer); return error; } @@ -1613,7 +1610,7 @@ xfs_attr3_leaf_compact( trace_xfs_attr_leaf_compact(args); - tmpbuffer = kmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); + tmpbuffer = kvmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); memcpy(tmpbuffer, bp->b_addr, args->geo->blksize); memset(bp->b_addr, 0, args->geo->blksize); leaf_src = (xfs_attr_leafblock_t *)tmpbuffer; @@ -1651,7 +1648,7 @@ xfs_attr3_leaf_compact( */ xfs_trans_log_buf(trans, bp, 0, args->geo->blksize - 1); - kfree(tmpbuffer); + kvfree(tmpbuffer); } /* @@ -2330,7 +2327,7 @@ xfs_attr3_leaf_unbalance( struct xfs_attr_leafblock *tmp_leaf; struct xfs_attr3_icleaf_hdr tmphdr; - tmp_leaf = kzalloc(state->args->geo->blksize, + tmp_leaf = kvzalloc(state->args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); /* @@ -2371,7 +2368,7 @@ xfs_attr3_leaf_unbalance( } memcpy(save_leaf, tmp_leaf, state->args->geo->blksize); savehdr = tmphdr; /* struct copy */ - kfree(tmp_leaf); + kvfree(tmp_leaf); } xfs_attr3_leaf_hdr_to_disk(state->args->geo, save_leaf, &savehdr);