From patchwork Tue Jun 11 14:49:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 13693871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30BB8C27C77 for ; Tue, 11 Jun 2024 14:49:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B071F6B00A3; Tue, 11 Jun 2024 10:49:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8F686B00A4; Tue, 11 Jun 2024 10:49:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BA986B00A5; Tue, 11 Jun 2024 10:49:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6EBD26B00A3 for ; Tue, 11 Jun 2024 10:49:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 231181A126B for ; Tue, 11 Jun 2024 14:49:37 +0000 (UTC) X-FDA: 82218891594.26.1F25F42 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 873661C0009 for ; Tue, 11 Jun 2024 14:49:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718117375; a=rsa-sha256; cv=none; b=odaKwXmXxrCkTUAGq+o/eSdqHiS5qTw+7HJ18y0Nvcyl634dc6yYqpptu7BcqJ4sRdUVv6 y2gugWgiZwVqb3dZz5PDfLCN7M8bSQmAwckbfrv1YipDy7RA/e7m1Yyt6Gn2I7jGCzIM9x bVkWllxni0098jV7ckV2tRDY4CnUEDM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718117375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references; bh=ZR5VQ90ZVMnvrAnWcqdc5KE2OBHygirUwjTUkw3SWgM=; b=4YG6t6gRRcSZSdhTqmofndWK61XZFNr4e/cEHBMfW1gM/KRXMIU3AmvuZoX+pyuxpJOhxm oIAz4s1g2VCIsLZbN1gYx5fQcYj6ZtlBNv3V4UcXpwa19MqdOjsPD9qMWQyqVoIgALgseS UQdNqyfdladqos8jLWR7KKtSF3hz/8s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5229D60EE9; Tue, 11 Jun 2024 14:49:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C55C8C4AF61; Tue, 11 Jun 2024 14:49:33 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1sH2on-00000001OoA-3XSY; Tue, 11 Jun 2024 10:49:49 -0400 Message-ID: <20240611144949.703297941@goodmis.org> User-Agent: quilt/0.68 Date: Tue, 11 Jun 2024 10:49:13 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel , Mike Rapoport Subject: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option References: <20240611144911.327227285@goodmis.org> MIME-Version: 1.0 X-Stat-Signature: shtp8p84567heayos8t1u5toyda8r9zb X-Rspamd-Queue-Id: 873661C0009 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1718117375-191264 X-HE-Meta: U2FsdGVkX1/Vk3OzA8u7S032RUByu8NW02eCvDj2epUGGAq6dz3OSLWgMAVUZzAe5u8GF5Rubo2B47uNGrz5JR69jTNTLZjyzY2AADzvA9pbxsHraG6BfSxWbXap1vQ/A1OuvuIEip7sjo8GPCNwIhjguXy/tcxMQDuEXSIO2LDPT+yLrnOwr7CAkRLXYQhlj9X3EBPbsXrUfjFKBxsz2UtWkyned+YC/SgOJH/rpd0fyCc/cAuVOgbMpTrlPlkhM9QqCBvKZoYAFxpZ/SQIe1/ekMWcO6lsDnuDawYOcZC7JObF5WXbM8meNISc+qx4fNkFww2tvo47feus2Sr5BiBSAKXGkEEavDoodfdk//DVpMPOpm9paJlpKQhsLOA3N748E+PwRi0gpTzDI+lnFFd7LrblTtMhoWmCq7Wxwla8ke1JS08JdLguwu6ANn21t0ACb3R9gHPre6FZMbFq43ZTLnVVqQ1SaFtGLm+b+2W8+Wg2uyMI9ixBdCbdjFH4OXuXARZWTGl32zhPgvjWXzfChJbI7mhn8IJMM8h/Ic3iPcikQWkEHiMVaQ8b77tgeNxytTC6gpkQPOcPsj3mFfk5T4ihoW/kLL9SPu55U8mAG+N6nT0nkxhejHwTdC8hXRjGLX39D44iljiY+Lfj5a1Zk/hAuto8w/Rnm0q1wQb1XMiv9UOWmoqmy4c1DUomFLKEu58bj47fEmThrDw0ty7ipQHjAsO4cLI8R+bfoTVAHJtmBNo0dt2sdg+T6clOBsdZe2M2CUZqU1U/vqy1tXEHYRItR8uTa9/7YmerbTf1NWf20yVOMdB0hPgtfApyrmqzqpw7pE5PVbaZ/PkgE6cqNC00QNJ5ZqjRup4iYj72EA1B7DvOE9tq8yuLvgPo7R+d/vneM8ijsCs1tm0XbMVocUG5x8rAmR4VPdn3OZcSkGkrI+m37am9kn+J2MIPh/OO62LtHdHgY5jYfXL DKqnJMmR VnOdSydTiBbmgTYudsVjpjNLvipRzwvrOytQ86hSkX3loLuvOzplmk/WqWpmvJxQDYoTWJGZQJqZgO3PBBgzBloZhn0OcXBZAJ1Q5PX2upRLBHH/5VcDPqk9Rug1n2fpUootsdh/JfljJNMMcKA3ukAJkDxB7lgw+KJ3W0NY4XiklEoZQC+kcu0ocohBpW1qSXzWSVufRN5tFT8WIYk72FkeqK0KZlQe46S1y3jxS25QS8RtlKLEAceN456qOkic9HSxbqechaF02EwrI7AwBnAqbykhLGqb8Djb6wBM8vuTzDQ22KzVIiIBV07VS7qZRqoY9Ubui2FDOssVjSjQRehd194OkBo/xssR1Agb7UQf3uFqoXVcGWK3vECuq5N2kWNGgfy4O1npi7X8Q6kOWnG8bmi5xpWbxHVf6N/Z1vix+N7T1LWyuUNBg+40M+0UbBR96E2bgLjpyOqQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Steven Rostedt (Google)" Add a method to find a region specified by reserve_mem=nn:align:name for ramoops. Adding a kernel command line parameter: reserve_mem=12M:4096:oops ramoops.mem_name=oops Will use the size and location defined by the memmap parameter where it finds the memory and labels it "oops". The "oops" in the ramoops option is used to search for it. This allows for arbitrary RAM to be used for ramoops if it is known that the memory is not cleared on kernel crashes or soft reboots. Signed-off-by: Steven Rostedt (Google) Acked-by: Kees Cook --- Changes since v2: https://lore.kernel.org/linux-trace-kernel/20240606150316.916395285@goodmis.org - Removed "built-in" from module description that was changed from v1. fs/pstore/ram.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index b1a455f42e93..0653b76c70fe 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -50,6 +50,10 @@ module_param_hw(mem_address, ullong, other, 0400); MODULE_PARM_DESC(mem_address, "start of reserved RAM used to store oops/panic logs"); +static char *mem_name; +module_param_named(mem_name, mem_name, charp, 0400); +MODULE_PARM_DESC(mem_name, "name of kernel param that holds addr"); + static ulong mem_size; module_param(mem_size, ulong, 0400); MODULE_PARM_DESC(mem_size, @@ -914,6 +918,16 @@ static void __init ramoops_register_dummy(void) { struct ramoops_platform_data pdata; + if (mem_name) { + unsigned long start; + unsigned long size; + + if (reserve_mem_find_by_name(mem_name, &start, &size)) { + mem_address = start; + mem_size = size; + } + } + /* * Prepare a dummy platform data structure to carry the module * parameters. If mem_size isn't set, then there are no module