From patchwork Tue Jun 11 21:55:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiaqi Yan X-Patchwork-Id: 13694214 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DEEEC27C78 for ; Tue, 11 Jun 2024 21:55:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51DF06B00EB; Tue, 11 Jun 2024 17:55:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC7D6B00EC; Tue, 11 Jun 2024 17:55:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36EBE6B00ED; Tue, 11 Jun 2024 17:55:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1940E6B00EB for ; Tue, 11 Jun 2024 17:55:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 954CE407B1 for ; Tue, 11 Jun 2024 21:55:52 +0000 (UTC) X-FDA: 82219965744.20.DE3446E Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf24.hostedemail.com (Postfix) with ESMTP id C98DE180003 for ; Tue, 11 Jun 2024 21:55:50 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=acjaPvW4; spf=pass (imf24.hostedemail.com: domain of 35cdoZggKCFI32uA2Iu708805y.w86527EH-664Fuw4.8B0@flex--jiaqiyan.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=35cdoZggKCFI32uA2Iu708805y.w86527EH-664Fuw4.8B0@flex--jiaqiyan.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718142950; a=rsa-sha256; cv=none; b=BPxY0hhINcxuw1qK0rCAaxeWaWiGCZFpqG69dtPI+j9QdDYEF5WfkjJJYknu9vuP/nqg0m N15BGVYOpduwx3zJYhd7wYP/QO24KwFEGp3r8q/qMX31L5MBNNKwUW1WMFrm4q5frL9K26 SxNLysIz1eyrJeOh3uX+BbRbPVhMStc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=acjaPvW4; spf=pass (imf24.hostedemail.com: domain of 35cdoZggKCFI32uA2Iu708805y.w86527EH-664Fuw4.8B0@flex--jiaqiyan.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=35cdoZggKCFI32uA2Iu708805y.w86527EH-664Fuw4.8B0@flex--jiaqiyan.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718142950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mS9HbFalMzShQT+POycEgy4uFajHDbIF3DAxgE060+U=; b=cMfKiIW9Sqq8iPhZH8CUxPfNIFFQwil4r2lJ/qvE9zRDBlw2Tacm7xhhD7h/K9zkATKXkU QS1nufp63ueOUBM6yu4ylHmVM/SYLdf6IFLEXfqiP1S0+b6RzAh+wpfp3ryasbcAmqVVsi 6ot+FOYDrBRQQWw/wU+61Lc89qqzh+o= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1f66f2e4cc7so16462045ad.3 for ; Tue, 11 Jun 2024 14:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718142950; x=1718747750; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mS9HbFalMzShQT+POycEgy4uFajHDbIF3DAxgE060+U=; b=acjaPvW4JPWTn8GgwW88AEiiYtGlJ/GEYTCTsI+KRA1SGNlGguR/SYO2pQGPNbt2Oc ro8sHpxNvcXKNc7KxBxsNDNUbX1Buhh5+EFgIPYEQg7ZyG932OpmJwJQ6+OaQfydiKZI Jf03tGLnB+beqpHs196F29rshsjKX5q3XLAiv5iHeL1TC5NsrqPrC2nQ5GFzUofys2R0 5Y3vuKYNt3NbqPNauHe6D+UJuTZ78F+AF95h/YJpyNL2iJufnJ2Cf+VS6IytKUTwYi6v 35t1dT0XoYlFVCioHHRhJ7TSDOYuG5vqOaBzt8otFqwOMSdEJ5OMcsNH3qdCjgwr3bhz N4mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718142950; x=1718747750; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mS9HbFalMzShQT+POycEgy4uFajHDbIF3DAxgE060+U=; b=uEo9gFnWRM1xwaGWF4Xw1uau13qv4CwInrTSVE9fqifPHdK339Yr6ylvE/TZm5rnwq +tZpjL3iyPsmiRFmvVVeFKSawA3LMr2O6Vv2C5CR/ZQMgGhwuLgaAEOSpnS5qZEOQ1cm 0TpRipMt8VsgN4EX+X5brsAm6mX6awv3kCo5Yinrk57l0APQLPgRHEJRi88nM1aC7iBy 6xuIih4xt3jTnDojR9PhcLW5eed5F4+oXpok83Fv7y2vRQwPY/Y2Yvf6+QAB3ZleH0CQ e0UIWWkzBHSSDYzIizeNZmhuXIb7oRvIeQg5LaeYM4TGnzyzGQruUhTpYL5wzpClpFSA bWSg== X-Forwarded-Encrypted: i=1; AJvYcCXeHv8B5CQgJIEG8fJiyy+Z017O85Ml0Jhf8ofwVeltErrxJTdDwpvG7qQh1OfHcM18r6wwFScex7JGXFllx6mj8QU= X-Gm-Message-State: AOJu0Ywg5/BB1ePizLn6HScqOACdaU94VUV+vBhcUQKkyeB1EFUA63M/ 1IlT4yUskbzBIkIkn7u17PbsUHKPb9yTD82UPxUF+ZOq9ETlIzukzW0gL1X++Grvani6s/n+WJm Zi5OufBI3fQ== X-Google-Smtp-Source: AGHT+IGVkIg7JWk4rLuAJDkogTWXTNBHCMXhvn7voGGCzQonk6iU8r5R/xu3mAl2mpNPj9KUz+/q9QkmMw61NQ== X-Received: from yjq3.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:272f]) (user=jiaqiyan job=sendgmr) by 2002:a17:902:c411:b0:1f6:daf7:1c18 with SMTP id d9443c01a7336-1f83b5da3b1mr6705ad.2.1718142949584; Tue, 11 Jun 2024 14:55:49 -0700 (PDT) Date: Tue, 11 Jun 2024 21:55:42 +0000 In-Reply-To: <20240611215544.2105970-1-jiaqiyan@google.com> Mime-Version: 1.0 References: <20240611215544.2105970-1-jiaqiyan@google.com> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Message-ID: <20240611215544.2105970-2-jiaqiyan@google.com> Subject: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages From: Jiaqi Yan To: nao.horiguchi@gmail.com, linmiaohe@huawei.com, jane.chu@oracle.com Cc: muchun.song@linux.dev, akpm@linux-foundation.org, shuah@kernel.org, corbet@lwn.net, osalvador@suse.de, rientjes@google.com, duenwen@google.com, fvdl@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Jiaqi Yan X-Stat-Signature: cqehetiije7c9euytzu4t46do8eirt5i X-Rspamd-Queue-Id: C98DE180003 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1718142950-322955 X-HE-Meta: U2FsdGVkX19pkWGZ1fj5/h5ILfZkVadehskHivAwHGnMf0KFdng2FENSn186gY6lhn6o4GQ34bzhWl8XdkKaAz7BZXmgNAGVr7nCPM0mbNdh2SYpo082bnnulrJhYa4o5Supdhh4IElwuL8UURGxfmdcrhaOZmJ/OCaNWOhJiSmwK55+DbI863m4SoAK2+wcw0hDc5U6A8dEKy6DemstVf9Cx1V2lJ82pmNwsYVw26wigvI95RU9hQcg/V/0er1c5W+2LwJ/OggLgc/Xojh64Rw6uPoeWPCnGFN4jh3Xh9TPpdyFoK2Ql9eaWoCAR3g9A19sLkWAAjasHARWHAMZialKiD4QGuWtJ53R7lkfMIvEvhlonQx9mC89QkIDRUDyr6p00YYLs0VkMWIuOLvnenVX/1Ulfwlu0XpT+iupKbi1SOb+wSl8e5tyreYruH3po2LmdJpoGAXYVRQArAS/RpEJgPmi57bqqfZK5G7bvgxRZRNOECRMHzS8MQ2i1/CVzXbQGAdkXOXTj2f1H0k1Yz6XoOthbRdFQ8JAH0Yc/FckJGNrNbmotMyMLTLp3m61pQJ88hD05jkNtOMZurLbqapt3kdJtBZzGz41u/TDGYhH/XaDyEqOYa0mDI0rR2vMdsNtd5VTV3YzsUC/jOOabjYeio9ep4eYGngjKyOdRy01YiuYkACcv2k4PZNJka+k+eo68HLhQ8QF+a/pB/P4O/4OomueW97nmHfKY0N+Me5RxbuFpnUfbpyONTIt+ovSSsUK1/5eeyLLIaitMVM+TCCH+Q/Nkh7wI0TOYKwT8v80+Kv2nNSL1WA3L+zqiWDlAiiyqkppiU7wf0WXVyifScaccAUjMZnBXYX2FQ9EsYQlPRPv2jhUkCJGgQ6S2nAcedRHwjg/3A2gJx+fs9zM7wArARI9VqDYU3tf98hsSPL6SlUvxfDKJJU09P4GvulYBQPifn/XMfW9ewRaja+ 4ZaZ/WTS jEaFGsKD4MqpZbA+IiPk0ta/uavt33Xu9xZuQsvYUWTAyTBtfohWbs6W98o3siLHwg0Escfy9h1gA1XsgSzl4ldPp+4CacP0Db4eYLpB9dD167V+/3DhuRZqyidkRD5XAb3GmQZfw5l46vP6qF5vSxt4DdDrvjUIJy0UdK/YmoI4T4wWpo1hY74cmg4APNIKPaoPMr1DPft5HGYP0KIZEyqyDBA8Gmu8NQOh3p92cMMEl8RwUP/dz5yqf9YpK1zG1PGgeKdwVLu2EiBOupCKPHRUDntlAVWQftUA1gtfflmaWxnFzYHwOzs+FKdVYA0A2/sLaY64GzmBt5xYWaZ0ZHfYrPcPFsKo2+gUOdy4hK+cGP6lmZxXN4BhOx/U5Q0L7STmMnTszA1AarWRxwZad+Ujv1IYrLWf5obAbCC/jcpYaLOnJJp6g8HAxOSAgAnMhROz6adV3I+MIzgPWa08Dw3iQrUzs+xnLYFBxMW364czEqrgDqcdODHFhvR43w2vBnJyotGj3Sye3MhZoMQSb1+F9jV+km0lp6v//dqZlug1WmSzBxhpEGDficXZSGdLEXyTgDnxL8vITe7ayGJf/Y8Bpi1TUkSiiwfYD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Correctable memory errors are very common on servers with large amount of memory, and are corrected by ECC. Soft offline is kernel's additional recovery handling for memory pages having (excessive) corrected memory errors. Impacted page is migrated to a healthy page if inuse; the original page is discarded for any future use. The actual policy on whether (and when) to soft offline should be maintained by userspace, especially in case of an 1G HugeTLB page. Soft-offline dissolves the HugeTLB page, either in-use or free, into chunks of 4K pages, reducing HugeTLB pool capacity by 1 hugepage. If userspace has not acknowledged such behavior, it may be surprised when later mmap hugepages MAP_FAILED due to lack of hugepages. In case of a transparent hugepage, it will be split into 4K pages as well; userspace will stop enjoying the transparent performance. In addition, discarding the entire 1G HugeTLB page only because of corrected memory errors sounds very costly and kernel better not doing under the hood. But today there are at least 2 such cases: 1. GHES driver sees both GHES_SEV_CORRECTED and CPER_SEC_ERROR_THRESHOLD_EXCEEDED after parsing CPER. 2. RAS Correctable Errors Collector counts correctable errors per PFN and when the counter for a PFN reaches threshold In both cases, userspace has no control of the soft offline performed by kernel's memory failure recovery. This commit gives userspace the control of softofflining any page: kernel only soft offlines raw page / transparent hugepage / HugeTLB hugepage if userspace has agreed to. The interface to userspace is a new sysctl called enable_soft_offline under /proc/sys/vm. By default enable_soft_line is 1 to preserve existing behavior in kernel. Signed-off-by: Jiaqi Yan --- mm/memory-failure.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index d3c830e817e3..23415fe03318 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -68,6 +68,8 @@ static int sysctl_memory_failure_early_kill __read_mostly; static int sysctl_memory_failure_recovery __read_mostly = 1; +static int sysctl_enable_soft_offline __read_mostly = 1; + atomic_long_t num_poisoned_pages __read_mostly = ATOMIC_LONG_INIT(0); static bool hw_memory_failure __read_mostly = false; @@ -141,6 +143,15 @@ static struct ctl_table memory_failure_table[] = { .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, }, + { + .procname = "enable_soft_offline", + .data = &sysctl_enable_soft_offline, + .maxlen = sizeof(sysctl_enable_soft_offline), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_ONE, + } }; /* @@ -2771,6 +2782,11 @@ int soft_offline_page(unsigned long pfn, int flags) bool try_again = true; struct page *page; + if (!sysctl_enable_soft_offline) { + pr_info("soft offline: %#lx: OS-wide disabled\n", pfn); + return -EINVAL; + } + if (!pfn_valid(pfn)) { WARN_ON_ONCE(flags & MF_COUNT_INCREASED); return -ENXIO;