From patchwork Fri Jun 21 00:24:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Leoshkevich X-Patchwork-Id: 13706564 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96719C2BBCA for ; Fri, 21 Jun 2024 00:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D604D8D00F7; Thu, 20 Jun 2024 20:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0FD18D00EC; Thu, 20 Jun 2024 20:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B89AE8D00F7; Thu, 20 Jun 2024 20:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D2508D00EC for ; Thu, 20 Jun 2024 20:26:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F126E1606E2 for ; Fri, 21 Jun 2024 00:26:46 +0000 (UTC) X-FDA: 82253005212.09.8C32B33 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf21.hostedemail.com (Postfix) with ESMTP id AEE971C0008 for ; Fri, 21 Jun 2024 00:26:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=h0Zvssk6; spf=pass (imf21.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718929595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3hDUyT9rvjh/uqttZeOy24s2Df+NNUjOmmqDaE5+6Vk=; b=Fx/0bUJMMyUd9fzDdIcrfChiYrfDCnI4sU+BLkWfBMS2EmZIYuY34JXJzF1PFbN3+n7CYV tJFZ0mpQbzw1COIPJvKZ8pWGlexoa/CBnxo51UMQxPl8kMReIiHLUbLaZjYX37BERFza1+ EsQZWUjv95/6dHq7NzLIyNMwEpCCWig= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718929595; a=rsa-sha256; cv=none; b=S5i3xAy4bNxo1rpf5vSThVItVNpr47MXqHmVp0dWo96V/q0tUA9rq+uYt/0qIwNcGAeZvl qvmi2Bu+Xz7GT4iOEQeieE7Wr/GaWxdw6yXy/fDgWCHFCjLsAyQt7czO0/IQog2krWe3Pn a0nPzvSYlwzOLcPSeoeLo+ukyaG/Rao= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=h0Zvssk6; spf=pass (imf21.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45KNSUVn000458; Fri, 21 Jun 2024 00:26:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=pp1; bh=3hDUyT9rvjh/u qttZeOy24s2Df+NNUjOmmqDaE5+6Vk=; b=h0Zvssk6U31qRBTvZ/Pep/F4zOG0K UMB+ltMG9SJ3UggEFvoAJ5AKPGn4mpzEhBQuM3OcoBV5mfxgW0+h6XdotimhQlqk +pELs0lzCnCQS2yvB46M5gVhI64pV53Rq71bjpy4OvrE4uAarl8+UOTG2EKdX7JI 0Zw2IW9a+UG1Ayn7x7zQyt7ZeexSF9Vbk9xcuMSyGwuoijUhKu+GkZh6rXN/LIkX W7ZaR8WhLDcweillMTLmQx7MsOx1fcg/nx7srbr0Av/UI1OejqBuB6HSa+z7438j I0VEw4cNTnnAaJnhT04NFnCgscpsJifpLcjlb3GFFqeXXRwkbAG3tUidQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yvw8c0704-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 00:26:37 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45L0QaeN022669; Fri, 21 Jun 2024 00:26:36 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yvw8c0700-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 00:26:36 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45L0G6WD031351; Fri, 21 Jun 2024 00:26:34 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yvrrq2na9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jun 2024 00:26:34 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45L0QSun21299646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Jun 2024 00:26:30 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A3E020043; Fri, 21 Jun 2024 00:26:28 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6ACD22004D; Fri, 21 Jun 2024 00:26:27 +0000 (GMT) Received: from heavy.ibm.com (unknown [9.171.10.44]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 21 Jun 2024 00:26:27 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v6 07/39] kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() Date: Fri, 21 Jun 2024 02:24:41 +0200 Message-ID: <20240621002616.40684-8-iii@linux.ibm.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240621002616.40684-1-iii@linux.ibm.com> References: <20240621002616.40684-1-iii@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 9aqDnYqiZJrIWgkclNbtCMnokhICs_wR X-Proofpoint-GUID: M6kl4HuHEuc2TVbCgmc2mbFwZv4B5LNB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-20_11,2024-06-20_04,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1015 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2406210001 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AEE971C0008 X-Stat-Signature: 9ntm3ghf88i836ma4sgjhoq9p8zbtemb X-HE-Tag: 1718929604-24761 X-HE-Meta: U2FsdGVkX1+HQsQJFP637HThC1aks6Wuy0DLJPB30RbCv9RwEWd6ui1xlHezRNq70MlEtied87b6ruAk6W3usm8hivKi42V7hUR6c8tkosylB+JpikgQi9eh0BFJuRpdxQpEzbAAiVJ4RHUVgb2IPTFb+GEQDFQ446OTdrj2h1vSYGw1u7NqZISqeseUfU+ushV+1gXeze8t03SsbZb6UQF+OA+WYl4VOADY+BjowHkPARdvz6BT0Mw3XoU1VyPqh9DXCtA23GFCAprifK1Cujx0b8KL2xANwrZIx0wm1AFloUmYUmSTIjQECANeLi9o1+/ZHANczI/A7wEEv0QZeomgyK+ht84oLarXijbJmv6BIPYK2fkJBNFe4Bfz7Q3GNJbYwF4e6Zsp+4cUmR2FqCvrTPDaGJf3eqAJd/VmWew5tC7vGTSAsQAUh0F2nI068A44sOCU0BNAGfWfw3f9x/LjZzcEPfQ+uC10TNSQ8tL1czOHBbJd5VSDVPNtb30s7NKlHFBPaTQyRFkzK+x2MzZpBafkfAB+hZoCtDS4ikyRBx4bDiHXsAq1jG2Moa0kX2ELQb7hmFA9WXgt7brwT3f/5g5gueYuVwb5PGvafJHN2XW2mYImqbroxDWDgLltzPkS3oI+osFgZvZS6Ziv0rGaADGaIN+cxggENeyB9zrd2HEQ9gskSqfuDGhAn/ZEnf5sCBA72Kj4UcLwtw1gInA0SwhbBA/ZVA8yTrTlp1sAmSlIL8Bjl1kdK7/F/qvedqHiEbzRIi1rIKDdA2lVSmI7fUWho7+lYQqGiaZTA93fObKYaWxV1OIJiPBdXWyw1Scy9dA/Oei59lFiR8zVVEWOQrFQI9Dm5MpVJynIvGAiCZc1FXKQ2a2o/nuIbBPEysoxApr/Nv1N5JdZupYucnKgfx98GZ6CdTupmGie3rufLgTa2SRkLLnI70mmVhrN6wSlmnxm/YkJk0cTK2Y ZerTjKZg me9OEDOqEjkhuLcAbUkTqx1u/5UdM3Ar4s0LK3zJeqqCMIX1CuCtY+3Xc55T20Vp4+YE5mawIkc54ux0NELYFCT91j07k9kSZTYDckfabxAGLJcJjiq3JMUA5Q3HdX81AxM4MCH/thcMBnTLCOwp/3lmFA7s8P427gpvAc66J6ILbmJ1sf0vQuD2bxsPc3lOnzbjDuDb8oPSH8yTzLPdsjlhoPiSSDW7UGzybcPq6EhBpeu5tewawC8bD84nN5exK69O1H72lYkNuWohzJBUpiQrWo2KPQIyw2bGi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000068, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The value assigned to prot is immediately overwritten on the next line with PAGE_KERNEL. The right hand side of the assignment has no side-effects. Fixes: b073d7f8aee4 ("mm: kmsan: maintain KMSAN metadata for page operations") Suggested-by: Alexander Gordeev Reviewed-by: Alexander Potapenko Signed-off-by: Ilya Leoshkevich --- mm/kmsan/shadow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/kmsan/shadow.c b/mm/kmsan/shadow.c index b9d05aff313e..2d57408c78ae 100644 --- a/mm/kmsan/shadow.c +++ b/mm/kmsan/shadow.c @@ -243,7 +243,6 @@ int kmsan_vmap_pages_range_noflush(unsigned long start, unsigned long end, s_pages[i] = shadow_page_for(pages[i]); o_pages[i] = origin_page_for(pages[i]); } - prot = __pgprot(pgprot_val(prot) | _PAGE_NX); prot = PAGE_KERNEL; origin_start = vmalloc_meta((void *)start, KMSAN_META_ORIGIN);