diff mbox series

memblock tests: fix implicit declaration of function 'numa_valid_node'

Message ID 20240624015432.31134-1-richard.weiyang@gmail.com (mailing list archive)
State New
Headers show
Series memblock tests: fix implicit declaration of function 'numa_valid_node' | expand

Commit Message

Wei Yang June 24, 2024, 1:54 a.m. UTC
commit 8043832e2a12 ("memblock: use numa_valid_node() helper to check
for invalid node ID") introduce a new helper numa_valid_node(), which is
not defined in memblock tests.

Let's add it in the corresponding header file.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Mike Rapoport (IBM) <rppt@kernel.org>
---
 tools/include/linux/numa.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Wei Yang June 29, 2024, 1:39 a.m. UTC | #1
Mike,

Missed this one?

On Mon, Jun 24, 2024 at 01:54:32AM +0000, Wei Yang wrote:
>commit 8043832e2a12 ("memblock: use numa_valid_node() helper to check
>for invalid node ID") introduce a new helper numa_valid_node(), which is
>not defined in memblock tests.
>
>Let's add it in the corresponding header file.
>
>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>CC: Mike Rapoport (IBM) <rppt@kernel.org>
>---
> tools/include/linux/numa.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/tools/include/linux/numa.h b/tools/include/linux/numa.h
>index 110b0e5d0fb0..c8b9369335e0 100644
>--- a/tools/include/linux/numa.h
>+++ b/tools/include/linux/numa.h
>@@ -13,4 +13,9 @@
> 
> #define	NUMA_NO_NODE	(-1)
> 
>+static inline bool numa_valid_node(int nid)
>+{
>+	return nid >= 0 && nid < MAX_NUMNODES;
>+}
>+
> #endif /* _LINUX_NUMA_H */
>-- 
>2.34.1
Mike Rapoport July 5, 2024, 8:28 a.m. UTC | #2
On Mon, 24 Jun 2024 01:54:32 +0000, Wei Yang wrote:
> commit 8043832e2a12 ("memblock: use numa_valid_node() helper to check
> for invalid node ID") introduce a new helper numa_valid_node(), which is
> not defined in memblock tests.
> 
> Let's add it in the corresponding header file.
> 
> 
> [...]

Applied to for-next branch of memblock.git tree, thanks!

[1/1] memblock tests: fix implicit declaration of function 'numa_valid_node'
      commit: 9364a7e40d54e6858479f0a96e1a04aa1204be16

tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next

--
Sincerely yours,
Mike.
diff mbox series

Patch

diff --git a/tools/include/linux/numa.h b/tools/include/linux/numa.h
index 110b0e5d0fb0..c8b9369335e0 100644
--- a/tools/include/linux/numa.h
+++ b/tools/include/linux/numa.h
@@ -13,4 +13,9 @@ 
 
 #define	NUMA_NO_NODE	(-1)
 
+static inline bool numa_valid_node(int nid)
+{
+	return nid >= 0 && nid < MAX_NUMNODES;
+}
+
 #endif /* _LINUX_NUMA_H */