From patchwork Mon Jun 24 06:36:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Kasireddy X-Patchwork-Id: 13709042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E38C2BD05 for ; Mon, 24 Jun 2024 07:05:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C84186B042C; Mon, 24 Jun 2024 03:05:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C35ED6B042E; Mon, 24 Jun 2024 03:05:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFB116B042F; Mon, 24 Jun 2024 03:05:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 95FF96B042C for ; Mon, 24 Jun 2024 03:05:28 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 460711A0C3C for ; Mon, 24 Jun 2024 07:05:28 +0000 (UTC) X-FDA: 82264896336.02.31E1AF6 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf22.hostedemail.com (Postfix) with ESMTP id 119EEC0018 for ; Mon, 24 Jun 2024 07:05:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=X+NI0ooL; spf=pass (imf22.hostedemail.com: domain of vivek.kasireddy@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719212712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WcOvBRskDu1PpfQbAOX+SjR2LUy9Zpx+5DJzF+xJ+6o=; b=37emTM9tEvK6zzeRDOUTvAdTsx05UGs+SkTFTyuqy4DCXU9zKC7aWANu2+F7FkJUvQTlZL VhNALcT1vVoUlPh497OO3dVHIJm9rgfW9OkzZozTDftrdpwh0PeOXkwHzLDIbcVEuZgJUK lYIq0xLIUx1jvILXNGg/A5dIqiDvzaU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719212712; a=rsa-sha256; cv=none; b=J9Oj5VwVUMLAZLXMJdnIKyWu2IFofq+Zv+7wf4MCu8uihbRSknTRBSHKc5gAL8aSYkTn8J wYmtHI1LTUjDXSw2CwQvGaN22kLyfpjmH8hNVKmOe90/cuCf9eb696ikS4w9UXJKys4Fb7 cETF0BdBneKqhGI1Umyp9Mhkg1u/fF0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=X+NI0ooL; spf=pass (imf22.hostedemail.com: domain of vivek.kasireddy@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719212727; x=1750748727; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ncdL0L8mJN53zm+PMLx7hY1Hn3m6ZNVipfI63CPcPB0=; b=X+NI0ooLAmMg1g6xGHab9G1tyYrk7iC8bQXfJ32yZhE9DwIpZhc3BpNC NW2DGSfcunx791fWj+4wyb+nto/RhYNh9G2HlYgidZoaddXjOF0zb4reh pbH5iwU+0fsc3MZCyNpdfWouOIVrO6v9i1z1iKiyGrrTchf+jXPpDzrfY ZsPjaUeoBR+6GltYm7HGnWUGSzbsNAWoVpL2oqQZ0lYyk9Y+iT14Kbjco 8rkBocoxWpH1UW51Ym90wTPY0JcyxVcDFarTZO62w4PLTAifRgGXlILyA R03M5l0dn0BYuy+6EQWQR4gL2zGD2LrS4dAL7HaiRBSh5AGxWMYhX1K7I g==; X-CSE-ConnectionGUID: Yv4JQNJEQ1mmy0qo3OboWQ== X-CSE-MsgGUID: XhujnTuxSquQi12gjtlhtg== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="16134939" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="16134939" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 00:05:24 -0700 X-CSE-ConnectionGUID: iWHG8+5/SZe4Yh0rlvYa6Q== X-CSE-MsgGUID: abebW33HS8KZgNZTUwVY2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="73955859" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 00:05:24 -0700 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Peter Xu , Dave Airlie , Gerd Hoffmann Subject: [PATCH v16 1/9] mm/gup: Introduce unpin_folio/unpin_folios helpers Date: Sun, 23 Jun 2024 23:36:09 -0700 Message-ID: <20240624063952.1572359-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240624063952.1572359-1-vivek.kasireddy@intel.com> References: <20240624063952.1572359-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Stat-Signature: jeegw441hdjb9xop99fm9mytnjzop858 X-Rspamd-Queue-Id: 119EEC0018 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719212725-915004 X-HE-Meta: U2FsdGVkX1/F+ckexCCPDHQR+LzhF8D1EUJDdmk7Eb0hTCoPzgY6ziUhP/0AZ2VQibQdWLjLt01UJ9gWMLFGp65IVESrHnyMb4cU8PxAEP4suylZZ/j3879WITDT4c+8PaN6NQb0PkjfTD9ZIlZLG1z1Rr7BGhDrOiuUTee82HIrzyiEFLD/ZsvZXX1HuoQTOrf656MQRsA3em0MFfIX0DmV3twlelvcdKFKfLy93/30plKiOpt7+2dBNijM3xY7T9SgJWAga5bBSIaep08Rd+w1I7wYny5dMH/MmTA/hsn+AnBIXkbeiVBGafDJyOw94DdIcZtCJqtckLP0QdzcW8pN4oGWRgQoTi+WTqJ3sNqKOLTPESkSXzwJwbhN4XugnYRXpUVxPntUFW9B26HkIWsjg9WOkgp09Wzta6+CaKo6d6IPkb4n/KiSSaUoiowoNL3vo/QxmVLXujUslMtkQSgjGAfb9otZ4HBK0PB6ZmlVqGDtg1YxgG3zLd3gGchejjxXIdwQlntW/dr4WDxPTn4C/CWiVUv+1aFN2MZ4zvj2EOH1Uw/m7YdDZ9koh5RXw68DF9J6ZuV86DdQzrIFRdTSqAi30CB/c7gIgsGOfi2Z2Ecd1Fa8ohYTbn2gLT/OE2hn822ox/DRSEI+q2qyNm+o2sx5TuiFycUI7GxpWf07dXvZqkxoY6WT3aQLZYXMPfX9Htys8nAqcWmbHxpNCLbvrTjoztpfPu2eztCtxC8tAhUjZfeX7ppQd4IKrG171IAqT6dy7Tcp1Wg8dRbmRZ5a0pWJQqiCN6nGvN0VddoekgBNFNq71Mg1uaggy1U9T1PfrPOupWUZ7zo4gBI1mZXD1H+8Bac6riUBxG2KfNCLR9XhvayblFGIMEl2LXk4o1G7adwGjPKOADh3XG7UrLlWH2dsoeyCn9Wxjd3x3XJEFZ2rZmbuTXS35Y7ew0cjAY5QO1WgI7CTLhhCJDc qhdh7I4N 8PolAbMeiowBO8eQP3SO82UZAKoVgb1YO3+8C8epxNLEjUPdYWeHLMmkoSKIWc/vItAs5jjm/mBPy/G8DMRGZTdY7DFDJNQ6+TAWxPF1GYA+4s7K7mW0s7KZnq0ozPUec1k7KwvJ3Rewfsj63FqNU4kwy8sW6uko6m+rqTtlMt7W6dKv1nT40RG+gIIRUzdSCHM8foaQ9eYGNAJNr0ZBaS+4EgnDQaMDiveI4MiHb7+hgjw4iRGxuMFTnUS9uy/MBc3IrfV8efZjg6CjNONUAeFGJSxcg2hn/KstLA3SluE1IyFxHhNkJ5zNFyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: These helpers are the folio versions of unpin_user_page/unpin_user_pages. They are currently only useful for unpinning folios pinned by memfd_pin_folios() or other associated routines. However, they could find new uses in the future, when more and more folio-only helpers are added to GUP. We should probably sanity check the folio as part of unpin similar to how it is done in unpin_user_page/unpin_user_pages but we cannot cleanly do that at the moment without also checking the subpage. Therefore, sanity checking needs to be added to these routines once we have a way to determine if any given folio is anon-exclusive (via a per folio AnonExclusive flag). Cc: David Hildenbrand Cc: Matthew Wilcox Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Peter Xu Suggested-by: David Hildenbrand Reviewed-by: David Hildenbrand Acked-by: Dave Airlie Acked-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- include/linux/mm.h | 2 ++ mm/gup.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index f1d3fd02e6a2..c0ee5f7978a0 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1594,11 +1594,13 @@ static inline void put_page(struct page *page) #define GUP_PIN_COUNTING_BIAS (1U << 10) void unpin_user_page(struct page *page); +void unpin_folio(struct folio *folio); void unpin_user_pages_dirty_lock(struct page **pages, unsigned long npages, bool make_dirty); void unpin_user_page_range_dirty_lock(struct page *page, unsigned long npages, bool make_dirty); void unpin_user_pages(struct page **pages, unsigned long npages); +void unpin_folios(struct folio **folios, unsigned long nfolios); static inline bool is_cow_mapping(vm_flags_t flags) { diff --git a/mm/gup.c b/mm/gup.c index 6ff9f95a99a7..d9ea60621628 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -276,6 +276,19 @@ void unpin_user_page(struct page *page) } EXPORT_SYMBOL(unpin_user_page); +/** + * unpin_folio() - release a dma-pinned folio + * @folio: pointer to folio to be released + * + * Folios that were pinned via memfd_pin_folios() or other similar routines + * must be released either using unpin_folio() or unpin_folios(). + */ +void unpin_folio(struct folio *folio) +{ + gup_put_folio(folio, 1, FOLL_PIN); +} +EXPORT_SYMBOL_GPL(unpin_folio); + /** * folio_add_pin - Try to get an additional pin on a pinned folio * @folio: The folio to be pinned @@ -488,6 +501,40 @@ void unpin_user_pages(struct page **pages, unsigned long npages) } EXPORT_SYMBOL(unpin_user_pages); +/** + * unpin_folios() - release an array of gup-pinned folios. + * @folios: array of folios to be marked dirty and released. + * @nfolios: number of folios in the @folios array. + * + * For each folio in the @folios array, release the folio using gup_put_folio. + * + * Please see the unpin_folio() documentation for details. + */ +void unpin_folios(struct folio **folios, unsigned long nfolios) +{ + unsigned long i = 0, j; + + /* + * If this WARN_ON() fires, then the system *might* be leaking folios + * (by leaving them pinned), but probably not. More likely, gup/pup + * returned a hard -ERRNO error to the caller, who erroneously passed + * it here. + */ + if (WARN_ON(IS_ERR_VALUE(nfolios))) + return; + + while (i < nfolios) { + for (j = i + 1; j < nfolios; j++) + if (folios[i] != folios[j]) + break; + + if (folios[i]) + gup_put_folio(folios[i], j - i, FOLL_PIN); + i = j; + } +} +EXPORT_SYMBOL_GPL(unpin_folios); + /* * Set the MMF_HAS_PINNED if not set yet; after set it'll be there for the mm's * lifecycle. Avoid setting the bit unless necessary, or it might cause write