From patchwork Mon Jun 24 06:36:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kasireddy, Vivek" X-Patchwork-Id: 13709044 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D3BC2BD05 for ; Mon, 24 Jun 2024 07:05:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5DD16B00E5; Mon, 24 Jun 2024 03:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B99016B00ED; Mon, 24 Jun 2024 03:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92C7B6B00EF; Mon, 24 Jun 2024 03:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5AA3A6B00E5 for ; Mon, 24 Jun 2024 03:05:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CE1E6C0BB7 for ; Mon, 24 Jun 2024 07:05:29 +0000 (UTC) X-FDA: 82264896378.26.C31E217 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf03.hostedemail.com (Postfix) with ESMTP id A6BFE20011 for ; Mon, 24 Jun 2024 07:05:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Uz5u1qPg; spf=pass (imf03.hostedemail.com: domain of vivek.kasireddy@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719212721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0R4u+8UGf+j7GEB8WEjwL1UKNbyQ2Id2+qiSqpkt7pA=; b=Y4w6SNSK2xfWlXiogT/lBeBzkmcfW4wO5xjUbHUAl6uPXavqHPtqfR3PF4ESbTo2fxPPsJ wS3vK3car3cM1ZAOOOT6rAh4jju/4oKgtfk/yb90cN/tste/iAtcK6ar6DG9euUvIKRF/0 dXx0Ipn097v6mS/8SxO1qixw4ptoZnE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Uz5u1qPg; spf=pass (imf03.hostedemail.com: domain of vivek.kasireddy@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719212721; a=rsa-sha256; cv=none; b=5qt6f+uQdr9S4Z8VWbYSEmI44uiPf4C+4Flp3AEGYfHA5mK0UfcngTy9dwi29vI+MezwFv 6tuwQTZGiR7xG3wofyn0iZOHXzCudvSEocKgh0QN0VOXyMXs9TZENFZA8Bwr63RWUAie7E NKy+dYc0zT8p8WF2Ih9/qOCpAVztm+U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719212728; x=1750748728; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uRaov+u2QvECVr64vlaQOQuZJ9huFgCJS0IymQdZ56s=; b=Uz5u1qPgrzQDd2LA/fPNfTtKFIQwtdLSR/kOwRx564M4494Rp6eWRZQV M3GX2jmstwmlKfAJtGGvF1I2vOjthrG49j/Q0fZjXkvRLlQk+aBdgBeml ZHlnKtDHhO6EHGGbmX3KewoYyxnvF+8zyZ/gOcIMO6qAuwMLgsg8UoaEO D9unHt2GLTauGuAbPIb8Wo/DdrJj4dYakn2v8ZwqcRdQMmv+V3EgRvTKI 46LfCfLE9QkLz6EGpWmm1odjq3m8rYPixpp8hG/elD6SnQnOO25Pjly1k Pf5bmX4LjV7QKpMG7uH3GzE4LL8ZG9DDVv6bQtLbbAQoFkhkCo0uZpHAR Q==; X-CSE-ConnectionGUID: npc1ilKnRB64/P8mErWDkw== X-CSE-MsgGUID: f8ziPbFgR3iVsr2kVMMaJw== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="16134945" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="16134945" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 00:05:25 -0700 X-CSE-ConnectionGUID: 0fviiTFzQO2YaP2pRpoTdw== X-CSE-MsgGUID: HhwAJyebTXOiekSkjBRXsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="73955868" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 00:05:25 -0700 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Matthew Wilcox , Christoph Hellwig , Daniel Vetter , Hugh Dickins , Peter Xu , Gerd Hoffmann , Dongwon Kim , Junxiao Chang , Jason Gunthorpe , Christoph Hellwig , Dave Airlie Subject: [PATCH v16 3/9] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios Date: Sun, 23 Jun 2024 23:36:11 -0700 Message-ID: <20240624063952.1572359-4-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240624063952.1572359-1-vivek.kasireddy@intel.com> References: <20240624063952.1572359-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A6BFE20011 X-Stat-Signature: 7gr57t84a856151fde8tiq754sp6grcm X-HE-Tag: 1719212727-744988 X-HE-Meta: U2FsdGVkX1/jwzzKJ7UPAC0NdKP0+5GgGCmx/RIrozmYkXQVZX+nNAgoiXlw+554HnoeLjJBIE0WcP6Sau2fwNCZHlMr9X7wtVaSI5uaMCjwyPIw/4pJcpVCo6r/3uGitVZ14xIeQS8K5ht8kUB3OupbGiCfywvUpyg9rf7PV73npRKZWZf4482R0C0xDA2C6CcHAZfQaCYA3JBiraO2/xBdjCF5cM+P2ofbetOiw/WL/wYpIDsds3wdMG8RqmZ0XeSHHprXV6WTD3gfQcL6YE9L/ENMgIDKYkX9M+BckCgbEBgCo16K6dbzYGdcJiK/7pKOEKaEvNAtiennfRyv3QX3ezJzt4XR9+UOP1CY/XeDusUpmE53WlYYDjz03RTkF1LANSV6kMl9QWb4ex8HETe27TDj8TZry2E01hG96eop4i9aOEfQOoeVg3Y4/zOyB3oTqiJPmd0amAyryTocCWcsAEBr15bFcqwdYThN3c+0VvIaQFyKCA41eM+A9Y5moX817Sa1EM9eHuG2H24MrLvqxrFYDoF9UuGAFc+u4uJhUXd9kfmUEusqw2oAij975Ni+Z5jQOA+uupCOFOMfeK3ZuUeE7lomumuh3485jizPlo88iDtucqcyDw8a/fG0hOwdfJZoeCdjRmXr+/SXUYAa1VNOCf5UaZx0gj+BaXOf371858rvRvxqaX00U/DpM9k6UnxSp309Ngt9r44oeXOWMZM/2efU9R1i2PMqWpR40VTKk/JYxkNSr37CaRLjbUDBiUcSwoZqIKqy59u7JrLvUydZocQrgmGNllo8ochazQyd8BUJQWcly0Ypp4lgy4mCmuPLgjgTsrhhKsm7GrXqgw6/G5Sdk7euoC9DZNRMXG5lgcXwVHQ13A/zXBqcIB6o3xDcnrb+mnVzLslc3PxyV5V7n1+BeRaG2eeCE1B1eF5pXRiorudVbzwoKWvlLP4YazvDh+n2r70N3FM eKknHRE/ 8ZbWFXnMovM0wIuVZSxzrb5XLMAQ/2qGdqcpO1d6fYRufjykw5HQTCLfh4cwTObelz6wvxVVFLqK2j5QxzvE+Kh3md1raCfPVspnOdy1lFkaEBTW8vy1cfhP8OOigzgBa9yW/5j1F9pc/UegpuzVErUBwxHhxkd0Fen7V7MOyZJTWCby1sRZxbo1EdujuzX2Cq7kq3oUcZ9dHRb1iC0lpalneOak97qr/ZWmxUqxj3EDQj1X65qyT5UQR7N3h6HpD2jsblCyTfahNQThsWbDPVzmtFH9fFUVVbjkzRHAzftJQ6oIiiSOrg3IOiqQY1zuSZgFm7BuooKwkcfY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For drivers that would like to longterm-pin the folios associated with a memfd, the memfd_pin_folios() API provides an option to not only pin the folios via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with memfds but it should work with any files that belong to either shmemfs or hugetlbfs. Files belonging to other filesystems are rejected for now. The folios need to be located first before pinning them via FOLL_PIN. If they are found in the page cache, they can be immediately pinned. Otherwise, they need to be allocated using the filesystem specific APIs and then pinned. Cc: David Hildenbrand Cc: Matthew Wilcox (Oracle) Cc: Christoph Hellwig Cc: Daniel Vetter Cc: Hugh Dickins Cc: Peter Xu Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: Jason Gunthorpe Reviewed-by: Jason Gunthorpe (v2) Reviewed-by: David Hildenbrand (v3) Reviewed-by: Christoph Hellwig (v6) Acked-by: Dave Airlie Acked-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy Acked-by: Vivek Kasireddy --- include/linux/memfd.h | 5 ++ include/linux/mm.h | 3 + mm/gup.c | 137 ++++++++++++++++++++++++++++++++++++++++++ mm/memfd.c | 45 ++++++++++++++ 4 files changed, 190 insertions(+) diff --git a/include/linux/memfd.h b/include/linux/memfd.h index e7abf6fa4c52..3f2cf339ceaf 100644 --- a/include/linux/memfd.h +++ b/include/linux/memfd.h @@ -6,11 +6,16 @@ #ifdef CONFIG_MEMFD_CREATE extern long memfd_fcntl(struct file *file, unsigned int cmd, unsigned int arg); +struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx); #else static inline long memfd_fcntl(struct file *f, unsigned int c, unsigned int a) { return -EINVAL; } +static inline struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx) +{ + return ERR_PTR(-EINVAL); +} #endif #endif /* __LINUX_MEMFD_H */ diff --git a/include/linux/mm.h b/include/linux/mm.h index c0ee5f7978a0..2bdeb94c2a28 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2510,6 +2510,9 @@ long get_user_pages_unlocked(unsigned long start, unsigned long nr_pages, struct page **pages, unsigned int gup_flags); long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages, struct page **pages, unsigned int gup_flags); +long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, + struct folio **folios, unsigned int max_folios, + pgoff_t *offset); int get_user_pages_fast(unsigned long start, int nr_pages, unsigned int gup_flags, struct page **pages); diff --git a/mm/gup.c b/mm/gup.c index a88e19c78730..94160abbf499 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -5,6 +5,7 @@ #include #include +#include #include #include #include @@ -17,6 +18,7 @@ #include #include #include +#include #include #include @@ -3747,3 +3749,138 @@ long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages, &locked, gup_flags); } EXPORT_SYMBOL(pin_user_pages_unlocked); + +/** + * memfd_pin_folios() - pin folios associated with a memfd + * @memfd: the memfd whose folios are to be pinned + * @start: the first memfd offset + * @end: the last memfd offset (inclusive) + * @folios: array that receives pointers to the folios pinned + * @max_folios: maximum number of entries in @folios + * @offset: the offset into the first folio + * + * Attempt to pin folios associated with a memfd in the contiguous range + * [start, end]. Given that a memfd is either backed by shmem or hugetlb, + * the folios can either be found in the page cache or need to be allocated + * if necessary. Once the folios are located, they are all pinned via + * FOLL_PIN and @offset is populatedwith the offset into the first folio. + * And, eventually, these pinned folios must be released either using + * unpin_folios() or unpin_folio(). + * + * It must be noted that the folios may be pinned for an indefinite amount + * of time. And, in most cases, the duration of time they may stay pinned + * would be controlled by the userspace. This behavior is effectively the + * same as using FOLL_LONGTERM with other GUP APIs. + * + * Returns number of folios pinned, which could be less than @max_folios + * as it depends on the folio sizes that cover the range [start, end]. + * If no folios were pinned, it returns -errno. + */ +long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, + struct folio **folios, unsigned int max_folios, + pgoff_t *offset) +{ + unsigned int flags, nr_folios, nr_found; + unsigned int i, pgshift = PAGE_SHIFT; + pgoff_t start_idx, end_idx, next_idx; + struct folio *folio = NULL; + struct folio_batch fbatch; + struct hstate *h; + long ret = -EINVAL; + + if (start < 0 || start > end || !max_folios) + return -EINVAL; + + if (!memfd) + return -EINVAL; + + if (!shmem_file(memfd) && !is_file_hugepages(memfd)) + return -EINVAL; + + if (is_file_hugepages(memfd)) { + h = hstate_file(memfd); + pgshift = huge_page_shift(h); + } + + flags = memalloc_pin_save(); + do { + nr_folios = 0; + start_idx = start >> pgshift; + end_idx = end >> pgshift; + if (is_file_hugepages(memfd)) { + start_idx <<= huge_page_order(h); + end_idx <<= huge_page_order(h); + } + + folio_batch_init(&fbatch); + while (start_idx <= end_idx && nr_folios < max_folios) { + /* + * In most cases, we should be able to find the folios + * in the page cache. If we cannot find them for some + * reason, we try to allocate them and add them to the + * page cache. + */ + nr_found = filemap_get_folios_contig(memfd->f_mapping, + &start_idx, + end_idx, + &fbatch); + if (folio) { + folio_put(folio); + folio = NULL; + } + + next_idx = 0; + for (i = 0; i < nr_found; i++) { + /* + * As there can be multiple entries for a + * given folio in the batch returned by + * filemap_get_folios_contig(), the below + * check is to ensure that we pin and return a + * unique set of folios between start and end. + */ + if (next_idx && + next_idx != folio_index(fbatch.folios[i])) + continue; + + folio = try_grab_folio(&fbatch.folios[i]->page, + 1, FOLL_PIN); + if (!folio) { + folio_batch_release(&fbatch); + ret = -EINVAL; + goto err; + } + + if (nr_folios == 0) + *offset = offset_in_folio(folio, start); + + folios[nr_folios] = folio; + next_idx = folio_next_index(folio); + if (++nr_folios == max_folios) + break; + } + + folio = NULL; + folio_batch_release(&fbatch); + if (!nr_found) { + folio = memfd_alloc_folio(memfd, start_idx); + if (IS_ERR(folio)) { + ret = PTR_ERR(folio); + if (ret != -EEXIST) + goto err; + } + } + } + + ret = check_and_migrate_movable_folios(nr_folios, folios); + } while (ret == -EAGAIN); + + memalloc_pin_restore(flags); + return ret ? ret : nr_folios; +err: + memalloc_pin_restore(flags); + unpin_folios(folios, nr_folios); + + return ret; +} +EXPORT_SYMBOL_GPL(memfd_pin_folios); + diff --git a/mm/memfd.c b/mm/memfd.c index 7d8d3ab3fa37..e7b7c5294d59 100644 --- a/mm/memfd.c +++ b/mm/memfd.c @@ -59,6 +59,51 @@ static void memfd_tag_pins(struct xa_state *xas) xas_unlock_irq(xas); } +/* + * This is a helper function used by memfd_pin_user_pages() in GUP (gup.c). + * It is mainly called to allocate a folio in a memfd when the caller + * (memfd_pin_folios()) cannot find a folio in the page cache at a given + * index in the mapping. + */ +struct folio *memfd_alloc_folio(struct file *memfd, pgoff_t idx) +{ +#ifdef CONFIG_HUGETLB_PAGE + struct folio *folio; + gfp_t gfp_mask; + int err; + + if (is_file_hugepages(memfd)) { + /* + * The folio would most likely be accessed by a DMA driver, + * therefore, we have zone memory constraints where we can + * alloc from. Also, the folio will be pinned for an indefinite + * amount of time, so it is not expected to be migrated away. + */ + gfp_mask = htlb_alloc_mask(hstate_file(memfd)); + gfp_mask &= ~(__GFP_HIGHMEM | __GFP_MOVABLE); + + folio = alloc_hugetlb_folio_nodemask(hstate_file(memfd), + numa_node_id(), + NULL, + gfp_mask, + false); + if (folio && folio_try_get(folio)) { + err = hugetlb_add_to_page_cache(folio, + memfd->f_mapping, + idx); + if (err) { + folio_put(folio); + free_huge_folio(folio); + return ERR_PTR(err); + } + return folio; + } + return ERR_PTR(-ENOMEM); + } +#endif + return shmem_read_folio(memfd->f_mapping, idx); +} + /* * Setting SEAL_WRITE requires us to verify there's no pending writer. However, * via get_user_pages(), drivers might have some pending I/O without any active