From patchwork Tue Jun 25 04:39:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13710594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60EA1C3064D for ; Tue, 25 Jun 2024 04:40:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E10DB6B00CF; Tue, 25 Jun 2024 00:40:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D98EB6B00F0; Tue, 25 Jun 2024 00:40:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC3DC6B00D0; Tue, 25 Jun 2024 00:40:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8F1F66B00A1 for ; Tue, 25 Jun 2024 00:40:27 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EDACFC15B8 for ; Tue, 25 Jun 2024 04:40:26 +0000 (UTC) X-FDA: 82268159652.14.A42B2D0 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf07.hostedemail.com (Postfix) with ESMTP id 8F23440010 for ; Tue, 25 Jun 2024 04:40:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=AOkVmtul; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719290408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4pKGIJo4HSuKfU0M2K9Y5VwTqoEGcxmVdtjuLcedzYo=; b=L7HqQ7ox6ofkiG88Yvcgu+l4kiojqk39o6mDSpcoPAIyqQ+hV/NJ4xnPKdBfWHNcP1sGuf bTw2QVhUqmbOqUA3ROUzflSmJuUet8AgoL1Hc1meGaCwSlclM8jAklcVC1N5oYO674L9hb kIjLFW2SekmDPh2WABo84R5ZE/dhFr8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719290408; a=rsa-sha256; cv=none; b=v3UWap7pSpQmmiPeXIFyeS7OaqoyqIB6PGqP/pgjiO7W6eUtadTNCm3Py52D5/4QU82fo0 b5ec2s6yLiTJhcHCcSyRYRmPaV5NAotq7fvWkB1pYzDYaZkXRwkfDxtaj7Ix0Bco8Fsgg0 pGIkPV1kAIm+CdPUvhur8U2ioslQ3CY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=AOkVmtul; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev X-Envelope-To: senozhatsky@chromium.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719290420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4pKGIJo4HSuKfU0M2K9Y5VwTqoEGcxmVdtjuLcedzYo=; b=AOkVmtulbKI3rbFIw1xAiYiBgbkMVJdCaJ7TFNgcZv6E0KTyy/RBcAQhfAIVgASUlPEvN9 pY7IEJ2oVy97AKK8/sLGyAm/Lm7/aJpxJOmD+hO3mHHN9TkhmL+DOJk29gmjy/022I+KAc VZKrXe9gsRh/Ate616bzqebyFzNZ6p4= X-Envelope-To: yuzhao@google.com X-Envelope-To: flintglass@gmail.com X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: zhouchengming@bytedance.com X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: dan.carpenter@linaro.org X-Envelope-To: minchan@kernel.org X-Envelope-To: chengming.zhou@linux.dev X-Envelope-To: yosryahmed@google.com X-Envelope-To: linux-kernel@vger.kernel.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 25 Jun 2024 12:39:05 +0800 Subject: [PATCH v3 2/2] mm/zswap: use only one pool in zswap MIME-Version: 1.0 Message-Id: <20240625-zsmalloc-lock-mm-everything-v3-2-ad941699cb61@linux.dev> References: <20240625-zsmalloc-lock-mm-everything-v3-0-ad941699cb61@linux.dev> In-Reply-To: <20240625-zsmalloc-lock-mm-everything-v3-0-ad941699cb61@linux.dev> To: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Yosry Ahmed , Nhat Pham Cc: Yu Zhao , Takero Funaki , Chengming Zhou , Dan Carpenter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou X-Developer-Signature: v=1; a=ed25519-sha256; t=1719290409; l=7705; i=chengming.zhou@linux.dev; s=20240617; h=from:subject:message-id; bh=Li6utiV8HVZ7YSsEACMojJqnpxw6KkasIDNGae+iQXY=; b=W1FR1Om9LTDEopO4RnmakTN3dtL10nv7yqtsg3qk290QpnITS9zGqJFjFfLC+ucvcOOzLOn0Z zR8NLvUy1+lA9+P4khbvc00fWDZ5hV14gl9MkX8jKE+21DsXNTEyD8i X-Developer-Key: i=chengming.zhou@linux.dev; a=ed25519; pk=/XPhIutBo+zyUeQyf4Ni5JYk/PEIWxIeUQqy2DYjmhI= X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8F23440010 X-Stat-Signature: sympfkjp8jomjnw5pic4k6reofiahwma X-Rspam-User: X-HE-Tag: 1719290424-231331 X-HE-Meta: U2FsdGVkX18lclBadUxADLLoTjU8T/vnUASMHdYobynpOm99o5wjgpRCoM1AYgPGY7xXrPxDa9rYcePFGs8lQQHO9W8tYrnmz5x0FOd3t3PZgyKkk4TNBDAfjFcRThcwcsPQ/0/YHc5c52EyRJt1F4J2UBJ7omjGSV0hwB5YzV0teF4718d0nbRb4K5gysj8XT5f8sVyeWPUcHimcLcW2KupRvgYHfMuiAtOrbaS0ibyeQT59qZ+fxHfNqj2hvA5emgHmx+bEehqL6LlkrTVg3PhGY8mJ9z+WMioAbtBPJHORVsWGwl8QCNL4oEMedXzGomLrSHK6qja9JEZaAAvBpHQ+o2HgSdAf0CtXLCpfbyW3Ym5rZ8VkAefwMy+Nr6Ef3HnS09Nas+y2YLRnhXDG6LY6ge+wO5DkCox0UDK6JRDK7DOE8z93DYT9troKF55c11D7RQupW1zyiCTPg2nEP2DdSr5ionVffqCgVmA379vf+HEXUOJGiSPLsMO1dErScJVXMlUyZFXBR/GmEIWbuppuqsL2yKjli+nxZWvQOAOGx5UJsKPLFGqw8iDLGfIzsafrjjpfUkNfEUunQGwNcmRGPlsh3gQ+ZaUu7x2xxK8cc2gUFHNZe2+wYb5hlgtFqAzgrNVQVJCFZcJn81tZZgKywJyHwbPWi8lDK4Egkt7xzcS5G1D3LLOR3ZjxCbfHsMNdvHaAb2C622pAuqLqBPZQFN1sD1yMrQZ8DIluBAbbUoUH/zlyLKREM3j6AmFe06fhyO78gNCsMNbhehw58iNgdDUoEeAV/2Q1glpIV2X4zWrPmbQ8fii0Agk6eiUsO53heobwj0VlCFhfd9v0LdlnCRzxTET+mmfWC/oUf4uhiOMf4IqwFo9Wg8yUjWn5X7Zmc/bS34oNmxTo+JOzbHL6k+KpTqmh/myjNM3iim2NwPTSSQIRzUiDbkPluEHIsDIQeiH/tsBj6NGWD6 5xzIvoA5 kGEUmSu820DPhfAD8EdzbNq+0tBCkDrD+9ewWgp6ig3C5licqoS6iLpk2/kLf7WHQJZrOvyp6TipMqb8yMy0BOiFI/1qfyqE7A6MUf4uY5mmi8XgybWCtbCoQK6DUJJIlJvqXT9H3dfcl6P8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zswap uses 32 pools to workaround the locking scalability problem in zswap backends (mainly zsmalloc nowadays), which brings its own problems like memory waste and more memory fragmentation. Testing results show that we can have near performance with only one pool in zswap after changing zsmalloc to use per-size_class lock instead of pool spinlock. Testing kernel build (make bzImage -j32) on tmpfs with memory.max=1GB, and zswap shrinker enabled with 10GB swapfile on ext4. real user sys 6.10.0-rc3 138.18 1241.38 1452.73 6.10.0-rc3-onepool 149.45 1240.45 1844.69 6.10.0-rc3-onepool-perclass 138.23 1242.37 1469.71 And do the same testing using zbud, which shows a little worse performance as expected since we don't do any locking optimization for zbud. I think it's acceptable since zsmalloc became a lot more popular than other backends, and we may want to support only zsmalloc in the future. real user sys 6.10.0-rc3-zbud 138.23 1239.58 1430.09 6.10.0-rc3-onepool-zbud 139.64 1241.37 1516.59 Reviewed-by: Nhat Pham Signed-off-by: Chengming Zhou Acked-by: Yosry Ahmed --- mm/zswap.c | 61 ++++++++++++++++++++----------------------------------------- 1 file changed, 20 insertions(+), 41 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index e25a6808c2ed..5bb5a34a28e8 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -122,9 +122,6 @@ static unsigned int zswap_accept_thr_percent = 90; /* of max pool size */ module_param_named(accept_threshold_percent, zswap_accept_thr_percent, uint, 0644); -/* Number of zpools in zswap_pool (empirically determined for scalability) */ -#define ZSWAP_NR_ZPOOLS 32 - /* Enable/disable memory pressure-based shrinker. */ static bool zswap_shrinker_enabled = IS_ENABLED( CONFIG_ZSWAP_SHRINKER_DEFAULT_ON); @@ -160,7 +157,7 @@ struct crypto_acomp_ctx { * needs to be verified that it's still valid in the tree. */ struct zswap_pool { - struct zpool *zpools[ZSWAP_NR_ZPOOLS]; + struct zpool *zpool; struct crypto_acomp_ctx __percpu *acomp_ctx; struct percpu_ref ref; struct list_head list; @@ -237,7 +234,7 @@ static inline struct xarray *swap_zswap_tree(swp_entry_t swp) #define zswap_pool_debug(msg, p) \ pr_debug("%s pool %s/%s\n", msg, (p)->tfm_name, \ - zpool_get_type((p)->zpools[0])) + zpool_get_type((p)->zpool)) /********************************* * pool functions @@ -246,7 +243,6 @@ static void __zswap_pool_empty(struct percpu_ref *ref); static struct zswap_pool *zswap_pool_create(char *type, char *compressor) { - int i; struct zswap_pool *pool; char name[38]; /* 'zswap' + 32 char (max) num + \0 */ gfp_t gfp = __GFP_NORETRY | __GFP_NOWARN | __GFP_KSWAPD_RECLAIM; @@ -267,18 +263,14 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) if (!pool) return NULL; - for (i = 0; i < ZSWAP_NR_ZPOOLS; i++) { - /* unique name for each pool specifically required by zsmalloc */ - snprintf(name, 38, "zswap%x", - atomic_inc_return(&zswap_pools_count)); - - pool->zpools[i] = zpool_create_pool(type, name, gfp); - if (!pool->zpools[i]) { - pr_err("%s zpool not available\n", type); - goto error; - } + /* unique name for each pool specifically required by zsmalloc */ + snprintf(name, 38, "zswap%x", atomic_inc_return(&zswap_pools_count)); + pool->zpool = zpool_create_pool(type, name, gfp); + if (!pool->zpool) { + pr_err("%s zpool not available\n", type); + goto error; } - pr_debug("using %s zpool\n", zpool_get_type(pool->zpools[0])); + pr_debug("using %s zpool\n", zpool_get_type(pool->zpool)); strscpy(pool->tfm_name, compressor, sizeof(pool->tfm_name)); @@ -311,8 +303,8 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) error: if (pool->acomp_ctx) free_percpu(pool->acomp_ctx); - while (i--) - zpool_destroy_pool(pool->zpools[i]); + if (pool->zpool) + zpool_destroy_pool(pool->zpool); kfree(pool); return NULL; } @@ -361,15 +353,12 @@ static struct zswap_pool *__zswap_pool_create_fallback(void) static void zswap_pool_destroy(struct zswap_pool *pool) { - int i; - zswap_pool_debug("destroying", pool); cpuhp_state_remove_instance(CPUHP_MM_ZSWP_POOL_PREPARE, &pool->node); free_percpu(pool->acomp_ctx); - for (i = 0; i < ZSWAP_NR_ZPOOLS; i++) - zpool_destroy_pool(pool->zpools[i]); + zpool_destroy_pool(pool->zpool); kfree(pool); } @@ -464,8 +453,7 @@ static struct zswap_pool *zswap_pool_find_get(char *type, char *compressor) list_for_each_entry_rcu(pool, &zswap_pools, list) { if (strcmp(pool->tfm_name, compressor)) continue; - /* all zpools share the same type */ - if (strcmp(zpool_get_type(pool->zpools[0]), type)) + if (strcmp(zpool_get_type(pool->zpool), type)) continue; /* if we can't get it, it's about to be destroyed */ if (!zswap_pool_get(pool)) @@ -492,12 +480,8 @@ unsigned long zswap_total_pages(void) unsigned long total = 0; rcu_read_lock(); - list_for_each_entry_rcu(pool, &zswap_pools, list) { - int i; - - for (i = 0; i < ZSWAP_NR_ZPOOLS; i++) - total += zpool_get_total_pages(pool->zpools[i]); - } + list_for_each_entry_rcu(pool, &zswap_pools, list) + total += zpool_get_total_pages(pool->zpool); rcu_read_unlock(); return total; @@ -802,11 +786,6 @@ static void zswap_entry_cache_free(struct zswap_entry *entry) kmem_cache_free(zswap_entry_cache, entry); } -static struct zpool *zswap_find_zpool(struct zswap_entry *entry) -{ - return entry->pool->zpools[hash_ptr(entry, ilog2(ZSWAP_NR_ZPOOLS))]; -} - /* * Carries out the common pattern of freeing and entry's zpool allocation, * freeing the entry itself, and decrementing the number of stored pages. @@ -814,7 +793,7 @@ static struct zpool *zswap_find_zpool(struct zswap_entry *entry) static void zswap_entry_free(struct zswap_entry *entry) { zswap_lru_del(&zswap_list_lru, entry); - zpool_free(zswap_find_zpool(entry), entry->handle); + zpool_free(entry->pool->zpool, entry->handle); zswap_pool_put(entry->pool); if (entry->objcg) { obj_cgroup_uncharge_zswap(entry->objcg, entry->length); @@ -939,7 +918,7 @@ static bool zswap_compress(struct folio *folio, struct zswap_entry *entry) if (comp_ret) goto unlock; - zpool = zswap_find_zpool(entry); + zpool = entry->pool->zpool; gfp = __GFP_NORETRY | __GFP_NOWARN | __GFP_KSWAPD_RECLAIM; if (zpool_malloc_support_movable(zpool)) gfp |= __GFP_HIGHMEM | __GFP_MOVABLE; @@ -968,7 +947,7 @@ static bool zswap_compress(struct folio *folio, struct zswap_entry *entry) static void zswap_decompress(struct zswap_entry *entry, struct folio *folio) { - struct zpool *zpool = zswap_find_zpool(entry); + struct zpool *zpool = entry->pool->zpool; struct scatterlist input, output; struct crypto_acomp_ctx *acomp_ctx; u8 *src; @@ -1467,7 +1446,7 @@ bool zswap_store(struct folio *folio) return true; store_failed: - zpool_free(zswap_find_zpool(entry), entry->handle); + zpool_free(entry->pool->zpool, entry->handle); put_pool: zswap_pool_put(entry->pool); freepage: @@ -1683,7 +1662,7 @@ static int zswap_setup(void) pool = __zswap_pool_create_fallback(); if (pool) { pr_info("loaded using pool %s/%s\n", pool->tfm_name, - zpool_get_type(pool->zpools[0])); + zpool_get_type(pool->zpool)); list_add(&pool->list, &zswap_pools); zswap_has_pool = true; static_branch_enable(&zswap_ever_enabled);