From patchwork Tue Jun 25 11:44:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Pankaj Raghav (Samsung)" X-Patchwork-Id: 13710926 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAADAC2BBCA for ; Tue, 25 Jun 2024 11:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FAF26B02F4; Tue, 25 Jun 2024 07:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A9D26B02F5; Tue, 25 Jun 2024 07:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44A076B02F6; Tue, 25 Jun 2024 07:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 23FF56B02F4 for ; Tue, 25 Jun 2024 07:44:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D54DE160B07 for ; Tue, 25 Jun 2024 11:44:57 +0000 (UTC) X-FDA: 82269229434.06.A7F4FD3 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf09.hostedemail.com (Postfix) with ESMTP id 070ED140011 for ; Tue, 25 Jun 2024 11:44:55 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=kipkGJg1; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf09.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719315879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kZG/lL31K25//iaIAV7jBbt1MNjj987Sk8ll7Dxjdts=; b=burVrT3rDcGc9F+h1kkAi2k/wQ/xZwA0/bwlxbJigCh/uiTvWEQ6bXSImBP2dAvQhvJOr7 N5XGzMeupnQ1lIExYpRXGObU837QYD92RS8266o6cs3UDsyAf56VK0ILyDUOm5TArWk3H5 oxEjgETUFLhGjSJIx43LgTxnOMQbQuQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719315879; a=rsa-sha256; cv=none; b=jvr+lrXh5Th82mGfm7Hc2JPbiBv67cpJQ5B9zFBeLPymgAe65q28j1vMe8v0Oyl83tp8Vt aZuaNin4wYPE+gdNg9BIP0j/tXyMemSuk8C3KmSy8ePwz136z7dPTsVt77KBoiDcbpYbdr rvBvzSa0o5hbaouXSn0cQBcAc9uxfCE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=kipkGJg1; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf09.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4W7jg86wgjz9sss; Tue, 25 Jun 2024 13:44:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1719315893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kZG/lL31K25//iaIAV7jBbt1MNjj987Sk8ll7Dxjdts=; b=kipkGJg13H64tB3xNiHrnDUQlknoj9SB5UwPL7W747iM43EClbh9mwGs/CrYevYpL7dwy5 yCNI2/rrK1OKsdZopIkCOHXT0eQ6Cqxr9v6msmK6G6JfpTTj1qEENLSiThEgtM/qhXGYMX GaWME0bvdKddSrBN8BOmm6NEQdQb4JpLcTqhPcYf2UJjmDDA2Xp3FaeTfjicWVxjfRpSkH nGUAu9grTCZ5xhJqILNQJrmMUyBu58f462EuVQDsqJF1tezZUcNuXmDw0tb/2iO5yXZCA3 qC/qL2yIXVEpw0zMc8ARKspky8n5jArAa6O92MNAB1BYNhkxgeYOBO/aixYVcw== From: "Pankaj Raghav (Samsung)" To: david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, kernel@pankajraghav.com, hch@lst.de, Zi Yan , Dave Chinner Subject: [PATCH v8 07/10] xfs: use kvmalloc for xattr buffers Date: Tue, 25 Jun 2024 11:44:17 +0000 Message-ID: <20240625114420.719014-8-kernel@pankajraghav.com> In-Reply-To: <20240625114420.719014-1-kernel@pankajraghav.com> References: <20240625114420.719014-1-kernel@pankajraghav.com> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 070ED140011 X-Stat-Signature: g6ufbkc8bno3ewwk6yhubb7aszb7d1p5 X-Rspam-User: X-HE-Tag: 1719315895-21706 X-HE-Meta: U2FsdGVkX191oCg6mpDT5o5/tg4nqj/xsvmaya2No4THbXVtllzhyDKqaYPnKPWPhtiKGs8DjuiTz7gFR6EhuvvpeLS7B2AKFmGXmV1ScyOJqSMVR7VYOQKCE2WAekJv11MrAkVuVLJ1AbLFcnVfgmFd8BOG+b4Dtb1kY70YLS6AINYSpgOgsbRosECl0aAxfKBO0GVFIzwpFxOPt9Q49ieNJOBnPNACiiyrigLAKIBb1R1Bd4UKrOaEP8utHSLH8fjj7eeDOtuLYhUulUl8n8SFWYnax8t+zEQHKv3nfbbxa/KGWU2WaQIryvWyRp24G361St2YxotMns3HHfiZb7yYfHJXFzqmXiYyU+owzg4J7ZjuHJfudj6zce97kTQH8IRn9WYDERVn6Qu+ut0nnbGn0zhwpKKEpRhy3Bvllum/5iP8jKsPSjZq3RVjP/hVpvIky7Jkr1JmS0XRAhXmhnXr4CfprB2g7WoCPk0FrTjojpd1TWA1faSLeiYw3cmwPUih2VCLGysDltbq6/naCHPPnncgxNti+uROt0CGIsoYg8C0Ny5roj315OlARmpn+Z1pUSHoe7MTVzXr9UFbJANMlYJJ+hen3xhown0J7kIGkCnkPn1cjjYrsTKhu/muoK2HrKNhm1rXzAxBhPkP9lO0cOyotf2YdrBk9OKJgE+QKdfsqrHGtPaVeYlqhse//xv6npWMzu9keQacplZ3QxRubjnfAKzoEVDgDTXJFAxr+fcu7UFqijx07idhTfYcDvOhI48nDdCH42xKnrXyLUb4CesdRQo+nF48wGKURQ7IskUa0IP1+PpfdUbbEmMw0Jl+UcgOo5zHYEKEujVIys81B9qCO/CQ2yji4K6vV0EGr3fMXqwgYFIBRxlHUFLTObM8Ael93PPDprktBC9MXeubE6cQlJU9+1CAr7+pN6za3+Lu7UcpLY+aZTLQSQZ58FiIH/7cZxarXF2GcC7 fzbjqoIJ 4f7CDsMZmpXJC6ayaSYsmWM4Zm5G9lK2pivUdzgBgLdqL1lzDkQqCS+8XJ1jPcCNv5vI17vFEVE516t31pAnqD//+zMSUvG6a5OMgdqo50WKYAk0dgwE4AXnJMaZavlBXWMAbopTXwWnQ5mVx92LuoRv/C6FgE0NisT9abJp2huIegXfg2I1Z2KFUXGpD6/yvEhgfZ2NryvWGHHyBcIeNIDwxNxOcu19vo6ORUkN4vK4XFgZNhjjFDUsRnMVSE1d1Pqf7T50VT/ELrOiQIW9nIxLI700EUvBQ84pfECmTp5yIwV8fCGN8wTDTDj0ZXru8kkZwXAVgtCX54zQrtxB3T+TSLc7Nz9vs7LSwaFhYMG7NwUOb+iFNZYq9TuMAdbqdAAc7+YENgnUzC/UlH2iFjeeZdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Dave Chinner Pankaj Raghav reported that when filesystem block size is larger than page size, the xattr code can use kmalloc() for high order allocations. This triggers a useless warning in the allocator as it is a __GFP_NOFAIL allocation here: static inline struct page *rmqueue(struct zone *preferred_zone, struct zone *zone, unsigned int order, gfp_t gfp_flags, unsigned int alloc_flags, int migratetype) { struct page *page; /* * We most definitely don't want callers attempting to * allocate greater than order-1 page units with __GFP_NOFAIL. */ >>>> WARN_ON_ONCE((gfp_flags & __GFP_NOFAIL) && (order > 1)); ... Fix this by changing all these call sites to use kvmalloc(), which will strip the NOFAIL from the kmalloc attempt and if that fails will do a __GFP_NOFAIL vmalloc(). This is not an issue that productions systems will see as filesystems with block size > page size cannot be mounted by the kernel; Pankaj is developing this functionality right now. Reported-by: Pankaj Raghav Fixes: f078d4ea8276 ("xfs: convert kmem_alloc() to kmalloc()") Signed-off-by: Dave Chinner Reviewed-by: Darrick J. Wong Reviewed-by: Pankaj Raghav --- fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c index b9e98950eb3d..09f4cb061a6e 100644 --- a/fs/xfs/libxfs/xfs_attr_leaf.c +++ b/fs/xfs/libxfs/xfs_attr_leaf.c @@ -1138,10 +1138,7 @@ xfs_attr3_leaf_to_shortform( trace_xfs_attr_leaf_to_sf(args); - tmpbuffer = kmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); - if (!tmpbuffer) - return -ENOMEM; - + tmpbuffer = kvmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); memcpy(tmpbuffer, bp->b_addr, args->geo->blksize); leaf = (xfs_attr_leafblock_t *)tmpbuffer; @@ -1205,7 +1202,7 @@ xfs_attr3_leaf_to_shortform( error = 0; out: - kfree(tmpbuffer); + kvfree(tmpbuffer); return error; } @@ -1613,7 +1610,7 @@ xfs_attr3_leaf_compact( trace_xfs_attr_leaf_compact(args); - tmpbuffer = kmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); + tmpbuffer = kvmalloc(args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); memcpy(tmpbuffer, bp->b_addr, args->geo->blksize); memset(bp->b_addr, 0, args->geo->blksize); leaf_src = (xfs_attr_leafblock_t *)tmpbuffer; @@ -1651,7 +1648,7 @@ xfs_attr3_leaf_compact( */ xfs_trans_log_buf(trans, bp, 0, args->geo->blksize - 1); - kfree(tmpbuffer); + kvfree(tmpbuffer); } /* @@ -2330,7 +2327,7 @@ xfs_attr3_leaf_unbalance( struct xfs_attr_leafblock *tmp_leaf; struct xfs_attr3_icleaf_hdr tmphdr; - tmp_leaf = kzalloc(state->args->geo->blksize, + tmp_leaf = kvzalloc(state->args->geo->blksize, GFP_KERNEL | __GFP_NOFAIL); /* @@ -2371,7 +2368,7 @@ xfs_attr3_leaf_unbalance( } memcpy(save_leaf, tmp_leaf, state->args->geo->blksize); savehdr = tmphdr; /* struct copy */ - kfree(tmp_leaf); + kvfree(tmp_leaf); } xfs_attr3_leaf_hdr_to_disk(state->args->geo, save_leaf, &savehdr);