From patchwork Wed Jun 26 08:53:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 13712429 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C50AC27C4F for ; Wed, 26 Jun 2024 08:54:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4D906B0092; Wed, 26 Jun 2024 04:54:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB0206B0093; Wed, 26 Jun 2024 04:54:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 967716B0095; Wed, 26 Jun 2024 04:54:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5F6326B0092 for ; Wed, 26 Jun 2024 04:54:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0CCA9C0C88 for ; Wed, 26 Jun 2024 08:54:45 +0000 (UTC) X-FDA: 82272429330.05.8115466 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf08.hostedemail.com (Postfix) with ESMTP id 19217160023; Wed, 26 Jun 2024 08:54:41 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719392071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLdchAKMVOnnow5g3bHuaFejgGWqLsRQABjHVMysOR4=; b=jUcw9GQSm168qguJwqdj39RUEsvgNJa1FPCnpYGPPoXZ5uVrP0ANsljGzH7Yq+d/p5ns2n oV/V5EVkSIX9S93jS/u9jL63E7AZAi0LAAkKaM3szQnh5nD1suo1avnoeS8P1+F1B4akx9 D1HkaxETejsZyOruBXJbW+fRt+k6mdE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719392071; a=rsa-sha256; cv=none; b=gpAffjIDbWZKgmRRUFQnkuFnVxUfofwJUJR8fAVqKnEn3rvLoyXQ7lw3DxWK5Lv2qocYv6 k7miVGkEYI1WAUSZ+ShUaIJA63WxblYo3OnVEZG4mqz0Wm3LS5fy+/SdsmKpMKQDkBWdI9 HaFR9n8twI7XLvDyCXsPfxDIcPLDPH0= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4W8FpS46mszddwR; Wed, 26 Jun 2024 16:53:04 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 702C414011D; Wed, 26 Jun 2024 16:54:38 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 26 Jun 2024 16:54:37 +0800 From: Kefeng Wang To: , CC: Tony Luck , Miaohe Lin , , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , Jiaqi Yan , Hugh Dickins , Vishal Moola , Alistair Popple , Jane Chu , Oscar Salvador , Lance Yang , Kefeng Wang Subject: [PATCH v5 4/6] mm: migrate: support poisoned recover from migrate folio Date: Wed, 26 Jun 2024 16:53:26 +0800 Message-ID: <20240626085328.608006-5-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240626085328.608006-1-wangkefeng.wang@huawei.com> References: <20240626085328.608006-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Stat-Signature: 4apmgdzu5m6ebouecu7gc5gr4ejxfdpb X-Rspam-User: X-Rspamd-Queue-Id: 19217160023 X-Rspamd-Server: rspam02 X-HE-Tag: 1719392081-364570 X-HE-Meta: U2FsdGVkX19BKlxqF3jpkCCbqUiBLcQv6BIWY6yVEwllMzwmdq/Jr+oERZeZqAY38EWag51JFPTZuCi3OaPpZwAXt0DCVDgZVqYP+I30OBGSy9IUOwDNxl0DXGYNFoWtplIBTJ7tT7mhu+M7LL6nNDEXhUO57Cp5WYgSmynG8mAblGbTii4jaerxmMeZzKtl/CS47wVxTn+fSn4Z8SpDoYcjk/KGfPJV1YH7HYkfY2hfke4egR3hK2y2qM1FI1bAZ9iLsoGhO10cM//N91UzWpbPzoQ7/d1FLMci7aRdKtnzJP4IeuPpJIq7o4RhhvjDFzeqzmWCmu4dPnud8YAJuOD6aqAnd/cmSyuiBCKaBfJAOlq0HSHor5Wyep5fNgSrbeZxY0a9xdUK+sgo8hKTqQUN55iMdWCxiLzEWUhcd1YghLILcHMux8G/IG9yY7BfV2Ssz/qcpPsF1WwmveJEG/VKZe7Y83ZGBAobw68nYGFhJzHskflWbtg+ks/zEhkjkS3zDdRFV/EPXXQvLfuKJWRTg8fgOo2wIKAPNx4EjhEQvZ99tsiew7jLONO7mmcqEgCNE0Kg+JHcj7cA2jEGho9pJfog7qyi+EwkcxAiD/dc4Q9OJlVpI2bOQAPhzDC5o9MPOpk5fcn0dZV3YgbFtFmSO+A519yDazMpZYliAqrWQG+wa0cYt99cKnjkRMiEG4HWHTNq136o1Mkmd8mTZ6XntXuSa+MNU4vQwuFdiX9zAapqrdt2oH/D0uBzPpZRR+4dLeBUgjSMMlzQS2Wjtn7/pEbRGJMN4zHz4ydAKo4FiA26cC5/JWNywTKrKeGL3pLbvcZB4VAcyB27aaOGUDZQ8PAmJCZ1iPgv0XpSPmU20BXfrcoQmqKQUvceZuy9IoXuWfn5VSKFBgJs0dpg8Yj5X3TVUxLQdK6n0K3/MvzMPT2I5l8Yy/v9GAn2q/lkRH9C1nqlPW8lH3Gs/fo CPGD4W6r nSTGLJtPSErDCkv5s1gfRgOkKDHYzbcvJKLqnoSui0hYxMSJqPyX6YG+4RQ5RLxCxEqIhAEdG1Xu7f+PnZMs8Qmo9N9NDlvzuJY8oQUPSyiZA4nBG90HKLOjn5lQccVOUy4KBaxWC8pk88Y/px0qd6qxOIEvEW2z6PwVSmCDH6FCrhLm7vLd8COInIGWFRCBlk/qa5cj6HTBq0EECsaHcrIcm0EBIVOcUH5Js X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The folio migration is widely used in kernel, memory compaction, memory hotplug, soft offline page, numa balance, memory demote/promotion, etc, but once access a poisoned source folio when migrating, the kerenl will panic. There is a mechanism in the kernel to recover from uncorrectable memory errors, ARCH_HAS_COPY_MC, which is already used in other core-mm paths, eg, CoW, khugepaged, coredump, ksm copy, see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers. In order to support poisoned folio copy recover from migrate folio, we chose to make folio migration tolerant of memory failures and return error for folio migration, because folio migration is no guarantee of success, this could avoid the similar panic shown below. CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0 pc : copy_page+0x10/0xc0 lr : copy_highpage+0x38/0x50 ... Call trace: copy_page+0x10/0xc0 folio_copy+0x78/0x90 migrate_folio_extra+0x54/0xa0 move_to_new_folio+0xd8/0x1f0 migrate_folio_move+0xb8/0x300 migrate_pages_batch+0x528/0x788 migrate_pages_sync+0x8c/0x258 migrate_pages+0x440/0x528 soft_offline_in_use_page+0x2ec/0x3c0 soft_offline_page+0x238/0x310 soft_offline_page_store+0x6c/0xc0 dev_attr_store+0x20/0x40 sysfs_kf_write+0x4c/0x68 kernfs_fop_write_iter+0x130/0x1c8 new_sync_write+0xa4/0x138 vfs_write+0x238/0x2d8 ksys_write+0x74/0x110 Note, folio copy is moved in the begin of the __migrate_folio(), which could simplify the error handling since there is no turning back if folio_migrate_mapping() return success, the downside is the folio copied even though folio_migrate_mapping() return fail, an optimization is to check whether source folio does not have extra refs before we do folio copy. Signed-off-by: Kefeng Wang --- mm/migrate.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index e97fbaed564d..f9d700d82ea9 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -668,16 +668,24 @@ static int __migrate_folio(struct address_space *mapping, struct folio *dst, struct folio *src, void *src_private, enum migrate_mode mode) { - int rc; + int rc, expected_count = folio_expected_refs(mapping, src); + + /* Check whether src does not have extra refs before we do more work */ + if (folio_ref_count(src) != expected_count) + return -EAGAIN; + + rc = folio_mc_copy(dst, src); + if (unlikely(rc)) + return rc; - rc = folio_migrate_mapping(mapping, dst, src, 0); + rc = __folio_migrate_mapping(mapping, dst, src, expected_count); if (rc != MIGRATEPAGE_SUCCESS) return rc; if (src_private) folio_attach_private(dst, folio_detach_private(src)); - folio_migrate_copy(dst, src); + folio_migrate_flags(dst, src); return MIGRATEPAGE_SUCCESS; }