Message ID | 20240721145415.fbeb01a853962ef91334f3d1@linux-foundation.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] MM updates for 6.11-rc1 | expand |
On Sun, 21 Jul 2024 at 14:54, Andrew Morton <akpm@linux-foundation.org> wrote: > > - 875fa64577da ("mm/hugetlb_vmemmap: fix race with speculative PFN > walkers") is known to cause a performance regression > (https://lore.kernel.org/all/3acefad9-96e5-4681-8014-827d6be71c7a@linux.ibm.com/T/#mfa809800a7862fb5bdf834c6f71a3a5113eb83ff). > Yu has a fix which I'll send along later via the hotfixes branch. That commit "875fa64577da" does not exist. I think you are talking about commit bd225530a4c7, which is in 6.10 and came in from your last hotfixes pull. I'm assuming 875fa64577da was some commit ID it had before getting rebased or something? I'm also a bit confused about why you mention this, since neither the cause _nor_ the fix are in this pull request and you have the wrong commit ID. Linus
On Sun, 21 Jul 2024 16:19:42 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Sun, 21 Jul 2024 at 14:54, Andrew Morton <akpm@linux-foundation.org> wrote: > > > > - 875fa64577da ("mm/hugetlb_vmemmap: fix race with speculative PFN > > walkers") is known to cause a performance regression > > (https://lore.kernel.org/all/3acefad9-96e5-4681-8014-827d6be71c7a@linux.ibm.com/T/#mfa809800a7862fb5bdf834c6f71a3a5113eb83ff). > > Yu has a fix which I'll send along later via the hotfixes branch. > > That commit "875fa64577da" does not exist. I think you are talking > about commit bd225530a4c7, which is in 6.10 and came in from your last > hotfixes pull. > > I'm assuming 875fa64577da was some commit ID it had before getting > rebased or something? > > I'm also a bit confused about why you mention this, since neither the > cause _nor_ the fix are in this pull request and you have the wrong > commit ID. > Yes, right, sorry. "mm/hugetlb_vmemmap: fix race with speculative PFN walkers" was promoted into mm-hotfixes after I make this note. Anyway. We broke a thing and it's being fixed.
On Sun, 21 Jul 2024 at 16:52, Andrew Morton <akpm@linux-foundation.org> wrote: > > Yes, right, sorry. "mm/hugetlb_vmemmap: fix race with speculative PFN > walkers" was promoted into mm-hotfixes after I make this note. Ah. And that explains why the commit ID is different too. Ok, thanks, Linus
On Sun, 21 Jul 2024 at 14:54, Andrew Morton <akpm@linux-foundation.org> wrote: > > - Is anyone reading this stuff? If so, email me! I do actually try to read the explanations.. However, I also do build testing, which seems to have been missing. Notably: > Ho-Ren (Jack) Chuang (1): > memory tier: consolidate the initialization of memory tiers causes WARNING: modpost: vmlinux: section mismatch in reference: hmat_set_default_dram_perf+0xc (section: .text) -> default_dram_nodes (section: .init.data) WARNING: modpost: vmlinux: section mismatch in reference: hmat_set_default_dram_perf+0x6c (section: .text) -> default_dram_nodes (section: .init.data) and sure enough, default_dram_nodes() is an init section, and is accessed from hmat_set_default_dram_perf(). I think the fix is to just mark hmat_set_default_dram_perf() as an init function too. Testing that now. Linus
The pull request you sent on Sun, 21 Jul 2024 14:54:15 -0700:
> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tags/mm-stable-2024-07-21-14-50
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/fbc90c042cd1dc7258ebfebe6d226017e5b5ac8c
Thank you!
Le 21/07/2024 à 23:54, Andrew Morton a écrit : > > Linus, please pull this cycle's MM updates, thanks. > > > > - Michael Ellerman has developed the series "Reimplement huge pages > without hugepd on powerpc (8xx, e500, book3s/64)". This permits > userspace to use all available huge page sizes. > Andrew, That series is not from Michael but from me. The purpose of the serie was to enable refactoring of different page walker without having to handle hugepd which was specific to powerpc. There is no change for userspace. Thanks Christope