From patchwork Wed Aug 14 22:00:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shakeel Butt X-Patchwork-Id: 13764178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D0EFC3DA4A for ; Wed, 14 Aug 2024 22:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ABE06B00A4; Wed, 14 Aug 2024 18:00:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 033FA6B00A7; Wed, 14 Aug 2024 18:00:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16BD6B00A9; Wed, 14 Aug 2024 18:00:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C41AD6B00A4 for ; Wed, 14 Aug 2024 18:00:34 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 88A8A1A0582 for ; Wed, 14 Aug 2024 22:00:34 +0000 (UTC) X-FDA: 82452220788.20.9902483 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf08.hostedemail.com (Postfix) with ESMTP id BBD09160025 for ; Wed, 14 Aug 2024 22:00:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wa4X42Rw; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723672797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CoKWYd7P/AKTgOxnO9z4vGUx2mh73AJSsiyA7cwqTAU=; b=wibjqp+9Rqo5qo0W1dwGa5POPfwCU4PF5IoWOs99TgoCqqF/nFSBwxYsnWXdN9H5KEwM27 rEIEDDMnFi9/kql7yGk1IeSiLHzOBo6Bpma5q92QTASsaeV6W+3O0ogMzfroIj8Mm623tW 7/ecKvzr72osdJRPckmzCkeKsdmxPWE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wa4X42Rw; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723672797; a=rsa-sha256; cv=none; b=g1wuceoR3pGNwKfdomEiQdZKbf46ZO964MeGXDTnK/FpVg67Tb/0ybkAJauCk4VPz2xOWR wa79pRIbBjXXWgj2ydVa9xpkadexc+41RFhVw03OOPMIn5npwbMlNGRRw2skWxZ/GYmLfw Jm3g5i4s6jUTS7P2Cfg2Yb3hKyoHmgI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723672830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CoKWYd7P/AKTgOxnO9z4vGUx2mh73AJSsiyA7cwqTAU=; b=wa4X42Rwt2kklgTFcAFXO/x/P5VKRQaJFoHFUwFYe4F6hsjQgaSSwKJXTPjuw7wjLUxeYX z8WHwVh0omw5zZdhINdF8S5R0v9ooyocSSy2i3Z9o5cVebyScNQVLRvrhbegTOVl3Vg5zK G69KtcTWY5BZ2dUv/cevweIOqDFOjss= From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , "T . J . Mercier" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Subject: [PATCH v2 2/4] memcg: initiate deprecation of v1 soft limit Date: Wed, 14 Aug 2024 15:00:19 -0700 Message-ID: <20240814220021.3208384-3-shakeel.butt@linux.dev> In-Reply-To: <20240814220021.3208384-1-shakeel.butt@linux.dev> References: <20240814220021.3208384-1-shakeel.butt@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: BBD09160025 X-Stat-Signature: ymyoacwqifqg7yge6bun8ktr4a9tu8d7 X-HE-Tag: 1723672832-884789 X-HE-Meta: U2FsdGVkX1+mqoxonzBnZMawOd5iKWMUO79To4xTq9bK8tBGi7y5f/MDXsG3ElaaiQUE/MwmTVOs+v3Wav4AJuFMHu3E3zZEZvfxXuzN3K14Vip8xyfG9IfTXWkJz+dofF4ZwI/8pysObg/wue1T0SHo0fAkgzYZGK8ioTcvK0hCz1boWa1F3TwbsxYjjO5Obm9haqg651xUeXia7e/qxlzi5afrZjTR6GI2NAU41sw4jl+u1JCI1XWswDu0Yob1Q4hn2jXHdEa/kn8dLDlXLz44TuMBjgBiBWUIgBcKbPUjFKhJxOug+iGEfgEayeZubk1whC0odRDrxNr2UajbPJpWjieCtpJCf+zJ0zaAIaVxzosowuQvnkQpdzHlVt+DtYxFeOsYxmhuTRh9p6oHAsmLtHs1tzbmBI/5g9kLxr4+83lV3Wg8iq2VkAcgpTKxO/hjMCL9juDXGYxI76arqH3B3ZadTgMFzqY0wmsVBGf/fWczhZev0UjU88zkUf5HOJnVx3fiJMHImuUytxUlgj7MpqQ/Z23GPcEzrxjokyJtfAOq2WZDSt6wN7B1pVBibClx0GuKPGGUmKecMpZZUNBkVMHEfbLLLuRDAatVi7Xxs8WtSEWOpPeXzoAOjWCV/CIm67Pyy9Hhqxvg8KjXA2v/mR5gcg0wPFJ6wBfNlublot/MRrxjmmTdOXfEznWlOxAiUZoLzkax9b++UGZQH0Y2x0RvZ8tE2wLg4hJgb6sjFRCsNAwJf5elSTMyA9fT8dSfmXU3xP76bwR374sRzHkkLfK42MdBJGZNbwO5v/PztmrbGFHt7IbQQGNbtWEOn+4mggIw1tV0BFk2p0TZZcJUias9GO1etHj4RG2etPy3h63UuGmTiUpHD7bzb5jWItkWHVHTi4w5x2bFchAQPF53SETmI6pr48TVTh/Z/d1UtNVk/MNTTU6nZ2aLld+0OdVws5RGL+0O3yQnv4X B2jNbJLE lmXcDMxbzaK9UbOurJGISK6MIONvKDquP4/m/rJudjavEnvZ1UDh/AEybqLPxJxhbqKKl5mWRaJRDYpSkwuhrhTkE1G67BpwWczHWOi3QMiDXvAiqsOMncUTonzp5WM1nzqxu3PCtlUJJSdzkKZ+YvdgA/n8LCDLjDfx1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Memcg v1 provides soft limit functionality for the best effort memory sharing between multiple workloads on a system. It is usually triggered through kswapd and at the moment does not reclaim kernel memory. Memcg v2 provide more straightforward best effort (memory.low) and hard protection (memory.min) functionalities. Let's initiate the deprecation of soft limit from v1 and gather if v2 needs something more to move the existing v1 users to v2 regarding soft limit. Signed-off-by: Shakeel Butt Reviewed-by: T.J. Mercier --- Changes since v1: - N/A Documentation/admin-guide/cgroup-v1/memory.rst | 8 ++++++-- mm/memcontrol-v1.c | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst index 0114d758beab..6831c6c16e3f 100644 --- a/Documentation/admin-guide/cgroup-v1/memory.rst +++ b/Documentation/admin-guide/cgroup-v1/memory.rst @@ -78,6 +78,8 @@ Brief summary of control files. memory.memsw.max_usage_in_bytes show max memory+Swap usage recorded memory.soft_limit_in_bytes set/show soft limit of memory usage This knob is not available on CONFIG_PREEMPT_RT systems. + This knob is deprecated and shouldn't be + used. memory.stat show various statistics memory.use_hierarchy set/show hierarchical account enabled This knob is deprecated and shouldn't be @@ -701,8 +703,10 @@ For compatibility reasons writing 1 to memory.use_hierarchy will always pass:: # echo 1 > memory.use_hierarchy -7. Soft limits -============== +7. Soft limits (DEPRECATED) +=========================== + +THIS IS DEPRECATED! Soft limits allow for greater sharing of memory. The idea behind soft limits is to allow control groups to use as much of the memory as needed, provided diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c index b8e2ee454eaa..e0bb54e42011 100644 --- a/mm/memcontrol-v1.c +++ b/mm/memcontrol-v1.c @@ -2458,6 +2458,9 @@ static ssize_t mem_cgroup_write(struct kernfs_open_file *of, if (IS_ENABLED(CONFIG_PREEMPT_RT)) { ret = -EOPNOTSUPP; } else { + pr_warn_once("soft_limit_in_bytes is deprecated and will be removed. " + "Please report your usecase to linux-mm@kvack.org if you " + "depend on this functionality.\n"); WRITE_ONCE(memcg->soft_limit, nr_pages); ret = 0; }