From patchwork Wed Aug 28 03:03:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13780364 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51480C5474A for ; Wed, 28 Aug 2024 03:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3C246B0093; Tue, 27 Aug 2024 23:04:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEAFB6B0095; Tue, 27 Aug 2024 23:04:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8C6F6B0096; Tue, 27 Aug 2024 23:04:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9864D6B0093 for ; Tue, 27 Aug 2024 23:04:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 47867AABC4 for ; Wed, 28 Aug 2024 03:04:09 +0000 (UTC) X-FDA: 82500160218.19.6A2D623 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf29.hostedemail.com (Postfix) with ESMTP id 4B9C5120009 for ; Wed, 28 Aug 2024 03:04:07 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AnS8Nsc6; spf=pass (imf29.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724814159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QQdkC9XISn7BWPlTE5/iE7aUj/L2jeLonKoaBsbNpS0=; b=vpiNNmhZjOZpEcQiz6887y+/+b9ZWD+7jKScF/e6RUNZc2hC4T0Xr2lf/GwIC1jdfPPqd6 t8n7s1reuau70tYuPXgsCq+5D3RWFxHA6TSRgYlc0CWgCwrqwksx/ol/324l8OYq7ezhTC HXOVT0L2Fq58pKaw7JhBUTvaaDgzIvo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724814159; a=rsa-sha256; cv=none; b=B1YHwuC60ukwSjeS2EB+XnvznwpYKqri8e4cuV0nLUCE1mh4Hwlmp0lG+sMp2YsRSGqDF+ 8Egr7hid5wJvPqTNizyq+TzdlOBxzeLZrvsrXfjFL0F+8HHB+RvbB5UM/PLBWo9ecsKvTk Bszvn14V+Cw+S1eXuRIs/znLm5vHiCE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AnS8Nsc6; spf=pass (imf29.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7cf5e179b68so124244a12.1 for ; Tue, 27 Aug 2024 20:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724814246; x=1725419046; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QQdkC9XISn7BWPlTE5/iE7aUj/L2jeLonKoaBsbNpS0=; b=AnS8Nsc6f1XjW1O0tA8USxF/ziGlhmwT5jxqnLgUmtryYneSahTfi56xHXdSq/dTqE eeR3zamZHX406XHlmMOk3sMZE9L79snkIRbZTwwVTv+yJ24D7x7XoCTdAeVSoFdNLGv7 PXOzzh5RfVFgJnV3zPYFfBrIbA/ybbcVebZWzvZk2ydz+0A12ZH4l9CViB4unIg6oHjz EI/wscbJN5doggqg5s0nW8MEJ41UunxGPmsHUNCxQfMBgHnY8pv2lNpNNw7JH1k8ewAS DW6s6Sj5T28BoMF7BbnDZe7scAUrl/6deQz7FD/4P+QryExcb9hyyC23lfuOMqQ9vGYC xZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724814246; x=1725419046; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QQdkC9XISn7BWPlTE5/iE7aUj/L2jeLonKoaBsbNpS0=; b=NHHEOKuVjQCNqFTDTDwm89JoT00cGGYUoT6ULhK5xppZ7imMgXZKzXsnWDiXy6aEwW WKJtwo9j6t9Mnhc1PXn4CCI3NHH/Lf9BPLEFOM6/QMw06SAvzhrn5Xv9Q54f0JeNDplz pvMyf6cgqfArYS52msJB6USnbzDXcKCP2AIXvcHe0wcOIMQ+ZnwzsF7lZT1rbf4KCfyN 46YqKsBYVlcYeHi4kCdbiNEbOSybpt9iX4ApMzCpQ32ZX4qtGLgNV4TikeTZO4TCezCM v0qTJO/cdGirDCl/HKHrmhgvFdPe2qZ5NiTLspk2jAxB71v8MzxrsXmiQGa4PNMRjKEg J+/A== X-Forwarded-Encrypted: i=1; AJvYcCU/tuJQjEk+2fD14Ux9hwcsClhew2A2oWX17Yr9SR/NjxIzeFc8ozcq4m1gG92L0ytnE7viYWH/XQ==@kvack.org X-Gm-Message-State: AOJu0YzZiBuR5hJ8DSrMdMFMxjtWQHl4Pha32mC/SO1b/378zKv5DwDO Oie65vEe1fMlWJlY/947Jm56FxkCBxdw4GiE6uim957SRpbRAfMzp2tcIkEI X-Google-Smtp-Source: AGHT+IHxaydVqwv10Tfh2ak5vjo3hT38eMV2JYlayqlM6cQqHxMPAOmu6Mb/QjPRAxpmFPgYrqTvlA== X-Received: by 2002:a17:90a:304b:b0:2cf:f860:f13b with SMTP id 98e67ed59e1d1-2d843da1884mr1305336a91.17.1724814245904; Tue, 27 Aug 2024 20:04:05 -0700 (PDT) Received: from localhost.localdomain ([39.144.104.43]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d8445db8f6sm317977a91.1.2024.08.27.20.04.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2024 20:04:05 -0700 (PDT) From: Yafang Shao To: akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, alx@kernel.org, justinstitt@google.com, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Quentin Monnet Subject: [PATCH v8 4/8] bpftool: Ensure task comm is always NUL-terminated Date: Wed, 28 Aug 2024 11:03:17 +0800 Message-Id: <20240828030321.20688-5-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20240828030321.20688-1-laoar.shao@gmail.com> References: <20240828030321.20688-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Stat-Signature: trbga8eazx4fsuqcfg13fndjx39yk5co X-Rspamd-Queue-Id: 4B9C5120009 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724814247-662396 X-HE-Meta: U2FsdGVkX1/2uV6UPFtyAVUzZs0nMEiPJ3lqwk8cUNMdzl614RkOJ6JCvqw/RBO/ptaUKOq37OzeDSc1XGZc5LnY89veA5AFXjvmTFQD6WiRZ+FH0VC+UkIcSkAPLnkVf0j/t9I8UGSTy17uGkr5Av+hi8dqozqDdMrbj5gWo3HKT8P8nfgBOSfrCEcVGkvdgMdUx1G+lhe9SqBkHTPfgA8OEjV01M66Zto6LHbRyG6jfxjeWK3xSW81yQhm2nMGL/5plCsrTQAUMzzBoJYUG3s4zL+cLV+qpGrrGZCor9kwAkByG2Q+X8zz5fe2x47WhssjWXr1G1GBMO69TMpnro0YpBwrAPHxFZXqDFH+aj+ZYf+tCMFjsh6KAQUDnB7kJNc67fQxfIyEE7JA40EKuhqZ8qc/qmaharNSy3WDuguGQsANEaTKNeIHHEzklhdFwLYPzW4a+uwRHBv6iDB5bvC7yKkwSGPMgpBp7HJLVsnj53LEl/MOBKASRREXdW6RrgFTadqp0yty+0GqXGTUOk7b+hJj7uPPpuQtSi1Og/bK+SfRm5nAhofHH4+0kwAqaQyeJz6DCxSHZf5nk5kNFhcmu9NGUxzyL6KIzfLOMJQTO53yuT+Tao0WFHFqOE09KxHKE1qxKH0TEhyawPY19vtu08rceHitGAfyg83SKE1HmHuurb9W6ezBCrJ8uFfRVImf3MGZd+7p5PtNHXKHpFqsAQ1MnUYgWNADbBzoscgaI3nCzD3+E/SKKVSitttRxqdphzoHGyZIsetTmP89OW8a1/Z3vqdZm8yUzt5MUkwVEDCTXpwFwzSe33DO4pwxPTiZOQEseQ33o4d0+0n1Bjmthes07m9uQqWmUp4tTq1TnucDeO4p/y5OkkvhDy6YhZomwygTtCCz7XhOorfKC2ELlsthf0g8rDkuEl+Os2fwKg55x5ysZ0uLy51Sw3LmzrfWrKZoVHUo+CD4Viv P06sZI+m tYi9u3bwX9z4Jipqou1OD36XC101Fb/JfzsCld0w4K7V5mg2ZKgzrm+TyhptlNTc5+V1rlgtDWmeQ+UiQNSVkpY8xPLwWs+U9JmUF9V2dI1KWxJqKTdULEM9fp/YpQQSncRdFho2HuGgSV1gRhp0RvUJCapHxe+HIPKQGPHryAsXzjO6iX1b9pBRWotFbjsr5ZLqaJ3cHpXtnsAlPQBC0ULu8k4mNvAke6OQ2//eNMdQ8+I7AT4nIa2IAzBeSo6i3Auo4MuAfPiDJu3dkOIyOfuUcI2od8fpvJGWjvWgJVQCzZuR5IHpBLle/7rB/ps64iMA8+b+wj6nlWbJffcXivAbegxMMbjGsy+N1DnmTUc2LpB4syZFyckhLVWnuP01PRXQ9oNbph1SZmNTcNp1FCPNeaSTDK8WJqjQHcKcCzArWMHHsYiN+/u3Uof6Ag5B/wWNbdSTbG9UfiUcw5La1EojgoU72Avz2Ynv0c0N8RVmb39VhfNyhW8qEcC9gG/7a5BtzO9T6xDGFr1JRuJbM+RVr56hZQP0v4zWiElny1Hcwtsj5PWeDIPDge4080PIsc0qZ/eGJNUFnPSONs3OAucXFsmXsq2ap1sQFPfnHFDwQLZI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's explicitly ensure the destination string is NUL-terminated. This way, it won't be affected by changes to the source string. Signed-off-by: Yafang Shao Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/pids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c index 9b898571b49e..23f488cf1740 100644 --- a/tools/bpf/bpftool/pids.c +++ b/tools/bpf/bpftool/pids.c @@ -54,6 +54,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e) ref = &refs->refs[refs->ref_cnt]; ref->pid = e->pid; memcpy(ref->comm, e->comm, sizeof(ref->comm)); + ref->comm[sizeof(ref->comm) - 1] = '\0'; refs->ref_cnt++; return; @@ -77,6 +78,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e) ref = &refs->refs[0]; ref->pid = e->pid; memcpy(ref->comm, e->comm, sizeof(ref->comm)); + ref->comm[sizeof(ref->comm) - 1] = '\0'; refs->ref_cnt = 1; refs->has_bpf_cookie = e->has_bpf_cookie; refs->bpf_cookie = e->bpf_cookie;