From patchwork Fri Sep 6 09:50:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13793829 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCF0CE7AFE for ; Fri, 6 Sep 2024 09:50:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A90E6B007B; Fri, 6 Sep 2024 05:50:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95A4A6B0085; Fri, 6 Sep 2024 05:50:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8205E6B0089; Fri, 6 Sep 2024 05:50:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 642FE6B007B for ; Fri, 6 Sep 2024 05:50:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0EE1380DE8 for ; Fri, 6 Sep 2024 09:50:57 +0000 (UTC) X-FDA: 82533844554.08.4BAEBBD Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 48015120007 for ; Fri, 6 Sep 2024 09:50:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=B34cIqit; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725616125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=+4TYk2P8rsrGGMkeOuqXW3lZdK3gNZRYY0x1m32EPi4=; b=1P90ndkCv3EL9PL1vLCU4uh120YP/LAYiKsKTWW1ztW62Em7hxO3JqZkCNAfbhFym9/rkk LTFqYipzpDGj8Xqp7uQXlTBZnSvj75rUKD7F9qWLw4nCx/xLSwhyMzM+eDHBqgIsszKRv4 OayR3FH8IpWTeuANO+dtn246Ip2EH6s= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=B34cIqit; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725616125; a=rsa-sha256; cv=none; b=tL/qVcdm3elx9BQfPyJb23ZD4wVwdZFysCo2Df8gCkKPCgbwbGToor2s2MjX7RWA84JI3L ZgSt1Vdh2wXE7yVelFbW4y9ryzhcY0DPZqtvH55Kd33THkluGLsVftozOt0sQp4p+FP12n Gxiu7PxIw1cWH6GjwE58e6KHXD9EAiA= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5365b6bd901so108630e87.2 for ; Fri, 06 Sep 2024 02:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725616253; x=1726221053; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+4TYk2P8rsrGGMkeOuqXW3lZdK3gNZRYY0x1m32EPi4=; b=B34cIqit1C8iFbjLs5y2DzbSr7wrMo9PwGAIH5ar6COBMrURIGOoq4psBCXhqYlH1K /SXb3l9/gJ9WlmELVdDS7jm5Xsk+I8eGCnxk3EmQTvIeptRA+Afjf+mDf23HrMDZVvXI QqbfTFOIM8plO9qrWIZXA/rYw/aLudUv9Z7FhDs0T145aWY05xTU2d4xfJ8fimckYSm3 iWBUcpnKDKGFQOdOO+MkhbJeufTKVKS6xHPO1LkdpLp+q5uU+Z9qftv9JMuy70kM5ZCi MGV+P8pfi7WzApVeXfdIMgiecbYlfbzeWo+E8YbYgMpw60Dv0x1X+7I9fhuSuUDTYNzy 0XFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725616253; x=1726221053; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+4TYk2P8rsrGGMkeOuqXW3lZdK3gNZRYY0x1m32EPi4=; b=KPtmJlh+5pRP9PCFAR9kUXzeIEPz8cPPPYNCzQ+WnpRj62FRR/I/M73OsD+iH1UsXI 2CrBduydB7YOOlKvlC82x8zEPk+zsYxDcCYGptZ1ADZzfSq6SRB6GgaLXlXafBhmHZre bqsR4AUa33A7HYtvTGoVpMu48DR/xqZvVb7r5GnPJ5ojOS6HkLF9JyAN3KWvH0MVliIf 4SQ5K1NULADVOBFnUkkaXXdOkjWKqwT78DA0rMVpeTZB1VGxTL0+Q1aLRaL7t/NSdVvM yGigsGa8BczAVx+KcxdX+SMgHy6SXf2bXLDN6KrzQMv9K62Zoq+GSfrfRp9u6AATH1Dy 2S2Q== X-Gm-Message-State: AOJu0YwQHH+QwBsxKGI6wObYamp5FnK/9DEbMCi+z7PJZsIQXVAv74++ JXe5LGgujbTIW1kwXxeaSboIunEaxjAFFBRnceaNEZ4ownl3Ouh05IH24w== X-Google-Smtp-Source: AGHT+IH4xgnJzuB+XNt+jzT483aoD47ewEooA1HsXBJo4l0GdOSXNStDt7eSLXB9clNpK1YrY0NVWw== X-Received: by 2002:a05:6512:3b0d:b0:530:e1ee:d95 with SMTP id 2adb3069b0e04-536587aa5c7mr1439310e87.1.1725616252386; Fri, 06 Sep 2024 02:50:52 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-536571b89e3sm180503e87.53.2024.09.06.02.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 02:50:51 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: linux-mm@kvack.org, Andrew Morton Cc: LKML , Baoquan He , Christoph Hellwig , Michal Hocko , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages Date: Fri, 6 Sep 2024 11:50:49 +0200 Message-Id: <20240906095049.3486-1-urezki@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 48015120007 X-Stat-Signature: 1mrhqfypt89sh86rcwhf3phpskktpi33 X-Rspam-User: X-HE-Tag: 1725616255-879247 X-HE-Meta: U2FsdGVkX1+4poB7nTcQEBdWKUYGe4ZaDvh8bpRyw+Wno91IW4TJNEoztgRJ1izJ19RxNGeM6DlwGkPScC7wK9LA50Q4T1GAZvij5ujuLVTN7szId/E5bnmHY4ixTfKcx1yrNPB395K/f5aZL3dxaKdn34sRKlVGlFRzfiF/zBRoIX4zlPdn6M5uHYalxqNWmbVKc8Bzr9b91R60iuShxzja4VAgRKDMmaoVW+L74MHi6vDPfslBwUhW2WWKb9xD9oSk3d0Z9nN5g8uyf6Tot+MGibJUDCVb7XavXfGBvJTQ5xAImhODqiPJvfZuuvHqxxsod/WFT5cCUhDcad35eqVpGvBcN18vJrCpx+5nW1vdrFjvZ2kkmGS+qbUlBl5UTpQaUHBy+Kxrf+q9HVIGwcP1dDfM+mzJ3M8pcyXskPcX9pkrvj7CyOz1N4Tq4fYXrN3RLaxuuimn5FajPh7E/HR1s33QB/ztyGggXo1PMCu/jw3vitZ/vgziExNGdEpcBGS70KzPQ7c5FrMeTwuS48bStWQzIvoiLPGcVjB6pXoDerdeFES/Z4iKUVeShbPA1/9JeP4M0q6nJ7JcNRJB/IJmjeD9UhHA8Rtka17CRPxS/2JBBCBXt0MQ2eijlprLIDTPhen9gESwiQjvaNZvowjdgwpP/ZcCzmysS7TCC4iIfhiEODZEMCm1Uyiq92dTNl6x83G5hLohrJq6R6pJ5MwmmSxXfFArWIsZg65NdSl//ujOrF1NwvVLCGimsqHHENKad36pDU6NWEQY8dR6PJELNSUpd0Vx06x8H1PVzCcDkxTgVdIzNEvu7lsQ5ZYT11KrpjrzTasGQL8zb5FgMx21x29WwGpjXepTdqf1i1LEcEX8aQMMAiN9TxbhvXpnFnhK8Q6SWM7dgSvMIhV14G6XS62IbkGX0b5+qzKRmtcq1KftYN3QeTxAuGC2rpFyT/hjrshNlqYkFsM/8OI emKBhHQ9 Oee0zDbOHf1f8u4rhQ6zH5TMnIWw0BIgezDTQPi80j/xpB3QySpR5H7ouDhLzpe0CjBgu6ewTbVsSEnY4Vp/OKlVMZeZc6E93XThVc3UERdu+W6krZHFaZOnEHtl7KC4xDye2j5fYKda/2oiUStGkh/09055eL5By1KJr3JrIicbaygSfEAniwU+SO3Rvhy6ea2Q8W38uQcpuVmkBNeDPlgZvF/F7Vs0t4r33SKCSEcxBH689SEpWuwEes+/8mF/kE1duin3t3RR4LJOQAGWMxDApkX6cR8c7i8hvzPMFY78KmGlDfFsDeBCoFd9uKRjaqJHVb+TUz8fg4KRDNDo3V/4fPnTYwYL+thFMwXtpeyztF1GECqvpkBJl+H7JZfrzDZ2v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In many places, in the comments, we use both "higher-order" and "high-order" to describe the non 0-order pages. That is confusing, because a "higher-order" statement does not reflect what it is compared with. Suggested-by: Baoquan He Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Baoquan He --- mm/vmalloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 37b6e987234e..c7bd8740b8a2 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3590,7 +3590,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, break; /* - * Higher order allocations must be able to be treated as + * High-order allocations must be able to be treated as * independent small pages by callers (as they can with * small-page vmallocs). Some drivers do their own refcounting * on vmalloc_to_page() pages, some use page->mapping, @@ -3653,7 +3653,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, page_order = vm_area_page_order(area); /* - * Higher order nofail allocations are really expensive and + * High-order nofail allocations are really expensive and * potentially dangerous (pre-mature OOM, disruptive reclaim * and compaction etc. *