Message ID | 20240909012958.913438-3-feng.tang@intel.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6622ACD4F4C for <linux-mm@archiver.kernel.org>; Mon, 9 Sep 2024 01:30:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1CFC6B00FC; Sun, 8 Sep 2024 21:30:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCC596B00FE; Sun, 8 Sep 2024 21:30:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6D9F6B00FF; Sun, 8 Sep 2024 21:30:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A7CB86B00FC for <linux-mm@kvack.org>; Sun, 8 Sep 2024 21:30:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 12117160BCE for <linux-mm@kvack.org>; Mon, 9 Sep 2024 01:30:14 +0000 (UTC) X-FDA: 82543469148.13.599C9B5 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf30.hostedemail.com (Postfix) with ESMTP id DD1388000E for <linux-mm@kvack.org>; Mon, 9 Sep 2024 01:30:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jDz1jhGK; spf=pass (imf30.hostedemail.com: domain of feng.tang@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=feng.tang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725845277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2rD/2vlH1Beqh3HFAyv0sq8bJP93CMB8SMvlgU7yd5k=; b=oV34Wt95mCGUW8KMlBjtM5RejhbWuBKmer9mwXya0I3bcTux2u5FZiODM0K8JfJzFdati9 pHR1QEhtV2yDQ8GWuP4R6cE5EfZXsf+q7XYB41XtIosLbuSbNu4w6k6y0vtx1QWM5GMtZz icJ4cphNgMTzafpRCEaclsX+BThvEFY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jDz1jhGK; spf=pass (imf30.hostedemail.com: domain of feng.tang@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=feng.tang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725845277; a=rsa-sha256; cv=none; b=gRf3ZiFPwOdEum1JRxFNtXPXxc4ZRDmghafJ/xUHC9JeEjf5r4qQhO0tZEkhrqynffFnnl PaFbOwOFz1EzfZcb6FZUIOfdoiUY4CIPxdB3Cgq1mRffUMyRx4em1Pwp0HYrTEqHTZYBsF nrhx+2K8Vr/cQj61q127it3upOpVKK8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725845412; x=1757381412; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XQhb14NwobzgpHBJToS+EBksbjOmwkl1vy/zAbUzlvA=; b=jDz1jhGKJRnFkH03NhfTiJFMUEeUKuQN+DywzQYCi97G1/3rDoI9F0OC fchBMfq/m+xf+Fq10auRWA0nI6TYwrfQupIkZh7NntObMpNWtadoNobBP PMLkTXus+s2cwDuSW6xicI+FqG+1/IUfcb8oGveUV33vSKDiZisVTMhhD tdIcwFVTgdnZUYVlKW/I+2P1dPX9ZVVkDpVnMQWClQLtYtm88xnZpwvCo LeBH3YRR1WUgt2lKnYx2fGNmjp7D1af8TfhoMhDCjba2/WsNdOXqg/OdN yyO8qx7Iv0MMXf/6RDkX8xKcTY8jiL7fZGXW3yT8ToOmYQBzo9e+Vj4jE A==; X-CSE-ConnectionGUID: ecBi6vlySRiiIigcj6eg0g== X-CSE-MsgGUID: ssg+OqlHTFO7z7Eg/CAfHw== X-IronPort-AV: E=McAfee;i="6700,10204,11189"; a="28258117" X-IronPort-AV: E=Sophos;i="6.10,213,1719903600"; d="scan'208";a="28258117" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2024 18:30:11 -0700 X-CSE-ConnectionGUID: DjU4Ii44RO+mC+79SYUM9Q== X-CSE-MsgGUID: wZvquO98SZKlH1AaBHu3rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,213,1719903600"; d="scan'208";a="66486450" Received: from feng-clx.sh.intel.com ([10.239.159.50]) by orviesa009.jf.intel.com with ESMTP; 08 Sep 2024 18:30:07 -0700 From: Feng Tang <feng.tang@intel.com> To: Vlastimil Babka <vbabka@suse.cz>, Andrew Morton <akpm@linux-foundation.org>, Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Roman Gushchin <roman.gushchin@linux.dev>, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov <andreyknvl@gmail.com>, Marco Elver <elver@google.com>, Shuah Khan <skhan@linuxfoundation.org>, David Gow <davidgow@google.com>, Danilo Krummrich <dakr@kernel.org> Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Feng Tang <feng.tang@intel.com> Subject: [PATCH 2/5] mm/slub: Consider kfence case for get_orig_size() Date: Mon, 9 Sep 2024 09:29:55 +0800 Message-Id: <20240909012958.913438-3-feng.tang@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240909012958.913438-1-feng.tang@intel.com> References: <20240909012958.913438-1-feng.tang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DD1388000E X-Stat-Signature: o8u33rnosisbg84hbbh36qe6he6yihzk X-Rspam-User: X-HE-Tag: 1725845411-711213 X-HE-Meta: U2FsdGVkX1+RFmYJ0Pu7vzk9T2QeyUG+Vszzsa7Glho68Rbp1SorRu+HyoU600x5b/zMhYQiZ7M9O0QDPbNWAE1IDUwfcBAQgw4gqY3ecPcj1lU8iDr73iiq34JyVmBn4BvOYhSoAuLi+1IZ5dmqoMPTiX250N8IX3v2QPHyV0RF6ZDnVtOF8yj6sZ9rDFIyojHB1Tn0Jnxs/im0xY7a9q1vBmZjQ3CQvRjOs1KCUFW7kXyVxz1kbgyMMVWdkIH709Bt8/s8m5cijS5NYcm0HVcp5C2R9OJAv0EDkgS2R9HVjbLdWSM0jgsZpYAhqFhPupeTj53uhp38z0syYhVG/WnCSihY4A8eMEx0jcGk8zIz9BqkbmKhaLXGapbKaCWs6zkow8ev538ebzxG4qXkw7HgC8C5bzoilngN40qzS/Qfxx5UCPeR+rIOebG2gn5PPGmFX2w+IrIV6ucR6r9Y3SSDohpP0W/fJkn6p6MPH7nkymrfelK9easj6Ojzr8mPOTW1iRrWxnQZUn11P6E6Z03jk8lk1vWeCScuuNWFQiY7LJqkT7mjQ3F5R4QFAOYzx4fcnLJT2lDdGXgEdMTiKiu4fJE8xg5spafljZE7B2xwRQe2FxFpL9toLS2KTCde/bG3zeUzS3+1Tyb0zZLEczoxQy0ubRpaHl4lkz/cUMPfOPUBk1IrsnuXOwYcnrH2MxucOu4wvgexPCvsX8gyx3oP1Z3O/4jIHJsijkV4j58+ltRtqfmlhH3k0Cy/AygeaqOs982oq5MdViOUduxSA5kmJgINivS5SByh4yNaY5PMmTsmP3uY0oyWNaCfeOAy2fUCIIafW5/gUjSi+W2cr2H7cPQgjEI70Su3SD2kvdTSJLUM26V2MNm88H/0CzUn//0RnJ0j69HPNu+kiYo9B1Z+SV1/25KtZcA7LquZwvCvdgf+RqeRm7Bhm1Pah8wNr9cEyYEnM7adKRNSgb+ fFRjR2+M 25MWRDmVOZwHkzAtRKc4dYQ58VWM8hCJ5uWsQ/rdtnN67kMkGKVXIWZaG7jr7k/KN27Gdd3MCqcv/sZQI+74pkBUGGsHeJrmNaPpYk3bZmGT78lhDfFCkhHlngwvw9naUX0d520DbdRwIWCuaY18oZdv4oPyvhawHGxfIVxmLd5ETOe+U+BgHmad2FKWKneLDzH+zZNpJJqDh6g14YVQ75qNNJe/HVifx/hkMwr5AYjT36S0/gIst2vTw7Sw6vdVKFY8dCAjBKAbzcgJQ4WWnR+Uts/NpcWATJOMkcZgsuypy7VM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/slub: Improve data handling of krealloc() when orig_size is enabled
|
expand
|
diff --git a/mm/slub.c b/mm/slub.c index 996a72fa6f62..4cb3822dba08 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -768,7 +768,7 @@ static inline unsigned int get_orig_size(struct kmem_cache *s, void *object) { void *p = kasan_reset_tag(object); - if (!slub_debug_orig_size(s)) + if (!slub_debug_orig_size(s) || is_kfence_address(object)) return s->object_size; p += get_info_end(s);
When 'orig_size' of kmalloc object is enabled by debug option, it should either contains the actual requested size or the cache's 'object_size'. But it's not true if that object is a kfence-allocated one, and its 'orig_size' in metadata could be zero or other values. This is not a big issue for current 'orig_size' usage, as init_object() and check_object() during alloc/free process will be skipped for kfence addresses. As 'orig_size' will be used by some function block like krealloc(), handle it by returning the 'object_size' in get_orig_size() for kfence addresses. Signed-off-by: Feng Tang <feng.tang@intel.com> --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)