From patchwork Wed Sep 11 09:04:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13800000 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6E6EE021F for ; Wed, 11 Sep 2024 09:07:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 525FB940016; Wed, 11 Sep 2024 05:07:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 436B3940015; Wed, 11 Sep 2024 05:07:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C93940016; Wed, 11 Sep 2024 05:07:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F2811940011 for ; Wed, 11 Sep 2024 05:07:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A96D9810C3 for ; Wed, 11 Sep 2024 09:07:22 +0000 (UTC) X-FDA: 82551878724.04.43476DF Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf01.hostedemail.com (Postfix) with ESMTP id B02FE40004 for ; Wed, 11 Sep 2024 09:07:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726045536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnBlZUP3iItYr0xKaaMAqVnO+5dW24mPvh/robH8+Vw=; b=UI4ZkwU3azPuYOe4oFuigvNrFwZLlewXGnXwwpTW73ctQ3VKatuwu3BHQXYrQqY5c9Yom3 UV06DflOTGGt93BWOcYnr3DxwJfsqWMiJAI2O/ZvLr6DSMBjJx1PitSstpr15n2VJKhgSj RamWCkrh/VNf9LXwsFpGKLb8e1ulF9k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726045536; a=rsa-sha256; cv=none; b=WQ9pD8az+24HmZJ/k7NnGXq0r7mAy0Me9HanJePz3LXGiNgcANBeh0nJ/VY86BSGITVqws wKkJJROQCWVanL+raPJ1w5cuL/1LUi9RF2vfvs0iK5uSSFQxcu3kwsFsnaDt2cJWxv5p4E 5Lb74cvTSjnE+wW181C3PEBMIQCle6Q= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4X3ZNQ49NTz6K8gL; Wed, 11 Sep 2024 17:03:02 +0800 (CST) Received: from frapeml500007.china.huawei.com (unknown [7.182.85.172]) by mail.maildlp.com (Postfix) with ESMTPS id 745DF140B55; Wed, 11 Sep 2024 17:07:00 +0800 (CST) Received: from P_UKIT01-A7bmah.china.huawei.com (10.195.245.151) by frapeml500007.china.huawei.com (7.182.85.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 11 Sep 2024 11:06:57 +0200 From: To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v12 01/17] EDAC: Add support for EDAC device features control Date: Wed, 11 Sep 2024 10:04:30 +0100 Message-ID: <20240911090447.751-2-shiju.jose@huawei.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20240911090447.751-1-shiju.jose@huawei.com> References: <20240911090447.751-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.195.245.151] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To frapeml500007.china.huawei.com (7.182.85.172) X-Stat-Signature: dhdpn16cxq7rh9kg6hygiyo3pi3wss1g X-Rspamd-Queue-Id: B02FE40004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1726045640-625952 X-HE-Meta: U2FsdGVkX187gMlcqlYs68b1tuY9x1OI4Ir6LKR2QeMgM5TD5RQcrjq+m8FvuW08wqBK7LjecwQp5AlA/tx7u7H/WP9dMdxQTqvYkc1hNBd8v7xjUjZ8pvQ93wK1RZ+qpOIlGgr22tOWulJHRH0XJkwLfvOdRwIRY+7bCBWme8uAMvuAZifZTeBcnSqu7MHNjfUWttkufMu/+9dYTrrDwn0NGArl4diE93sKjYJlBudgTtZ48RkXUfnHVzDz7BskKDmdnmFnsaNBSrpoo+/GJg1WlMbl9nmB1ENHDAcUVDzwNBwBNdb6qaiUhZU+fYtLk+bbBtxZeofLeHYdz39tz8EcgOSpLMX68iEgfQHQb7bC0a/e/tr34gJPhb9byIZIcDJYElZz/0B31JQJwDyI2HdejyIqPLVZlbx2y5LcI0PQbEYjIbY0gwjMvc3vu8avwMo0U8u7nHOsEcZSfg+fZ2soHk7260Xzbu3KlsWBIpfIzi2kRpAhfYxZTCiVhWa7R57nnIe+jTB2iUZEwd01qY8mSbinOt9vqUKC6OtZ2SQdEBe/3D2Lu3d7DJJomnbf2XBr8VtHi+l170/TQJ8i2RPj/EES6+Pi7mWBoYi6pwy8UYcYJ6bBQZeu44JTL4ZfYFWmaMWMTDYU+8Ogi7F7R/GDcq/GFsKKW2fiVxuZL0UnjfN+zVKsMIiL7ejCc8MX71PuTv+vv9GkzYXwSZ4CEC/d+WUORsDghLYJfSq50PIRWKdRvIcboNjmTF69cxYkf+jhD+iDL0/o9V+U6SDC9jFj26e+robzzA5PXymVEYsFujMyTdo2YAbTSolz82bzWJXizszTc7bSazOy/x6gSWQyKq6AqU7Oyd7HDIM2ZinXmkSmPCtl/cSw1/r2hco2snuidZ5TOqUvtc32vVDZIjZ9KnJs5Va8ARmoclXI1SmyndSg9q/tEjKCzntDR6VneqTZnUcHglXHEMPxWY7 waiizamU P+2fZCwbF/xvj2QaOde6bkgzBm3EL6Sblmbixq3qW0ozKahlYOZj6wy9OSYty7ZB0NNXFpbc0K0uqm+mpK6Be4Yk1h9+ZF6YzVUie88ifLYtHHqayb6HduzPCiDrzT+h+81dvCQ2U3zgZsKKJjKFgma8XK0v/OCS3auek8hSBfyNf+O/KhkOFHyDqjzJcsMq5o5/aSdwbvigLUlYHuRcmAtxywg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add generic EDAC device features control supports registering RAS features supported in the system. Driver exposes features control attributes to userspace in /sys/bus/edac/devices/// Co-developed-by: Jonathan Cameron Signed-off-by: Jonathan Cameron Signed-off-by: Shiju Jose --- drivers/edac/edac_device.c | 202 +++++++++++++++++++++++++++++++++++++ include/linux/edac.h | 55 ++++++++++ 2 files changed, 257 insertions(+) diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 621dc2a5d034..e4a5d010ea2d 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -570,3 +570,205 @@ void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev, block ? block->name : "N/A", count, msg); } EXPORT_SYMBOL_GPL(edac_device_handle_ue_count); + +/* EDAC device feature */ +static void edac_dev_release(struct device *dev) +{ + struct edac_dev_feat_ctx *ctx = container_of(dev, struct edac_dev_feat_ctx, dev); + + kfree(ctx->ppr); + kfree(ctx->scrub); + kfree(ctx->dev.groups); + kfree(ctx); +} + +const struct device_type edac_dev_type = { + .name = "edac_dev", + .release = edac_dev_release, +}; + +static void edac_dev_unreg(void *data) +{ + device_unregister(data); +} + +/** + * edac_dev_feature_init - Init a RAS feature + * @parent: client device. + * @dev_data: pointer to the edac_dev_data structure, which contains + * client device specific info. + * @feat: pointer to struct edac_dev_feature. + * @attr_groups: pointer to attribute group's container. + * + * Returns number of scrub features attribute groups on success, + * error otherwise. + */ +static int edac_dev_feat_init(struct device *parent, + struct edac_dev_data *dev_data, + const struct edac_dev_feature *ras_feat, + const struct attribute_group **attr_groups) +{ + int num; + + switch (ras_feat->ft_type) { + case RAS_FEAT_SCRUB: + dev_data->scrub_ops = ras_feat->scrub_ops; + dev_data->private = ras_feat->ctx; + return 1; + case RAS_FEAT_ECS: + num = ras_feat->ecs_info.num_media_frus; + dev_data->ecs_ops = ras_feat->ecs_ops; + dev_data->private = ras_feat->ctx; + return num; + case RAS_FEAT_PPR: + dev_data->ppr_ops = ras_feat->ppr_ops; + dev_data->private = ras_feat->ctx; + return 1; + default: + return -EINVAL; + } +} + +/** + * edac_dev_register - register device for RAS features with EDAC + * @parent: client device. + * @name: client device's name. + * @private: parent driver's data to store in the context if any. + * @num_features: number of RAS features to register. + * @ras_features: list of RAS features to register. + * + * Returns 0 on success, error otherwise. + * The new edac_dev_feat_ctx would be freed automatically. + */ +int edac_dev_register(struct device *parent, char *name, + void *private, int num_features, + const struct edac_dev_feature *ras_features) +{ + const struct attribute_group **ras_attr_groups; + struct edac_dev_data *dev_data; + struct edac_dev_feat_ctx *ctx; + int scrub_cnt = 0, scrub_inst = 0; + int ppr_cnt = 0, ppr_inst = 0; + int attr_gcnt = 0; + int ret, feat; + + if (!parent || !name || !num_features || !ras_features) + return -EINVAL; + + /* Double parse to make space for attributes */ + for (feat = 0; feat < num_features; feat++) { + switch (ras_features[feat].ft_type) { + case RAS_FEAT_SCRUB: + attr_gcnt++; + scrub_cnt++; + break; + case RAS_FEAT_PPR: + attr_gcnt++; + ppr_cnt++; + break; + case RAS_FEAT_ECS: + attr_gcnt += ras_features[feat].ecs_info.num_media_frus; + break; + default: + return -EINVAL; + } + } + + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + ctx->dev.parent = parent; + ctx->private = private; + + ras_attr_groups = kcalloc(attr_gcnt + 1, sizeof(*ras_attr_groups), GFP_KERNEL); + if (!ras_attr_groups) { + ret = -ENOMEM; + goto ctx_free; + } + + if (scrub_cnt) { + ctx->scrub = kcalloc(scrub_cnt, sizeof(*(ctx->scrub)), GFP_KERNEL); + if (!ctx->scrub) { + ret = -ENOMEM; + goto groups_free; + } + } + + if (ppr_cnt) { + ctx->ppr = kcalloc(ppr_cnt, sizeof(*(ctx->ppr)), GFP_KERNEL); + if (!ctx->ppr) { + ret = -ENOMEM; + goto groups_free; + } + } + + attr_gcnt = 0; + for (feat = 0; feat < num_features; feat++, ras_features++) { + switch (ras_features->ft_type) { + case RAS_FEAT_SCRUB: + if (!ras_features->scrub_ops) + continue; + if (scrub_inst != ras_features->instance) + goto data_mem_free; + dev_data = &ctx->scrub[scrub_inst]; + dev_data->instance = scrub_inst; + scrub_inst++; + break; + case RAS_FEAT_ECS: + if (!ras_features->ecs_ops) + continue; + dev_data = &ctx->ecs; + break; + case RAS_FEAT_PPR: + if (!ras_features->ppr_ops) + continue; + if (ppr_inst != ras_features->instance) + goto data_mem_free; + dev_data = &ctx->ppr[ppr_inst]; + dev_data->instance = ppr_inst; + ppr_inst++; + break; + default: + ret = -EINVAL; + goto data_mem_free; + } + ret = edac_dev_feat_init(parent, dev_data, ras_features, + &ras_attr_groups[attr_gcnt]); + if (ret < 0) + goto data_mem_free; + + attr_gcnt += ret; + } + + ras_attr_groups[attr_gcnt] = NULL; + ctx->dev.bus = edac_get_sysfs_subsys(); + ctx->dev.type = &edac_dev_type; + ctx->dev.groups = ras_attr_groups; + dev_set_drvdata(&ctx->dev, ctx); + + ret = dev_set_name(&ctx->dev, name); + if (ret) + goto data_mem_free; + + ret = device_register(&ctx->dev); + if (ret) { + put_device(&ctx->dev); + goto data_mem_free; + return ret; + } + + return devm_add_action_or_reset(parent, edac_dev_unreg, &ctx->dev); + +data_mem_free: + if (ppr_cnt) + kfree(ctx->ppr); + if (scrub_cnt) + kfree(ctx->scrub); +groups_free: + kfree(ras_attr_groups); +ctx_free: + kfree(ctx); + return ret; +} +EXPORT_SYMBOL_GPL(edac_dev_register); diff --git a/include/linux/edac.h b/include/linux/edac.h index b4ee8961e623..b337254cf5b8 100644 --- a/include/linux/edac.h +++ b/include/linux/edac.h @@ -661,4 +661,59 @@ static inline struct dimm_info *edac_get_dimm(struct mem_ctl_info *mci, return mci->dimms[index]; } + +/* EDAC device features */ + +#define EDAC_FEAT_NAME_LEN 128 + +/* RAS feature type */ +enum edac_dev_feat { + RAS_FEAT_SCRUB, + RAS_FEAT_ECS, + RAS_FEAT_PPR, + RAS_FEAT_MAX +}; + +struct edac_ecs_ex_info { + u16 num_media_frus; +}; + +/* + * EDAC device feature information structure + */ +struct edac_dev_data { + union { + const struct edac_scrub_ops *scrub_ops; + const struct edac_ecs_ops *ecs_ops; + const struct edac_ppr_ops *ppr_ops; + }; + u8 instance; + void *private; +}; + +struct device; + +struct edac_dev_feat_ctx { + struct device dev; + void *private; + struct edac_dev_data *scrub; + struct edac_dev_data ecs; + struct edac_dev_data *ppr; +}; + +struct edac_dev_feature { + enum edac_dev_feat ft_type; + u8 instance; + union { + const struct edac_scrub_ops *scrub_ops; + const struct edac_ecs_ops *ecs_ops; + const struct edac_ppr_ops *ppr_ops; + }; + void *ctx; + struct edac_ecs_ex_info ecs_info; +}; + +int edac_dev_register(struct device *parent, char *dev_name, + void *parent_pvt_data, int num_features, + const struct edac_dev_feature *ras_features); #endif /* _LINUX_EDAC_H_ */