diff mbox series

[1/1] mm/mempolicy: fix comments for better documentation

Message ID 20240914151801.4388-1-tanyaagarwal25699@gmail.com (mailing list archive)
State New
Headers show
Series [1/1] mm/mempolicy: fix comments for better documentation | expand

Commit Message

Tanya Agarwal Sept. 14, 2024, 3:18 p.m. UTC
From: Tanya Agarwal <tanyaagarwal25699@gmail.com>

- Fix typo in mempolicy.h
- Correct the number of allowed memory policy

Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
---
 include/linux/mempolicy.h | 2 +-
 mm/mempolicy.c            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Shuah Khan Sept. 20, 2024, 12:59 p.m. UTC | #1
On 9/14/24 09:18, Tanya Agarwal wrote:
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> 
> - Fix typo in mempolicy.h
> - Correct the number of allowed memory policy

You don't need to say 1/1 for a single patch.

Please write changelog in paragraph form. Also mention how you found
the problem and include putput from the tool to find the problem.

> 
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> ---
>   include/linux/mempolicy.h | 2 +-
>   mm/mempolicy.c            | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
> index 1add16f21612..ce9885e0178a 100644
> --- a/include/linux/mempolicy.h
> +++ b/include/linux/mempolicy.h
> @@ -47,7 +47,7 @@ struct mempolicy {
>   	atomic_t refcnt;
>   	unsigned short mode; 	/* See MPOL_* above */
>   	unsigned short flags;	/* See set_mempolicy() MPOL_F_* above */
> -	nodemask_t nodes;	/* interleave/bind/perfer */
> +	nodemask_t nodes;	/* interleave/bind/preferred/etc */
>   	int home_node;		/* Home node to use for MPOL_BIND and MPOL_PREFERRED_MANY */
>   
>   	union {
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index b858e22b259d..613fdb73c404 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -8,7 +8,7 @@
>    * NUMA policy allows the user to give hints in which node(s) memory should
>    * be allocated.
>    *
> - * Support four policies per VMA and per process:
> + * Support six policies per VMA and per process:
>    *
>    * The VMA policy has priority over the process policy for a page fault.
>    *

With these fixed:

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
index 1add16f21612..ce9885e0178a 100644
--- a/include/linux/mempolicy.h
+++ b/include/linux/mempolicy.h
@@ -47,7 +47,7 @@  struct mempolicy {
 	atomic_t refcnt;
 	unsigned short mode; 	/* See MPOL_* above */
 	unsigned short flags;	/* See set_mempolicy() MPOL_F_* above */
-	nodemask_t nodes;	/* interleave/bind/perfer */
+	nodemask_t nodes;	/* interleave/bind/preferred/etc */
 	int home_node;		/* Home node to use for MPOL_BIND and MPOL_PREFERRED_MANY */
 
 	union {
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index b858e22b259d..613fdb73c404 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -8,7 +8,7 @@ 
  * NUMA policy allows the user to give hints in which node(s) memory should
  * be allocated.
  *
- * Support four policies per VMA and per process:
+ * Support six policies per VMA and per process:
  *
  * The VMA policy has priority over the process policy for a page fault.
  *