From patchwork Thu Oct 3 15:29:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vincenzo Frascino X-Patchwork-Id: 13821163 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44003CF34B0 for ; Thu, 3 Oct 2024 15:29:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAAE86B0476; Thu, 3 Oct 2024 11:29:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B32F96B0478; Thu, 3 Oct 2024 11:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 986866B0477; Thu, 3 Oct 2024 11:29:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 77B9A6B0400 for ; Thu, 3 Oct 2024 11:29:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2C646C1700 for ; Thu, 3 Oct 2024 15:29:26 +0000 (UTC) X-FDA: 82632675132.10.98A4E57 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 7F608180010 for ; Thu, 3 Oct 2024 15:29:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727969269; a=rsa-sha256; cv=none; b=riFQc+5w1jPxVjWmeIOqoMjfcRF7XVPtaHvY/y5QwHUKzzaicVf6sOtw4wff3Rlk58Jtvk ycFKhYBz9L9OqlDHOpNqfZl9eC4HRHaUSqoO8ecMrVpltuZ4+DRsmAnBNRD1PDRsaYY3hN a9dryguhlIs1VlY8lJr9vg6VpehdqH4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727969269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dOaH9Tm+8hlINETgYKYKnAhOS1xwlxi07qA8yD5Vww8=; b=on52818BTEkG6iUwL52z23WFH2i1jRXjz2qOdhf7vZfnwZGEbb7ZKWKrhBqPLE8QLixuT4 I+N1hAB7y0CfTRIoVa70xOCoZ4TKeD/fGWhlsY8O/KInkSB690QdWJaICH94KDEPxlCLiP p6onPFxcCZA16Bi1Wf6jkqRzRB/gsJM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 245E014BF; Thu, 3 Oct 2024 08:29:53 -0700 (PDT) Received: from e119884-lin.cambridge.arm.com (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF29F3F640; Thu, 3 Oct 2024 08:29:20 -0700 (PDT) From: Vincenzo Frascino To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Vincenzo Frascino , Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Subject: [PATCH v3 1/2] drm: Fix fault format Date: Thu, 3 Oct 2024 16:29:09 +0100 Message-Id: <20241003152910.3287259-2-vincenzo.frascino@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241003152910.3287259-1-vincenzo.frascino@arm.com> References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 7F608180010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hfefm5cu8x5ssunpkun3wizz7sbub5sz X-HE-Tag: 1727969364-474317 X-HE-Meta: U2FsdGVkX1/f3bd70WtfcgYyvQ1hUrW1BlhUSHsmjAOFmzj9bfYBdP1GdGRsNQKrjuePfVqbbxyaTTD47IMPqAtPqOdS4mQg8xi5Nj1WfDF7zYclQku9k9GNvY1jZMpcgi7S2Lo6kNF8abd/Dy7x9EWBg8dNV6Doj5TzJdV2k7Jt9lEp28ovks2j0WLUBI4dPV+5s0ae54/VP9sWJT1czDrhFxgm27QbbPgzFk7KlzXzY4FsYnWSK3nz/7N5n1OxJJV0MRBB/W18a+NJ6sITei/Aae3ao961IEZe6Ua67B3ePiFdKfMq8WTDerdWLt0VSc8SQcFgGfwps8oZJS8bZYOOuoEW5wYajPRaRrBuncjBAGPCgPVAz6TrX7AYOUlVplyvFLWbp1H9aiHuZQwjPf5k74kTbT4P8vPo1b71yOHSeLDO4sXBiHTOkkZItCsS8BtKlyrTugNU8WWwM1lmUXpLPwd98woGlhMUP5DO5oX/OjL07JH73nXAm/2VGf6YLlr44GM85nz3GhmwQGJPhhIzsInpJT/UNj+LelzFzldRPiIq32RAh0wvvHARJ8ZMTEFU59Kx+lHu9DX5pUj3oLkqUgjo/mEbPrtsQngPp8UtzHMPsvSC0nuPnVwVLpjKZAlJpJ/mPrEZ6ie2ZkFkujYl2w4A9v0YS4AJln//KFMRNS7SSjCmxCMnykNvgpDVCqKNKIJ593lVzBesfLeQWwLB+J7Kbbo82q/bTnRK+h6r9JXfWELUT4x3E2zzq3bd6POH0u1oqsg0MWdB5iUsmReFOsLpRz5jzERv5/WtA2HjNJNmG1XOnK8c0pUyvA2Zxpj6tf1X4krUGGAIjlrB2IPHHn74qUrpgoKewrDTMZ1SJMs8O6zxVT7yX5TadAKB+s/M8hbu8AQOncOMY24ylylocoQJ7+wT9nLEiWOVRCMtB+e1GWEjTpzH3z5yKVccIl5STDrorG6CldwHkrr AsJtN5lO TuxZnfyBCKd9EzTBXTiHtyuQdAhRv4W8B2DnyqkkpzE1P5V16ZmNi1ufSVPcMlbQpMCKFXEBLIL7MZHYXXFA1NDuiIk88roMZR4aJJHvsPuoqz3q7mwvl4aMchOi+hW29aPbjQ5xqWJ5ui2lnVxjDlweMsfHrUQB/qZaCeKwREF5zydLyR1QFrcZTW15TbMcngz8WTpHsnp4ey3leqh562cHJ7wiUS565aCnYnE8GcA3Xv0z0Zxl+/7i+TNy+G63j6KbDzpejyx3a4A3E3218tSYv4xJMyPb4UT8c2brpraiXU3EZlSG6/3Pv22xQtOSTcHYRboGSIqn/dP0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fault is of type u32 and PAGE_MASK is type agnostic, hence the correct format for address should be %x not %lx otherwise: drivers/gpu/drm/i915/gt/intel_gt_print.h:29:36: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘u32’ {aka ‘unsigned int’} [-Werror=format=] 29 | drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, | ^~~~~~~~ include/drm/drm_print.h:424:39: note: in definition of macro ‘drm_dev_dbg’ 424 | __drm_dev_dbg(NULL, dev, cat, fmt, ##__VA_ARGS__) | ^~~ include/drm/drm_print.h:524:33: note: in expansion of macro ‘drm_dbg_driver’ 524 | #define drm_dbg(drm, fmt, ...) drm_dbg_driver(drm, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~~~~ linux/drivers/gpu/drm/i915/gt/intel_gt_print.h:29:9: note: in expansion of macro ‘drm_dbg’ 29 | drm_dbg(&(_gt)->i915->drm, "GT%u: " _fmt, (_gt)->info.id, | ^~~~~~~ drivers/gpu/drm/i915/gt/intel_gt.c:310:25: note: in expansion of macro ‘gt_dbg’ 310 | gt_dbg(gt, "Unexpected fault\n" | ^~~~~~ Fix address format. Cc: Arnd Bergmann Cc: Andy Lutomirski Cc: Thomas Gleixner Cc: Jason A. Donenfeld Suggested-by: Christophe Leroy Signed-off-by: Vincenzo Frascino --- drivers/gpu/drm/i915/gt/intel_gt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index a6c69a706fd7..352ef5e1c615 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -308,7 +308,7 @@ static void gen6_check_faults(struct intel_gt *gt) fault = GEN6_RING_FAULT_REG_READ(engine); if (fault & RING_FAULT_VALID) { gt_dbg(gt, "Unexpected fault\n" - "\tAddr: 0x%08lx\n" + "\tAddr: 0x%08x\n" "\tAddress space: %s\n" "\tSource ID: %d\n" "\tType: %d\n",