From patchwork Mon Oct 7 14:49:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 13824831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36C1CFB443 for ; Mon, 7 Oct 2024 14:50:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 818016B00A6; Mon, 7 Oct 2024 10:50:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 778A36B00A7; Mon, 7 Oct 2024 10:50:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CAB56B00A8; Mon, 7 Oct 2024 10:50:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3419E6B00A6 for ; Mon, 7 Oct 2024 10:50:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CCC98A17B1 for ; Mon, 7 Oct 2024 14:50:56 +0000 (UTC) X-FDA: 82647093312.10.24F533F Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf30.hostedemail.com (Postfix) with ESMTP id EB2678000B for ; Mon, 7 Oct 2024 14:50:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bVKYqzBU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728312507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7VwBx3mFnKYzOzVHPezqvf6E6t3GSTY/lMuePwrb08s=; b=4Yk3acYxVl2g4IFAkq/m5A/fhknWHw4HXTUMtd13RY0Ai0teudB8Whyrn0lcaO1k58gNC+ 1Dl3EbVhqwoAhG8fwJdiwRaXicT2lXKw6orMr6hwYNipAIHmvw/JkEUA9bDEJyyVLCBh2z Rg/O9I3IONMDxhsqZ6Rxm3sLh1aIGVs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728312507; a=rsa-sha256; cv=none; b=Vkm1if8Dd5WLDtkBDNLKl4VRaeyQwb/yyYAmW+9etuDe4zHt5R1dw4rZmrJYNkjwFMfCLK IIO1+EZMd5QfFvGrsC3HNCOeYpywqXNrLduvc6egT1wCUHJvrNLEed7NW/EBn6ggeSC/+6 XffLUYt836k8BWJF4GfmZKBOhxOJJoE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bVKYqzBU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7cd8803fe0aso3101988a12.0 for ; Mon, 07 Oct 2024 07:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728312654; x=1728917454; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7VwBx3mFnKYzOzVHPezqvf6E6t3GSTY/lMuePwrb08s=; b=bVKYqzBUtxOs5xby9W/Yz2BOrYWAr5HIG3gojQxFnksXC18MJnB5NVfjSDch3Q63pY 1djecYzYrTjfURtJDJrX63G3N+5eE+fhtsmYvrGIEVfYL9dn1myGOnP69p2QJPMcxMmS zZHq/OWaPfSfu9jsS7/++TpC547Jg/tTbQNjaj6PN59cw/vCob1ysvPw1z04lkyVw6gV R+z4XXaBxenYIDzzFtTCL6ZJnngyT8Rr+gtxvBb1c0tBLimTZe/sM2NC+6hETFIMrneF 9x2uuFYa3G81yLhAcePH+Ym2wtk/ZdIsWjGPo7mHOMNW+VA2VeTgMDGIjXsawWCYD1cr SAqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728312654; x=1728917454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7VwBx3mFnKYzOzVHPezqvf6E6t3GSTY/lMuePwrb08s=; b=Sna5vSffNxAY6hIw7tCMqGM7KD1yjXQ9/KlO3mDPgPyt2VOMjCMIFWgmbQkQz4DZ0j RGX3yooIz0Vcy4G9kyV9Aiy7K4sE8QwUFQrPaE3nBecr2AbyIWavp8W//Y7ML69l5+y5 xIgKUeIdOUJiRnLpBjPHQ3/QaNJncn81Gx6Vr4hMmgZ1Ljc/Mmb2QNHXXebmgoyrczFP mUgRO7ZpDnnOkQ8GDEHXgrpZBFdQWGE6y0+hAbtipbAwp7hS1UfNmSt2ZWT55un9Kavg TolR+9/uoCX1bUdvewh1A72qdZPQkzW3qbo6UysalLYUjU0Twj1uYHOwZ869HPQl0y9d zX4Q== X-Forwarded-Encrypted: i=1; AJvYcCXTD5T8ml3wfUZkU5sBvFfC97cbhYAbjDOc75xcY7bON7MR7uptppERJG751pg0DZS5IOsKNDjd9Q==@kvack.org X-Gm-Message-State: AOJu0YwCC/+Yc7vKRuD0xAcWgSkn92y3/3fbpF6ly5zun0R19ZY4R48Z 7fqOn2XOoJ7Rjsi+CgGTREbRMZ5CkcUrp1dB89Iu22+6oZ2aFCRd X-Google-Smtp-Source: AGHT+IEwpXCzalPlyOY9Cdfli1GLzxvFvEupvvujLKDDOEy0H0EsRpGoLeoHLvpBbBHNCnkbeHqgcw== X-Received: by 2002:a05:6a20:9f8f:b0:1d2:eb9d:997d with SMTP id adf61e73a8af0-1d6dfa23bccmr18227823637.7.1728312653634; Mon, 07 Oct 2024 07:50:53 -0700 (PDT) Received: from localhost.localdomain ([223.104.210.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0d7cf82sm4466432b3a.200.2024.10.07.07.50.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2024 07:50:53 -0700 (PDT) From: Yafang Shao To: akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, keescook@chromium.org, alx@kernel.org, justinstitt@google.com, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Yafang Shao , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Subject: [PATCH v9 7/7] drm: Replace strcpy() with strscpy() Date: Mon, 7 Oct 2024 22:49:11 +0800 Message-Id: <20241007144911.27693-8-laoar.shao@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20241007144911.27693-1-laoar.shao@gmail.com> References: <20241007144911.27693-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EB2678000B X-Stat-Signature: ocndtj4moty5d9d5gd3ct8wznf7jsjyd X-Rspam-User: X-HE-Tag: 1728312654-773998 X-HE-Meta: U2FsdGVkX1/KtdemWLCOF6TJiAfbdm/Px/iMs4Qj8zMP1ug7CcaPFSjwn97wZeiNHZZHwLA83Lt3LBgN5GKKTJgrQaTQzLWLEfxM4/LlfP0o9OzzHG/u/Lfeal0FrJ9Yeo1ou87tdsvEZqAyO9cuA4dmtXZ1AfC09QrPcMUVvZ5k0oJwBHZAQzC4ZCxThwVN2NLPiECxWSRtbnKCNYPikmwsJCtPqoGPsyApv+wvxB9S/1jy5UvqoQbm91ldtb4rQRKWDZ08S1NNLF88vMKHS8FQ37GDuHxVAgwSJe2Dh0covZ/0vNa3HLCKnRSxsHQPQ3YPpvfB7+Gt/XJJNidNlpCIMADI7o9fIViGWYLo8tLQZrp12wuCV3xKVruJiXDZQ/p0H0EyIqqtObl9P6drGRQRaWRaiYecKGsWVrvq4sedvKf5m1v68mpHdhGh/wArTb5L33ICbkNh1ODdVHrj9e8eCxuxPZ22jZuHS/v0t//4GD7aT2fZ0tHdV46Pl7N+CGIHtRkzJ2vdX+HSzu5+ZKQ+UP0M5dTSfBWHdoKxloq62bo05gMUKLi+WWz2kQKckJ7wmkOKTDsn8A2u/1d1iC4vy6pzU3xBBJDKGv85BBftiJEgPs/g0x++SQ2WSuZAvdpPQ2x1u+eBPCzi2ewK87LLYNC0zLc4CdyVsM+VDtjrpWfjq0svNACwJ0gjjPj/fFLfbt/3AMhY81Ja2vS6SxBb/z5gvVWDMYEBLonglDFQ82TQmV4HKPMhyLXZqE9AIwHwVi9pwssE6Q0nqXzkv4UlvPbH3RBYkMv0260IhZEMmfZwpmISsVI6u9Y5pthVaO7PIr8Y2Fcsbi8b00T4ZL3Tsf+VgNxEcHqWqlLnoc00EMUj3/nXXJaE/cjc6VXz6YKUht3GJY6LWg9EBf4nTxe78TuzxqCx7VAuGpsbqLAJocRX/82NyuftHOYDncpQ+7RdqgyEfavqmKqlQeq J8ZWO2c2 ttvub1bdl96jVokQkIWGmDtnNqen7wlJWq55KHNPhDXb6MyomM8BerTc1GrMjJEdVX8ucyk5ETGxGEJ6PN2NHOwzAjyymGVWEuEyY9WM3FW4fmYDC4XJiNytCP3gtUmwO8f4juV4/0hgTumMF/nhWGqmvbKtMPbzPpN9r2Fnw6r9DU7uNxFTVsudI+znAYX9G7H0SLry22P7mQdeumB+zghrqxQ7g4c1wdG5XJ3qdEE63AKonqqBILxHPWPErclfuSYO5u3R5URn2Bep4UiXE6BSWBLo3tQ6VtIrV+mkkQAHMx7PnII4V6+ZzPbYdGDLzR4cHHkuWlXCKtD8DofRJdV//5iabP/GVR5Dto1tLccDJMS5EFG50Ws4OqtNSKIuzXio8q5eFxJCw9wBoWUszMrJhSJd0KOXN589Hu5pF2btdW94gz+HXPr/aRyMUeGrWOpqBjrKLp/9k/BRKYVmRndskltDosR7wDpTWmBsA2SJyFOvqhZGfgP/yg8wTYx26/FFhrG31tuzr+rk8DiCWYp+4UPfRPeYdXDzOWxDsSSD27z4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To prevent errors from occurring when the src string is longer than the dst string in strcpy(), we should use strscpy() instead. This approach also facilitates future extensions to the task comm. Suggested-by: Justin Stitt Signed-off-by: Yafang Shao Acked-by: Daniel Vetter Reviewed-by: Justin Stitt Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie --- drivers/gpu/drm/drm_framebuffer.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index 888aadb6a4ac..2d6993539474 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, INIT_LIST_HEAD(&fb->filp_head); fb->funcs = funcs; - strcpy(fb->comm, current->comm); + strscpy(fb->comm, current->comm); ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB, false, drm_framebuffer_free); diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 6469b9bcf2ec..9d4b25b2cd39 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -1113,7 +1113,7 @@ i915_vma_coredump_create(const struct intel_gt *gt, } INIT_LIST_HEAD(&dst->page_list); - strcpy(dst->name, name); + strscpy(dst->name, name); dst->next = NULL; dst->gtt_offset = vma_res->start; @@ -1413,7 +1413,7 @@ static bool record_context(struct i915_gem_context_coredump *e, rcu_read_lock(); task = pid_task(ctx->pid, PIDTYPE_PID); if (task) { - strcpy(e->comm, task->comm); + strscpy(e->comm, task->comm); e->pid = task->pid; } rcu_read_unlock(); @@ -1459,7 +1459,7 @@ capture_vma_snapshot(struct intel_engine_capture_vma *next, return next; } - strcpy(c->name, name); + strscpy(c->name, name); c->vma_res = i915_vma_resource_get(vma_res); c->next = next;