From patchwork Tue Oct 8 06:17:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dev Jain X-Patchwork-Id: 13825669 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5928CCED26B for ; Tue, 8 Oct 2024 06:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C505F6B0085; Tue, 8 Oct 2024 02:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C00B36B0088; Tue, 8 Oct 2024 02:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC7556B0089; Tue, 8 Oct 2024 02:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8FC6C6B0085 for ; Tue, 8 Oct 2024 02:18:18 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 26BD6C1903 for ; Tue, 8 Oct 2024 06:18:17 +0000 (UTC) X-FDA: 82649430276.18.CDB4F2B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 8B256120005 for ; Tue, 8 Oct 2024 06:18:16 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728368117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q+iPYv8wG+OP8oDe8z/ynCOnB9a24SzjjUfifnvd9JU=; b=mHXp6IEFgzOs+vVYHkoPAYzqaJKk/aXtEeNSWdtQGPIPc3IGhBq4Z69Z8E8fvZCaVfNlVQ OTz7guhV5GEZRfZwHJeXiK7X/sdI9tCLNlSr+CbxrezpDTafewrv+AsUpSKXLASy83VO/n 1EvdZh/fREc/D+74I5TMX0UrRheWs8k= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728368117; a=rsa-sha256; cv=none; b=lGMI7OlA5A7aPd43dEUtGk3tuASOvliTk8rZ5M8fsg3DkVoV1cvrfVcHppXQmZrrU9Mx1k oQHJZpMYiZv0LSNmdSZc32V5L09m7PELM1DaeZrNb6gYv0mARtPxsD1MwEXNanT6Qb/Bp+ WaF7GJpCHBkBxHt1oED5rySg7GIMMLo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C483FEC; Mon, 7 Oct 2024 23:18:45 -0700 (PDT) Received: from e116581.blr.arm.com (e116581.arm.com [10.162.43.142]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 168493F73F; Mon, 7 Oct 2024 23:18:06 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dev Jain Subject: [PATCH v7 1/2] mm: Abstract THP allocation Date: Tue, 8 Oct 2024 11:47:45 +0530 Message-Id: <20241008061746.285961-2-dev.jain@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241008061746.285961-1-dev.jain@arm.com> References: <20241008061746.285961-1-dev.jain@arm.com> MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8B256120005 X-Stat-Signature: btyopm78tkfx98zxybi6hqsrs3mpwioz X-Rspam-User: X-HE-Tag: 1728368296-325991 X-HE-Meta: U2FsdGVkX1/s/3WEGXBE/zT+4KPUG11JviEZy08LWFr+SRAHCM8C/6tktptvrwbaiNcbNVZPxjfKPUyk/hqXkeoHttavOq0IZB85BgSsSe27fmEqLSbkzkvZi9sO9ybleJgjVNQ2MotR4v4SYTGVIz30sy+l2/5AJpajQbfmuoUAbPv3uKwnl07I1Ez27Q2Kh0OyZYWvIOzBRjvjtod1foBICfc9q6CjaDaqHfI7Nhzy734gH2SyNyV+8fkEVymIJttpuy8fvTcJlpAIe4K7mTAducXNhu3qKtAA5hR1d3D+qYrs7H81phTCK6fLupPNxmc79pLKuqHxq+57oI3XJZVk+jso93vgF2lu8T5nHdCIBbkB58/jXqtEuYcznIyMsKDfnFhQ0m7kQkP0AwlApZ+NhGoxtVhdac2RGoUjNOw6QytSpzsSGtr20eI7g4ZE8YeYLjtexkueFCIWNvde4anJZxJtNjw8Nofew2jvOa48MXmjEZ6R9MKedQucx9vi1Hbl+o1K15m7U1jWggG8HixOYihE6RDZamiEZRElzij/lYC1Mao2ckO/+FHIZyhYHS0vMrJ/PyQgd1+MBKsD0tU/RxxfAZRzR+faNCbtLga16RuHF9SQ2vvIexA+rXR+bkqDWzIfKHAeXrCFE8g9I7JoNVtlQgAyjIIINztcEgoT/2axJdsaCbDv1DADgpMwXJqgJJv0mOduHR1Zae7taDn2VYFryrAoFG1fMATU0fiCdLAUF+55i3mYTiagtGeQOTAWi/luhXCqpVxiT2XkhpfwLyipa62Uj2Jf35sDY/9p2uFMqyKXuDjKv2cymCCTz+r9B32FBs6j/EgBJxcKNwdpqPMbGlMVFEnhY59Ys+eC26oqd7ng94IbN7Hj6tmO1bFgJJxGwdbEhWm/wXh0+z+vOhHnIdXzi/H226DSHmsinsyoNDbd5BwrvdX1jeErgmb+GwdJrTW11mW+GU3 BkqFTEf4 OgRvrhPNPzj/pxtKuWKI8M4GHIzE1F+EFYx6hL9HuaFXeaJSM932SPwBBdBvz47zG5e0oFVaDT3To30ftsBc3tbYa7IOHfrxHPsKWqteNo6w7WdjNPE7lspkj36F/gMxyJad7v4ET1avGPyJ+m31EC2L3ZnlE2wtry3o/fMkOfbspzAwImTmy9cu1QBEqfECTYq9Fzm88MnYs6anPcOF7t/80ZArgqPtSW87G X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In preparation for the second patch, abstract away the THP allocation logic present in the create_huge_pmd() path, which corresponds to the faulting case when no page is present. There should be no functional change as a result of applying this patch, except that, as David notes at [1], a PMD-aligned address should be passed to update_mmu_cache_pmd(). [1]: https://lore.kernel.org/all/ddd3fcd2-48b3-4170-bcaa-2fe66e093f43@redhat.com/ Acked-by: David Hildenbrand Reviewed-by: Kefeng Wang Signed-off-by: Dev Jain --- mm/huge_memory.c | 98 ++++++++++++++++++++++++++++-------------------- 1 file changed, 57 insertions(+), 41 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 3ca89e0279a7..e21c4f759e00 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1148,47 +1148,81 @@ unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, } EXPORT_SYMBOL_GPL(thp_get_unmapped_area); -static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf, - struct page *page, gfp_t gfp) +static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, + unsigned long addr) { - struct vm_area_struct *vma = vmf->vma; - struct folio *folio = page_folio(page); - pgtable_t pgtable; - unsigned long haddr = vmf->address & HPAGE_PMD_MASK; - vm_fault_t ret = 0; + gfp_t gfp = vma_thp_gfp_mask(vma); + const int order = HPAGE_PMD_ORDER; + struct folio *folio; - VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); + folio = vma_alloc_folio(gfp, order, vma, addr & HPAGE_PMD_MASK, true); + if (unlikely(!folio)) { + count_vm_event(THP_FAULT_FALLBACK); + count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK); + return NULL; + } + + VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); if (mem_cgroup_charge(folio, vma->vm_mm, gfp)) { folio_put(folio); count_vm_event(THP_FAULT_FALLBACK); count_vm_event(THP_FAULT_FALLBACK_CHARGE); - count_mthp_stat(HPAGE_PMD_ORDER, MTHP_STAT_ANON_FAULT_FALLBACK); - count_mthp_stat(HPAGE_PMD_ORDER, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); - return VM_FAULT_FALLBACK; + count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK); + count_mthp_stat(order, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); + return NULL; } folio_throttle_swaprate(folio, gfp); - pgtable = pte_alloc_one(vma->vm_mm); - if (unlikely(!pgtable)) { - ret = VM_FAULT_OOM; - goto release; - } - - folio_zero_user(folio, vmf->address); + folio_zero_user(folio, addr); /* * The memory barrier inside __folio_mark_uptodate makes sure that * folio_zero_user writes become visible before the set_pmd_at() * write. */ __folio_mark_uptodate(folio); + return folio; +} + +static void map_anon_folio_pmd(struct folio *folio, pmd_t *pmd, + struct vm_area_struct *vma, unsigned long haddr) +{ + pmd_t entry; + + entry = mk_huge_pmd(&folio->page, vma->vm_page_prot); + entry = maybe_pmd_mkwrite(pmd_mkdirty(entry), vma); + folio_add_new_anon_rmap(folio, vma, haddr, RMAP_EXCLUSIVE); + folio_add_lru_vma(folio, vma); + set_pmd_at(vma->vm_mm, haddr, pmd, entry); + update_mmu_cache_pmd(vma, haddr, pmd); + add_mm_counter(vma->vm_mm, MM_ANONPAGES, HPAGE_PMD_NR); + count_vm_event(THP_FAULT_ALLOC); + count_mthp_stat(HPAGE_PMD_ORDER, MTHP_STAT_ANON_FAULT_ALLOC); + count_memcg_event_mm(vma->vm_mm, THP_FAULT_ALLOC); +} + +static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf) +{ + unsigned long haddr = vmf->address & HPAGE_PMD_MASK; + struct vm_area_struct *vma = vmf->vma; + struct folio *folio; + pgtable_t pgtable; + vm_fault_t ret = 0; + + folio = vma_alloc_anon_folio_pmd(vma, vmf->address); + if (unlikely(!folio)) + return VM_FAULT_FALLBACK; + + pgtable = pte_alloc_one(vma->vm_mm); + if (unlikely(!pgtable)) { + ret = VM_FAULT_OOM; + goto release; + } vmf->ptl = pmd_lock(vma->vm_mm, vmf->pmd); if (unlikely(!pmd_none(*vmf->pmd))) { goto unlock_release; } else { - pmd_t entry; - ret = check_stable_address_space(vma->vm_mm); if (ret) goto unlock_release; @@ -1202,21 +1236,11 @@ static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf, VM_BUG_ON(ret & VM_FAULT_FALLBACK); return ret; } - - entry = mk_huge_pmd(page, vma->vm_page_prot); - entry = maybe_pmd_mkwrite(pmd_mkdirty(entry), vma); - folio_add_new_anon_rmap(folio, vma, haddr, RMAP_EXCLUSIVE); - folio_add_lru_vma(folio, vma); pgtable_trans_huge_deposit(vma->vm_mm, vmf->pmd, pgtable); - set_pmd_at(vma->vm_mm, haddr, vmf->pmd, entry); - update_mmu_cache_pmd(vma, vmf->address, vmf->pmd); - add_mm_counter(vma->vm_mm, MM_ANONPAGES, HPAGE_PMD_NR); + map_anon_folio_pmd(folio, vmf->pmd, vma, haddr); mm_inc_nr_ptes(vma->vm_mm); deferred_split_folio(folio, false); spin_unlock(vmf->ptl); - count_vm_event(THP_FAULT_ALLOC); - count_mthp_stat(HPAGE_PMD_ORDER, MTHP_STAT_ANON_FAULT_ALLOC); - count_memcg_event_mm(vma->vm_mm, THP_FAULT_ALLOC); } return 0; @@ -1283,8 +1307,6 @@ static void set_huge_zero_folio(pgtable_t pgtable, struct mm_struct *mm, vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf) { struct vm_area_struct *vma = vmf->vma; - gfp_t gfp; - struct folio *folio; unsigned long haddr = vmf->address & HPAGE_PMD_MASK; vm_fault_t ret; @@ -1335,14 +1357,8 @@ vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf) } return ret; } - gfp = vma_thp_gfp_mask(vma); - folio = vma_alloc_folio(gfp, HPAGE_PMD_ORDER, vma, haddr, true); - if (unlikely(!folio)) { - count_vm_event(THP_FAULT_FALLBACK); - count_mthp_stat(HPAGE_PMD_ORDER, MTHP_STAT_ANON_FAULT_FALLBACK); - return VM_FAULT_FALLBACK; - } - return __do_huge_pmd_anonymous_page(vmf, &folio->page, gfp); + + return __do_huge_pmd_anonymous_page(vmf); } static void insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr,