From patchwork Tue Oct 8 11:20:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13826288 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ABBBCEF157 for ; Tue, 8 Oct 2024 11:27:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 298006B009A; Tue, 8 Oct 2024 07:27:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2213E6B009B; Tue, 8 Oct 2024 07:27:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 073606B009C; Tue, 8 Oct 2024 07:27:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D8C116B009A for ; Tue, 8 Oct 2024 07:27:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4BBAAC1201 for ; Tue, 8 Oct 2024 11:27:17 +0000 (UTC) X-FDA: 82650208956.17.949524E Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf23.hostedemail.com (Postfix) with ESMTP id 41F13140024 for ; Tue, 8 Oct 2024 11:27:15 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728386737; a=rsa-sha256; cv=none; b=nDdtucS9fw/0F4hjcgscUIlfOJF7pOvLzo2t6ijNyflDMF98CY6nh/3MG/UBVMD0geKAYx 1I9vrgxsw/QrlM5PlqHrCMdAegpT25VmG1wtDMWhSJ+gjiVtNJyVYwalKLDAKnoelgXnSa /MdARsh6FR8j8e2scyM0V4Vz7Qz6abY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728386737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nq2KmnF09Rk6AEkftK2+7007fKrv7e9tUB3VuZeZ2fg=; b=LYzJzuQVJgyF9TEsLRKbAhjJX+FI0uPnrCselAdx/PNC6gWwgAhwK7v7IdDtepyL9Kki3j 0lWbvJmr7LkP8RYezAb3YHhZLjHjrerQj5qJTwDAbhRa3QdVYGoar/SGExAQDlDVcqpg0d NOk/hsOcYcJP/UMvEJEZiaKQegpoiU0= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XNDHd3dZpzCt4S; Tue, 8 Oct 2024 19:26:37 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 388E81800DE; Tue, 8 Oct 2024 19:27:13 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 8 Oct 2024 19:27:12 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , Alexander Duyck , Andrew Morton , Subject: [PATCH net-next v20 08/14] mm: page_frag: use __alloc_pages() to replace alloc_pages_node() Date: Tue, 8 Oct 2024 19:20:42 +0800 Message-ID: <20241008112049.2279307-9-linyunsheng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241008112049.2279307-1-linyunsheng@huawei.com> References: <20241008112049.2279307-1-linyunsheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.30.45] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Queue-Id: 41F13140024 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wfnak9qqhyz1gxaqhrtymrghtu9t5uxw X-HE-Tag: 1728386835-799168 X-HE-Meta: U2FsdGVkX1+Qsvv0K6Fxr8XMLmRGlCIh+uL29O3KAfUkRcoD+k8thlsMnVLKwPcaHy+nyMJMOx1oelsTQJ3qgYy984VGxXg8gxTTuh3OwXL4ZUgHjn3DnYN2t+voX+gI+Fyxnk9BPfJqERhMqiqOI8BgDWsJNJw548fnLjxQ3Hy71ZaiQDNtqA/lIf8rKdCO9utuUuqMwBSEwbZi6ffXKvR2QQBZVtJzXQZ8J4M+Aejfdfq7u+rncOofWskujzXoncn6/XmcTX/HScMiXRVkAQI0Oy+6I4FtXYtDR6a/OkB/cLySuwnXVtpTv1jjLCKaUxsGLqpnooTioIrKyN1Uel34RZfGRSd3UaVidx4NiaYQjRQElT7iGoQB/fwXs3io3HE3ATVescgPMC4Qm5aFZWTDibqN6Onu5Q48dbk3RYeEM0xLdjhDJ9aVI+07XF/S2I7zVKrLov2ABVKaqw5SCFYxvK/W7QgnMw4xGLTtTjndRzRk7leOEGzOZC1ITHl7Y6scqBnItxJmok+6Q1HKfGP4hy8SlVF0hxDuth/7IMfYTFTUIlfT3c8yrVcEnHujpJvdyy7IJut6R1u4wMlHplAaHvcXuenQIu4MKQzsoPVAD68uBF1wpni8+KJ5kmUPxkhnhSs7EvwXDgbdUy4kc/Z7IuIqkSJFFpUojJdZgXJoqVLth4uvNKfyZ5qiEPSakdpczY9MgIcLx4NA7Fjnqs/1af69OqOJvvLs9Rdo3yAtziIh3ajuoJ3W9RfzzefWHhhBYt/z4G7HHaHTchWOHbJ+qQoHqDtciScKV2Jlj1qffzfj+lZIPICFiWe4t2gxl3GjAk+9pWxqOS5V1CH97+QtGi8FNV5fqbPZ92FdKHdbr5yYMNM1Wrobfa9NHKO4ExipsYailuIyqyUF+OZv+SgxdF3InomSE9c4Q13jekWktQKjttG01YzMN0qT3a0zkIEff+t9eDvCAnYaBqy 1j9yL9i1 k8lSuUNHWAMVMFpCMcOMK6sL8X87Yh8++8znmDWmU0o6F6a8J644FGc8lxxqCQxgsQk4uokmAdsa8Prc08D+Z81Dq43fDk67G2H5BTqD4bqD4ZsyJRPHupT3pxQ/NmKaieqF8IEcHVa5W4Ebuq4ftku53MUoQ2kLuMWNCwHkdBtFBKG7n9vjbzHIn8VXOBXK+5gn4IchGx9zpCC/UKU94sTAo1VlPQgk2/x7Ubb0vREiFPTIWnY2eL++RRx6QxGzZlqaBC7/fDOhFFx/d4mM+8uTaU5lXpYMeHHEJIxMPwtXWbceaKZTHcM45Qw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It seems there is about 24Bytes binary size increase for __page_frag_cache_refill() after refactoring in arm64 system with 64K PAGE_SIZE. By doing the gdb disassembling, It seems we can have more than 100Bytes decrease for the binary size by using __alloc_pages() to replace alloc_pages_node(), as there seems to be some unnecessary checking for nid being NUMA_NO_NODE, especially when page_frag is part of the mm system. CC: Alexander Duyck Signed-off-by: Yunsheng Lin Reviewed-by: Alexander Duyck --- mm/page_frag_cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/page_frag_cache.c b/mm/page_frag_cache.c index e17f4a530af2..4666dbec38eb 100644 --- a/mm/page_frag_cache.c +++ b/mm/page_frag_cache.c @@ -61,11 +61,11 @@ static struct page *__page_frag_cache_refill(struct page_frag_cache *nc, #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE) gfp_mask = (gfp_mask & ~__GFP_DIRECT_RECLAIM) | __GFP_COMP | __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC; - page = alloc_pages_node(NUMA_NO_NODE, gfp_mask, - PAGE_FRAG_CACHE_MAX_ORDER); + page = __alloc_pages(gfp_mask, PAGE_FRAG_CACHE_MAX_ORDER, + numa_mem_id(), NULL); #endif if (unlikely(!page)) { - page = alloc_pages_node(NUMA_NO_NODE, gfp, 0); + page = __alloc_pages(gfp, 0, numa_mem_id(), NULL); order = 0; }