From patchwork Fri Oct 18 10:53:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13841630 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1946AD2FFEC for ; Fri, 18 Oct 2024 11:00:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EAE46B009C; Fri, 18 Oct 2024 07:00:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79AC56B009D; Fri, 18 Oct 2024 07:00:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 662ED6B009E; Fri, 18 Oct 2024 07:00:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 48DA36B009C for ; Fri, 18 Oct 2024 07:00:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9DE9314196E for ; Fri, 18 Oct 2024 11:00:28 +0000 (UTC) X-FDA: 82686429378.01.6BFB7EB Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf10.hostedemail.com (Postfix) with ESMTP id 5AB00C0023 for ; Fri, 18 Oct 2024 11:00:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729249190; a=rsa-sha256; cv=none; b=sueeGO0IaP3qScZ08W5dypQj/HBaYU8wNSGL/12aHtPpbCQb2uR8SSK8ycjKrJcfLpdLGy 5ecEohCZDMlQFU8SycHBF8baBQiw3owcrQzio0fcQPkMP0SEyhrux5TAtnEXgAZwyV/PkU 4uOAzD7dnlhSPkcCTT5iZy/wNa9tcRE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729249190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vtsqCM0cvngpZbYjmneEJIYJz6vHe4F6LJZG69+Vp48=; b=lH8TLCJ+Tnz8dyZPVsUFlTVlqMLA+b/OAaA0p44HXxsSZJqB09vEBYDtULDrtf/zD+NDJ5 ws2YF0c3g/aN78wbOStyEVfIbpW+Q/RHmcHHy78KOdtqWDGBORxXnN9IpGra3VjzB2rOl+ R608OiQBA8cUTVvNRvATh1D6SYco1OY= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XVMD46sfkz20qY6; Fri, 18 Oct 2024 18:59:48 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 4EB141402E2; Fri, 18 Oct 2024 19:00:35 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 18 Oct 2024 19:00:35 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , Andrew Morton , Shuah Khan , , Subject: [PATCH net-next v22 11/14] mm: page_frag: add testing for the newly added prepare API Date: Fri, 18 Oct 2024 18:53:48 +0800 Message-ID: <20241018105351.1960345-12-linyunsheng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241018105351.1960345-1-linyunsheng@huawei.com> References: <20241018105351.1960345-1-linyunsheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.30.45] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspam-User: X-Rspamd-Queue-Id: 5AB00C0023 X-Rspamd-Server: rspam01 X-Stat-Signature: pty8zo5w367gk5pek3hqqh1eq84cfk9j X-HE-Tag: 1729249232-634149 X-HE-Meta: U2FsdGVkX1/V+3Le+7TJCCkTdARnVkyX+FKpQKC2X89FZclxvjFyJK3HMMvI9VEAOB7F8hXgQ5RKxkGsyZ+7QXYIjRXU/y62BIZiGAxDeIpXhl2lNpvZxkfOYKNgeJW7SLPxdxw5da2g2uxK49jZLwsJ5fONWkk0r/yDBFfK6DUvtRSlSJE632wGPkf5QwJds04lPRYDzMuWdfVjaaPl555piTCWb1DEp3e9ibKFJLOV85c0sFWj1bP6Iwx7yc/6qTzSoPZXjh2n1SAKm86Oe/yJYacVpZ/f0LArmebytG5xu/HZMZQ2iNaVZJujbhqkPN/ZUJA1eAvxZMvqy3MTrZbGqWCe/6w9DAgk6IAwDF2X2IIzFiCME3dvlTQH/YajqOkp60i3irkGIEZtPiUhOtBn3CZBpTWeh+rkBralATHFDr8CITEBpGKOIiT1iFR8hK9yaPbkGnnclP78c6xAF53bGa/YonnFA+hE9HCnCQCJjIkanxoEu6b7RuqrHMm9vsUlBCymf5HGOF3GkcnWbJhkEK4oLkQV90PZCY82eLgJzrWmdaG6oNch7GAiVuLyZZqxwpAxTFCCMwpUNJkhNkMRlTajGxDXajLqP0MTsjsAv2i0P1b1ujLK+cxi8ZcB9NOGH3tzAeLjJNwzRtTqT1/eftdepIVnlrqKak2ha+uLXIMpkKaJHj6xs8OUafQBUGtJLRSaDHlxwaGqDYFSLBubnpCagGQFBLt1EdgJ2CGQO2HWyPB7ADcn/eqCAE+Ak78RAFKM8NmDNUzV+sAUE1cQmG7ho4qvgRoBVTgBKpr83gDzkwLieIzTEiZLx2c7H91K9SK+k/Mz2Qd7w7Z1Ze2WlwPCxXVrBzAGb6kkzoka4/zBQMrcQaTnX0vwlGiNIqvngklu5kwVo1KKVqJSZ6WVR/i6BuzvqK/Ov5ya7MrGWhljQu3Rm4tnpR50yu+ikBB9jPUy+LoUPvPH+MU PjR/kEB7 +xwccIJoG60SkW6Uucg0qYNNXBRNMLOGZ6yV28IW5ARCiyb7EPBwRG/Il6Yhj0fThiACXNyUMbjr36AdqGQRZrngqekEviZXWAOSJrcBICoxfnJQP4q8TBoYpt1AGgy/PjpWKRb7O5yiuUkY5zTBic3Xiito2O28I1yyc+RmZJxBkBfghUFKZrONiR9iqUOwa8RegOfXs0COtt8mo5zzMHN0W1uVylHt412HCAA5XRE82UvWxsx88SnfAfAJGNyB1I+P3GtcY30RIx7SZY0OA9VP0oiLSJsNMWZAP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add testing for the newly added prepare API, for both aligned and non-aligned API, also probe API is also tested along with prepare API. CC: Alexander Duyck Signed-off-by: Yunsheng Lin --- .../selftests/mm/page_frag/page_frag_test.c | 76 +++++++++++++++++-- tools/testing/selftests/mm/run_vmtests.sh | 4 + tools/testing/selftests/mm/test_page_frag.sh | 27 +++++++ 3 files changed, 102 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/mm/page_frag/page_frag_test.c b/tools/testing/selftests/mm/page_frag/page_frag_test.c index e806c1866e36..1e47e9ad66f0 100644 --- a/tools/testing/selftests/mm/page_frag/page_frag_test.c +++ b/tools/testing/selftests/mm/page_frag/page_frag_test.c @@ -32,6 +32,10 @@ static bool test_align; module_param(test_align, bool, 0); MODULE_PARM_DESC(test_align, "use align API for testing"); +static bool test_prepare; +module_param(test_prepare, bool, 0); +MODULE_PARM_DESC(test_prepare, "use prepare API for testing"); + static int test_alloc_len = 2048; module_param(test_alloc_len, int, 0); MODULE_PARM_DESC(test_alloc_len, "alloc len for testing"); @@ -74,6 +78,21 @@ static int page_frag_pop_thread(void *arg) return 0; } +static void frag_frag_test_commit(struct page_frag_cache *nc, + struct page_frag *prepare_pfrag, + struct page_frag *probe_pfrag, + unsigned int used_sz) +{ + if (prepare_pfrag->page != probe_pfrag->page || + prepare_pfrag->offset != probe_pfrag->offset || + prepare_pfrag->size != probe_pfrag->size) { + force_exit = true; + WARN_ONCE(true, TEST_FAILED_PREFIX "wrong probed info\n"); + } + + page_frag_commit(nc, prepare_pfrag, used_sz); +} + static int page_frag_push_thread(void *arg) { struct ptr_ring *ring = arg; @@ -86,15 +105,61 @@ static int page_frag_push_thread(void *arg) int ret; if (test_align) { - va = page_frag_alloc_align(&test_nc, test_alloc_len, - GFP_KERNEL, SMP_CACHE_BYTES); + if (test_prepare) { + struct page_frag prepare_frag, probe_frag; + void *probe_va; + + va = page_frag_alloc_refill_prepare_align(&test_nc, + test_alloc_len, + &prepare_frag, + GFP_KERNEL, + SMP_CACHE_BYTES); + + probe_va = __page_frag_alloc_refill_probe_align(&test_nc, + test_alloc_len, + &probe_frag, + -SMP_CACHE_BYTES); + if (va != probe_va) { + force_exit = true; + WARN_ONCE(true, TEST_FAILED_PREFIX "wrong va\n"); + } + + if (likely(va)) + frag_frag_test_commit(&test_nc, &prepare_frag, + &probe_frag, test_alloc_len); + } else { + va = page_frag_alloc_align(&test_nc, + test_alloc_len, + GFP_KERNEL, + SMP_CACHE_BYTES); + } if ((unsigned long)va & (SMP_CACHE_BYTES - 1)) { force_exit = true; WARN_ONCE(true, TEST_FAILED_PREFIX "unaligned va returned\n"); } } else { - va = page_frag_alloc(&test_nc, test_alloc_len, GFP_KERNEL); + if (test_prepare) { + struct page_frag prepare_frag, probe_frag; + void *probe_va; + + va = page_frag_alloc_refill_prepare(&test_nc, test_alloc_len, + &prepare_frag, GFP_KERNEL); + + probe_va = page_frag_alloc_refill_probe(&test_nc, test_alloc_len, + &probe_frag); + + if (va != probe_va) { + force_exit = true; + WARN_ONCE(true, TEST_FAILED_PREFIX "wrong va\n"); + } + + if (likely(va)) + frag_frag_test_commit(&test_nc, &prepare_frag, + &probe_frag, test_alloc_len); + } else { + va = page_frag_alloc(&test_nc, test_alloc_len, GFP_KERNEL); + } } if (!va) @@ -176,8 +241,9 @@ static int __init page_frag_test_init(void) } duration = (u64)ktime_us_delta(ktime_get(), start); - pr_info("%d of iterations for %s testing took: %lluus\n", nr_test, - test_align ? "aligned" : "non-aligned", duration); + pr_info("%d of iterations for %s %s API testing took: %lluus\n", nr_test, + test_align ? "aligned" : "non-aligned", + test_prepare ? "prepare" : "alloc", duration); out: ptr_ring_cleanup(&ptr_ring, NULL); diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index 2c5394584af4..f6ff9080a6f2 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -464,6 +464,10 @@ CATEGORY="page_frag" run_test ./test_page_frag.sh aligned CATEGORY="page_frag" run_test ./test_page_frag.sh nonaligned +CATEGORY="page_frag" run_test ./test_page_frag.sh aligned_prepare + +CATEGORY="page_frag" run_test ./test_page_frag.sh nonaligned_prepare + echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}" | tap_prefix echo "1..${count_total}" | tap_output diff --git a/tools/testing/selftests/mm/test_page_frag.sh b/tools/testing/selftests/mm/test_page_frag.sh index f55b105084cf..1c757fd11844 100755 --- a/tools/testing/selftests/mm/test_page_frag.sh +++ b/tools/testing/selftests/mm/test_page_frag.sh @@ -43,6 +43,8 @@ check_test_failed_prefix() { SMOKE_PARAM="test_push_cpu=$TEST_CPU_0 test_pop_cpu=$TEST_CPU_1" NONALIGNED_PARAM="$SMOKE_PARAM test_alloc_len=75 nr_test=$NR_TEST" ALIGNED_PARAM="$NONALIGNED_PARAM test_align=1" +NONALIGNED_PREPARE_PARAM="$NONALIGNED_PARAM test_prepare=1" +ALIGNED_PREPARE_PARAM="$ALIGNED_PARAM test_prepare=1" check_test_requirements() { @@ -77,6 +79,20 @@ run_aligned_check() insmod $DRIVER $ALIGNED_PARAM > /dev/null 2>&1 } +run_nonaligned_prepare_check() +{ + echo "Run performance tests to evaluate how fast nonaligned prepare API is." + + insmod $DRIVER $NONALIGNED_PREPARE_PARAM > /dev/null 2>&1 +} + +run_aligned_prepare_check() +{ + echo "Run performance tests to evaluate how fast aligned prepare API is." + + insmod $DRIVER $ALIGNED_PREPARE_PARAM > /dev/null 2>&1 +} + run_smoke_check() { echo "Run smoke test." @@ -87,6 +103,7 @@ run_smoke_check() usage() { echo -n "Usage: $0 [ aligned ] | [ nonaligned ] | | [ smoke ] | " + echo "[ aligned_prepare ] | [ nonaligned_prepare ] | " echo "manual parameters" echo echo "Valid tests and parameters:" @@ -107,6 +124,12 @@ usage() echo "# Performance testing for aligned alloc API" echo "$0 aligned" echo + echo "# Performance testing for nonaligned prepare API" + echo "$0 nonaligned_prepare" + echo + echo "# Performance testing for aligned prepare API" + echo "$0 aligned_prepare" + echo exit 0 } @@ -158,6 +181,10 @@ function run_test() run_nonaligned_check elif [[ "$1" = "aligned" ]]; then run_aligned_check + elif [[ "$1" = "nonaligned_prepare" ]]; then + run_nonaligned_prepare_check + elif [[ "$1" = "aligned_prepare" ]]; then + run_aligned_prepare_check else run_manual_check $@ fi