diff mbox series

[v4,2/5] maple_tree: the return value of mas_root_expand() is not used

Message ID 20241019023716.4516-3-richard.weiyang@gmail.com (mailing list archive)
State New
Headers show
Series refine storing NULL | expand

Commit Message

Wei Yang Oct. 19, 2024, 2:37 a.m. UTC
No user of the return value now, just remove it.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 lib/maple_tree.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Liam R. Howlett Oct. 29, 2024, 3:23 p.m. UTC | #1
* Wei Yang <richard.weiyang@gmail.com> [241018 22:37]:
> No user of the return value now, just remove it.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
> CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>

> ---
>  lib/maple_tree.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 21e6895b7aef..517ddf2950e6 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -3400,7 +3400,7 @@ static noinline_for_kasan void mas_commit_b_node(struct ma_wr_state *wr_mas,
>   * @mas: The maple state
>   * @entry: The entry to store into the tree
>   */
> -static inline int mas_root_expand(struct ma_state *mas, void *entry)
> +static inline void mas_root_expand(struct ma_state *mas, void *entry)
>  {
>  	void *contents = mas_root_locked(mas);
>  	enum maple_type type = maple_leaf_64;
> @@ -3436,7 +3436,7 @@ static inline int mas_root_expand(struct ma_state *mas, void *entry)
>  	ma_set_meta(node, maple_leaf_64, 0, slot);
>  	/* swap the new root into the tree */
>  	rcu_assign_pointer(mas->tree->ma_root, mte_mk_root(mas->node));
> -	return slot;
> +	return;
>  }
>  
>  static inline void mas_store_root(struct ma_state *mas, void *entry)
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 21e6895b7aef..517ddf2950e6 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3400,7 +3400,7 @@  static noinline_for_kasan void mas_commit_b_node(struct ma_wr_state *wr_mas,
  * @mas: The maple state
  * @entry: The entry to store into the tree
  */
-static inline int mas_root_expand(struct ma_state *mas, void *entry)
+static inline void mas_root_expand(struct ma_state *mas, void *entry)
 {
 	void *contents = mas_root_locked(mas);
 	enum maple_type type = maple_leaf_64;
@@ -3436,7 +3436,7 @@  static inline int mas_root_expand(struct ma_state *mas, void *entry)
 	ma_set_meta(node, maple_leaf_64, 0, slot);
 	/* swap the new root into the tree */
 	rcu_assign_pointer(mas->tree->ma_root, mte_mk_root(mas->node));
-	return slot;
+	return;
 }
 
 static inline void mas_store_root(struct ma_state *mas, void *entry)