From patchwork Mon Oct 28 11:58:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 13853380 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6ECD1359C for ; Mon, 28 Oct 2024 12:05:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 329ED6B00A1; Mon, 28 Oct 2024 08:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B2926B00A3; Mon, 28 Oct 2024 08:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17B306B00A4; Mon, 28 Oct 2024 08:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EF6266B00A1 for ; Mon, 28 Oct 2024 08:05:29 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 79F05141E27 for ; Mon, 28 Oct 2024 12:05:05 +0000 (UTC) X-FDA: 82722880212.27.F8C6922 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf25.hostedemail.com (Postfix) with ESMTP id 3CDDAA0024 for ; Mon, 28 Oct 2024 12:05:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730117047; a=rsa-sha256; cv=none; b=xD3ImzuFs4HnEOlRdE2bqYMmc+5FmTFu42L2zYey7jAKqbXtp1C9AOGS/3NUOy8YRrT5og JZY9u/jGr/kZbNaWY3ep4JSNRhSVLGdzuOClEVO3yCm+EqBDM/Z8GIm3Q8Q9UgemwDTfJY 1olI4i59Xug5tklCqWwsqWZT1TCgWZI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730117047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXj8sFW2sI2fPPOekjTdISpPeCEMGaPkaag0g/i1t1I=; b=xV5WLi9Jwu8WAPd7nVN6qxGxpLuSc+kjpKC5/HOfxGWluN9DzxxEBoCIj/2sgqVqGmtZ2N JRFPLowrgHnra6MUS5TWx1QQQXIbK1DXxWCWff/nB6bf3n4LGcJSNV7LtsmH+vRvX3/iBh oHj4dxAIVOg1BdPubREW5ffdeHePTnI= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4XcXCH3dm4z1ynhW; Mon, 28 Oct 2024 20:05:31 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 396571A0188; Mon, 28 Oct 2024 20:05:23 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 28 Oct 2024 20:05:22 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Alexander Duyck , Andrew Morton , Linux-MM , Shuah Khan , Subject: [PATCH RFC 08/10] mm: page_frag: add testing for the newly added API Date: Mon, 28 Oct 2024 19:58:48 +0800 Message-ID: <20241028115850.3409893-9-linyunsheng@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20241028115850.3409893-1-linyunsheng@huawei.com> References: <20241028115850.3409893-1-linyunsheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.30.45] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemf200006.china.huawei.com (7.185.36.61) X-Stat-Signature: zti3qk51teobzfx5dwk3eo6ng8gjgj18 X-Rspamd-Queue-Id: 3CDDAA0024 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730117109-699279 X-HE-Meta: U2FsdGVkX1+nUxxcWmH4JNOXPbpn9qdmLMW3dZEsMrNY0bp9qTXS16tl4k/l4086GcXjSjASfN/miS7a1LfYEsEraTXHmvsFBVMuC9j1PAKfMjRtkdcRMVG0DUDAlUeqOabgQblymupFEulzQl4g2jeBc96BOKo96K1uB/FbhF7mRzPHxxFqr3iVaAtVjEyG8Kepd6sqQWe4TRIsmMU39ATDhDYWyNJFEYSjoXl6gNzpaEVvi/qyDEWSxPeiVdV7FpaRW5bLQc4C2nhmyJWU57xs6zkplWd0L5vo2pozRyESvf+Rvu9WRoLzNSwd2/Cpd5hjKK3ca10udkCPPhYaAGpSn9O34/JCCc+nILXLnQm8PkCGeZcFv6XNLUCNfSMy58VDBE2LOurRSogenMxrX9HcsMui6McuJkd+PrUBz4CYIlLAT3rQBHoiPThUF75yi/TwDgDPMzotH5+ZUN+4QmU/7tuj1lgQgkaHavDAKfs+ijIy7M69LqoSQkxqan0QiXZBTlb3ti52Jn2CmqrudWQSXlsn8YgFXcxGmTp9sQlF2lR++QRZv4lJHE2JFkAzR+QfIeBHxX4ZSNgf8cA6kBhBkvdonh8Bt4bYPyzeP8g3BlxxP9IuJPQovCkHMTe6xsAVKNhDND5Znd4Wl3ypSuk4158bhgH9q6rT/08tbwXb4DYovEvMhV8DDgIeRXR5eSyEwna3HUZ3WzPRL42zItlvqnjKFMxIoSTVVU4MOLehUY2SyQDRre55RRQGrD2dxbmp+kfuqgisZRXYZ6haG8PTwAcnvlalEf8nvv6mIBfTv1qVRpL4kpOsVR/4NErdBIaG3jkv/cetXgTe6JesNRAlrMCYl13oPp2+NPT6N6WibZMAgiMlZczTbEA6RUNBHGjB3GGpa1VyCvFtmi/uGUzkbSCq0abojW007VV0of1oKyRyNUN+NV5WjsNoJJfVbKO9FONf7xwZX8IHayl /k3+RMZL FmGGklQyq6gv8d5IruJYT5Oyr8iw752TvxGikfWY2qhOwkMWe0KaNedk7CuorsOEKmrlt/pN0dH+5IjSHcVb8KzSMmOl5Reyicn/5Q5wfI+ehnQkA1kMj7CtUhqDRCtnO+xAHOZV50sS6qBzHE93/KPKpmwsjUF22Hh4OLfgsZVc0PB4FCgb69faYJhFUOl9M4CUU5mxoeLvinIWcn93HHNluiytzXCchf3NGnsvLWg6vFX1OMXK7IhS4BYFzyaJzxUR9vfyAvaLzZRRyg9XrXJ0hc8N747OcvhD/MclCzQRiBmH3VlKmDlDMYyM+PEFYRlVJRbSa0893gjDmp3POwh6LBdE7kuryUIFZvpVCo7x1dcXualskvOl8GHAaND3q7zKPzHmcIYy3VK0rSyuPWRvhf+hl/Ze5a3CPW6dwKGAAoCMeobSB9TNrX1M+c2zmyE0LDXTsRbbzjQsRoxiUSw9FDnzOuOdnBllVzHtMuWP0sc24N3P7OGaw6tgqf+VA+rk+bucFIwTac/kO2lvKGJ2/y0M7E0h3n7CcucamykLs2RU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add testing for the newly added prepare API, for both aligned and non-aligned API, also probe API is also tested along with prepare API. CC: Alexander Duyck CC: Andrew Morton CC: Linux-MM Signed-off-by: Yunsheng Lin --- .../selftests/mm/page_frag/page_frag_test.c | 76 +++++++++++++++++-- tools/testing/selftests/mm/run_vmtests.sh | 4 + tools/testing/selftests/mm/test_page_frag.sh | 27 +++++++ 3 files changed, 102 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/mm/page_frag/page_frag_test.c b/tools/testing/selftests/mm/page_frag/page_frag_test.c index e806c1866e36..3b3c32389def 100644 --- a/tools/testing/selftests/mm/page_frag/page_frag_test.c +++ b/tools/testing/selftests/mm/page_frag/page_frag_test.c @@ -32,6 +32,10 @@ static bool test_align; module_param(test_align, bool, 0); MODULE_PARM_DESC(test_align, "use align API for testing"); +static bool test_prepare; +module_param(test_prepare, bool, 0); +MODULE_PARM_DESC(test_prepare, "use prepare API for testing"); + static int test_alloc_len = 2048; module_param(test_alloc_len, int, 0); MODULE_PARM_DESC(test_alloc_len, "alloc len for testing"); @@ -74,6 +78,21 @@ static int page_frag_pop_thread(void *arg) return 0; } +static void frag_frag_test_commit(struct page_frag_cache *nc, + struct page_frag *prepare_pfrag, + struct page_frag *probe_pfrag, + unsigned int used_sz) +{ + if (prepare_pfrag->page != probe_pfrag->page || + prepare_pfrag->offset != probe_pfrag->offset || + prepare_pfrag->size != probe_pfrag->size) { + force_exit = true; + WARN_ONCE(true, TEST_FAILED_PREFIX "wrong probed info\n"); + } + + page_frag_refill_commit(nc, prepare_pfrag, used_sz); +} + static int page_frag_push_thread(void *arg) { struct ptr_ring *ring = arg; @@ -86,15 +105,61 @@ static int page_frag_push_thread(void *arg) int ret; if (test_align) { - va = page_frag_alloc_align(&test_nc, test_alloc_len, - GFP_KERNEL, SMP_CACHE_BYTES); + if (test_prepare) { + struct page_frag prepare_frag, probe_frag; + void *probe_va; + + va = page_frag_alloc_refill_prepare_align(&test_nc, + test_alloc_len, + &prepare_frag, + GFP_KERNEL, + SMP_CACHE_BYTES); + + probe_va = __page_frag_alloc_refill_probe_align(&test_nc, + test_alloc_len, + &probe_frag, + -SMP_CACHE_BYTES); + if (va != probe_va) { + force_exit = true; + WARN_ONCE(true, TEST_FAILED_PREFIX "wrong va\n"); + } + + if (likely(va)) + frag_frag_test_commit(&test_nc, &prepare_frag, + &probe_frag, test_alloc_len); + } else { + va = page_frag_alloc_align(&test_nc, + test_alloc_len, + GFP_KERNEL, + SMP_CACHE_BYTES); + } if ((unsigned long)va & (SMP_CACHE_BYTES - 1)) { force_exit = true; WARN_ONCE(true, TEST_FAILED_PREFIX "unaligned va returned\n"); } } else { - va = page_frag_alloc(&test_nc, test_alloc_len, GFP_KERNEL); + if (test_prepare) { + struct page_frag prepare_frag, probe_frag; + void *probe_va; + + va = page_frag_alloc_refill_prepare(&test_nc, test_alloc_len, + &prepare_frag, GFP_KERNEL); + + probe_va = page_frag_alloc_refill_probe(&test_nc, test_alloc_len, + &probe_frag); + + if (va != probe_va) { + force_exit = true; + WARN_ONCE(true, TEST_FAILED_PREFIX "wrong va\n"); + } + + if (likely(va)) + frag_frag_test_commit(&test_nc, &prepare_frag, + &probe_frag, test_alloc_len); + } else { + va = page_frag_alloc(&test_nc, test_alloc_len, GFP_KERNEL); + } } if (!va) @@ -176,8 +241,9 @@ static int __init page_frag_test_init(void) } duration = (u64)ktime_us_delta(ktime_get(), start); - pr_info("%d of iterations for %s testing took: %lluus\n", nr_test, - test_align ? "aligned" : "non-aligned", duration); + pr_info("%d of iterations for %s %s API testing took: %lluus\n", nr_test, + test_align ? "aligned" : "non-aligned", + test_prepare ? "prepare" : "alloc", duration); out: ptr_ring_cleanup(&ptr_ring, NULL); diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index 2c5394584af4..f6ff9080a6f2 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -464,6 +464,10 @@ CATEGORY="page_frag" run_test ./test_page_frag.sh aligned CATEGORY="page_frag" run_test ./test_page_frag.sh nonaligned +CATEGORY="page_frag" run_test ./test_page_frag.sh aligned_prepare + +CATEGORY="page_frag" run_test ./test_page_frag.sh nonaligned_prepare + echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}" | tap_prefix echo "1..${count_total}" | tap_output diff --git a/tools/testing/selftests/mm/test_page_frag.sh b/tools/testing/selftests/mm/test_page_frag.sh index f55b105084cf..1c757fd11844 100755 --- a/tools/testing/selftests/mm/test_page_frag.sh +++ b/tools/testing/selftests/mm/test_page_frag.sh @@ -43,6 +43,8 @@ check_test_failed_prefix() { SMOKE_PARAM="test_push_cpu=$TEST_CPU_0 test_pop_cpu=$TEST_CPU_1" NONALIGNED_PARAM="$SMOKE_PARAM test_alloc_len=75 nr_test=$NR_TEST" ALIGNED_PARAM="$NONALIGNED_PARAM test_align=1" +NONALIGNED_PREPARE_PARAM="$NONALIGNED_PARAM test_prepare=1" +ALIGNED_PREPARE_PARAM="$ALIGNED_PARAM test_prepare=1" check_test_requirements() { @@ -77,6 +79,20 @@ run_aligned_check() insmod $DRIVER $ALIGNED_PARAM > /dev/null 2>&1 } +run_nonaligned_prepare_check() +{ + echo "Run performance tests to evaluate how fast nonaligned prepare API is." + + insmod $DRIVER $NONALIGNED_PREPARE_PARAM > /dev/null 2>&1 +} + +run_aligned_prepare_check() +{ + echo "Run performance tests to evaluate how fast aligned prepare API is." + + insmod $DRIVER $ALIGNED_PREPARE_PARAM > /dev/null 2>&1 +} + run_smoke_check() { echo "Run smoke test." @@ -87,6 +103,7 @@ run_smoke_check() usage() { echo -n "Usage: $0 [ aligned ] | [ nonaligned ] | | [ smoke ] | " + echo "[ aligned_prepare ] | [ nonaligned_prepare ] | " echo "manual parameters" echo echo "Valid tests and parameters:" @@ -107,6 +124,12 @@ usage() echo "# Performance testing for aligned alloc API" echo "$0 aligned" echo + echo "# Performance testing for nonaligned prepare API" + echo "$0 nonaligned_prepare" + echo + echo "# Performance testing for aligned prepare API" + echo "$0 aligned_prepare" + echo exit 0 } @@ -158,6 +181,10 @@ function run_test() run_nonaligned_check elif [[ "$1" = "aligned" ]]; then run_aligned_check + elif [[ "$1" = "nonaligned_prepare" ]]; then + run_nonaligned_prepare_check + elif [[ "$1" = "aligned_prepare" ]]; then + run_aligned_prepare_check else run_manual_check $@ fi