From patchwork Fri Nov 1 09:17:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13858956 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E242E674BD for ; Fri, 1 Nov 2024 09:17:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B40F96B0082; Fri, 1 Nov 2024 05:17:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC9536B0083; Fri, 1 Nov 2024 05:17:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 942FC6B0085; Fri, 1 Nov 2024 05:17:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 70CDE6B0083 for ; Fri, 1 Nov 2024 05:17:55 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 237CBAD9A5 for ; Fri, 1 Nov 2024 09:17:55 +0000 (UTC) X-FDA: 82736972682.13.E3B6E9D Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf29.hostedemail.com (Postfix) with ESMTP id 5A24612001D for ; Fri, 1 Nov 2024 09:17:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730452617; a=rsa-sha256; cv=none; b=3/AE+xKejLvRNGCMDNG7W5if0SU58SUkEKouf+22eLPdCovWRpXFfGPoy1dWhZcPJbvPTX uEA5+pz/gh14Tnfx0qZwH9t91gN+ettYrS8akaXUyJ/bbDXh75nYNSPC/z671NwyapkxOP 8PHr2ZhfUMQtw0tJf0SbzbSoBleaj4M= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730452617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NYFLWJU/nJ/Qpvgtx8myvYL2TtifOyxWJTmJpbGDZeg=; b=q9gYYMsZt5HOziKwuuofxjJXWmwB6DTDutMnnjA5iuR0yflStSqn8B7dODl+i0DTmpD2h6 rPhdI1i7/VoXv2lh/BfWO9tZDhRf5zG/2AxoWNnPhI6S1NJw1lOveAc4FPxvfetP26MxdG M4ZWUrrpzYg4ob2YozAwV9X6+GXIsjg= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XfwF441ynz6K6Kb; Fri, 1 Nov 2024 17:15:20 +0800 (CST) Received: from frapeml500007.china.huawei.com (unknown [7.182.85.172]) by mail.maildlp.com (Postfix) with ESMTPS id 80B1C1404FC; Fri, 1 Nov 2024 17:17:51 +0800 (CST) Received: from P_UKIT01-A7bmah.china.huawei.com (10.126.171.129) by frapeml500007.china.huawei.com (7.182.85.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 1 Nov 2024 10:17:49 +0100 From: To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v15 01/15] EDAC: Add support for EDAC device features control Date: Fri, 1 Nov 2024 09:17:19 +0000 Message-ID: <20241101091735.1465-2-shiju.jose@huawei.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20241101091735.1465-1-shiju.jose@huawei.com> References: <20241101091735.1465-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.126.171.129] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500007.china.huawei.com (7.182.85.172) X-Rspam-User: X-Rspamd-Queue-Id: 5A24612001D X-Rspamd-Server: rspam11 X-Stat-Signature: eckymxrzu6esdbp48bniumj88onwzk1z X-HE-Tag: 1730452635-949103 X-HE-Meta: U2FsdGVkX18tlBG/4kEDG68mnJ60Wfk/gYOHYGjdfrkJQ0ZlNMUzwhmCNeX2OKeTY2nTIqfRovJ3oUYZW8mnVeUTQ3pt+7RFD0fajHZNo0i+eGS31cspq/BHE3h5BTMWVeiGkBDZtzmXfhtUufucQZpjLf5mvCFOmdkFuAhYf2fqq9iOmDb2YyRbqQR0puAa9g/ivzqVbgx94ZU5pjEIa+hMPJ2whlwUXwEOO+xgcxB9chqjNKK539Hp7fMTilNvyIqroHSiNHjYL4PQxS5NmiKiRS8OFzIhgTN1A3C6wqqMFZ6Cc95gorfp/6T4cj7ihTFjb1IaKLft3X1oHPSB0O1AeuV3104e3XoJkiPfJB+AEGOOmejlHyTOB4Q8dcvSg+UotGhU4/HeHj24UBIbpFkkVNYly2jNzK+jyySgnvlptxtBIEMm7yjlEPFaPYZDAZ1aQByM6fx0tpmsh+ltve/cxYtQMZGwnDm7XxsZf5su6VNKZO82NIrRlhAnsxN8SKJjTPUBhiWQezHlgsrFn/IhigpGccUb+/Rea0hIHY2TOcTIltGaPlEc/m4EkQFRQqTZJTNeCJ6+nTjQWMjX0Aa17rfuyjdvepu9RYkQxw7+UUtaXa1u5aXSccqZJc7SpZ7kRT1GFCFJNiKbU9wJASu43s3oZCic9YOAgNbBHk08SAGA3r388sA6S8HWP+UQhQPyjeKOm1aKBk4/Vznln+WHk111iT7WdJRpniA7F40LUA4KCEGKFpxlxUKiw5vk8kmnbTMu6UCCbSRflH1XoC5rSAzSS64XUzLOZKiMVl5LySvkBmOgHFx5b0OZ/BU9+FtdLSGYGbR5q4pP1H7FIPkHLD1hvUnzgBxsu6ubw/N3LgTaN4i4zy37d14k0zEFZm0Z4S9VZ84GoCEXM3gaIBUtKjqLQvLYXjU72OnjtktPtXm5kO60wS5GSZr2rNoaPAgGYsitv4iv4suzn/4 xOwvOC+t Ju4P8u+rh6fM0+VXNfHBZlkG3so6BdHkaCzcCFihZdWtEoSGyuyCO4JNyuD6+iZuaoXJY9IpLyTdjAjFwLvSQ6ZEgJxFwVq01lQf1V3oSs+av/Ihic98Ka19FRWyv6pZOYwrHxytsvPy39Bsch8bU9fenki5ZDs7746xcmne1LpBsC3HXkMHpsOE2Nh/u/P9cCdjl314fAsT31bw7Hz/AkEOxGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add generic EDAC device feature controls supporting the registration of RAS features available in the system. The driver exposes control attributes for these features to userspace in /sys/bus/edac/devices/// Co-developed-by: Jonathan Cameron Signed-off-by: Jonathan Cameron Signed-off-by: Shiju Jose --- drivers/edac/edac_device.c | 101 +++++++++++++++++++++++++++++++++++++ include/linux/edac.h | 30 +++++++++++ 2 files changed, 131 insertions(+) diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c index 621dc2a5d034..e9229b5f8afe 100644 --- a/drivers/edac/edac_device.c +++ b/drivers/edac/edac_device.c @@ -570,3 +570,104 @@ void edac_device_handle_ue_count(struct edac_device_ctl_info *edac_dev, block ? block->name : "N/A", count, msg); } EXPORT_SYMBOL_GPL(edac_device_handle_ue_count); + +/* EDAC device feature */ +static void edac_dev_release(struct device *dev) +{ + struct edac_dev_feat_ctx *ctx = container_of(dev, struct edac_dev_feat_ctx, dev); + + kfree(ctx->dev.groups); + kfree(ctx); +} + +const struct device_type edac_dev_type = { + .name = "edac_dev", + .release = edac_dev_release, +}; + +static void edac_dev_unreg(void *data) +{ + device_unregister(data); +} + +/** + * edac_dev_register - register device for RAS features with EDAC + * @parent: parent device. + * @name: parent device's name. + * @private: parent driver's data to store in the context if any. + * @num_features: number of RAS features to register. + * @ras_features: list of RAS features to register. + * + * Return: + * * %0 - Success. + * * %-EINVAL - Invalid parameters passed. + * * %-ENOMEM - Dynamic memory allocation failed. + * + */ +int edac_dev_register(struct device *parent, char *name, + void *private, int num_features, + const struct edac_dev_feature *ras_features) +{ + const struct attribute_group **ras_attr_groups; + struct edac_dev_feat_ctx *ctx; + int attr_gcnt = 0; + int ret, feat; + + if (!parent || !name || !num_features || !ras_features) + return -EINVAL; + + /* Double parse to make space for attributes */ + for (feat = 0; feat < num_features; feat++) { + switch (ras_features[feat].ft_type) { + /* Add feature specific code */ + default: + return -EINVAL; + } + } + + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); + if (!ctx) + return -ENOMEM; + + ras_attr_groups = kcalloc(attr_gcnt + 1, sizeof(*ras_attr_groups), GFP_KERNEL); + if (!ras_attr_groups) { + ret = -ENOMEM; + goto ctx_free; + } + + attr_gcnt = 0; + for (feat = 0; feat < num_features; feat++, ras_features++) { + switch (ras_features->ft_type) { + /* Add feature specific code */ + default: + ret = -EINVAL; + goto groups_free; + } + } + + ctx->dev.parent = parent; + ctx->dev.bus = edac_get_sysfs_subsys(); + ctx->dev.type = &edac_dev_type; + ctx->dev.groups = ras_attr_groups; + ctx->private = private; + dev_set_drvdata(&ctx->dev, ctx); + + ret = dev_set_name(&ctx->dev, name); + if (ret) + goto groups_free; + + ret = device_register(&ctx->dev); + if (ret) { + put_device(&ctx->dev); + return ret; + } + + return devm_add_action_or_reset(parent, edac_dev_unreg, &ctx->dev); + +groups_free: + kfree(ras_attr_groups); +ctx_free: + kfree(ctx); + return ret; +} +EXPORT_SYMBOL_GPL(edac_dev_register); diff --git a/include/linux/edac.h b/include/linux/edac.h index b4ee8961e623..e19706311ec0 100644 --- a/include/linux/edac.h +++ b/include/linux/edac.h @@ -661,4 +661,34 @@ static inline struct dimm_info *edac_get_dimm(struct mem_ctl_info *mci, return mci->dimms[index]; } + +/* EDAC device features */ + +#define EDAC_FEAT_NAME_LEN 128 + +/* RAS feature type */ +enum edac_dev_feat { + RAS_FEAT_MAX +}; + +/* EDAC device feature information structure */ +struct edac_dev_data { + u8 instance; + void *private; +}; + +struct edac_dev_feat_ctx { + struct device dev; + void *private; +}; + +struct edac_dev_feature { + enum edac_dev_feat ft_type; + u8 instance; + void *ctx; +}; + +int edac_dev_register(struct device *parent, char *dev_name, + void *parent_pvt_data, int num_features, + const struct edac_dev_feature *ras_features); #endif /* _LINUX_EDAC_H_ */