From patchwork Fri Nov 1 16:38:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ma=C3=ADra_Canal?= X-Patchwork-Id: 13859596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88529E6F06C for ; Fri, 1 Nov 2024 16:44:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 124CE6B0096; Fri, 1 Nov 2024 12:44:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ADD96B0098; Fri, 1 Nov 2024 12:44:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E69DB6B0099; Fri, 1 Nov 2024 12:44:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C5F886B0096 for ; Fri, 1 Nov 2024 12:44:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 58853A09CC for ; Fri, 1 Nov 2024 16:44:07 +0000 (UTC) X-FDA: 82738096602.20.480E4C8 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf08.hostedemail.com (Postfix) with ESMTP id B762A160029 for ; Fri, 1 Nov 2024 16:43:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=DAf8W6rj; spf=pass (imf08.hostedemail.com: domain of mcanal@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=mcanal@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730479400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8BSVR7eAERprKgDeJ6doXC6uVFc0KlLSJulHHmYrLgw=; b=i9TYeBbaX8MX0Qf6OMRV+OUUwQ2cgyiHJ7M70yZnn8kvl8HkoznkuabqBmSCk4vBu4xjUZ +5/lPckZ4bNB7kw6NsepDGkroaVyqB/33W8KlblUIEmHrZ80/Qqk7ohfpdYT7Yi5eM/pGQ ISh8WmLTUzWcRNXBnTw0juvVhTivrkQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730479400; a=rsa-sha256; cv=none; b=my8ANW/tFpXFi7eSRfnRSbld18jzdXI6R0cNja9Ocq9FcywLDLzEwPMUnC9X6V5JWJImKT hWVQoqSadAEi+E8UysZBcSRK+ZX0JiFXrual117ooDGqeTV27yLzdIg8SCwIo1E5nk8jPM xEbF/i1P6VufE6Bme8WN8iY+EWoYd7M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=DAf8W6rj; spf=pass (imf08.hostedemail.com: domain of mcanal@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=mcanal@igalia.com; dmarc=pass (policy=none) header.from=igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8BSVR7eAERprKgDeJ6doXC6uVFc0KlLSJulHHmYrLgw=; b=DAf8W6rj4sGQ1pVJpVHNr5uElU qF5GdXXIFPvp3rk4vrHyP7cDCSJQJM/Ose1bN/RPcg9s89Oqj7P/skzNqCAp4meggmmtuqpU3+EXy l4bX/eZ+BovJ3kiVQsLBwSUqR41dHNaymaCn45L71Ov8m1J8TeJSS7SnNnIIv7Q1Jz50QltIJYvgz qLNFXvx4TndNwVbCc0Ugto+36fnTECzGMZ4LeRgQG2I6380kAxsDoHsLeg9cLxp2rTsE9IE1FYe0I 4PV3SplVuI6NN3ol/q6aXTLSTukPhfmdBDbCOQPX2JBSWU/ptIMRxtvNL3rVUu+/mFH9G8iSAae49 MmM/IAsQ==; Received: from [187.36.213.55] (helo=morissey..) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1t6ukf-000V38-0G; Fri, 01 Nov 2024 17:43:57 +0100 From: =?utf-8?q?Ma=C3=ADra_Canal?= To: Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , David Hildenbrand , Ryan Roberts , Baolin Wang , Lance Yang Cc: linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, =?utf-8?q?Ma=C3=ADra_Canal?= Subject: [PATCH v4 1/5] mm: fix docs for the kernel parameter ``thp_anon=`` Date: Fri, 1 Nov 2024 13:38:42 -0300 Message-ID: <20241101164313.1073238-3-mcanal@igalia.com> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241101164313.1073238-2-mcanal@igalia.com> References: <20241101164313.1073238-2-mcanal@igalia.com> MIME-Version: 1.0 X-Stat-Signature: gr3q99xx8dmxh1n87eejpd36z5twsyk4 X-Rspam-User: X-Rspamd-Queue-Id: B762A160029 X-Rspamd-Server: rspam02 X-HE-Tag: 1730479426-770145 X-HE-Meta: U2FsdGVkX1+FvrmIpwhivY4lK5SWwktVyNvsb1lABsb14/5TKCicIo6DkM0JSV0cvlGeDYokw6sS129jxsOMzejLEhttU1lqqCVT6e+zbb1OWWN+Pxss/Kwpi+QAX6gskNxnj2NGpZXkM5+N4tiBmsvDndOmX4h485IxsNcbvRjvDKkPd3W7Uaw7iHCSo4x9BmCQ0n17i9bxQDEOgnFsR0vJAeXFezC5nj2WQ6ubjpwXLisqq1a9POHTv523Vc81mK0852xjoQ79sh7e6zD1boTUtAK9Eq7d2FwACTDztydDP3o2nyBVT8GIysWH6g3gYTVRhSPpIdfQBKD+wZ2oc+MeStQGJ7bzYJn1yNLPjyiXuyWa2tnDf+yDNZ7Kcb8tfBo4TuRhQOUcrzml4w4mGiZThMOe2ZIuUtBNDpIuGQnCnV6vOx6ZmF9c4bE9Fi6WPyzmVRLu2zNBl+zkY8prBZLIvWq2A7p6wV8M6oDEM1CJ54G2y7HapXt2LN9TG/zk8C2LF3ev/pcw97ImYNgRJ7f4g0YGjNuNiykkreiUV5pRSuEoR9A9vP0lkkamv7JnxIne/+4g7y45rlyksEKfYW3cAE3u2Qv56acE3yzizuh2RBQzqm1IQcDeTYq/Z464+xJWHq+gSoo0XYL4B7sTehDR5W/j8LUaUC2VvjCNTf6W2VZYDkvXhMMp1drZ58+xcB7Z6f4l6CrpeB7cuHmtTNowCk0wLOVpbXDt1jRw5c2foBAZGuuxOMWIvfe4ykbo6R8I+O/T9TDkPFM/ZjRMA3ra7mipXxWydoJaY29xzxZTh+/mT+OSMkzip0c9dyt+s/WMwNgUTfcWBLPDNvxrt43H7HJZjGD2jGbVXGm8qW8ZeF15Ii5ThuQgL020qxZoeH4dlNtx5PHBGGp+hHGah6RjnFFXbevEwMItZA0iNM78xWckZvafw15vr7m8Zku8nsz9HthiGvouljv0phF fHJu1rNK BL2iM5v6MEzit6cznLTEg7FTNDh1310XS/Ao8xol4diijW3X5Nmr8oE37dhXwf4Qnl8+YLp9NTASjG/eTa5Sj4nm/37/+0GFAlwkS7J36atrQiKdv5WjrfKQBTKXVPb8d4ptiM4UUxVCSL/MJOW841DIZnFToKsoeldZbhBBS4BywOgAZlcBrRleCmES5juoA/v16TATIrnKS7kAuqS3cF6dmlhN8wqNPlL8tWgW2H8AkrvwG7CrQecv82El0TonlVjSMN2v5616ItT8RX6EgDHB5kBvdBbVwoQkRxAbTU3RbrqIuizCjnRY4Xg0iqKE4KQY2VsIjqx7Jk9lP4c03hx8qhI3R/kLMZIkmymYqyCKmA2AL1/FxDZ4LiheR82YKIhfFO3mcOIn0Xm5EQjheqdBnHWh00eJLDBhckLiR6FL+8Gg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If we add ``thp_anon=32,64K:always`` to the kernel command line, we will see the following error: [ 0.000000] huge_memory: thp_anon=32,64K:always: error parsing string, ignoring setting This happens because the correct format isn't ``thp_anon=,[KMG]:```, as [KMG] must follow each number to especify its unit. So, the correct format is ``thp_anon=[KMG],[KMG]:```. Therefore, adjust the documentation to reflect the correct format of the parameter ``thp_anon=``. Fixes: dd4d30d1cdbe ("mm: override mTHP "enabled" defaults at kernel cmdline") Signed-off-by: Maíra Canal Acked-by: Barry Song Acked-by: David Hildenbrand --- Documentation/admin-guide/kernel-parameters.txt | 2 +- Documentation/admin-guide/mm/transhuge.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 1518343bbe22..1666576acc0e 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -6688,7 +6688,7 @@ 0: no polling (default) thp_anon= [KNL] - Format: ,[KMG]:;-[KMG]: + Format: [KMG],[KMG]:;[KMG]-[KMG]: state is one of "always", "madvise", "never" or "inherit". Control the default behavior of the system with respect to anonymous transparent hugepages. diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst index 5caa3fb2feb1..abdf10a1c7db 100644 --- a/Documentation/admin-guide/mm/transhuge.rst +++ b/Documentation/admin-guide/mm/transhuge.rst @@ -303,7 +303,7 @@ control by passing the parameter ``transparent_hugepage=always`` or kernel command line. Alternatively, each supported anonymous THP size can be controlled by -passing ``thp_anon=,[KMG]:;-[KMG]:``, +passing ``thp_anon=[KMG],[KMG]:;[KMG]-[KMG]:``, where ```` is the THP size (must be a power of 2 of PAGE_SIZE and supported anonymous THP) and ```` is one of ``always``, ``madvise``, ``never`` or ``inherit``.